From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E43C02183 for ; Fri, 17 Jan 2025 16:57:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 153E1280007; Fri, 17 Jan 2025 11:57:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DD8D280002; Fri, 17 Jan 2025 11:57:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE67E280007; Fri, 17 Jan 2025 11:57:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D0986280002 for ; Fri, 17 Jan 2025 11:57:22 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 78480A06B1 for ; Fri, 17 Jan 2025 16:57:22 +0000 (UTC) X-FDA: 83017549524.20.FEF7FBA Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by imf17.hostedemail.com (Postfix) with ESMTP id 8991B40013 for ; Fri, 17 Jan 2025 16:57:20 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=MSQDvS9P; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.181 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737133040; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A3+FOZl9G0CmS+l4AgTiYZxyDmYtH5WqjmYohOoxqVA=; b=DX67WIlPuRAZ71I8DDNZuB10Tifcz4t2mEHwTzBtmlBHXB1lFNTMqseak+l2xSI6nvV0yb MysaTYACsL2lk0gwjxYuK3O7Ym7WGUKNcxXgpHR4ybOTq/Hbt+/CVFVo2Dvo2E1SjQN5/z UDTcORm6QwSiKnJFe1jTdvi8+/p3XiA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=MSQDvS9P; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.181 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737133040; a=rsa-sha256; cv=none; b=1RCN7BiplKOUeEvR620QCD4tg41H6YsXSRJneXTQhRbpDCtdDxLVVELAjGsgs+7p+m1OMY ddg1roAAZIz8tS0fyn7L1dG6G75uxB/YAN+zkSNoqwLZCX7JqN3PbA7FTlVFnON/nwe7y3 Bj0/PjwZSlsU/dhFeJRBFVeZJ2KsXQg= Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-7b6eb531e13so124045585a.0 for ; Fri, 17 Jan 2025 08:57:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1737133039; x=1737737839; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=A3+FOZl9G0CmS+l4AgTiYZxyDmYtH5WqjmYohOoxqVA=; b=MSQDvS9PAZPNOYoxU+1C46ghGUTN2tOpfUk8VL5QZ7KVNPuSIixKsiYNGrXkRspG9U qp5dGl3pA6gu2nlnUWDyN+bARyn77/0YUpq0RmLOBgPjKzFYsthQVpUzKw7gt0fETZWw jEhUQtJYuvLmfaLSjEbG+EXcnx+rxcRvi4fKkLI8Nl4ccoMlNjEXY2V91n2H8Tc2lsS+ f7zlKUMm3wWUphfeqx7h5PcYw9/jzKrZc7qDkbs0Un5kgg1V2KjJkBDHGcVhDazi7xP3 jFq6Saw6/d4MtcGjzqPQQDnoY1vexuxglVh9/BQ/vTXnRIdNR6ocd4lOihV6JQNoFrxu HSrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737133039; x=1737737839; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=A3+FOZl9G0CmS+l4AgTiYZxyDmYtH5WqjmYohOoxqVA=; b=kbKR4MnysC2IUfbvFheHI1G0HObSiKmtek5j9pdS11jWnXRYZSx3ISkg1AQcG+o3Di umMksXinPrTfHDW/WiWDdFfN0d6zEILkYee988R8zLeGNFAR6rTA0kDWuFV6uHnmw+Ti sbUcbTiZZ/1x0Dyap0+yAQHx3YQFc4wo/k7+Srw1H3aG7Sf3T14pwdCkRGaqYmnH6ypM cIVHGnyeIXS2vw8uS3kWv8fO+rc/4PggJEi3+xWUrkiZEN+7Yu8vKQ9g0/hSzb4sRy/K cRAKn6mXyZ3mJdUpeWLTEt/ne4+/yBoY+pB9FEi7l+EAvILFg6L+vFQAgtLysWr0SZps EdHw== X-Forwarded-Encrypted: i=1; AJvYcCX9HinHV7qoLT2WgI/8QkukwXUx9bp5B6SE34zMGxPiuNuL/Lr8wGSvl+xgMVvKclCqRNdqBK4U8w==@kvack.org X-Gm-Message-State: AOJu0YySDRl+TR0r+1rPhnwiQqqTJBt0XZeqBM9nRzqU14BXXVBLZPWZ kWJlLvKy87u+lAeKfQkd331APTBcCjz3S4duYzHgpuD2t2cKUvi3zuDTO7U1o4k= X-Gm-Gg: ASbGncvVcQiuRqucVkMfTMiGVwL7GntwJ10I8wgJDhxRd8ZEMWRw45ZLFyk95c4wGML RQNVAY/Ue0E6IJVlL/4I9qXA3Xedh0UEZDzs8tdPAU43BeHILT2t9F+/6wYXMbj3w35x9KDFwTu 6GU9maT6Ql4q5FydYaiLHh7S9Y7DQnUEa6jeYGcGQK6vPTGrNWbUCocKi18TVGLBsyxSDAmf4us S7euNmdPirjf/skBbYqrMEMId20uvov3fgUI75yvbf580CxSvXaH70= X-Google-Smtp-Source: AGHT+IEXRz29FmQ7/DeWr+qbLVpSrbszPsxs9nr3ZLeyzTMwlO5/BUjKEPnQYg9GbkTNysXjXKLj2w== X-Received: by 2002:a05:620a:1916:b0:7b6:e98e:ad15 with SMTP id af79cd13be357-7be6320d09cmr474429785a.34.1737133039335; Fri, 17 Jan 2025 08:57:19 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:f0c4:bf28:3737:7c34]) by smtp.gmail.com with UTF8SMTPSA id af79cd13be357-7be61484065sm130301685a.49.2025.01.17.08.57.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2025 08:57:18 -0800 (PST) Date: Fri, 17 Jan 2025 11:57:17 -0500 From: Johannes Weiner To: Chen Ridong Cc: akpm@linux-foundation.org, mhocko@kernel.org, yosryahmed@google.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz, mkoutny@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com Subject: Re: [PATCH v3 next 5/5] memcg: move the 'local' functions to memcontrol-v1.c Message-ID: <20250117165717.GG182896@cmpxchg.org> References: <20250117014645.1673127-1-chenridong@huaweicloud.com> <20250117014645.1673127-6-chenridong@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250117014645.1673127-6-chenridong@huaweicloud.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8991B40013 X-Stat-Signature: kce97bd3fm5nc8be7aiyzgrcw65x9us4 X-Rspam-User: X-HE-Tag: 1737133040-203369 X-HE-Meta: U2FsdGVkX19NVfzzxqvK1Blmk8aPnTaLEYCkGtnN06zqrW3+f9X/Z3ftC2s67kUR6PRW8gaSOvbtJ81PTWeszVKqSivNvZ1fMDZr73foe6PeSwZEbWIeR1rWQVczmCXti7iRNPMTRHReUy82euDdSr5Lx1VhgqwBZOtXyIOypDlVNmRtO+Jb5FJJsst716bcBlErym1zi4KUS9MngpIm+E1ZucOBN/jCGtxplw3x/jseEy/vqalb/NI4zb+N500dAVVhmqGmVgAQJlgdS31zE9Y4ChE3Z6rMPr1nCOwRhspIU/Z9iHv6YyQAHV6jn2o+ey1dJq1AP5i1j9AGQfa85dnwblgAYsMsJ0iUsMOcjzKT3tt+1X/9hcMscSzgnJFGXsD8bRES554QfB2Z+oz+VAq6RfFGCFpgsgRkq0IH4x/7IX8SA1XXVbsOeNLRrSLR7A9kpM6xaveGbQJrIRTlv5EWnXt8qz+5JS707P23uRrE0td7G4q7IzRj2GFbxRATL/pbAbCzdFF2ViECyZfYBO5qazTRkrF/B/IGe3k0Efajp7HqRF0FEMrx2mWNe4p/xEj1cxjRoBtenBK1Dj4O2pDSnSnAKzQUTpy/2BThOZJdjOglrZMLsq8YBy2s2LUdqQ1FyqIRowgh3UeAaUXKM801O82ETC4Y846lt5n5CQrBm5JovxBl9GJ+nhcGOD2yBtGBeuyq8bYaYDFbrAvrFjNhEuBFDjEFdI+QUlQfNMZDkRv/U7hpnfTqqU4bTmZBgOVFrNGkWDoZh4JeAVIODHLvek7llSHOhLUf+ff0oHzbt9m8gYZsJjk95vWnO2fHoSLMDHWzq+MtoCkOFaQNBVY/ORlvqMNo6c1isEucOTYp9ir/irQj9m4JuELvS0hVqQJyQ+HpQkVbiF4m6ehlXg+ZSJNaHekZEq8kMxeyq3fNcRVp9/9+fw2K6q///E94MFdpi011Jg7rjeXJ1KB eBvbI/Kl xT4pc/ziIJ8arm79l6cD5NTtirZmFh9/53tKU/wRkxOUMeQ+CsLVcR3Xut7LXPl9fWhyWrdNNxwiN7HqikkmjgN7XsXfLcWp/d+nBo7K7KPwUSqL2lKr+fJp+N6HcjzaZnxT7+IFAJTncOmY2ZxRblK5h0+3pPL3iqfFJh5DX6TwBxvOrNppHGUdSIgRsu8sEVNVI/Hlv3+aH+Gk4VUiQHZ2lMK1bhiofwfo+td2U+xXXQYYiVt2CvPocNdS9aYjT1MBowY5oyego7XcHpmS2+AWR1knoLD5LfBgYjhz0nWNKydyw+z2APke8jFUjvcEOoB1mruRX56WPQ1Mc4hFhAoVKF1KyL0IldmGSKHs8/fKqCor8pm3nGf1H7pvMaBvM1CktK/PdG0g7BW+PHsvlWkHBIyZbJctW2JDdJT6T1Tj8uWcpPEft18/pMkRSzSktrjV1670K0OCKotY+XxGewRTlyIMuJnxFUqSwsDbyDWx28Ob4N6wpTLBhaljucUHVbBn2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 17, 2025 at 01:46:45AM +0000, Chen Ridong wrote: > From: Chen Ridong > > Move the 'local' functions, which are only used in memcg v1, to the > memcontrol-v1.c. > > Signed-off-by: Chen Ridong This makes sense. Without the refactoring from the preceding patch: Acked-by: Johannes Weiner