From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31B54C02183 for ; Fri, 17 Jan 2025 16:48:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAE39280008; Fri, 17 Jan 2025 11:48:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B365B280007; Fri, 17 Jan 2025 11:48:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B14F280008; Fri, 17 Jan 2025 11:48:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 73F9C280007 for ; Fri, 17 Jan 2025 11:48:14 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2921EB06F0 for ; Fri, 17 Jan 2025 16:48:14 +0000 (UTC) X-FDA: 83017526508.14.DC24D85 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf11.hostedemail.com (Postfix) with ESMTP id 4E83340011 for ; Fri, 17 Jan 2025 16:48:12 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="ehpHDi/i"; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.175 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737132492; a=rsa-sha256; cv=none; b=pjsDa94NGy8h2UEQjEcqtFayxMbkMYGHmP5iY4sjQaxYeETcaxYfiR8ErwOC5XNygvqS64 OvwKM+uNbL+Z++04GuqAvPYHOoLvtyEBY0nxUqvQcP28+KETFQbaenhC076CA41agxIK0G iBzSa+nIgpMZUr9MUgfUWP1pPJeRNkk= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="ehpHDi/i"; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.175 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737132492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l8YaBSyWTZacAKpiBL4zeCVsLIUHz0xsGOJbxkKSeNE=; b=xY6KWtSS5dbtoIrB5ubWNPy/CgJYhq4O/dcjuHA5deD1UusZ7tRaHYe4lcSIH7gLZi4nJW RgHFcjuy5ftNHcc8JRlYgp70fssh/ELpxVbOIP6SnC5h0InDFpNdEAPzTK/n1o6sAvNhUH KIL3He6QdRM+kVwWv2lO8hMB73fvU7M= Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-467b086e0easo13525641cf.1 for ; Fri, 17 Jan 2025 08:48:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1737132491; x=1737737291; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=l8YaBSyWTZacAKpiBL4zeCVsLIUHz0xsGOJbxkKSeNE=; b=ehpHDi/iDk0EbYkR4aSKwqds8k/nrnZAtPELqUhFzwBVu6dH0K/9mNqt2OBHWwHO8k xTpKXqiqdorjdM8d/6m6jGP7XX6uPz7WsXamGJANH0h+P0I95jBcZDmpZ2H3DNzz9hqo l6J3e5dD3bZEuoZzEbPajCz9y85u5ouj+fMkkc3sfZEZeo5CmLRk597HpTEvr6pYA8j1 9dDbPw0i9fz8DW2JSM3vt9bmT+H/W89gZsjNwxElKco/air+y8hz9SLktEVdyOz8b/IK hOoLlEaaQCQecLclrFbG36jQn1RdtD1slnRXyy8DFWvIr2alwlI2hzn4mMpLI/EV3xjc hW/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737132491; x=1737737291; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l8YaBSyWTZacAKpiBL4zeCVsLIUHz0xsGOJbxkKSeNE=; b=pm5vZqnRbIl8MNA/oM4agM4eZZd7qoZEvpJ9Y1AjZP8qGDP9bXaXb4LFGAz3Z6Myew rEoaFG+G8miPjTBBaWAA0balZkbuNaF7JRCw6n69LrGSCSnBx46f6aUWIWhwE2wC3Jdb NTff/JZAy9Fh8Swwix/2FaqPF+C3iIlSH3nvDZ0F0MtenMzGCgLq3HyYYNbBV+QH4Xt7 26ot14fg5Kf3X2UsaHuNOE72SVbe4sgB+iAI+6a5veRaZsZ/lehHzfgMxolJQxCdqcu6 MUpBrdaNQl4xeIN5l7iH0P9Jxh6YmqMbhu5v6RU94xyR0ZifItjpb9+NQ2imhNd4w98W ayjA== X-Forwarded-Encrypted: i=1; AJvYcCX5/GC9UkejKrSfzpYM7DcPEPik3T9MLyKzod9B5CojBzBLECKkYs0IVCm4sImpAY26oSZKg2axmQ==@kvack.org X-Gm-Message-State: AOJu0YznO7/LjTpSUtBoWPYvvG+u+UFItTCugumgnVUnctI0qV8tv5H8 /uSWnn126i64iWSLqU4iWJVCYkV/yRdO/4lBLkgQcw1fZ7EiYWkQiMg1m87O+SI= X-Gm-Gg: ASbGncvcZWrJheFjshrNKpcbcVnjBxFnZvetXBXoMD0hAiF0S9xBPdrbuljvPfdCc4W A/VmKkbJ5FyZp+PDtE5r5eCVE+BVkBsPU1A69aZ6pz2AP/fkbUPVUn5bLYAz++0Xfp7cdJw634C PI0dULPcrOdHkZNLEemVuOJv+1qA7584cLK3NE7c2Hkbyb3LLAW1bTwUqKVFOZuvCQMJRparPWL HPZaS03JuJpHdNq4orO+BYk3fpWyyhiuPGcQ91cavrdgd18fj0WIgg= X-Google-Smtp-Source: AGHT+IHnKmujOhexofpW2cCRKOdVd4mgH+9RWl0NrA2BUuwjZsr+vt7twxWRa+WyYfI3I0Pnq20sFQ== X-Received: by 2002:a05:622a:229e:b0:467:8797:29f1 with SMTP id d75a77b69052e-46e12bb3aaemr46795911cf.45.1737132491435; Fri, 17 Jan 2025 08:48:11 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:f0c4:bf28:3737:7c34]) by smtp.gmail.com with UTF8SMTPSA id d75a77b69052e-46e10323c3fsm13162711cf.48.2025.01.17.08.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2025 08:48:10 -0800 (PST) Date: Fri, 17 Jan 2025 11:48:10 -0500 From: Johannes Weiner To: Chen Ridong Cc: akpm@linux-foundation.org, mhocko@kernel.org, yosryahmed@google.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz, mkoutny@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com Subject: Re: [PATCH v3 next 3/5] memcg: factor out the replace_stock_objcg function Message-ID: <20250117164810.GE182896@cmpxchg.org> References: <20250117014645.1673127-1-chenridong@huaweicloud.com> <20250117014645.1673127-4-chenridong@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250117014645.1673127-4-chenridong@huaweicloud.com> X-Rspam-User: X-Rspamd-Queue-Id: 4E83340011 X-Rspamd-Server: rspam10 X-Stat-Signature: 7tybn1b8qtc9u8xtsdfyyu96bgop755o X-HE-Tag: 1737132492-169137 X-HE-Meta: U2FsdGVkX19cCdXbNwbTyEUt1VudZtoLSNFTZyUUPhS/z4dyNfuG+4Y209awGipiULdQCYj7GtKBdQbKysUXwCb/8iY28+YUgCvFbSeEDHEKgIrHK5PUFvNlovle1/8FOOFo5LfXOZXB1vsiE6l6JsfkOA7OUKWMbR5lnkMlLPSYeEvnAYH7Whv5/6rRFxc4lkEtlLlOpmtlMw2hebdcN6CJv71pn/DnCxrsnf2PKlhx3uNXzIsnUOqB992jNx132YZEpg7g2jZZ/cPQZ9no71bKT3LANmAM0/0qh8S767Ua+45KDdhKphd0KUSIiSdH+txjqllmcojnF+GDtLbMSjpe2kKVrGiavovLh6IbZjNUcvWBACcUwj/QAc484KXom5NNRUyVJhsu7VPIkTHhC5XGkwdPUf68pRAVtDUQlD4YFZmTe6KrBXi5gi8z6TazljOq/rEHsijcRQZKhVGZdVQpPlLAv3a5W6R+VU0aZHfFKIiR8oUAvg7cJWHsD8tO+H69p7Dlm7+BAe733XhMvL++qatbOjJ2sx/rAU2wpZJi6VKVeVWft8WdHuHtNQmUcPBhubXaRD89MODm8BAv1DJGQyIy0mFUEaYvMtl4WxWw/ElieRna8Zztjc8zQ7vmvMrFbtGkzw3vKXV8sEN1Oker9YAzLFE1+fvOy//9aCLiQCpObzM7ybhdj3e1QaXvmXl+SlAFbh5GHOSVhyT5Tv18fB2d7yD3+IgpLiD4e3lhoghypDRJQzcUevQPOxItKdE4TCFda1FRTuowLRJZQnTXTVfbLdyg96pg4uYzDRxS3VSDUdHO7Gjs+YN7oz4n20jdMyQoSRHKkwiUKqXM9+OGtCod7LlYUBC50YHnJqa3J9Pj3EMTnpKHyphRycEzBA2KrJHoCSrSe0f/KNOI6pBD5gu7TNSoF2I9CLsYQl0zDPUTqjpjua1WNsutJhytebDrKDS96m4Pe8NMEFg c3Z1rHXD qi2ACAXfoj7QQCRAcwhWEwwbE1xmJSMkaH0LUf7W8XFnZd0jjxBp+1cYJ6V1t5+RteTgIkWsoTJkfpGdw/yvhRLu3PY5id0RfrBbg0pHw6Mo0m44R8xKmL05Kt44dGDzY3YjZljFl0BWfM+775u24NSMI0q3ak0Va57XQL6Z8gOoN/xqZJu4DFDgKAn9h852m5P76hBrkeBLOEpz8CBm41rE5DO2OmSVuWUqDNe1T3OZH/BUKfJHwFHSnUW8HzADbwTB71G/SiYkNXnhyw3JwTcTrARsqL25PitdwWYrXcs1dSMND9NPOtleP0h7/Eu6DegHDx+XMFalpivkdjjXENhqcKV6V2HoNm03mYW+pTv2gacR8ju/59ri8qY/EKYVwMEgAHoh9hJ9SzdqimtnMbQaEq99ybvT83ShsdfCNM7VQaHJ+XMM2bTGB7zi8jkwtcF8bNZr+vWG1JuKOV2ji215X0vSRnPsnBOXyUe0uXzUAu0rTDVyG+LebEzWj55iSV8E8UXuXFXZN9jR/8k7gYyPdw6Fpu7CkbWO+SW5iw9j50EbnlFjA660lew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.009110, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 17, 2025 at 01:46:43AM +0000, Chen Ridong wrote: > From: Chen Ridong > > Factor out the 'replace_stock_objcg' function to make the code more > cohesive. > > Signed-off-by: Chen Ridong > Reviewed-by: Roman Gushchin > Acked-by: Shakeel Butt Acked-by: Johannes Weiner