From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B33E7C02183 for ; Fri, 17 Jan 2025 16:47:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 480B1280006; Fri, 17 Jan 2025 11:47:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 430A7280002; Fri, 17 Jan 2025 11:47:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D18B280006; Fri, 17 Jan 2025 11:47:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0B036280002 for ; Fri, 17 Jan 2025 11:47:52 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C49E0446EC for ; Fri, 17 Jan 2025 16:47:51 +0000 (UTC) X-FDA: 83017525542.24.C01F655 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by imf23.hostedemail.com (Postfix) with ESMTP id E7290140013 for ; Fri, 17 Jan 2025 16:47:49 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=WofVg8hw; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf23.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.42 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737132469; a=rsa-sha256; cv=none; b=n0cRtUzrYNeqKwHWVxET/wCquDSfVDG/b8/I1xRHivu8nz++wf0q55JG+l4xEXdxOferRW bmu4Qi4rp3AMF+wob+YRQacZflenc3ksP9ReeAJ6JFU6yDMvaMl3x/yPHpSzcH7Z9zYAgq UcQdx2DFJ+/b2sDY376BooOnwaOUd54= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=WofVg8hw; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf23.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.42 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737132469; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ALV5l/odctAX4u/DDnncfiVwNjPi9uf3gn37R/WtIws=; b=S9VF71iqGnfl+s1jTy+Xg+gn2p7qyVbkcqFMW/I93iz/nNMjmzBQ548nuLOvfGK2eKBDSA ugoHIMy7aFBO6uByVkqmWHZU+nXmu8fYJrR5pMWfnpsa0dC9ScK98YrXKKTL8iMtUeXop2 uB/GhSICD+ruqkcFCy2sykDsqH5rGAw= Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-6d896be3992so17917786d6.1 for ; Fri, 17 Jan 2025 08:47:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1737132469; x=1737737269; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ALV5l/odctAX4u/DDnncfiVwNjPi9uf3gn37R/WtIws=; b=WofVg8hwu96cI11IGu2qHBZK7tLCcEbm07MA5HdhIWHYCUWyLcAy96Ektw5KNqoaYn 1CoUwabrpYLqH/qiyN165TeUcO06pLaX2pbqumlZdvFnAXX0T0cWSs0GTP6Ugj1edVPm QASJ6q5cnHZWHaS4Su9h3iAgOZ3bZAHMIqNOvPKPQ28QzDbKZVJ4MiqTpEYXcYjt538/ qGz0MtEDAg9EmP8VfNox2i/bUpACkxwB1yovzKYlKzTFp//dbThM7X/6nTNyGCEbDej6 2FTO8grT8oAiSK0pBAN0putcf3M3oidpkL2PF5wp7Mg9k1fL2MJNb28Kv78myp3ZaDn4 zU0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737132469; x=1737737269; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ALV5l/odctAX4u/DDnncfiVwNjPi9uf3gn37R/WtIws=; b=cRzZECB2kG95t2N6L3PLNUx7A82VOFuypmIQrcMm7vT4RkEsRagKa5/unRMct0WYHT JCHaUg4sKySubiiIRB8P1F+Pr9HBKfwQvY/8DVnjxdT/rnaQbuJvF6omFq3bbvwAnR55 hJQ6OniWGhoObCG9UWMXKeMqASAaCzy87eI59YeUSb+7gEG14O6ywKgLlo3vGBMBIecV jw2xUyiw6KReClh7aOVqO/a8zhR9CfosVVnau7NdLORpmoZ+vq7C8hUcpa7ghSY+TUua VI1JgP84r773aT/wNnOrMe78bIJBIxcAyESb/PumvkXEXyzzgdV+PUjoB90UevQ65HPy XxcA== X-Forwarded-Encrypted: i=1; AJvYcCWk/IqtJlpAsh5yCBPpzM+OGLrE4q2YCsxGlaKowj0TDQCiNXL0DcmMIjqW9fEooUfF6wCHc1Tp+A==@kvack.org X-Gm-Message-State: AOJu0YybGnU/crZSfY6rJS9khh6hXkX3HW4BntgW1huaNNy9rQlKvkrM zca07m8ghrUORZASrECJV2ZhSHX+TC0ZyFmSKKNvnH3D2gxBNLoLlABw6RnhOAo= X-Gm-Gg: ASbGncuhgKDlur8TObI2icRNknxTyvBtwc7W85l212oBD0TcruG213HaMT7KTgVPr4e zTRSrCuwMkixCtpg1EnYyo38fO2ApYuX0r4ffy79PYChSQNGKbYAFrVlwHlx8r6zOvaJlM4LoKi 0jEukQDiF7auDVGZcaiYxRmvo1jHHgtWFr9zjWo6VlgMyaLeEFOvuOnF+4v/H/R/BCZFNlhNr5+ zNu4KMGqxmaSsGLiPlVdsPSIFo1FIs0RdXTFbNjo43wNOUH7/4P+dI= X-Google-Smtp-Source: AGHT+IGJD22IumK4sgXeQYpyReO0k61FPPlVycvnYk8ngibV4lTzbMH3JRKUWQsEY2VfnGaf5KWdIw== X-Received: by 2002:a05:6214:400f:b0:6df:97ed:54d6 with SMTP id 6a1803df08f44-6e1b2180604mr62615746d6.21.1737132468860; Fri, 17 Jan 2025 08:47:48 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:f0c4:bf28:3737:7c34]) by smtp.gmail.com with UTF8SMTPSA id 6a1803df08f44-6e1afc117a2sm12960046d6.40.2025.01.17.08.47.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2025 08:47:48 -0800 (PST) Date: Fri, 17 Jan 2025 11:47:48 -0500 From: Johannes Weiner To: Chen Ridong Cc: akpm@linux-foundation.org, mhocko@kernel.org, yosryahmed@google.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz, mkoutny@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com Subject: Re: [PATCH v3 next 2/5] memcg: call the free function when allocation of pn fails Message-ID: <20250117164748.GD182896@cmpxchg.org> References: <20250117014645.1673127-1-chenridong@huaweicloud.com> <20250117014645.1673127-3-chenridong@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250117014645.1673127-3-chenridong@huaweicloud.com> X-Rspam-User: X-Rspamd-Queue-Id: E7290140013 X-Rspamd-Server: rspam10 X-Stat-Signature: 6ayhff4cty1w8mwsuqwc8si9ta1dux5z X-HE-Tag: 1737132469-763741 X-HE-Meta: U2FsdGVkX198NPtNSQWdR+TFWq1KOqAH0ENcmUHvCDvVqpxpf7uoPaZ5c9Ro3I3XLhdBhFN3sAOmTuLBef1fekbS03Oz/UpbQDDrG7y+gpZdXY7vFZWcvVp74MP2dLSR4S4M6c0G9QlRMJwdXzny5np5doZHi9yccWi+NCIZMRUxv4+ZE0cP31ImliDhtSkRlQKWHpzIQywn7FtLltDAJM/Dpj812PQlct7G3btYjUxSJLA160BvQY3bTXCaa2tnA7F78Vg3pjqrZH5pj0/rZ2KUGvQccQNjbIxqAHQVt6DuvLUofr0kbpckiAC66Y5UomWyDIVa1I8v6vHkC5tWiLqHKi2/rdhgQ3yqFIYktT0pzAyht9OM+p4L2aAujHmdGDXmKkLaCinAk5yXl6Y/PVWK/q5qd73/F8vK+qgdfQ7tQOjJhP/jjD15l1KfOk7HxiU7xCXfmUbMHOSwafmrqJuFoeB5J9wzE6HmSyAVQqRd+MtSHqitMF75cricPwc8bnJwdEO/jKNc5uawohi0I2Ur/3KOJffSZbFlEx3sI5IeNOgaEzSghXm86oSRaqCTGg+XnVjNjHjp0Asb0ZAF6qr3qHU8KneJ51wIXTYDI/fTqKCDcj+GQtbu0zqtyXEJE1sNWUlgAv5nFlpz1B6EFIQlzm0hTzJrEq+A3aOCX3w0IiSyrtukJ0CgNaUUXlri1M9y2emiqDtfHG2bb23QhpAiomyUX0v5GmFED8F8FM6/vbB7x9ErppseJfcLTxQu0t6QB5U2qBLl74JuKwxmhir+aIGS8U5b+S1y+1CxNm4okx8M9b3ON+Om9omR2SZ1Q6RGLVCHLlBYhE+7EJkEXM2J6UV3AuQP5QVz/Ff5b28n1Aee7uluVrslC4vtsLm0WtsgsYI4seLtJJcazF9TPD5u/hSeUvWJEuYqyVjePqxSh8UG7SuG+hpcm0iuBt2Da/O2SiQ0O+ehwynn2X7 DLlXg+lu ROpI1aBEqyQTcDdGVfzSY+IUdI8GXIIRXuYK/I5FLhS5iTHocF2MJGAE9x13Ov6aVEeRPpJd3vxsJD8nnDdpz7OH1vURt6NzxmnlzdlhEGpNsLllPY5BOTijTdvhFDIW9vR2bNP4cpgycF5SJ0ZLUj028uMQxcG2zO62a71mQLQVZtrZHB5TGYDM06ds6N6yi/AtzZDp4SXFazT2g4O/5ccOicZ4ac5zwChYioL4xq6tioj2zVfTkfgeZL2XcGC7RYxeStzMchg6wuVSnSKlvTwJvVIXEGPBQ7ehGxJeIQlnXPqmvskToukXjdCseXde8T4UGP8qE3NnuQHOIVswR6ETpIdhnAELS0YA7PGaxDopL43xwxeEpX3TrEu93azMKtVwJN7/MPPolosGpFPHgcGfkYuwdgoZL0uQkuUGtFhXzjvL3z1epcakXDVfiwwoIYgRXWN1Mjsk0uLWkYOxxtz0DgUzbn3fv8PFxoj7UE0nxJnBBjEfSmAtWcYkS1BGwLWtIU7RWVXlxiJE+VwTUh88F0AIf6xtKLa81RqZJsuGNRyBoCSeGVibZlkJFpZT+/LCL+AsSFJKVL9lyGq2sqwo00g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 17, 2025 at 01:46:42AM +0000, Chen Ridong wrote: > From: Chen Ridong > > The 'free_mem_cgroup_per_node_info' function is used to free > the 'mem_cgroup_per_node' struct. Using 'pn' as the input for the > free_mem_cgroup_per_node_info function will be much clearer. > Call 'free_mem_cgroup_per_node_info' when 'alloc_mem_cgroup_per_node_info' > fails, to free 'pn' as a whole, which makes the code more cohesive. > > Signed-off-by: Chen Ridong > Reviewed-by: Michal Koutný > Acked-by: Shakeel Butt Acked-by: Johannes Weiner