From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 258CAC02183 for ; Fri, 17 Jan 2025 22:05:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 722FB6B007B; Fri, 17 Jan 2025 17:05:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D3406B0082; Fri, 17 Jan 2025 17:05:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 573346B0083; Fri, 17 Jan 2025 17:05:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 36E906B007B for ; Fri, 17 Jan 2025 17:05:25 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DBA0480F53 for ; Fri, 17 Jan 2025 22:05:24 +0000 (UTC) X-FDA: 83018325768.03.3DB480F Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf15.hostedemail.com (Postfix) with ESMTP id 802B8A000C for ; Fri, 17 Jan 2025 22:05:22 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=qualcomm.com header.s=qcppdkim1 header.b=aKPy3Dm5; spf=pass (imf15.hostedemail.com: domain of elliot.berman@oss.qualcomm.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=elliot.berman@oss.qualcomm.com; dmarc=pass (policy=reject) header.from=qualcomm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737151522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JSLK34Lu3YRBCLGcytvmW0b35pxC3UtVOnWaZ8x+bow=; b=4Ens4f5TyqwHDXruQ7EsENtEjrL5m1ZbG/wZ1bVTW04dmImdw3Nv1F20g9tl7quKlfLxqc pZ1WpYV8yCZh5ps03Hy8M3P8cJJNnbaXwOm0GJfK2tCT1Y/jxDb48Ofl0S9RROEUjkSXYP 7vKKo8lt1Q8STjH0bLeMSp0ajMBatZ8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737151522; a=rsa-sha256; cv=none; b=y2XzgdxoXeGH8Sd99ZPcElRmbhuLju4pBrsYLtEFWvzqsw4r99W68Gr05+iaFcYl+AY3n3 dU7h+97TdDq4Gp9nzXlRbNUZi65R8scjeHI5NfhobJn8A6hz0MnLAeADS2i9xCReMie9Wr WMh9XtpmIH8eInuPZOXnK5ZrmYnrTIE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=qualcomm.com header.s=qcppdkim1 header.b=aKPy3Dm5; spf=pass (imf15.hostedemail.com: domain of elliot.berman@oss.qualcomm.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=elliot.berman@oss.qualcomm.com; dmarc=pass (policy=reject) header.from=qualcomm.com Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50HE6343010939 for ; Fri, 17 Jan 2025 22:05:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=JSLK34Lu3YRBCLGcytvmW0b3 5pxC3UtVOnWaZ8x+bow=; b=aKPy3Dm5ouC+0mQnc+a+5z2phKxBp+BpMJ3Qt7Qt jPer4T9AyxYPNpWj9AYRr+he8QZMGUvmRIkhC1MXzXJxkSa+BSRV+VbJIfgLnT0s bddhrwTbqyamWg3GWpZiUCEHf/oy4CWxjWfEfw4q+bJCUhcUZXi3uZuCdKJe1JS8 c82B2ENp4eL/6DbBTfy4QzR2H0V0hVgWlRsblRSuje5TK5R43R5K3qxy+MOpkOsE LGYDZiytEgrd9Lrc8T9EvPq/RlSUDlsYsfssj9i7sh5khdxEaXqJJ0vuGZhWcjLu 67xJqQGis6JKy91qSaFmh/NZBpKG9mZ8RuMngPcCS0KlbA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 447rnx10sw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 17 Jan 2025 22:05:21 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2163dc0f5dbso50918115ad.2 for ; Fri, 17 Jan 2025 14:05:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737151520; x=1737756320; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JSLK34Lu3YRBCLGcytvmW0b35pxC3UtVOnWaZ8x+bow=; b=Apt/AxMPhSUjbc35ZBJWqyjEezKE316diWs6KCFqcyhjvtQqpINrwRsf3AF/KxEQNT z2LC/w/vA6/PLwPWE6LMZHzGUGoK+A5JJ236v/iK7yYtf4WsNUdK7M9coC7+anPWbzPr zsSAOZJNrFgboqTT5Z/FeInTzgym7pAJsti/MnzvOcVR7bQrmJOSZ01by6m05ifHFbSe IgqpMRHZYH/Ulbip5K7V2JlMHcLcn+B1Y075sId5TbHDknv2Ce7oilnabCJ7D0BoNy4m Oid2HgBctFIFzNSnTFLHWuRSyekOV7hB0daKEbt7nGIMAy3cvenIHbmh/ptcY49ALYFC JBsA== X-Forwarded-Encrypted: i=1; AJvYcCWfC0Ym0gLoKqRhMKGmLpVQBZoQV5Es7a5UNJsDUCBTBRtwK/txNpzEYpqOZkj6brbZrveMRrZtKA==@kvack.org X-Gm-Message-State: AOJu0YydSbZ3efUY89AeHX/cebWs4IDsEicXWtkyE5nAgdKV3Vys2kGp LZYzMP1TGx5O4g+g5+gDm982Udt0xaEznjh3TeP60mKDzk1Pvy1rBFE6WwaO8TA8d3th2iScuHt p3Px/yILO6VwNJiENXLjQh/zBEl5HM78A0pZD5iUWILmoxYKJ5g== X-Gm-Gg: ASbGnctLdOaIRGM1Hjskg3FVys1+ddMxnoCJ2mh614SorUx+UZPFs2XEiIzprp/3Oan 2czCG9gtFrOwCIH732BpH5Yoi7J3xBkCzR/5CzG3THao+realwA/66qpIOmKbEJTO60Hhjjo0Bv cWaU7OKXHprtYBBH9LFKl3AmLkl/pbxPJxX01bmzdcK85KLHYkFlD+f5HgbbhZ+X1APF2VcmNCo 45JK7zbtaV7wGGwSoxAG0Bm42VG59aOT8P7drdwUcpHw4YfpWh9AKoCtwWdH75VEWnqQMcAOF3S Inm4gzVcC4Ryp6foYFSx/IKJTVDpY1PQbPD8icGhvb1UkWhdmg== X-Received: by 2002:a17:902:ea06:b0:216:45eb:5e4d with SMTP id d9443c01a7336-21c352c7921mr57027415ad.6.1737151517389; Fri, 17 Jan 2025 14:05:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHk7q6iHrRnd1nXp+s+RpidtLrv0uU4L62iDyixRYGuxhfV0N1Xq3R/zhpGVH2sq0L2lUGqQg== X-Received: by 2002:a17:902:ea06:b0:216:45eb:5e4d with SMTP id d9443c01a7336-21c352c7921mr57027115ad.6.1737151516934; Fri, 17 Jan 2025 14:05:16 -0800 (PST) Received: from hu-eberman-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21c2d4042f8sm20582705ad.236.2025.01.17.14.05.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2025 14:05:16 -0800 (PST) Date: Fri, 17 Jan 2025 14:05:13 -0800 From: Elliot Berman To: Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com Subject: Re: [RFC PATCH v5 01/15] mm: Consolidate freeing of typed folios on final folio_put() Message-ID: <20250117135917364-0800.eberman@hu-eberman-lv.qualcomm.com> References: <20250117163001.2326672-1-tabba@google.com> <20250117163001.2326672-2-tabba@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250117163001.2326672-2-tabba@google.com> X-Proofpoint-ORIG-GUID: VF3sEBRGUZ3NTnkr3byDemq-zOg8CfgL X-Proofpoint-GUID: VF3sEBRGUZ3NTnkr3byDemq-zOg8CfgL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-17_07,2025-01-16_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 phishscore=0 impostorscore=0 mlxlogscore=999 mlxscore=0 priorityscore=1501 clxscore=1011 lowpriorityscore=0 bulkscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501170170 X-Stat-Signature: 85aarko4a33z9nh7fepg8f8pgcidw3bm X-Rspamd-Queue-Id: 802B8A000C X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1737151522-217866 X-HE-Meta: U2FsdGVkX18bMjZulClltiW1EnaZEMX3c9u5smMHklE82FHPt2O3N5nuYIsUi71wbiiQvWhX5cvfpJ2IO26Bo5U6AzBRA3hIXdIAwWytvZZqyndULBnC5wQvysKQyyxNuf40+anFrVKFL/C/zQ8MrfG2Cm/L6F80jR7E7zMV1H5yF9zubcV1TY0UXWCc8kraP92VQi4u725B6to95K67HQVZmA9Q4uCUGvqHvLbyTy/RrX6NmJXb674T7wF0Th5PmYyIQxiM9ELKrJfnVxG++98mAX1rUyZ3GWsa7VXI3vtS+Xo8XUfqHVhO6ta6XpMdEzZtqUgipyO2JjMeS9FhBetyt7miy8SwkvqiBNbKLmMOkow0d6d6rpBOrbUrnIOluLhSW3igS5Sa8wzSnjKCpImbab57sweVcP0xRvlQSbfPDsGCujjd78VBEcrl5QW1k0Yy+RgRZsVEUQwGiSheQSpPL/p/cEYfdtlnqB7vPhriZiMls9h/Qh+nU3iYyIbhSyC82tJ/LG3/qnlZl2pysyNrGWkaawCZzu5aeqnRD3NRW4EjG7VZgwxvING5+mmeCmPiFRNnKbzSdjDfLnkXD7PgQhbX8Hn7VMyWaMTf+ymi6zifQnDuUHgFNbqlXnywB18vrznNvrG/XRh1Uw+of6Ruu3jQrVjObGdMiKAu/fzf95Drd+J084ivwK+p2pSWoL/GWdQEciknTyIMOzAoJRUGPdKYn2DujjAFQEZYP3R053f49bC6NMNAY4/5NqVxZhGekVSDWjl33cHLgbIXwz4GtOMx9iwbofSoNSedzgxo8wbHyg7od7jpeKkHQ6WrlJ5RNcxkgbou1390gyo43I70Ybc9Rpr4gfwvab+BrOtMvBlZlX1AjnmnmtlREd0JnCAVcJHpV5EEykkVIEtqjkVBBctEgqhClZbXPbMtGdQckbhF5nAIkN7yV6bBlbV5ECicDhEI+LD+TPCz3Io X5BA5m7Y c7CXVmQe/+PCup8vgbCucLDPZ1DhWzOM08tqQ2YwConMANDzgS611ejgV+4pEdSiycUSWqCAOcv2Xi9aC9FUnVyjboaHQGGqftPP/an4bQP2zSDCDoFksJLGYziyQQVHeDO7ehROr/jneopRdXWBNHlNB6DPSurp1ymUcZaagbAyEr21Ht5+yZaVRFEaK8hbYmnvnv4aSqoQd7/0yXjfotVpDjFh9NVyl2VNU5G29+TFoPw9DEjBOP+pf9E2uIlw35PJBlO3/Z/K47xRCoHQlzh0YZR6zu7ub+VeertbTjBk41aCP4wi33qaGK9KGiYXXhttEPGeL6TKv7+n3obgS0wBPY86+Kd6FrR4eOtgK4Azf1rtXVNmMQeLzBL+Z7nBJx2Olo1XMiqg27XtLy1GKlw9luOkauriS2l5AIYnAFapAIjlNT+YxGHp83Oqv8/WTPCN4qpACVzxPYeqbucu2URZIG0PbJhn7axLU7xRGNZ/t0S1oe5DCZ6dPSM6o7gonjqa5v8DlhRAYmHcYeB8YqNqc0w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 17, 2025 at 04:29:47PM +0000, Fuad Tabba wrote: > Some folio types, such as hugetlb, handle freeing their own > folios. Moreover, guest_memfd will require being notified once a > folio's reference count reaches 0 to facilitate shared to private > folio conversion, without the folio actually being freed at that > point. > > As a first step towards that, this patch consolidates freeing > folios that have a type. The first user is hugetlb folios. Later > in this patch series, guest_memfd will become the second user of > this. > > Suggested-by: David Hildenbrand > Signed-off-by: Fuad Tabba > --- > include/linux/page-flags.h | 15 +++++++++++++++ > mm/swap.c | 24 +++++++++++++++++++----- > 2 files changed, 34 insertions(+), 5 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 691506bdf2c5..6615f2f59144 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -962,6 +962,21 @@ static inline bool page_has_type(const struct page *page) > return page_mapcount_is_type(data_race(page->page_type)); > } > > +static inline int page_get_type(const struct page *page) > +{ > + return page->page_type >> 24; > +} > + > +static inline bool folio_has_type(const struct folio *folio) > +{ > + return page_has_type(&folio->page); > +} > + > +static inline int folio_get_type(const struct folio *folio) > +{ > + return page_get_type(&folio->page); > +} > + > #define FOLIO_TYPE_OPS(lname, fname) \ > static __always_inline bool folio_test_##fname(const struct folio *folio) \ > { \ > diff --git a/mm/swap.c b/mm/swap.c > index 10decd9dffa1..6f01b56bce13 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -94,6 +94,20 @@ static void page_cache_release(struct folio *folio) > unlock_page_lruvec_irqrestore(lruvec, flags); > } > > +static void free_typed_folio(struct folio *folio) > +{ > + switch (folio_get_type(folio)) { I think you need: +#if IS_ENABLED(CONFIG_HUGETLBFS) > + case PGTY_hugetlb: > + free_huge_folio(folio); > + return; +#endif I think this worked before because folio_test_hugetlb was defined by: FOLIO_TEST_FLAG_FALSE(hugetlb) and evidently compiler optimizes out the free_huge_folio(folio) before linking. You'll probably want to do the same for the PGTY_guestmem in the later patch! > + case PGTY_offline: > + /* Nothing to do, it's offline. */ > + return; > + default: > + WARN_ON_ONCE(1); > + } > +} > + > void __folio_put(struct folio *folio) > { > if (unlikely(folio_is_zone_device(folio))) { > @@ -101,8 +115,8 @@ void __folio_put(struct folio *folio) > return; > } > > - if (folio_test_hugetlb(folio)) { > - free_huge_folio(folio); > + if (unlikely(folio_has_type(folio))) { > + free_typed_folio(folio); > return; > } > > @@ -934,13 +948,13 @@ void folios_put_refs(struct folio_batch *folios, unsigned int *refs) > if (!folio_ref_sub_and_test(folio, nr_refs)) > continue; > > - /* hugetlb has its own memcg */ > - if (folio_test_hugetlb(folio)) { > + if (unlikely(folio_has_type(folio))) { > + /* typed folios have their own memcg, if any */ > if (lruvec) { > unlock_page_lruvec_irqrestore(lruvec, flags); > lruvec = NULL; > } > - free_huge_folio(folio); > + free_typed_folio(folio); > continue; > } > folio_unqueue_deferred_split(folio); > -- > 2.48.0.rc2.279.g1de40edade-goog >