From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 974F7C02183 for ; Thu, 16 Jan 2025 21:18:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29ADE280004; Thu, 16 Jan 2025 16:18:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 223A3280001; Thu, 16 Jan 2025 16:18:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C49C280004; Thu, 16 Jan 2025 16:18:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E2635280001 for ; Thu, 16 Jan 2025 16:18:12 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8228A45D11 for ; Thu, 16 Jan 2025 21:18:12 +0000 (UTC) X-FDA: 83014578024.10.111A1FB Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf17.hostedemail.com (Postfix) with ESMTP id E3A5240013 for ; Thu, 16 Jan 2025 21:18:10 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="sp/vGnV7"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737062291; a=rsa-sha256; cv=none; b=bPZGnpYNxmB43KpQNge46Sf26eeN6oyIUZOCy/bEMArJs3hmuabjg9bD5RjOnfo27SLDvO pWJz7q5YfZqOZ/zgR66amHoUnek/LEvMm3RvioJ5YfoK7YZQMRx8QUybNnaUDFwyLyVY4h Gr2f8skDbHsguC6dK1XYOpgabj6y3bw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="sp/vGnV7"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737062291; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=17CyKbHriyy2mjAPn9Jsu5Zmzd2D10Ftgk/R2JMIvrM=; b=D62xpFzGweJWHj6bGq/hfOrzeuaxcMQKUeEv3avjf9l1VNo0VnCxnUiAkwXBZXkabx1kDN GO9Wj/mj+ENita0z98wljayu2giANL3zbjjbwwjbfP5ivqjE1BS7t+un7dJw+59wg+fA8H twc1e1LDh55a4kwF25cIEpGjnvcK9JM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 1F629A4279C; Thu, 16 Jan 2025 21:16:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92B05C4CED6; Thu, 16 Jan 2025 21:18:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737062289; bh=4nU4YLVck1cnanHF7eMWqo+M3LlO8RKHg4oPPXm0JUU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sp/vGnV782r6dokBVUMw4LBXzeuV/pkXLah8svGVz7vrXFbcH+HpCYIBp07gHN8GE BU5qtIyjasfZIvGuTY7DLmf3+nVhjnUcJnrhBaRGeCQBrh06W2b8UP+ToV0DXExWb8 BKyeMd+qNGnivWiDdr9A+/Emk8JdkXVo16mC+RD2irJOB1cfxb1t9MRkcvnq0gYEv8 HrDcou7cv7TQ83yAk0nPera34VccZgkj3iLS7CBXIJ8L9hmaBbdV1zuM+lyt2clFqw maNIi3lreizSXILps27sk2Y2nJEb0gEqXBjcZCF5IjQVsJiKCICCmtWB5xOqF1gpe0 p8dPBOrIuoThw== From: SeongJae Park To: Thorsten Blum Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon/core: Use str_high_low() helper in damos_wmark_wait_us() Date: Thu, 16 Jan 2025 13:17:58 -0800 Message-Id: <20250116211758.47368-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250116204216.106999-2-thorsten.blum@linux.dev> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E3A5240013 X-Stat-Signature: m3a36y4s8977jy4u6946mk6tbojubhqp X-Rspam-User: X-HE-Tag: 1737062290-765336 X-HE-Meta: U2FsdGVkX1+RN54GwB6xrvgHzxMmAx91K4Af5hVhTaJlkhm2s6Yaz6Z6+nKZlKg87P/ncNmxnZO/etv6SZy9tMjBJ0Sm8eVRVsaD1Jn1ZasJJpc1ELbSY59KLLnAQsEARltg2OY9qVtByK76Dr83LzloxIc46krJasIoZauXlx4/XKFNeI897Oa0iEnWA00J3UG7PaKKOMQnPcb5ZGnmAOq25BN/gWpJA7ct6nOmoq60IF7PUu7wHoyB/5X3J/Nwt4Etf6gzihkAtAyK9msCAr3HJ2NRjEL1Nohhki3MrlK5G9OkiQdxh5Aik3nI9EwvOR04L/uIv1IooO1AwTGxlTGeBzTSF99cpQRqkMBdsrUVCySHWCaQQ1EYhocnRjnvjO7/SMNZxq7MQEnCUtqzCKeUNNlvU+4jodhEhQkekqu/9IBoHUXvC7klG2ICZt73YIn/skwtZIT/bNKzUbTzaB+wlT3OdJwsaPJc2hI5zTXltVOPWOaMDsecb2pDXO22RZlCmMb3UtdxHWsmVzjS0Sc1gEvPAwfS/KonujauCrAqB5Zqh2gwWpr4xfBbxZFG9WKr4BszjVQhBLzRSB6X8tVIjlM7JhbU8nwbEr9tOH57GgNTeMdoTRAZtPD52+1Noxzuj6ZEUQhVj2oPEXXtXaca7GtQyiZsNR3zWDa2v+1ks3tIXuG1RYrxnEv1iRHEI3C1w6Wm2D9zgdfsCVIBg5IiwZgpU8ZRnOKYc/2gSq5rYU/7j2+4IwCRvz4ZL3qe42pA8qxnw010lDyZqwaBoZ09jIf+wWlG0FwM3PERXi+PhJuc1BdegeeF/YiAddLNa544yv5qL/1GRGBOywUE9VKucO7ej97b+3bT5uVATwK5JaF9cKzxtqaJUKMvLdaSxcSE9pIAvN2KlS3WYMlRFJcD4gvqjBt7oViPmlIOLMy6OJ/eI9xlFrK1Rdq5Vio2zNIZb4N7frvT/Nzvs5b yT4R1ieE gZNwH+EW9uTaTPkWiqyWxK9YAJ2N77jEylWOqxt6gKCY4nvkuAINlmLGRJR/a/aQJlZesLtt2pCnktZQqR6DY3V4ppGbWNbEMovtLqlyJM9tlE0mpvmEP9hfvTTZbxs4LcpL73IdTPwV6SvS1OKM7tw2Hlbe8SP0DuxJ4DUvKN5CsNZbMolrs4KEGIuNJutKYN1I6TLMzeBCGVL3j9pDaepSgvzMf/L7HfVN4/tsimQoelGPP/Sq3ahmYIfnpbXS5cOXO7GoqjGrzdqWMVxfDJt3xXvEwDOyqVWVlIaJ7YLfjfOaxHuuzS63dFcGhRTEM6IzU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Thorsten, On Thu, 16 Jan 2025 21:42:16 +0100 Thorsten Blum wrote: > Remove hard-coded strings by using the str_high_low() helper function. Thank you for this patch! > > Signed-off-by: Thorsten Blum Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index 0776452a1abb..ae1715a338d4 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > > #define CREATE_TRACE_POINTS > #include > @@ -1894,9 +1895,8 @@ static unsigned long damos_wmark_wait_us(struct damos *scheme) > if (metric > scheme->wmarks.high || scheme->wmarks.low > metric) { > if (scheme->wmarks.activated) > pr_debug("deactivate a scheme (%d) for %s wmark\n", > - scheme->action, > - metric > scheme->wmarks.high ? > - "high" : "low"); > + scheme->action, > + str_high_low(metric > scheme->wmarks.high)); > scheme->wmarks.activated = false; > return scheme->wmarks.interval; > } > -- > 2.48.0