From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BC64C02183 for ; Thu, 16 Jan 2025 20:12:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E4B76B0082; Thu, 16 Jan 2025 15:12:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 96D686B0083; Thu, 16 Jan 2025 15:12:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80E3F6B0085; Thu, 16 Jan 2025 15:12:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 61C9F6B0082 for ; Thu, 16 Jan 2025 15:12:31 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E2F9A1411F3 for ; Thu, 16 Jan 2025 20:12:30 +0000 (UTC) X-FDA: 83014412460.30.B9F6D5C Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf12.hostedemail.com (Postfix) with ESMTP id 53C9D4000C for ; Thu, 16 Jan 2025 20:12:29 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of "SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737058349; a=rsa-sha256; cv=none; b=NovZSnBbpfapXVJS3sSNBZCU7Ko28tBK5I8gjNqFdNuTiWG+wjuURtwsQ4WOck4FAkGlWl fKqIO9TaYxdKSZPWMVhSrilEaIPE664d9Z2bMWYOmaIU3RKpzR56vwbGzN46Mil7hBztCq E6JdTQj3ODsfZG7jwBrpbFvnP4FDy8k= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of "SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737058349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2nOR4l687lTSoeUme61v0hYtVFEYXfbPNGL17lcOV3M=; b=pY/sEZFBE/kIFy3m4F8sHC3FiKGZTiefpZKp0tO2TRqk13OWCESRygAj5kXlxwQq49kylT CTaadiRssrA+zJK1/HnZ/Dp4ttnnaGOywUMoVRws8tempE09FMYiQZRyjSSgOk5+blJp98 cxhVYCGT9v7BnRyV40zlI2DZbqiAtGI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 983E2A427AE; Thu, 16 Jan 2025 20:10:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A53A8C4CED6; Thu, 16 Jan 2025 20:12:26 +0000 (UTC) Date: Thu, 16 Jan 2025 15:12:32 -0500 From: Steven Rostedt To: Linus Torvalds Cc: LKML , Linux Trace Kernel , linux-mm@kvack.org, linux-perf-users@vger.kernel.org, Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Michael Petlan , Veronika Molnarova , Suren Baghdasaryan Subject: Re: [PATCH] tracing: gfp: Fix the GFP enum values shown for user space tracing tools Message-ID: <20250116151232.4cc70a51@gandalf.local.home> In-Reply-To: References: <20250116132359.1f20cdec@gandalf.local.home> <20250116141800.31d519eb@gandalf.local.home> <20250116143018.0b156e42@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 53C9D4000C X-Rspamd-Server: rspam10 X-Stat-Signature: b7qumm38p3qim7fmqucg648amy9tyi5f X-HE-Tag: 1737058349-779778 X-HE-Meta: U2FsdGVkX19Ao7ScZ9ZttgZwceOqdUgt9dsEWJ92dvAtc31PYN0AmLIRGDxlrV90+g/9HzeVxoK03tH85gF8Afe8dQW79P/SMHC2EEqAY1kYJQ2VV09sj8LHNY4GgK2ohXIta0WLt/LNrGB4GowCd+mbFe3rmE0Qhq9YUdjsyumL6lTC3skTTiuUmBxYFfuxTHQo/GM2Xm3HAOwuh+iPDvLTFoLTsJwoLmb6OpR5lLnjvo+u8RZ1jtvGzEOpYNTz9GCT2284hj8ROGr4miAJ/WW6AtNDSLwqSvTN0Ib02NGaoRdlwUXStB3pCJf43UkvNscavBYTVrA78mR9HJUY5oLXEeQDkbIYfOBpnR5Qhzezab11nqs4g1bdLR15DdE2IIKhjEO3VyPvH3ErwO7X2smYYk0bmZ2awgQYiJmY4qcyg9HYcTUUZnLIgtx6+Jetz1IO+Bhnt/a565S+nNQChBbmONTOAFoExzrY5Bw7/94Xwgxv450zwEFQ0ksBiv6KCctrc5Cd5vccc5famP7AbiyHJCHNfkmQzse4kH5pdrRie6UBueGimGv3GmPipbfFgikFlk1/A8D7J+3Wp4hm8A3UG6BDDuQdusX6wx9tgGuycW+xj86E0HJvH5dyV6O+dx9E03YOmxLxH3k9osJjWUzcku5dB0JTB9A/IOLrgRrw/hL2RJdjVB/UfP8TRWwS8eqa849UgZ7RJ4l96bJtuo/bsLBsV5nlysn4v1VJXLBqEIoemgLF7ClgG9L4w7fMzcRRMIBs9AhfO15phPsOUjyTVb8pUMlOKX/4zHT2OxUXZcUODJJjKK8B2P7uFZQyl/iqfXKklQAATOc23FPlAxkL3Sr20FXy452mm1dxJLhBeGb3taKVyKdMlvY8/YaWH0iFceMI//OtbL/GuqKdbEwa7p9R+Q/9iQU+Iqbqd3rkqhGESY7hdrWl3t5nnuLjZGdnarFR30hGdBm8rYC cI2TkRp6 +dnrWKdYM4R0RXejXYjiSg0LB28qZ35CHQq4ZyoV2jvsG4cjvv9ZVpnb2NlTXyfBw4nLnKxoVpIf32deTmyVw0vtIuAsnURSvdGD8EpdCrvBp9ZZ0JDnIy4f2XU0RnSF0FGYzzI7GR+YdLcanjMYKMFCVCvcSD7Y3DLnvvAhtv56A3OhJ9MiCNEzA7PDdyFb38SnxudW70LkPdTvfTtgezPWm/p4tHu+RL3yiVBpXjt+QbwzjbIUioPE7/z0oISJldg77J3ofegZtD5gVznPHRERjUWI9s9ssrpjcjGZtSoEDfvIygTxPrPkw72ddUHbKMR9gXySPnndNsSOESEiARg7I8ZNdqbk+QrATKzFb/wSJoxc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 16 Jan 2025 11:30:52 -0800 Linus Torvalds wrote: > On Thu, 16 Jan 2025 at 11:30, Steven Rostedt wrote: > > > > Would it at least be OK to add a comment there to update the tracing code > > if a new GFP flag is added? > > Sure. Heh, there's already a comment, and I can make the changes there: /* * In case of changes, please don't forget to update * include/trace/events/mmflags.h and tools/perf/builtin-kmem.c */ enum { ___GFP_DMA_BIT, ___GFP_HIGHMEM_BIT, [..] -- Steve