From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B789FC02183 for ; Thu, 16 Jan 2025 19:49:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 230DA280002; Thu, 16 Jan 2025 14:49:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E198280001; Thu, 16 Jan 2025 14:49:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D0AC280002; Thu, 16 Jan 2025 14:49:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E34FF280001 for ; Thu, 16 Jan 2025 14:49:21 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 978881C7560 for ; Thu, 16 Jan 2025 19:49:21 +0000 (UTC) X-FDA: 83014354122.08.7031744 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf23.hostedemail.com (Postfix) with ESMTP id F2C85140013 for ; Thu, 16 Jan 2025 19:49:19 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of "SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737056960; a=rsa-sha256; cv=none; b=f4D48HwlXWV+QOHGaDMwVbsFRkW0J/kz336n1+DjWH+QQnUl562SPLpFOYvN30aXsnU/Di Ph3u3BJukdRu5vEhK6DqhhLEgVrIaE+W0qkD3Pci7uQkVQoZc4tLUdx0sNg0GhtzJo2HaR QD2yOZ5w4D/qAHG4XA2SYFKPB7ERDyg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of "SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737056960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lZTgHaMarGug3XjHKoprNugtPde1H0Bfdo1CYGcuKYQ=; b=VviFMh10ErrUnpgBM86MUCuqsPH0+7BwSCQuOeUnvJabFHfsKGTUek6r++Y1A0x/MNP79s UBWAuIZDuqZxSueA1e2/3gHbAnO3eeLjvZ8nGQu0oQiw198ALf18mvIIwqYpiJ3QmNtlb1 Hu/xwFSfSYFl2UZ34BlV0BOdwyOzga4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 5FB36A42789; Thu, 16 Jan 2025 19:47:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF67FC4CED6; Thu, 16 Jan 2025 19:49:17 +0000 (UTC) Date: Thu, 16 Jan 2025 14:49:23 -0500 From: Steven Rostedt To: LKML , Linux Trace Kernel , linux-mm@kvack.org, linux-perf-users@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Michael Petlan , Veronika Molnarova , Suren Baghdasaryan , Linus Torvalds Subject: Re: [PATCH] tracing: gfp: Fix the GFP enum values shown for user space tracing tools Message-ID: <20250116144923.6b8cda97@gandalf.local.home> In-Reply-To: <20250116144341.7e883931@gandalf.local.home> References: <20250116132359.1f20cdec@gandalf.local.home> <20250116144341.7e883931@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F2C85140013 X-Stat-Signature: zhufx5bkcietgzsz8tyyburwyck674yh X-Rspam-User: X-HE-Tag: 1737056959-18266 X-HE-Meta: U2FsdGVkX1/0R7pUaVPOuHThPZxrjL/PCYbJ8wxbwG54BWHbx2CAQEWDUjDlW3G076MOQlM0wUGEjxLepOF8ebOmMbw9VDWtIpOMHxnHreWcz3bhjQgsfMknoIScfsj/MPIXE1lqZyh7MiURjYCQZSkb4kG3sA06fr/V2xS8x6KebfpF6EoUmfjJzb3xsFl9jJbMZ8CkTOkD58P/QY9AYGywEd9lfBxgDB8dUTRzkGOe95pcTM4Zg3RgNRXHIoWw/s/Ozx8Xjx6KcY4g2u5rDS1hvPKkldGyR4ob72ZolFGdPSR4Q5IbayrZmwiGBnkjRMrIj22XI2myD4cn4jTNj3ZlOJngvjEBUUU40P8TibU3MrtOXAduQMFV9bUqzzW3eA1NWiIGyqVs+rO812aP4zzOybadcg4Lr3uAUmRCtd0MAY/qRA5O5vNSUVwOhEVqLncxMqYty7cUMdXRSPfmhxYXxBlUJjjsc+2YlUWv6TrRa9czAKWNEIAszVMvI/+36DHci4aZvLVAPMw+/gx2ukm4uPHfIrNRT8REdbnvTlTUtRse8ut2N8j5SAdTpjBxdBz4P+F6cChHc9FHg0Y2yWvlLQ1rFvb7NHdIXLYcnnbdz33lGjv2C4h2ckDh50QfwzCDv2fGMBseiPao866RjNDwfxS3gItwGW3jmyorqvQT92Lci5JypxYtsLDumrHWOw2Jdl9Z35wBqwIUpS0R+5RiQb2Lehua/nA66PYbkGsJWSHQk87R9dQ9r96K3rnG9OGTRbbn0nDP8C0tiV9SiJz0hbHuDDxMY1mpcvslCj49TmDhfrKnoYuqiHt4LLmPXbbxZXoOvDIdWnNeCNmxSFa30MxZ07n+nwvLKHTfRww1BQAzSVb1fSn0vHbOJp1GVDk7IjScAzEsvg2s99Jg8pQQi2US2EzKnxnO8Iu672/NmZ9BoQeW92deV65vMowpcxdq1GR8x9klI0t/Q6e jnKSXH6P W47yqRf3gKDc9iPvsF5NIq3ql9WabqGdeWnisC6l+WaZiXBbBiDv9/3g3UyuH+CDRsivYbvvy/10YGtsKAtOXFiucM3m4GM/xbbSC36mH06yKuNWl7CUr7B9sJSW2qGkA/x6BQq0KhgPswIv+/s3i+POIqneLUIY1HqO1UgT8SsuImeONTqtmnzQ776GfgEDtC2POoPoQdBioB2ObB/HFuoV0WfayvhTIbPZS3vAdVpkNnRNtUdkinVqj1OECr2Geff0tRFCuKrFdUoTEMLnTjQbW6fBTizFIm3XmxYLDHHDGcxgin3Z9aYwh3g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 16 Jan 2025 14:43:41 -0500 Steven Rostedt wrote: > I also tested this only with the above define in mmflags.h and just added > it to kmem.h before sending out. It appears there's a bug in the > TRACE_EVENT_ENUM define that doesn't translate the TRACE_SYSTEM properly > and it created the same variable used for both kmem.h and mmflags.h and the > build failed. > > So v2 will also include a fix to TRACE_DEFINE_ENUM(). Never mind. It appears that the kmem.h includes mmflags.h :-p Well, the TRACE_DEFINE_ENUM() still needs to be fixed, but that could wait for the next merge window. -- Steve