From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6A9DC02183 for ; Thu, 16 Jan 2025 19:43:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 400846B0085; Thu, 16 Jan 2025 14:43:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B11A6B0088; Thu, 16 Jan 2025 14:43:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29F1C6B0089; Thu, 16 Jan 2025 14:43:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0BB996B0085 for ; Thu, 16 Jan 2025 14:43:40 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A41AE141155 for ; Thu, 16 Jan 2025 19:43:39 +0000 (UTC) X-FDA: 83014339758.22.54C9729 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id E036D100007 for ; Thu, 16 Jan 2025 19:43:37 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of "SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737056618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2yb2IdoTzdOzvZ2pJpFP1mee9oukZ3Kw6QhYsMhuOkU=; b=o6E8gzKztSwRygfJj+O42I1V+s04l6AemFQ4PIpXiSLUGTYBzKFEtk0UUaCLP1UwxZWoj4 tGXTvZHmUvYJ3ob2+7glHJhH744XPA++A0hFKL1UK3y8GyA0Zi4VsttVmIuVDsEMlJGRih OpHE8Mawv+ab6UX7YgtRHVM8uu0lDo8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of "SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737056618; a=rsa-sha256; cv=none; b=uyPRKQap/8LX3GAPfBi2vPQW6BlXARL+J10hxmpFti6ZbxLjXs9ogMxPue2c3hcQKAV31O vG0R1zip9+8rQnfrjSDajj5jrb+4LMqMarL2Intc+uNA4s/Y83M6ec7uIeiV8JpPkM4lBc OxYyD8kuzgwxAcz+RmbRIAR63Xn58YI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 700C15C5B42; Thu, 16 Jan 2025 19:42:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A32ABC4CED6; Thu, 16 Jan 2025 19:43:35 +0000 (UTC) Date: Thu, 16 Jan 2025 14:43:41 -0500 From: Steven Rostedt To: LKML , Linux Trace Kernel , linux-mm@kvack.org, linux-perf-users@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Michael Petlan , Veronika Molnarova , Suren Baghdasaryan , Linus Torvalds Subject: Re: [PATCH] tracing: gfp: Fix the GFP enum values shown for user space tracing tools Message-ID: <20250116144341.7e883931@gandalf.local.home> In-Reply-To: <20250116132359.1f20cdec@gandalf.local.home> References: <20250116132359.1f20cdec@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E036D100007 X-Stat-Signature: pbgst9zmx6d8powioncxny7yn7x5zgt9 X-Rspam-User: X-HE-Tag: 1737056617-523283 X-HE-Meta: U2FsdGVkX1+Lctoru0oX3JNN4st2RyYt+JzUEnUPH2kN5UtMHuaWBo43mIKYeXX+n1hN4qCkVuTM8+4Qz2DmhILZnuMWcY7KPuhtm5hQMhqnYleVp/sasunxSFKIr5FlRYYArlnKbghKwY0URk0SQmciHeTtbREd/Cu/k+g/GilgUU7XwSIpt6UgoWkpMXCm4W1K767ZXcZGzVQh2ky1LeOs/QhXbs3dHtNrEsL5L73zBl6mQ5zG1IVWCf8PBB5mVy47bRLsY/z4dA3oU0PYQuJrw6vKSK979mAdNUzv0U2Jv6pY1ZsAg9AmdBCbLGpR3XAD6LoIRokUgLsIt4nDekYcw9IBzA5liZRsRZSIfRCvE71VcTyJhE1aFYKhKRasXSYzCJXhJF4YYSIp9hlWcgXO7JRjg7+NuBkQJXVJ/XjnGkluL7TU+RS4otK5tyfzBq/B/lGv2ch1OIms4KdS8fVVZnoEp/zcyjPEYnKXUnxyfDY6CLRKBgmuO1OYO7y96b2JCJTNWYwrA/Zs8doyE98m6DmmzESeZjbg2NMrevfRa8UVSYJ06XuecU5xCpm94FNcNasc2eyn2ZBBLIJLe7J6/dqOETKuzXMk9lRlENI9TT0c+XFXSO4GHeXIrJiDhA48YttTEWiCxhKTcOnhzJyCqFXolvEYRAqGYtbXmzlpDYjEnqaHv1K2CHjUqUkfWXPYOHgR8+nmeYpgRY3y2+BeG2ND5h3DrRQH+QshW2f/oeqD/OhvJN6BImti/NCrzuGaoxSIFFLv/U3dSH9eVU/3Mmnej1NPwv7LqK173oPiVtgcgvT0wTwp0adu3b0rq7pxeytYmNvWpiiLETgQQjAH9SdgDCxRNTG9hIrGoSI2z6ujMuKfMs6cdi2S3gMUpRjDY+gHj7MoJBUGhqRa7uHd3tz2BwZiqB5jpG6qmVAy1/eP5JEFXo+rRu7QftJa8MkyqARq5yzMEU6EKGi 0Rxe22Qe 4MrjoOclUBz59eEwxO3P4ZFlplDMsrvgtGBQ3GlrL0zXEwTnIBedwbqoG/4PMkD3X04twiFYEhbNBiIMrpAQBZhhP1nuGzpusAQVPGmnNz+/2pVMR+BVNDcHrcI6/voSqG0VAVjRwVp3Nz9MCRQasAS9gS3GCqlr4yKrKqBStC4nXEaPbB330ErSwqJXjInij+3Pbfu4X5amkNmpB1dytF4SSwkR19Uo5uCXIinUNcnEA1HmcOPXS2g+EsMM2r/Du4/4Ql1NKwZd4C7snbb/R6Sz/OqZo2uY0d65Qo49eznJqxzruPNevnRHBJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 16 Jan 2025 13:23:59 -0500 Steven Rostedt wrote: > --- a/include/trace/events/kmem.h > +++ b/include/trace/events/kmem.h > @@ -9,6 +9,8 @@ > #include > #include > > +TRACE_DEFINE_GFP_FLAGS I also tested this only with the above define in mmflags.h and just added it to kmem.h before sending out. It appears there's a bug in the TRACE_EVENT_ENUM define that doesn't translate the TRACE_SYSTEM properly and it created the same variable used for both kmem.h and mmflags.h and the build failed. So v2 will also include a fix to TRACE_DEFINE_ENUM(). -- Steve > + > TRACE_EVENT(kmem_cache_alloc, > > TP_PROTO(unsigned long call_site, > diff --git a/include/trace/events/mmflags.h b/include/trace/events/mmflags.h > index bb8a59c6caa2..522bbe3a5fe1 100644 > --- a/include/trace/events/mmflags.h > +++ b/include/trace/events/mmflags.h > @@ -15,6 +15,8 @@ > > #define gfpflag_string(flag) {(__force unsigned long)flag, #flag} > > +TRACE_DEFINE_GFP_FLAGS > + > #define __def_gfpflag_names \ > gfpflag_string(GFP_TRANSHUGE), \ > gfpflag_string(GFP_TRANSHUGE_LIGHT), \ > --