From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03D80C02183 for ; Thu, 16 Jan 2025 19:30:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 702E46B0085; Thu, 16 Jan 2025 14:30:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B2D76B0088; Thu, 16 Jan 2025 14:30:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A2266B0089; Thu, 16 Jan 2025 14:30:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3AE6E6B0085 for ; Thu, 16 Jan 2025 14:30:18 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E6072141184 for ; Thu, 16 Jan 2025 19:30:17 +0000 (UTC) X-FDA: 83014306074.27.0B21665 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf24.hostedemail.com (Postfix) with ESMTP id 3C02F180009 for ; Thu, 16 Jan 2025 19:30:16 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of "SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737055816; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G2dU6ibk/zQQj/zgr25j5NlarLzl6Brr57lWl/9lotc=; b=geukqoTJIEA48yRV4tB42nvAg6mFiji3poXsz0NwhtfdQhJ1Q7tojOzUxIJjZEgY0LZ3qa WIf6N9VJfgEDBXvNYVvTp5QY0zkbaTPFr3nw1cXX0blYjiNKOAaoZ8N1lSDpg0m8xuV6MT EOus5schgKmIFibkwSuk8OfrfWMpyk8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737055816; a=rsa-sha256; cv=none; b=YvWXPwqmz4dBEMdVvVfvf2ZHlwsforQ57xVLD8TF7yQFKB3fDr1HcggPcG1vjTUikyrcnV OIGB+34qBdH503u/jp2gOOGG9Ske8vht/rUD9MZkXOPaxoqnPb75Fq/5E8Ro0w/FOpXXM6 yFJXkSJmZu/pc1q0HYNEqU5JvywFa/8= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of "SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org"; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 3782CA42750; Thu, 16 Jan 2025 19:28:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52A0BC4CED6; Thu, 16 Jan 2025 19:30:13 +0000 (UTC) Date: Thu, 16 Jan 2025 14:30:18 -0500 From: Steven Rostedt To: Linus Torvalds Cc: LKML , Linux Trace Kernel , linux-mm@kvack.org, linux-perf-users@vger.kernel.org, Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Michael Petlan , Veronika Molnarova , Suren Baghdasaryan Subject: Re: [PATCH] tracing: gfp: Fix the GFP enum values shown for user space tracing tools Message-ID: <20250116143018.0b156e42@gandalf.local.home> In-Reply-To: References: <20250116132359.1f20cdec@gandalf.local.home> <20250116141800.31d519eb@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: rzrfghuo8ejywa6388wjubrurbn1baqu X-Rspamd-Queue-Id: 3C02F180009 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1737055816-226644 X-HE-Meta: U2FsdGVkX1/pL6kBc+I3xI/rpC19XO0dhL3TpSDQZWSpB0nV8BJNpPV1DW8uhYPa3HAJl6lwuxmQBPMIz7Bf8NW2F00oM42vbRlYXkfrmAsiQz6SfeZ+q4r/bLL60HHq0JK3PpOtIeXomzEsU77H2Z2uPmdndnfFWFh+8rVfer0ryR9UrU5POG9rCzO8laQOSqFEB51eKLCNzabgJm8guGTR21jzzlYxgakZg5IXr2Y+zgNYpggFQINynEx/gnOLYHPyB+IXi4GPxuNBeMOA63u+LV1wrnHPiLYNafhUDVUMnnzsfY2hjWRS1gIT9VSmJIuL6IE8JE4Q68hRvTJfHuevN0cS7Hd0AV45wXATKP9iJtTX2wkgCdnncHNomh56PMkXcGckDXccWruSgg+DskDqWsu4wxhPs5kuCxRsICe16ip3HKiFQ5JeO4Xv9fKrh/zEF/ioMP43cbYDbVQ5G2w6t5oe+Ou/MczEzqj0sejc2OsIxS5ZHRG3tAFzMGxBWCGyX4bdiQXWvZnZlik2rcTrhrtq64k9lUvV26IYGU5ty+MAWIf9dCKr42hM0bwxq3StHb9cpi/gSUF+GzWMeqiqHtKXmg/27HwKdkdNbSslBpLUTkwpp2KTYLCjagl2N0pkNutu5khF0bM4kj69tn6WOCM2mR1dNtFbeYxKGrLzYeVoXEUHS3Pjp7lufaf0D5TSo7LTSU6f3KBt71LmU03bLDZQEXoHAnIF8xVQoByNXnJJW7pbSK8h4yV6lwuhESooB9pjZ9ms7PTMwfERa2AJEQddDxryWIjEPdNA0CVY0k5iNPuEcC5BEsWLaQdAPPhI1qgUdWe7gDiff2eMvOshfC088kGmKZsX9vpSi+h8w42imT2yMbuVspW21e7v43N7xZopy2Wwf301cgJB3qygIUUiLsieHZhrIG6U2UhdEr6tClMu+yoa6mgibd+ibwV/zwTMkeDsk0CdjFT zQslNx0B pacKdBuV3cYXwiE7sd0OmQcx96UrHhi6M4oe4LbNPJpzHZX8Mm+dZ10KMxOhBdjQJWslHCQdm6qN3EFYgJYvaK0M0uEWGUZkvqEm0Nqj/EYFKC7CawjWU8hGdVlxCt2aBASb1Ep2ekDH00KNxjQfMgIQQmEx7L0IpP0+58CJYBmXyA16m88KCveN/2+03oWeKGJmN3mkFsqALKOIW457xxwSRCo7CebJ9EeF/GBkUPOLER5+PJ/jioKQnbgPO/gECPfI0CCy2CLis8sbLkMIoNNusdBgUir0NKCuNJAkhpI3AfqzILia8jC+nNeDKqTUOOdEn8TohPbKTr9mv30QIeeAha40Kp5SxSC1vzQitWyo8xxs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 16 Jan 2025 11:19:20 -0800 Linus Torvalds wrote: > On Thu, 16 Jan 2025 at 11:17, Steven Rostedt wrote: > > > > But they are only defines, they are not created until used. Are you worried > > that it will slow down the compile? > > Yes, and the whole "pointless noise" thing. > > I *look* at header files sometimes. I don't want to see pointless > noise that isn't relevant to the context. > > This is not relevant to non-tracing users. Would it at least be OK to add a comment there to update the tracing code if a new GFP flag is added? /* * If a new GFP flag is added, a new TRACE_DEFINE_ENUM needs to be added * in path/to/where/define/is/made.h */ ? -- Steve