From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DC87C02188 for ; Thu, 16 Jan 2025 14:04:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8EAC6B0082; Thu, 16 Jan 2025 09:04:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B18996B0083; Thu, 16 Jan 2025 09:04:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96A4D6B0085; Thu, 16 Jan 2025 09:04:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 747276B0082 for ; Thu, 16 Jan 2025 09:04:55 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9065E1C6A8C for ; Thu, 16 Jan 2025 14:04:54 +0000 (UTC) X-FDA: 83013486108.11.658C963 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf19.hostedemail.com (Postfix) with ESMTP id 324511A0004 for ; Thu, 16 Jan 2025 14:04:51 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=AoUcPN70; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf19.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737036292; a=rsa-sha256; cv=none; b=SgztuJ3CpA45/JIO44jwkgzV3mWvANv9jYMFulPWlvg9zcWhnXu02VGf4lB9H0mSb6T3jl QTwhXSwJiVRGq2ULMeDmYrgo1TIrew7n8nuxNA12li8HGjR9HcdSOlkvQnYW3MpB8OVYKW rssVGjc18pQgdJFCSCGbMeTDmS++VNc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=AoUcPN70; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf19.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737036292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ugKrbojVRwTBmPMKkHUcaS2aDcqRv9OqaSevzpXMYOg=; b=Ces+Y8bmasSxfosTz4QXXlFNe9N5vAb4KaZjE5D5mznG9L39Ip6j9vsokOV+JkHKgNimh3 sxIJWDk7QUGTEkGsTBTQi/OltoPLANW/4dM4bq7naPdDqkxP4eRk5uKFu1y2aIbWKhYhuX IS4wRia0ZPrkAXKg2Fx+gWQvnVmHv8M= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id A169B40E0289; Thu, 16 Jan 2025 14:04:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id vINyDaL1Xg3b; Thu, 16 Jan 2025 14:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1737036284; bh=ugKrbojVRwTBmPMKkHUcaS2aDcqRv9OqaSevzpXMYOg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AoUcPN70r71GRskEbBjwKB5t2IpKoOvWroHj7Gj+yh3TXIQq4jAaeXsAtKetsP+we 7U42EJbMPBRZdphzKgKJnl1FaXd4+NOPdDL1SkgOkJuvHbUXMBGkSPz+3v8h7dNhmT Hnpwxe9r0qX772w6Op3rP2iEyZS27E/nwn39RIAvFhrt8U3AgFlwZ1zghfPHzcZ8zO c/4ymjaW+0fTU8jpLPb236iMCAWdJa4hZ/QKzL2ReUqqUBynyzdljxfL49TuGZKsUK HuZUYY0mmrBW4uLQ4YxKMwtuKAzOBBOTZPyqnz4H81TmMZX9A3znFZ3JT09PpbLLCS Ia6e5nKvzD4mq+MXsOmJ3+GXejTE4cvNoC5h043TIg2mzfveb9shxPPW6gBlFTA53E 7jgElnzIfinsMoQwVSg6i18FLDzY50+kqVz9+zbr5gpiPs5LeCwLYM/Aq1u2fGPpZ0 0Ls41+wYzo1pfh0OpM+GBydt5tkuWtf+9452THH3PFkEdzhwGbhRprrYvj75bnToTh nRx4uZELom9gJdmd+ZcYZKN5oNcUaiz0Ijo4hBEtkfRieSbS8RUd1mN91KKgO2qVid d+CXJjbRpPfJbO67fm64t8fRGqM3v/OqRo/Z09m5/2qMM0veqGpRWUhNKQ3qXXaJz4 pfAh9T0l+/f8chSy2nlAbhlU= Received: from zn.tnic (p200300ea971f934f329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971f:934f:329c:23ff:fea6:a903]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B67F640E0286; Thu, 16 Jan 2025 14:03:01 +0000 (UTC) Date: Thu, 16 Jan 2025 15:02:58 +0100 From: Borislav Petkov To: Brendan Jackman Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Richard Henderson , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Chris Zankel , Max Filippov , Arnd Bergmann , Andrew Morton , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Uladzislau Rezki , Christoph Hellwig , Masami Hiramatsu , Mathieu Desnoyers , Mike Rapoport , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Dennis Zhou , Tejun Heo , Christoph Lameter , Sean Christopherson , Paolo Bonzini , Ard Biesheuvel , Josh Poimboeuf , Pawan Gupta , x86@kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org Subject: Re: [PATCH RFC v2 01/29] mm: asi: Make some utility functions noinstr compatible Message-ID: <20250116140258.GDZ4kRkvEGYovA_J5u@fat_crate.local> References: <20250110-asi-rfc-v2-v2-0-8419288bc805@google.com> <20250110-asi-rfc-v2-v2-1-8419288bc805@google.com> <20250116001858.GDZ4hQctZe_PFvJ0AJ@fat_crate.local> <20250116102747.GAZ4jfI9HG3K-PW7nf@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 324511A0004 X-Stat-Signature: f9ybj87a6irz618c4nm5n4h8xjkra6r3 X-Rspam-User: X-HE-Tag: 1737036291-449128 X-HE-Meta: U2FsdGVkX19GKmNPB+NOeY5gOpDZLZo2FPQzh4pcBLDoTGDaar0XmuDN1BS7MLBxgmKDNjCjdHJ20q57jAEPj2wYydwiEcshCA9MK9fI9WPp4CK+22hbYiHAGE74VwukYCT9G+IgGqqQz5H54pDqReI1rlX0K0Jj/L/jpi+nEOfbZbuHP617Bj3flywGaAjF1pB370RGkbyGLjMmQ+5n3XDsYWpzChk/Ea7eBlLWoTJ6u5gA1mnuoA4vhWj6JT+l95siRgkFWjetFKiEDmUuSJ7y1AbZQ/OFL7Ssrgo7fnuLZdyBWIrT8v4jhSbxEd6bicMbCW+MMs0e7E6JIprq1l5BPPmfn5DHfBQiCi4MZCUhM2yYnsh0bWxEu67nxhe92jhR17eb6BxZd+/uCbGJL2WT+Y4uuz78mfx+OoSQGGi58oh6pbpMe4hN6HmJlYX6m0PDC3xtH2v33YHNxvhl2OHkvBXOKqvZn0yJy6lu5t1W4i74i5KjpwzzmrhxXR3kIPO5nwSBprALgntDtIgjnhdmASz6K0RZ9oQ9ijnlJs384TZjr1d+AgcaRoX0YwW8eKFzHLqA8yxz+m1I32o08p8HH1zBPVmVg8BCQzjpRJ9CvBLJ5Eu28cIJp6YvhDmVSJit9NVtR3FcVIU4v+LYBTTjtwdchCoXh1ydelTvBVvH6yrKtdqOJ676B1QYC2I/QpTDpRdcwc0Rr1E62LHr4LwJrgl33wM5FbVhnJTF/NY+LG1avqMDHeHt2Uw3S5DLgLaz2D8UZfoOk7WY4qgbFcmeu0c8RKBttG1qixOplEc0tybMyN9/RN7cXu2MNdXB08ycfctbKoAmxq0h6I1bMcPjbiUxd9JXZGT5w0ghHthXoZ+/Eci1s4VwQIJqMvzzHNDkXcF/M6Sj8PMxXIbKX8kv7sRK4A1ARYVo1M3s4warRuPCLyby7DI3S4mzzoS2ixnoTOtUBYUib2yyZnN XVHsTEAZ wtvqQgCe2SML3FgxeM7a2XtJ3gzUG6npICrI69xPKBg+HgZaSNns/5AP+PcfNx/fXYyIijxSnZgjfAhdd6s5M/0taThXviFurgsBZoc9LVN/dfMb9dy0AHB6SywY2QPz8ORc03Ovr7JR2ldPZs84ZnOqxHDyoXrjcr2nvI/F8hEmSYJoVr9vkFRKwWifPRASRipnF/PqwHEjgexTkJCKX4nOBsnvaqdAtC4ccYnUzHTvIMHkLUVo3WPLFV+xQgE1xBAjWB9lbv00vYCVEorrcdcL8bdOx4p9uxjU8E54SI5LqmDM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 16, 2025 at 02:22:42PM +0100, Brendan Jackman wrote: > Sure. I'm actually not even sure that for a [PATCH]-quality thing this > cross-cutting commit even makes sense - once we've decided on the > general way to solve this problem, perhaps the changes should just be > part of the commit that needs them? Right, that sounds better. > It feels messy to have a patch that "does multiple things", but on the > other hand it might be annoying to review a patch that says "make a > load of random changes across the kernel, which are needed at various > points in various upcoming patches, trust me". > > Do you have any opinion on that? You're absolutely right - we do things when we need them and not before. Otherwise, often times things get done preemptively and then forgotten only for someone to notice way later and undo them again. > (BTW, since a comment you made on another series (can't find it on > Lore...), I've changed my writing style to avoid stuff like this in > comments & commit messages in general, but this text all predates > that. I'll do my best to sort all that stuff out before I send > anything as a [PATCH].) Thanks! Btw, good and funny way to use "[PATCH]-quality" to mean non-RFC. :-P > Oh, I didn't notice your update until now. But yeah I also couldn't > reproduce it on a Sapphire Rapids machine and on QEMU with this patch > applied on top of tip/master (37bc915c6ad0f). Yeah, it feels like toolchain-related but I can't put my finger on it yet. We'll see if and when this thing will re-surface its ugly head... :-) Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette