From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49F65C02187 for ; Thu, 16 Jan 2025 18:53:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDF286B0083; Thu, 16 Jan 2025 13:53:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C67B46B0085; Thu, 16 Jan 2025 13:53:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B08B96B0089; Thu, 16 Jan 2025 13:53:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8FB876B0083 for ; Thu, 16 Jan 2025 13:53:26 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1FAFE8114F for ; Thu, 16 Jan 2025 18:53:26 +0000 (UTC) X-FDA: 83014213212.02.3E1A8E9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 815F612000E for ; Thu, 16 Jan 2025 18:53:24 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of "SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737053604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ayoUMuHt41uTCSKQ87FAOlyiZ8CN+wxQJPPzrPZktdY=; b=q6mh2rCa0zjjvbEE1eERiVKL+0rjrZrek1taIxsIi+ImWifYnUnxUohi05jMDXWJNMOvvn fdE14u6Byov0vhQhus6ULYmi7FHTkB00uRmm3j0EImQYDyWdAEfQUCGlPytSXC93JK94Br i3QnbBslrkSVqYmjeGHMRcjFcAU56dI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of "SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=fJp8=UI=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737053604; a=rsa-sha256; cv=none; b=tS/7arcQWqhFXNeW+7s3+xNzEjMg4OAjy1hwIWGSHokLCDh1Uz11+9JCoWO997hctFlgGP M2nJd2wlbUFPTSDsjVYMqho17M+4uQPmOhKAv4OFKql0nF6lS4HgGlgaJ6ALC7vX2nHoEU HQRuoWiE3q8D90Nz53v3B3wdY1eI+mQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B1A325C5F48; Thu, 16 Jan 2025 18:52:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF729C4CED6; Thu, 16 Jan 2025 18:53:21 +0000 (UTC) Date: Thu, 16 Jan 2025 13:53:27 -0500 From: Steven Rostedt To: LKML , Linux Trace Kernel , linux-mm@kvack.org, linux-perf-users@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Michael Petlan , Veronika Molnarova , Suren Baghdasaryan , Linus Torvalds Subject: Re: [PATCH] tracing: gfp: Fix the GFP enum values shown for user space tracing tools Message-ID: <20250116135327.64264109@gandalf.local.home> In-Reply-To: <20250116132359.1f20cdec@gandalf.local.home> References: <20250116132359.1f20cdec@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 815F612000E X-Stat-Signature: am8c6fahit8grc5738qbb3st3yakkb5h X-HE-Tag: 1737053604-343652 X-HE-Meta: U2FsdGVkX19x9Unwq0eQ+SK7V52pwXVJctH92QN7amV8LUFxQJkLztbOA1TIOe29Pye6pMlvA+E3oxEOUjCpkguTpFxwAk8+SOkn+8gklG7OXl9cq7XGSfiM9DhBJRaqqAPPsOQJPeWxUAr6TSdl+OHGQzgd2PZjToq9/ZMhaWTX5J+Q+A1POXYWmk23N7HBb/jO29GcfhP6iIIZzwTallvtvic9YNB0FEHGdfnWHL16NU+Rk5zMC4lN87tOE3UZbIQj48CVTcPVi/UxPRnz2nFvwVBZiDiC4lvTWA/uYdXZsC2ftVSAN7BS1DdWBoaiJy4/kWMk85bV/b4M3D7siZFqK5WDIPthZlyxNpyraLXAmsk+Wrj6KBU/v0rMkV63Ju4wAxp43Q45uuxLC1chKjtSCB2CjnRX+9rdeRB17H4bhLpB3IHNrBkGRnSO4QvoTNFvUFxNC0kjpc31NcgYBD4ZBrexe2SG6jGHH/tlZwG5/wdEG1ZF663xieBeGN5+lUR5jApbxk2Vh8BMrDqKRCUTHj1WIjqMTuUMW1WnHEXv5pn0XtbVxcWV8LyKGm4/5LVpR7aQkwsKdoV/yVWpjhdDxGgEno6M3a/nzjKuaDqMne0uxj2r6+9ZB3u7XiiMFU1YvLZSGLBwyqXEXHTlo0+/P5SIOm6D1//SmfVj21pXRNwCdiHiJO0UtzI5ID4nqtNnxrDSY8tVvD+Q8HcfB9X9VR2tp+olS+wJSVUiUeOGExf0UWtuEQGHdcdTacrW6lhmTkQen5vusDwkqiNBVTWJMCqccsDxxaKBxvzIZ6ZhBqfgQIfm+gn/nzUXQfq83Wc2ioUrtf3J/zwE9nITxXfVihytHe3OpLTHd9gLxY4vyRx1CxQbVwmkr8oLIw//+lkW8VWVlQ5RU6fjJ73RUSlg2SipeenLdV5QYnpuRYuAWDTZFqyD+/rgoPLcPcAIyrkMbQgcSlET051oVoj x239cvRa doAKsJEo0tEFSl6/piURvpIeV15CUDG0Tk+v1Fhl0flM4D5lb+2lpuBMp17lufb80W2OKbnQp0PAgLeqgC7poQWGRNcTB3mMuh1WJe6nSf2vqYLKnwNYgGqialUV6lW7wbEmFgQhuF9rEFyr+QwR6gvJ/m8mugb3gY56gGzj0TUGqsAGK8l2CfBJ7EH/xjtY34A60hbxoW0Hl7Rk8PyXopyuZJCrA3qHY4g2dFhEsOQog86o9dvjS6OsMJaWqJx9APvZlHNsh4ztj5bqkx2c5It1VMYF8lvGIrGYFV35C8clT7U9/LpFR/45PMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 16 Jan 2025 13:23:59 -0500 Steven Rostedt wrote: > +#define TRACE_DEFINE_GFP_FLAGS_GENERAL \ > + TRACE_DEFINE_ENUM(___GFP_DMA_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_HIGHMEM_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_DMA32_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_MOVABLE_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_RECLAIMABLE_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_HIGH_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_IO_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_FS_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_ZERO_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_UNUSED_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_DIRECT_RECLAIM_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_KSWAPD_RECLAIM_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_WRITE_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_NOWARN_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_RETRY_MAYFAIL_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_NOFAIL_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_NORETRY_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_MEMALLOC_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_COMP_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_NOMEMALLOC_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_HARDWALL_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_THISNODE_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_ACCOUNT_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_ZEROTAGS_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_LAST_BIT); Hmm, I don't think I need to include the LAST_BIT. > + > +#ifdef CONFIG_KASAN_HW_TAGS > +# define TRACE_DEFINE_GFP_FLAGS_KASAN \ > + TRACE_DEFINE_ENUM(___GFP_SKIP_ZERO_BIT); \ > + TRACE_DEFINE_ENUM(___GFP_SKIP_KASAN_BIT); > +#else > +# define TRACE_DEFINE_GFP_FLAGS_KASAN > +#endif > +#ifdef CONFIG_LOCKDEP > +# define TRACE_DEFINE_GFP_FLAGS_LOCKDEP \ > + TRACE_DEFINE_ENUM(___GFP_NOLOCKDEP_BIT); > +#else > +# define TRACE_DEFINE_GFP_FLAGS_LOCKDEP > +#endif I also missed adding CONFIG_SLAB_OBJ_EXT. I'll send a v2 shortly. -- Steve > + > +#define TRACE_DEFINE_GFP_FLAGS \ > + TRACE_DEFINE_GFP_FLAGS_GENERAL \ > + TRACE_DEFINE_GFP_FLAGS_KASAN \ > + TRACE_DEFINE_GFP_FLAGS_LOCKDEP > + > /*