From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
linux-mm@kvack.org, linux-perf-users@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michael Petlan <mpetlan@redhat.com>,
Veronika Molnarova <vmolnaro@redhat.com>,
Suren Baghdasaryan <surenb@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] tracing: gfp: Fix the GFP enum values shown for user space tracing tools
Date: Thu, 16 Jan 2025 13:53:27 -0500 [thread overview]
Message-ID: <20250116135327.64264109@gandalf.local.home> (raw)
In-Reply-To: <20250116132359.1f20cdec@gandalf.local.home>
On Thu, 16 Jan 2025 13:23:59 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> +#define TRACE_DEFINE_GFP_FLAGS_GENERAL \
> + TRACE_DEFINE_ENUM(___GFP_DMA_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_HIGHMEM_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_DMA32_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_MOVABLE_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_RECLAIMABLE_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_HIGH_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_IO_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_FS_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_ZERO_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_UNUSED_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_DIRECT_RECLAIM_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_KSWAPD_RECLAIM_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_WRITE_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_NOWARN_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_RETRY_MAYFAIL_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_NOFAIL_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_NORETRY_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_MEMALLOC_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_COMP_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_NOMEMALLOC_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_HARDWALL_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_THISNODE_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_ACCOUNT_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_ZEROTAGS_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_LAST_BIT);
Hmm, I don't think I need to include the LAST_BIT.
> +
> +#ifdef CONFIG_KASAN_HW_TAGS
> +# define TRACE_DEFINE_GFP_FLAGS_KASAN \
> + TRACE_DEFINE_ENUM(___GFP_SKIP_ZERO_BIT); \
> + TRACE_DEFINE_ENUM(___GFP_SKIP_KASAN_BIT);
> +#else
> +# define TRACE_DEFINE_GFP_FLAGS_KASAN
> +#endif
> +#ifdef CONFIG_LOCKDEP
> +# define TRACE_DEFINE_GFP_FLAGS_LOCKDEP \
> + TRACE_DEFINE_ENUM(___GFP_NOLOCKDEP_BIT);
> +#else
> +# define TRACE_DEFINE_GFP_FLAGS_LOCKDEP
> +#endif
I also missed adding CONFIG_SLAB_OBJ_EXT.
I'll send a v2 shortly.
-- Steve
> +
> +#define TRACE_DEFINE_GFP_FLAGS \
> + TRACE_DEFINE_GFP_FLAGS_GENERAL \
> + TRACE_DEFINE_GFP_FLAGS_KASAN \
> + TRACE_DEFINE_GFP_FLAGS_LOCKDEP
> +
> /*
next prev parent reply other threads:[~2025-01-16 18:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 18:23 Steven Rostedt
2025-01-16 18:53 ` Steven Rostedt [this message]
2025-01-16 19:00 ` Linus Torvalds
2025-01-16 19:18 ` Steven Rostedt
2025-01-16 19:19 ` Linus Torvalds
2025-01-16 19:30 ` Steven Rostedt
2025-01-16 19:30 ` Linus Torvalds
2025-01-16 20:12 ` Steven Rostedt
2025-01-16 19:43 ` Steven Rostedt
2025-01-16 19:49 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250116135327.64264109@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mpetlan@redhat.com \
--cc=surenb@google.com \
--cc=torvalds@linux-foundation.org \
--cc=vmolnaro@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox