From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BD33C02180 for ; Wed, 15 Jan 2025 23:52:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD0776B007B; Wed, 15 Jan 2025 18:52:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D58DD6B0082; Wed, 15 Jan 2025 18:52:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF9D06B0085; Wed, 15 Jan 2025 18:52:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A0CAC6B007B for ; Wed, 15 Jan 2025 18:52:30 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 54770120490 for ; Wed, 15 Jan 2025 23:52:30 +0000 (UTC) X-FDA: 83011338060.13.DF34081 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id A733340002 for ; Wed, 15 Jan 2025 23:52:28 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p1OTwamC; spf=pass (imf01.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736985148; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1hq4wa0+fzlgh2XPtzjRrjJtexLJd5wRNmv/stLiTYs=; b=o6Z63sloBA9W50dr4dji7NOLSf4Pp0LEmMBeCVE+61vQdjDIIFin5WL+IIKBNgWhcElvim JDIf9o+GQQ5/DsKKc6siJgf82KCfucgpo8KzX5/KzPh6X339n380taDT1qaOBQFlpLJ966 kWBDIJgf7loYjOrw9su9s3yMrvIiEsU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p1OTwamC; spf=pass (imf01.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736985148; a=rsa-sha256; cv=none; b=mYAjAiXXMndiFF+h2eFt7DkuPstN7sOcTAQSSP9egtVGOm62u5NMEIL11IDfKe1bHmL6Y5 o3ZrX/JtGEV8PxBCAUFkz56QM+8ly2QYXsAShiI7uiVwz+sRjoJHZPuZTireGc2KDFMC2/ UZEVpdWmFZEdjpY2lmKJkk2ynrOaF3c= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CE9035C4860; Wed, 15 Jan 2025 23:51:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C305C4CED1; Wed, 15 Jan 2025 23:52:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736985147; bh=usyC6r7teDvo9uThZarga5X1zNn6I8cqW+sSlamTdk4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p1OTwamCXon4A5RcfRuFwlqgq1cPbI5o7I3HtMqztdEmzVYIPiZsmPpR/wgcyIF9G Fj2r8dLncZAXJsme5nX7tPHqpQlW2F9wVPArcJ4UnSi6yZ+HFv5zgw6pI2UwV/UM4c hKVeAz/HWs0lspszPBMFU3FkpEFH5GFTRr2tlMSAZjY02SzTS87ym8ISCBDAe/D+EV E1q+D+MyRFsPKOeIgges9iJcXpR+pHRDtsksMBX1vIXoAUPNFyR2QzeLtp2l6bhzK6 wMcRzXppi2005WW86oygKs8o60lAS/8jpF851zskk3YibQXIcY6ebhVFbmHwHwgJ/R lztR2t/kkX8tg== Date: Wed, 15 Jan 2025 15:52:23 -0800 From: Kees Cook To: Lorenzo Stoakes Cc: Jeff Xu , akpm@linux-foundation.org, jannh@google.com, torvalds@linux-foundation.org, adhemerval.zanella@linaro.org, oleg@redhat.com, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, ojeda@kernel.org, adobriyan@gmail.com, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, hch@lst.de, peterx@redhat.com, hca@linux.ibm.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, Liam.Howlett@oracle.com, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, Vlastimil Babka , Andrei Vagin , Dmitry Safonov <0x7f454c46@gmail.com>, Mike Rapoport , Alexander Mikhalitsyn , Benjamin Berg Subject: Re: [PATCH v4 1/1] exec: seal system mappings Message-ID: <202501151538.3E757401@keescook> References: <20241125202021.3684919-1-jeffxu@google.com> <20241125202021.3684919-2-jeffxu@google.com> <202412171248.409B10D@keescook> <202501061647.6C8F34CB1A@keescook> <5cf1601b-70c3-45bb-81ef-416d89c415c2@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5cf1601b-70c3-45bb-81ef-416d89c415c2@lucifer.local> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A733340002 X-Stat-Signature: 717pozqbytk6gbfe3f1h6x5qzeemhp45 X-Rspam-User: X-HE-Tag: 1736985148-400488 X-HE-Meta: U2FsdGVkX18lMjQ++OIB+uZvxW2vyQXbCADpQJ88iV0YrSSaqm8UCryK/vasDnP5ctlZp/G/NQ17gspsazpYDjl3AegatRJFGx88PszR1NhpRRu3Sz8/jjaWeAZsV1xkvp1ny/CMrSJ2sZdQxNy0SBJ/EZDkY2Gqxj7LgzZAOU3yg7ZkYhu1qX9HoQrrijhNEdQSAhznIys6LvEdCT3PjJkYQFAvmW4WjmR3vsiEo4HKnh6g/EcuQvZjHZxOxq65aAJ6yXoo0dno6Ma2N2KRHRE3utCdjenWmrtdRseGWlODLOmQpr5zSjRuKfGWydrL8IeGTcy4ZsG1W6U6u2ySDRlZdGHOb80vIBgXFTu1lIqrcwPKWAKXEsGKfWUGtu7mdqDlWcRmCekO6i1pstgRIKfVRRE1WErtd8vFIqKn3Dj3wtbHpk3ZqCEZoIjgxvUQN4OmEE+RkEgx12C+iiiv269SKt+d2Bxj/rLHcAtsoePWHvj19BxrUg/02XRLGMLjV0Pdqpg2SG1GDREq0VedYHolXH+68OFHpaH8mRIQv7+MYEKQouJuU5bnU75e3T+DLL7H2RJ4Hxh6kYGtzbfKbjMPHApg4pPyEgXrb4UzYh4Qojrdl0XmIKo6PkTCGynZVHfX5hHg463Jy9wC+R10w0dgOFmpKHw4za/m1QgG0rJ58EHmacrpyQU90IObrdhAnem6xxenuScj+Zb59maWTx7f7IRv6xvElELGbjlZPZ4H5Iv3rACyZj5UO+vjh0lQApH7JIXMfC4wbttdnW3MKslAN2NsvD8wq6wP9WnQBwlGOmz39hYSsWwiu0nY0c9Jv1w/ek9VYmDgLPIywwkay8lxqU3plwxOKH2FKr9J/MgkHzDzWaEupQNezSvHnypNF9U1JWR/DPLdgd8k5+3tHMdG8VHJxyvp8f+B+SEYkfqsMXTott/utv0xA4okamXQ0GppHJZ3GyIpEUg9uQ1 niYp8k7y qPGIw5CVfviS3L+AG/+Y8O9M3n3tbmT/5LMGtumoBqE6xVsUxdmkUCjHZogXFC8QfLL3Kg5Qzi0SHzB2yUe5z2XhFQUGvmSZhWiQhjtp7Hu+m3mppt7VsM22kQveR2zcMoZtS4Bl+bfUXCAk/fmQwRQccJmDwIvC+sSOuvV/Ldnd9JHykNx2KFhUnZzfd2qUci7SZJrs0uuR7DO5OyIK53AuouBEUa3YZ+dcQ4fYcYiza8smaMQCmQ+/qWRafxVH+nNVmMhX0Yo/2M3HAzSP931rI056I/oaiUbjWT6LofhKsBQ5c204gBnX0JyynSTBb2Cw8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000752, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 15, 2025 at 07:46:00PM +0000, Lorenzo Stoakes wrote: > You are now suggesting disabling the !CRIU requirement. Which violates my > _requirements_ (not optional features). Why not make this simply incremental? The feature isn't intended to work with CRIU. Why don't we get the feature in first, with a !CRUI depends? This lets the users of this feature actually use it. > You seem to be saying you're pushing an internal feature on upstream and > only care about internal use cases, this is not how upstream works, as > Matthew alludes to. Internal? No. Chrome OS and Android. Linux runs more Android devices than everything else in the world combined -- this is not some random experiment. I really don't like the feature creep nature of the system mapping sealing reviews. There's nothing special here -- we have plenty of features that conflict with other features. And we have a long history in the kernel of landing the core changes with lots of conflict depends that we then resolve as we move forward. Why not just make system map sealing conflict with CRIU? Who is asking to use both at the same time? > I have told you that my requirements are: > > 1. You cannot allow a user to set config or boot options to have a > broken kernel configuration. What do you define as a "broken kernel configuration"? > 2. You must provide evidence that the arches you claim work with this, > actually do. What evidence would you find sufficient? I'm concerned this is turning into a rock fetching quest. -Kees -- Kees Cook