From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B9CC02180 for ; Wed, 15 Jan 2025 23:28:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C33A86B007B; Wed, 15 Jan 2025 18:28:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE49C6B0082; Wed, 15 Jan 2025 18:28:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD2D1280001; Wed, 15 Jan 2025 18:28:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 918906B007B for ; Wed, 15 Jan 2025 18:28:41 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 15134437AA for ; Wed, 15 Jan 2025 23:28:41 +0000 (UTC) X-FDA: 83011278042.05.C81B8D8 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf10.hostedemail.com (Postfix) with ESMTP id 684CEC0006 for ; Wed, 15 Jan 2025 23:28:39 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="I/pa/+OL"; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736983719; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4iFcVA0S835ExaBMR8CBe4P+FWm+zXRYM6re24+vs6U=; b=6yWrcFkDaXZo6QCqPwHm/LEsPnNqbZei3F7RrFc5QSb/vGGzXXRKvLE1s1n0vht1ecEc0C +FxHqB0hEHcdvDVjrswM0pA6iLPcXClzOintbTw0e1f9TLd59bvtwerByFcPiJrkSRRZfm BN68weU04oSUvvh5uo/gW9xaRe0tBYQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="I/pa/+OL"; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736983719; a=rsa-sha256; cv=none; b=iojuNPEGz/P/n8Y9S8Kc/l+EgyHRKpZfrEGtAjshVOccbvtg3Bs6Lbjl1ENtW9tJi2bd+Q 82Niy7dCr/l/VzJlIHbWoba+tEcjqc+P9Lq+UYLYtUC4aRNOrrXXyWYw9Z0ETBe3LR17fi zxJi23pdQKU54I869TrP74NR+1ur10E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 66D48A42664; Wed, 15 Jan 2025 23:26:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8D12C4CED1; Wed, 15 Jan 2025 23:28:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1736983718; bh=kDfcMpdpjZxfdtKb7Tp08GotUeCqXiX7sfAnuuPns1c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=I/pa/+OLT3zlX7TPjvt4aw00WltnE2BG/TUHtUs+6NR6dj16hENhqIvL3/WUueF+N tnSwurppzG8ycTWQREOZkDKoLU8GcciqGh6/e6/LrNL6YZHKk+HVLPUxWjd2/OD9Xi kluUWpAN+WZyV0LC5jgUTzMb0g6Ma0P9UPqEWOtU= Date: Wed, 15 Jan 2025 15:28:37 -0800 From: Andrew Morton To: Sergey Senozhatsky Cc: Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] zram: remove zcomp_stream_put() from write_incompressible_page() Message-Id: <20250115152837.b9f721bccfd07ce903fc4539@linux-foundation.org> In-Reply-To: <20250115072003.380567-1-senozhatsky@chromium.org> References: <20250115072003.380567-1-senozhatsky@chromium.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 684CEC0006 X-Stat-Signature: a4ktswqzgch434rdqqwxoej99nkjde5w X-Rspam-User: X-HE-Tag: 1736983719-580633 X-HE-Meta: U2FsdGVkX19iVvCE7fqd31/t14AhswugvmEz6ADHJkKFw6yXAzReCKAk9J7xfb8Qy6ayELlVD60/YPJ8vZ6bd7l7nXaM9W1ex9W2YGhDoe8yTMLfQNMmqLpsOzTETzGZrwnX8lOeKDQvcyB6E5Bj1YlvaK+f+zjIkKWoo7wYh8syLNeQOiDVmrnTsvv7CXo18PXSCJ+VhvpLPakLbbzPCQgz5vVUsSGReM6RSFEJJSkz3GAc4lMDRcyuK6I13Gq0Tw9Lql3SuLeivwWmhWd4viAmfwEXt/sYpo1/G3tHEXHfDNUkPjH860oVJhzdPchatXEq92Q+dZJwQiZKK10869OqPFnPpXgg4JFvIS4QSmWKJhEVY9lV2UtTfP/SXonOp6OjlyiFulI6I+eKiqLQ9dYU+m+iz/5RkPrU2Kfs4dHyfWBKwFlxBmHrE+j34d0KtoOxXgGkjIcR5aAQLZYB8kOcXZ52WLbXi63R/mPZqdKbgh6INQY9vzo1rKSkpG/XthUSetPpMhB7wZQTjL4JkNiVMqSsPbw5M8yYkxtS/x4Dx+UaMSr7TXTY9e585raezQKPp9iBHY2fltadyuvLr/xqXtEjfoFC7xYOANvUwAj6ba2I3og5PjUaus/qKcPHvo/yuym5Yic53S2Uky/BPR7/NBz5WmQ77kDmAebPDohxA1eQk4KVTNi9Q+UATn8wXkJ1VhHFsPbhldVZJqe+qEusgpEBbiyS8rKa/3hGARvTWOcQfs7A++aXw1qUnaneaK8h4ND/Xkx1nnbhzGbiFMEB8Hf30PCLL35ztCM+AkDpQdCKLTNLrqL8prFM6fSqahN1d5yuJOHUrDysmt7ZoAXWqOGfommRI37yo4qgKeLxzzzctTBB/MGALjXqGBGM4/GJ3GW4zM67tmhUVQFuT9z/MWK9YVZxYBrlTml/koAQ58BekyIcloDk0oxn5xYy8cqO2TKuPx/wxZKKu0j i1JhFGr/ Kybid3f7paVV41ZHOzgNFSoZbXWOGRn6lH9wJzYrX48NR8TLqEPuuSw0VjsZsc6zOmXwcNlBHGGlM11Cjzj2+b/gPcW4uUKFUU7c8nhzAowycIvc50pt4udMdz2VOYd9y/Hf+VVWqMbieVTm25WFYxRZRYRzs6eO3AbKCJwwrfoWxq/ysPrLWTmx48+hzYqFx2ONI3DHGu1OIqQq9zaGcidJZL7gJu86er+cNOeOtXqYNaiKjhxJ1N4lT6Sso/Ki2fxUt5XV16jHlXFgF5WX9AMwjuLZ/ZeRljaFalaEE+Le3s3uSLvvqt+uCJ83JnbuHpL6m X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 15 Jan 2025 16:19:16 +0900 Sergey Senozhatsky wrote: > We cannot and should not put per-CPU compression stream in > write_incompressible_page() because that function never gets any > per-CPU streams in the first place. It's zram_write_page() that > puts the stream before it calls write_incompressible_page(). > > ... > > +++ b/drivers/block/zram/zram_drv.c > @@ -1683,7 +1683,6 @@ static int write_incompressible_page(struct zram *zram, struct page *page, > return PTR_ERR((void *)handle); > > if (!zram_can_store_page(zram)) { > - zcomp_stream_put(zram->comps[ZRAM_PRIMARY_COMP]); > zs_free(zram->mem_pool, handle); > return -ENOMEM; > } I added Fixes: 485d11509d6d ("zram: factor out ZRAM_HUGE write") That way, anyone who backports 485d11509d6d into their earlier kernel will have a better chance of noticing that they need this fixup.