From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77808C02180 for ; Wed, 15 Jan 2025 13:42:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0827F280003; Wed, 15 Jan 2025 08:42:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 05956280002; Wed, 15 Jan 2025 08:42:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E62BC280003; Wed, 15 Jan 2025 08:42:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C7521280002 for ; Wed, 15 Jan 2025 08:42:15 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 781B7141277 for ; Wed, 15 Jan 2025 13:42:15 +0000 (UTC) X-FDA: 83009800230.18.22D5BF4 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf07.hostedemail.com (Postfix) with ESMTP id E3A634000E for ; Wed, 15 Jan 2025 13:42:12 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736948533; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wa9D66D8RRUJl0DXtTEctETAwUU6WB1VZMwkJ653L7Q=; b=iDQIOcAbBb9po2ZuYoP+0PqqnMrEAYL4gFPQTIN9Ia3WZLG5ExSCWVjbBeZU7sYHUorUVs qscJ/csW8l/86XXltbWpyQQvUhplzoYIRRc1W0/sglM0Y41hR5+vWsc5ti1rJ4K4b7dBWt tLEsV1idbsfEoiGEMG5OmMdfTuxqyUc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736948533; a=rsa-sha256; cv=none; b=n/5YTpdNaJk0MQURR2nCyD/zVjREhbg/VgRgfKFsoWAViOirAnIERt7saxBMD0q5psRz6P EBIg39M8Vecyo6skGUAjz93y+WcdfRSFh+ExwaVEDJOYm6qZwSCt2q4A7bNTixOhoUsOsG OyDS+P/TaFhG3/docN6bK2kWP0rNJGc= Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YY6ZK0018z6LD56; Wed, 15 Jan 2025 21:40:24 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 284411400F4; Wed, 15 Jan 2025 21:42:10 +0800 (CST) Received: from localhost (10.122.19.247) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 15 Jan 2025 14:42:09 +0100 Date: Wed, 15 Jan 2025 13:42:07 +0000 From: Jonathan Cameron To: Neeraj Kumar CC: , , , , , , Yicong Yang , Niyas Sait , , Vandana Salve , Davidlohr Bueso , Dave Jiang , Alison Schofield , Ira Weiny , Dan Williams , Alexander Shishkin , Peter Zijlstra , Ingo Molnar , "Arnaldo Carvalho de Melo" , Mark Rutland , Gregory Price , Huang Ying , Vishak G , Krishna Kanth Reddy , "Alok Rathore" , Subject: Re: [RFC PATCH 0/4] CXL Hotness Monitoring Unit perf driver Message-ID: <20250115134207.00002918@huawei.com> In-Reply-To: <1296674576.21735899902648.JavaMail.epsvc@epcpadp1new> References: <20241121101845.1815660-1-Jonathan.Cameron@huawei.com> <20241127163426.00004a65@huawei.com> <1296674576.21735899902648.JavaMail.epsvc@epcpadp1new> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.122.19.247] X-ClientProxiedBy: lhrpeml100011.china.huawei.com (7.191.174.247) To frapeml500008.china.huawei.com (7.182.85.71) X-Rspamd-Queue-Id: E3A634000E X-Rspamd-Server: rspam12 X-Stat-Signature: q5w6o6oy9rw35ucj1rp98amkqozwyyid X-Rspam-User: X-HE-Tag: 1736948532-68870 X-HE-Meta: U2FsdGVkX19z0cnPwUCgIHEVblfjBZ6ZXh0BVIgA89LskwRWc0nixlyTENReX5gu+9So/uhf5ItHdHF6JtNRjnoi1rwcpPqjwsD+puJTMg6+ml9wHAryu+dPaPaWlyNFJ0Xl4d3gtvP0W0rlhbDJxXVRVntIFK9BMjHC/S+KgJnYp1SoDWpM32utW6Bm9nhL5Dxv8ytY19Fvl5UhFsU7gzltnoozsbHoI3k0ijlVX1NuxsZPlaUYrD+rKiU4n2u16ElIXLCKpk7hVIc8I/hW57LuLyHJOnzn65CNtujMoWOiuXP2ULVcXoMXdQC09U+Bvn1U/dH62nCzsvFmRvkug+iMn2MNmfoQ8tQ4H/BxcN/1jd5OYlOgAru24OMkb4foeexe6q7U4TJ4YkPdoGD94yxpA/EzSuOvadLhnQF+6ZIo7ebiu/gtAL9aZgGTIeq9vj7cov8i+tpRLj8IDZ6cSuzQJPlDiW5ja4ajwNPXDyKIRG4XRnacU/OASvQg5u5Mu/XCLPgYTDLOO+4E5C2Y/oi4aw764ET02MCa8tNlEjdk0GW4GcxYHKL+1sHmvZDv5n+MxqIInVN+lf7fJ+kjSm+KhgJj0JEXEFWvW6h8VyKvYUh3+VRoQwpr83PSszYnRwWWR3nWtkJS9rmPcrC5dpZdnsQY2BbeILFpcC5EdI35WaLuj9XHfzA9r06fvpw+uXMH3EXtC/8cNe70Uc6GDQ8BIseOPyswNhC67uqHANBnePYN4w7x12ULY/IqVHc6GqmUaTZCdO1Ls9sf6g9V7AnznWuXJXMysvlv0VNcSQBq6YFl/41BymVKIGyYo6elWXldSVFM9EL/kfm3o+ME5ngv9wtYtq4BAbHDHunJ+PYMOuGLdk9+FuuaMN8653qJKIIeJf/6WFigTyyE7Al3Hl3G4S1B+vPg0teJUT6j5U8ghWGOUQwtVE3plT8WdVnVqAYht8UmD9C7vfrq1Xu B+ARuOFL bDpSTIM6l5EOaCwBkPkkQuraemOK8cKIAnNiiACGuhk378HgXIskX5DlsehUFtuyxpAEGsPyBj5um+EEQbeTDqJt4DfDMQ65GcOpOwp9gLtG+Jc1aMkruXLzEuErN8LOtbpaNV7FnmzNCM8EY15qA3U6xKsAigcGXqKMlwx1BR9k+f4Ud/38i3HejjlAIUMxlDgHLf1fvJokyWPxVKsvFWytLdBlKbd1YDmX22KJ3nUifnbsFTtV7a+DdRnpeBK7zZRUQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 3 Jan 2025 10:57:22 +0530 Neeraj Kumar wrote: > On 27/11/24 04:34PM, Jonathan Cameron wrote: > >On Thu, 21 Nov 2024 10:18:41 +0000 > >Jonathan Cameron wrote: > > > >> The CXL specification release 3.2 is now available under a click through at > >> https://computeexpresslink.org/cxl-specification/ and it brings new > >> shiny toys. > > > >If anyone wants to play, basic emulation on my CXL QEMU staging tree > >https://gitlab.com/jic23/qemu/-/commit/e89b35d264c1bcc04807e7afab1254f35ffc8cb9 > > > >Branch with a few other things on top is: > >https://gitlab.com/jic23/qemu/-/commits/cxl-2024-11-27 > > > >Note that this currently doesn't produce real data. I have a plan > >/ initial PoC / hack to hook that up via an addition to the QEMU cache > >plugin and an external tool to emulate the hotness tracker counting > >hardware. Will be a little while before I get that finished, so in > >a meantime the above exercises the driver. > > > >Jonathan > > > >> > >> RFC reason > >> - Whilst trace capture with a particular configuration is potentially useful > >> the intent is that CXL HMU units will be used to drive various forms of > >> hotpage migration for memory tiering setups. This driver doesn't do this > >> (yet), but rather provides data capture etc for experimentation and > >> for working out how to mostly put the allocations in the right place to > >> start with by tuning applications. > >> > >> CXL r3.2 introduces a CXL Hotness Monitoring Unit definition. The intent > >> of this is to provide a way to establish which units of memory (typically > >> pages or larger) in CXL attached memory are hot. The implementation details > >> and algorithm are all implementation defined. The specification simply > >> describes the 'interface' which takes the form of ring buffer of hotness > >> records in a PCI BAR and defined capability, configuration and status > >> registers. > >> > >> The hardware may have constraints on what it can track, granularity etc > >> and on how accurately it tracks (e.g. counter exhaustion, inaccurate > >> trackers). Some of these constraints are discoverable from the hardware > >> registers, others such as loss of accuracy have no universally accepted > >> measures as they are typically access pattern dependent. Sadly it is > >> very unlikely any hardware will implement a truly precise tracker given > >> the large resource requirements for tracking at a useful granularity. > >> > >> There are two fundamental operation modes: > >> > >> * Epoch based. Counters are checked after a period of time (Epoch) and > >> if over a threshold added to the hotlist. > >> * Always on. Counters run until a threshold is reached, after that the > >> hot unit is added to the hotlist and the counter released. > >> > >> Counting can be filtered on: > >> > >> * Region of CXL DPA space (256MiB per bit in a bitmap). > >> * Type of access - Trusted and non trusted or non trusted only, R/W/RW > >> > >> Sampling can be modified by: > >> > >> * Downsampling including potentially randomized downsampling. > >> > >> The driver presented here is intended to be useful in its own right but > >> also to act as the first step of a possible path towards hotness monitoring > >> based hot page migration. Those steps might look like. > >> > >> 1. Gather data - drivers provide telemetry like solutions to get that > >> data. May be enhanced, for example in this driver by providing the > >> HPA address rather than DPA Unit Address. Userspace can access enough > >> information to do this so maybe not. > >> 2. Userspace algorithm development, possibly combined with userspace > >> triggered migration by PA. Working out how to use different levels > >> of constrained hardware resources will be challenging. > >> 3. Move those algorithms in kernel. Will require generalization across > >> different hotpage trackers etc. > >> > >> So far this driver just gives access to the raw data. I will probably kick > >> of a longer discussion on how to do adaptive sampling needed to actually > >> use these units for tiering etc, sometime soon (if no one one else beats > >> me too it). There is a follow up topic of how to virtualize this stuff > >> for memory stranding cases (VM gets a fixed mixture of fast and slow > >> memory and should do it's own tiering). > >> > >> More details in the Documentation patch but typical commands are: > >> > >> $perf record -a -e cxl_hmu_mem0.0.0/epoch_type=0,access_type=6,\ > >> hotness_threshold=1024,epoch_multiplier=4,epoch_scale=4,range_base=0,\ > >> range_size=1024,randomized_downsampling=0,downsampling_factor=32,\ > >> hotness_granual=12 > > Facing issue while executing perf record on x86 emulation environment using following steps > > 1. Tried applying CHMU Patch on branch cxl-for-6.13 using b4 utility. As > base commit is not specified, with minor change able to apply patch. > Compiled kernel with CONFIG_CXL_HMU > > 2. Compiled jic23/cxl-2024-11-27 for x86_64-softmmu > > 3. Launched Qemu with following CXL topology along with compiled kernel > VM="-object memory-backend-ram,id=vmem1,share=on,size=512M \ > -device pxb-cxl,bus_nr=12,bus=pcie.0,id=cxl.1 \ > -device cxl-rp,port=0,bus=cxl.1,id=root_port13,chassis=0,slot=2 \ > -device cxl-type3,bus=root_port13,volatile-memdev=vmem1,id=cxl-vmem1 \ > -M cxl-fmw.0.targets.0=cxl.1,cxl-fmw.0.size=4G,cxl-fmw.0.interleave-granularity=8k" > > 4. Created region and onlined this memory. Also run top utility on the newly created > numa node using numactl -m top > > 5. Compiled and installed perf utility in qemu environment, and able to > see cxl_hmu_mem* entries in perf list > > root@QEMUCXL2030mm:~# perf list > > cxl_hmu_mem0.0.0/hotness_granual=0..0xffffffff,hotness_threshold=0..0xffffffff,downsampling_factor=0..255,.../modifier[Raw ev> > cxl_hmu_mem0.0.1/hotness_granual=0..0xffffffff,hotness_threshold=0..0xffffffff,downsampling_factor=0..255,.../modifier[Raw ev> > cxl_hmu_mem0.0.2/hotness_granual=0..0xffffffff,hotness_threshold=0..0xffffffff,downsampling_factor=0..255,.../modifier[Raw ev> > cxl_hmu_mem1.0.0/hotness_granual=0..0xffffffff,hotness_threshold=0..0xffffffff,downsampling_factor=0..255,.../modifier[Raw ev> > cxl_hmu_mem1.0.1/hotness_granual=0..0xffffffff,hotness_threshold=0..0xffffffff,downsampling_factor=0..255,.../modifier[Raw ev> > cxl_hmu_mem1.0.2/hotness_granual=0..0xffffffff,hotness_threshold=0..0xffffffff,downsampling_factor=0..255,.../modifier[Raw ev> > cxl_pmu_mem0.0/vid=0..0xffff,edge,mask=0..0xffffffff,.../modifier[Raw event descriptor] > cxl_pmu_mem0.1/vid=0..0xffff,edge,mask=0..0xffffffff,.../modifier[Raw event descriptor] > cxl_pmu_mem1.0/vid=0..0xffff,edge,mask=0..0xffffffff,.../modifier[Raw event descriptor] > cxl_pmu_mem1.1/vid=0..0xffff,edge,mask=0..0xffffffff,.../modifier[Raw event descriptor] > > > 6. Tried running perf command mentioned in Documentation/trace/cxl-hmu.rst > > root@QEMUCXL2030mm:/home/cxl/cxl-linux-mainline/tools/perf# perf -v > perf version 6.12.rc5.gc198a4f4a356 > root@QEMUCXL2030mm:/home/cxl/cxl-linux-mainline/tools/perf# perf record -a -e cxl_hmu_mem0.0.0/epoch_type=0,access_type=6,hotness_threshold=1024,epoch_multiplier=4,epoch_scale=4,range_base=0,range_size=1024,randomized_downsampling=0,downsampling_factor=32,hotness_granual=12 > event syntax error: '..ess_granual=12' > \___ Unrecognized input This is probably my mistake when cutting and pasting the example from a terminal. Add a trailing / and something to run. perf record -a -e cxl_hmu_mem0.0.0/epoch_type=0,access_type=6,hotness_threshold=1024,epoch_multiplier=4,epoch_scale=4,range_base=0,range_size=1024,randomized_downsampling=0,downsampling_factor=32,hotness_granual=12/ -- sleep 10 Jonathan > > > > Are there any steps i am missing? > > Regards, > Neeraj > > >> > >> $perf report --dump-raw-traces > >> > >> Example output. With a counter_width of 16 (0x10) the least significant > >> 4 bytes are the counter value and the unit index is bits 16-63. > >> Here all units are over the threshold and the indexes are 0,1,2 etc. > >> > >> . ... CXL_HMU data: size 33512 bytes > >> Header 0: units: 29c counter_width 10 > >> Header 1 : deadbeef > >> 0000000000000283 > >> 0000000000010364 > >> 0000000000020366 > >> 000000000003033c > >> 0000000000040343 > >> 00000000000502ff > >> 000000000006030d > >> 000000000007031a > >> > >> Which will produce a list of hotness entries. > >> Bits[N-1:0] counter value > >> Bits[63:N] Unit ID (combine with unit size and DPA base + HDM decoder > >> config to get to a Host Physical Address) > >> > >> Specific RFC questions. > >> - What should be in the header added to the aux buffer. > >> Currently just the minimum is provided. Number of records > >> and the counter width needed to decode them. > >> - Should we reset the counters when doing sampling "-F X" > >> If the frequency is higher than the epoch we never see any hot units. > >> If so, when should we reset them? > >> > >> Note testing has been light and on emulation only + as perf tool is > >> a pain to build on a striped back VM, build testing has all be on > >> arm64 so far. The driver loads though on both arm64 and x86 so > >> any problems are likely in the perf tool arch specific code > >> which is build tested (on wrong machine) > >> > >> The QEMU emulation needs some cleanup, but I should be able to post > >> that shortly to let people actually play with this. There are lots > >> of open questions there on how 'right' we want the emulation to be > >> and what counting uarch to emulate. > >> > >> Jonathan Cameron (4): > >> cxl: Register devices for CXL Hotness Monitoring Units (CHMU) > >> cxl: Hotness Monitoring Unit via a Perf AUX Buffer. > >> perf: Add support for CXL Hotness Monitoring Units (CHMU) > >> hwtrace: Document CXL Hotness Monitoring Unit driver > >> > >> Documentation/trace/cxl-hmu.rst | 197 +++++++ > >> Documentation/trace/index.rst | 1 + > >> drivers/cxl/Kconfig | 6 + > >> drivers/cxl/Makefile | 3 + > >> drivers/cxl/core/Makefile | 1 + > >> drivers/cxl/core/core.h | 1 + > >> drivers/cxl/core/hmu.c | 64 ++ > >> drivers/cxl/core/port.c | 2 + > >> drivers/cxl/core/regs.c | 14 + > >> drivers/cxl/cxl.h | 5 + > >> drivers/cxl/cxlpci.h | 1 + > >> drivers/cxl/hmu.c | 880 ++++++++++++++++++++++++++++ > >> drivers/cxl/hmu.h | 23 + > >> drivers/cxl/pci.c | 26 +- > >> tools/perf/arch/arm/util/auxtrace.c | 58 ++ > >> tools/perf/arch/x86/util/auxtrace.c | 76 +++ > >> tools/perf/util/Build | 1 + > >> tools/perf/util/auxtrace.c | 4 + > >> tools/perf/util/auxtrace.h | 1 + > >> tools/perf/util/cxl-hmu.c | 367 ++++++++++++ > >> tools/perf/util/cxl-hmu.h | 18 + > >> 21 files changed, 1748 insertions(+), 1 deletion(-) > >> create mode 100644 Documentation/trace/cxl-hmu.rst > >> create mode 100644 drivers/cxl/core/hmu.c > >> create mode 100644 drivers/cxl/hmu.c > >> create mode 100644 drivers/cxl/hmu.h > >> create mode 100644 tools/perf/util/cxl-hmu.c > >> create mode 100644 tools/perf/util/cxl-hmu.h > >> > > >