From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCB72E77188 for ; Wed, 15 Jan 2025 02:58:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D6CF6B0082; Tue, 14 Jan 2025 21:58:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 386CC6B0085; Tue, 14 Jan 2025 21:58:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2280A6B0088; Tue, 14 Jan 2025 21:58:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F11F16B0082 for ; Tue, 14 Jan 2025 21:58:37 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 82775B0598 for ; Wed, 15 Jan 2025 02:58:37 +0000 (UTC) X-FDA: 83008178274.30.DF226CE Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf10.hostedemail.com (Postfix) with ESMTP id 7E04BC0006 for ; Wed, 15 Jan 2025 02:58:35 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CaUP9zTG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736909915; a=rsa-sha256; cv=none; b=uZ2O/eJpCTxPQXAWwokLO2AbGYsvg7akGGjbCKL48iCvZGlYJsSpeeJ45GmCHxAHJvgJC/ 8fnR/L05yOiHL5vwv0aCaQWBs+OshxcpR7VACKtNAWIMFoa6YH+cBi/6P3qvtn2bRz7d6B d34pU88NzoSxkj1Jlzc8ekoExxXVaoI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CaUP9zTG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736909915; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DOcRRRb2tRIdJ2BkO0YaTQVSUXC8mfW5SWFnS3UV9Bg=; b=aThF+7PFSop3z/g1u4FdEKHWAeGVclAQLQLojTbbkOEsf1Kx/cDx9D45WUeqYjiYwNHo/2 kfT0bz8AMvnn0kQ1yVSOefFHu73ItqJSLsleGrBGxRWEFQxMotQE0mmaqWyW4IoDo+PMaA zXG2wHFBDXaVLbiqZDI9PKdK6/3mnMg= Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-aaf57c2e0beso1266315866b.3 for ; Tue, 14 Jan 2025 18:58:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736909914; x=1737514714; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=DOcRRRb2tRIdJ2BkO0YaTQVSUXC8mfW5SWFnS3UV9Bg=; b=CaUP9zTGgJ1tI7w+YRrfGBSTlOTPMNQKO1/lQM2puHVLarrZwz0BraZUw3dWWSntXB BN1elJNXozuuk4uPSl1TqJ9bL5uPS82w0cK2YOBcRZf+Ng3a+19sq6BbJXiqnYK+tyL3 48hF++L/6ICyII0TVxIgeSOaLzR2XB0Y/zYlojZFhV2BNrM3m6CuW705uBnufHqVS35X j6+mM3ZzrlNwxJVtv1tNEgk+k7SMbDA/qkEkL2dsDrpUdMGfDRkeR9mNkqMibnnGkWVA br0zzK9Qve/21CiPUsrw4SGZ0nKFRJ8Yv7zlxQRSgzfA/yJK+imTtwT0oGrDHHPKbX0E CJjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736909914; x=1737514714; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DOcRRRb2tRIdJ2BkO0YaTQVSUXC8mfW5SWFnS3UV9Bg=; b=TAGt0rUCqGyo0UEDE0Y/GQF3HgFy69RLjp0xid4/P8x3/14TYu+VDgUuT0y1vj8gc3 hC2hBKXTx9N5EiKaUZ4Al9hb4oD5kxYWm3oTl2bnozRJbabLiPRQZ3UUpAzEB8MZfeZq eFSaW7kzCg+40UYZI/fEvZ/OgmCcDVQ7j876N6u8Q+TWKVKVvJeTk4vavDLX7BbDFLDo CJwiMlTN4ARWPBfNi65yRCDeTKlFywn4y7XkKgl7xkFBKSfXb+FaSGNJFI3BQTRTLbc5 ti9dD3zhzatVl/Wcqg7kWu0kFDvipf7F3N1REJKASSExJJ3Tjo34tDt154xbSFsQM78A zOEA== X-Forwarded-Encrypted: i=1; AJvYcCXf8Suo4myp2+/Ce7tykd+K0ERx+HxxpFbLX8DMMvA7t79sSvG/7aO3s7aBIApNx5XypnE11eygLg==@kvack.org X-Gm-Message-State: AOJu0YzCSMlthO8Mo9g3oRxeqPAAyNW0iF98g28zjLdeCwwOk0egttzN HDDtAoZlt5jHLuBGsFF21WiRSHk/F/P34iHjZc3KT0G1RxaqFw2u X-Gm-Gg: ASbGnctTF0fPdl6S6Ill0xAXfCEXJqqOADt+7jxnSJQS1hr/kl3m8RVMjvrEjaRkCHM S9um6TOjSVvcxa4VOIT4z/Na+8Lnmv8cRg66d62EKFYVYSlGp2CA/QE/MaOPtUEcRDnZi2s8Yix pSr9EDvkWCvqF8GEjVKeWF0dSbix7zU77L1AxPSeQyeuCUz5B0qyv1FRFeSdxA93jZgriamfjVz KmNV8uTz1q5X66xQJHotgr/bdQvbwrzA6oxHBWQ1AChgGU6d5N3Plev X-Google-Smtp-Source: AGHT+IE0wx+2Az22Xb8x1x1CxWZaauraPRs1nL8gyFw8PRcQDDH6sFebSZCPEqphD2UPGUruyufDUQ== X-Received: by 2002:a17:907:3f95:b0:aae:b259:ef6a with SMTP id a640c23a62f3a-ab2aad3a453mr2652717566b.0.1736909913726; Tue, 14 Jan 2025 18:58:33 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c95625a5sm694594766b.114.2025.01.14.18.58.30 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Jan 2025 18:58:31 -0800 (PST) Date: Wed, 15 Jan 2025 02:58:30 +0000 From: Wei Yang To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, david.laight.linux@gmail.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, richard.weiyang@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v9 11/17] mm: replace vm_lock and detached flag with a reference count Message-ID: <20250115025830.pebmoyerkruqtx5y@master> Reply-To: Wei Yang References: <20250111042604.3230628-1-surenb@google.com> <20250111042604.3230628-12-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250111042604.3230628-12-surenb@google.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7E04BC0006 X-Stat-Signature: s6a6o8eier6up9zpacqqbag7qupupb7z X-Rspam-User: X-HE-Tag: 1736909915-698066 X-HE-Meta: U2FsdGVkX181JxuaOl0pr/scv5iFOLJ+yzDMoWfwKp8mO3M0VGc+eMLogHhSGo5U2yqQcLL+DhuYQo/D7lc/atmcmpd0Zs2+gXjRnTDj/ONHuKYP66WdK5sN0CApSS0Ysw/YuOYpia+8O4c7TzwYHiEJG277XizG54yZETs1iThtmOPETKM9iDgqfsu1tqDAFL55LHhYXpRSrhBKejeNvmTe1jWOL7SRCEdHlpna48u7yHIz9SHqEIitXcisnn+O9BiT8MesXi4s3L3ub0eAHwrUjpwHDSGzkTY5xd54Y7jwFRhmwbFgJWXDUfC/bPMG+dHsajJVO7zE/3K1vaKYEVWRO/BK62/I+nO+c2kscMABJyGHGvByGRZaWDEcLG92lNICvAehhCn7Sz3sS3fiNUYmFzZcYWEXzWUvR0BY6n74l0EYl5mBX5C7D8hDQnJzfazrH5fMcR777FFKEo8Jktro2DNThmX0guXeDlFn8k/3FS6IzKU1xEFvdUre6xzFMaPNWLPhbth33bqDAXYWt1hJ+KnN1LsdrQe0jNWMynzdVZVdpqheYwX8l0+l+0t6timOpfoGrLFHp2WaE/6c7lmh+bevlIQGlU/KeUKjavVyfhs4qbCyEfckAjtONbmAkeFtYSyydOTu2Kx3ETZS4l4ldMEfnGQ14Fa2LLS2dqwLOxPYMRvZtDAxyLET1tC/G9Mw0ylD2HSeCm23vlpFE5fcd8yMzqUhPEH9PTwd+eJaoNlOd1WrMB0Mx9bwglo9MGD5Vh9M+MWCCPsgJfN8z0g9df7rl7qKGUtvPGrd2M5BQymUaCegbjUTCdzUSlVlBiOmNi8DpSy0FI75rMYGwS+MYgGjK8cU57RsPlB5r3LNyGfIZZNnbDrzw+G/Rnjmyqiq7jWJwpj2fieJUfrvnGViHni7cx/TUrb1rA68AZHFOdg6KDA16J+RL/YWTTeJ6U3H2fRF92F1s2hBeaT DjFvRQNJ EZyalLjYYDhOOEKUzClAtPbRmQjucIWxkbdN2CBbe0fL8yXPVyj/w1FdBpwT0xficKs9j3J2JiHAfjDFElRh8BsnSpBFPhhGlG3c+whS38JOzI04rOpYKKTQ0gckei+vpSVJjTArxDJ0HuUu4rC2a0tJWHohjXHVJ4Y07mgrmGzNaTrlY7j+bcuwscGvyKWBGCdvgILRnuGiEgcSzSuo42JoESk17yQbPx/814q5UBeXpC1lySR02aju/n3/1T6n0qd1/Dq7rSTLaGe3y1tfwfdtUrtBV56czbZXts2tVtmnxyUUlQTJ9Y15CRIWTWmksXfCEnZW1dKFK0UjwXgOrmhyXPgm3x0vUH4NMody9cwPxTDiVHpfIvSCC4SRNRpcq+RrNEKX0J/MEfTasY3h1eDP4VfNI+d0+uMl++MVRvFWOzgKc4tmgBWFKiWJJVDpoXxhV4vpmdk2BWbzxvQeY86XhQi886GH/EdTsQKFt4xtQkiNzUPfq/Jf2lwMkkhx1upNFVtQy2JbEd+xQ094xK/OMVDpDAoCyJrSGOdChN0S1FDgucF1/kBMp+eV6yOiEXGT5ghnXwrDKff4OsZ6NUA1q4IePDwu+4tzHPID79XaXNiXakQbsJIRkHiTUM5T9zGTxTC+1cSdrX+EM76Rqlp5ILDT0gHpgjzybD/gdOErjbAc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000049, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 10, 2025 at 08:25:58PM -0800, Suren Baghdasaryan wrote: >@@ -6354,7 +6422,6 @@ struct vm_area_struct *lock_vma_under_rcu(struct mm_struct *mm, > struct vm_area_struct *vma; > > rcu_read_lock(); >-retry: > vma = mas_walk(&mas); > if (!vma) > goto inval; >@@ -6362,13 +6429,6 @@ struct vm_area_struct *lock_vma_under_rcu(struct mm_struct *mm, > if (!vma_start_read(vma)) > goto inval; > >- /* Check if the VMA got isolated after we found it */ >- if (is_vma_detached(vma)) { >- vma_end_read(vma); >- count_vm_vma_lock_event(VMA_LOCK_MISS); >- /* The area was replaced with another one */ >- goto retry; >- } We have a little behavior change here. Originally, if we found an detached vma, we may retry. But now, we would go to the slow path directly. Maybe we can compare the event VMA_LOCK_MISS and VMA_LOCK_ABORT to see the percentage of this case. If it shows this is a too rare case to impact performance, we can ignore it. Also the event VMA_LOCK_MISS recording is removed, but the definition is there. We may record it in the vma_start_read() when oldcnt is 0. BTW, the name of VMA_LOCK_SUCCESS confuse me a little. I thought it indicates lock_vma_under_rcu() successfully get a valid vma. But seems not. Sounds we don't have an overall success/failure statistic in vmstat. > /* > * At this point, we have a stable reference to a VMA: The VMA is > * locked and we know it hasn't already been isolated. -- Wei Yang Help you, Help me