From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C7A0E77188 for ; Wed, 15 Jan 2025 02:27:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 069CA6B008C; Tue, 14 Jan 2025 21:27:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F343D6B0093; Tue, 14 Jan 2025 21:27:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAEAF280005; Tue, 14 Jan 2025 21:27:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B8B836B008C for ; Tue, 14 Jan 2025 21:27:10 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 727C41C7FA4 for ; Wed, 15 Jan 2025 02:27:10 +0000 (UTC) X-FDA: 83008099020.21.71C2146 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf10.hostedemail.com (Postfix) with ESMTP id 7594FC0021 for ; Wed, 15 Jan 2025 02:27:08 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IJmDqMYx; spf=pass (imf10.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736908028; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Cft0FFnxbXaKCYduOTSHaxekyaoRv/tqmxl3MTYv73s=; b=PP2SAPTuz92icoqrik3iYS4+H7Xj6pvir5+ihquGnec087HZGB5z50paCqKo/8HISKMptz F7RU0SY29HV/l79az1IJcq1MPQxXgU3kqYjvOdphFZTocT1H3aav6DDTYCy5Adm3trrUJx xku5q1yly9CCEEiZR2IqrxsHp1Pn/0g= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IJmDqMYx; spf=pass (imf10.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736908028; a=rsa-sha256; cv=none; b=5gL6p2b7OZB/3I0wpi8GPUuJDCVK0xc7C+QRKhWToThq6iqOgnsxOt/bbSDf64FznRUAWC tkE7EcmXMM7uPQiZcywZJfvzcSxiwAQW62cQvloJseOotDILkj5vioT9cyHUY2j6YopSyE EROqQb68VFDjqtZWhct19T6drpg/enQ= Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5d3f57582a2so805433a12.1 for ; Tue, 14 Jan 2025 18:27:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736908027; x=1737512827; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Cft0FFnxbXaKCYduOTSHaxekyaoRv/tqmxl3MTYv73s=; b=IJmDqMYxEULP4dArb0kZmo+SoA6Yy1PnTZAxJmLGbfJx+8RW2BDgN7YvXbtMq3I9Sl MZwJq80fFeyZ1pGiXyqXYyxcvuKCCJT2NVWMqCPDK7cOoSggFvzwMj8lq8kGeFXNSVhj i27fW6DffSXj5SAkAjmemmHmAbuWcpfUTbVv+11U1Z4CTz53o9pVMnyKqpu+L7wjoHqh dRfqR2IylJNVUT0NvRTc3B0k4d0hNfeENux/G4/9mDzJqeR93HRktNIye8wSHDSJjyyX FYJjh+XENAdLylxSYM3EhVAGNep1SJDm389sf9KyVCl8NhYiNoLkraG0zFDhEHOIYgmz Z5YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736908027; x=1737512827; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Cft0FFnxbXaKCYduOTSHaxekyaoRv/tqmxl3MTYv73s=; b=EiOja8ciPcbuqeBS4SZUUkCQhOcOeCeSr+us3bhBaV2mslkUlS0jhnDYK6dUZYr2+Q TChL/CSjv1qlcg02lG8Z793BWqaR83tbnmD3XkaAWsbBalPrtaOO3aH86Bo4MFRcFo83 5F7l4bBugvMqS70qz18zTOQdiWhvhWaCljnYFQ9i/B3J9PcSiykKgweHQtS+PqPcm2e8 btEO5UosIma3cbJvrCMVCbukyjBPONIkkB6qtvbLvsUn3eNeCWNDT+QHOBI+XozdVZff aw36Dfx+fWXZcL38OZT7jZ8A1PkidszMWzbuObui4y0oIaPWB4K7nCFW1vcQaBKN3O9q FdXg== X-Forwarded-Encrypted: i=1; AJvYcCWFJURpiCXJy30h4xbLGmQsDEOWpxb3bkpF+OKSJ3lFjVW/6ABGU1ksb6D9WnzAGwMAIC+9RabVLA==@kvack.org X-Gm-Message-State: AOJu0YyUxBhKt52jRiQecUXq/+y6CTGgifowQSaoBp5/9MabdFEtrUEF PejN26skzsL0ffUyN/cMX66K2k2bCTQXrDuhQjYJvs693dfSjlmn X-Gm-Gg: ASbGncuRmtDRaMnog2mpvXV2U5r2IqKKfoG8GQm/R98hmZInC2betLBeq9wjs/CQ6Ma K9liZGmLBoR7e5iTD8viuihyaMBQLHlZRBnx7jusbpbIlJCO6tHJ4AGYl1M0mwZkUzuzXijF2PE LDGMZ2j/rLgEekEzk03Duq5uZYcNE99Phyl2JnUjsN6F/A+fCntfwx/Mca3ts4JUmIgc2Owr+96 lIQN4hqV4eVh9Nk0b9po0mo3tfkRpslX8lrs+5tmPT885OURas5Acpq X-Google-Smtp-Source: AGHT+IEXyK5JsIG/REt2LqHjIyVyNodxD/Vbd8MXSPX+u0YWKZ4KISrSFVqciHOWz/+J8reVSqyBoQ== X-Received: by 2002:a05:6402:27cf:b0:5d0:ece3:158a with SMTP id 4fb4d7f45d1cf-5da0bac2db9mr987630a12.3.1736908026651; Tue, 14 Jan 2025 18:27:06 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5da0aec6e7asm421301a12.33.2025.01.14.18.27.03 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Jan 2025 18:27:04 -0800 (PST) Date: Wed, 15 Jan 2025 02:27:03 +0000 From: Wei Yang To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, david.laight.linux@gmail.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, richard.weiyang@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v9 16/17] mm: make vma cache SLAB_TYPESAFE_BY_RCU Message-ID: <20250115022703.hqbqdqawvqgrfgxb@master> Reply-To: Wei Yang References: <20250111042604.3230628-1-surenb@google.com> <20250111042604.3230628-17-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250111042604.3230628-17-surenb@google.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: 7594FC0021 X-Stat-Signature: tsstn338ea53dzx7nyqwwui1qdunu8w6 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736908028-566889 X-HE-Meta: U2FsdGVkX1+lbcQcpvjfO8L7ZiWV+84TN5SXCFoA94vywEcBPbBZDCyr75Mrz9LP/khfcxG8NKPTgcWPDIY9v9X4u2sCaqKErWZYa4vNjpjsnybflKK2pC4ELZxCdsqRsEiCwkd1PCKLFpx5q91wGgg+VXPWp5QTtae2jEHy9b4Jr3IozJ6DUx7c28D/gJLxXjmYxW8DXp8XiiNA95QGvLILBhJQJaZZPfgV7bJQsXpw+ngOrklM19GgQv0Q/fnMGvZdvvIQPg0SDMt/OyaPWDAA6CxAjxoxcJOg+pXk9R/GvDZMAkqAMd6qj677O0LYSBTqemUNQa/G0U3Cu/K2l0phr3rFKbdCrhgO3QGOBpKVL8wuEBNbmtEvy3MFrheLYvtqLnMaJ+XpkLQwf3JFTaLt+dSR6/mFrbS3aRSE3WTlIqykVq/aKgA399oUfa1zZ1SDoewtzzvfK0+5hAYV1JFoypQtbiRq3MCA1VH6wHegnQdjamR7mF6ZMSgd78ikvzDwPNjOIbRDrHHRKjMpbEAS0xG5uZPMxLk+VMHyCtSfifsjQxhae+WyqYxnMaEti6F5taK8CPo9A7d68yo9D3eHmzQK9L1ANfrnyZeL/1/ROvMp8+RXZY2bJVnM0Ry2lC/znDNdA27wDKCGWVRokGuLJL63Jun7T2xRYeTzUAc+sMCkuTVMoynjLzAgnJdFwc9zlaMAUJQ1/UP6JDCmPoak/ITE+v1szerXTbbAy5P6SjadQe3dJ+mzPyi9DntCIB/j14M039KPi9bn7n+KV3qGyn6VlW6kw9kF95G+amnQAB+yvxsx49qfGcIpNPqoJhg4YrMyqwgCmfzejpBlVzbsldaT6IGFSA0sLTtAz0qSXq6ajk1ZJqv3lXUJ7Um0d5P5bDVnw6c31vUt7yifoiK8HyOXcZuqVKCUYcpZem19EYdY0+aA9/oPswKq+qZL0Q007y4OYzW9dPfKZ9/ kXGt4cdE xFztOGMby0gssiFKVuY9kNtjRf/8AIgfR0JRaSCBcbV9MF3yHAlkxuXjNzk+PvCLjtRXqHOFX0MnUk1rrJF5Qbo55944hmP6gi9ZwXYGFs+wK6SmNOMZzIOuE8TMEjZFbCnfO2ATHR3uHY5RLXhDG8jtREJ/l3CnQmVqW5LGTRY9xbT/i+8JzS9NeGebBHS5gzlfONZaH5VJdTUaHif8KA+GklR+ap6EwWyIE3X7qLAsTZRRcKt5wV37JcuIyUIQhwey3OcDxlRdUEO6+disaHoPgVcGnQzeJ1Ti1YehtIrWpRavbBv/kn4R77br7XY69ZFS6+mNG58cHgVWkrZzx+xxqA7Ktq9/UyZmU7dantxIT98LNfX111FFHVVEH1ve0KllKgZbMAHX6rtT/QMOgLBbmMJ3NvhaE0jDYrSF/Ub2by83h4tDYit2XXXO8AF0+pvQAPnZ7cd1lkCYRF2srpcDCpt4OwMheLCqkcpEY82RqOdPR9xGcrPCwQYdDuBya6bxiR7CqEyrBwg8bVvfl/8GPJESwZwz4UBGGszzuWyBq/HhNDM4Eb5vGcbAAb+V9FUrmWNqDeYTOfj2kRZp1sawNRudaM8O+300Q56+t54ceB6hdIfidoXKYCpgqmFZ7fWuZyA8H9dzXfL9zzwtW2wGqZchd9U6/mco16bhyBuAXzQc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 10, 2025 at 08:26:03PM -0800, Suren Baghdasaryan wrote: >diff --git a/kernel/fork.c b/kernel/fork.c >index 9d9275783cf8..151b40627c14 100644 >--- a/kernel/fork.c >+++ b/kernel/fork.c >@@ -449,6 +449,42 @@ struct vm_area_struct *vm_area_alloc(struct mm_struct *mm) > return vma; > } > >+static void vm_area_init_from(const struct vm_area_struct *src, >+ struct vm_area_struct *dest) >+{ >+ dest->vm_mm = src->vm_mm; >+ dest->vm_ops = src->vm_ops; >+ dest->vm_start = src->vm_start; >+ dest->vm_end = src->vm_end; >+ dest->anon_vma = src->anon_vma; >+ dest->vm_pgoff = src->vm_pgoff; >+ dest->vm_file = src->vm_file; >+ dest->vm_private_data = src->vm_private_data; >+ vm_flags_init(dest, src->vm_flags); >+ memcpy(&dest->vm_page_prot, &src->vm_page_prot, >+ sizeof(dest->vm_page_prot)); >+ /* >+ * src->shared.rb may be modified concurrently when called from >+ * dup_mmap(), but the clone will reinitialize it. >+ */ >+ data_race(memcpy(&dest->shared, &src->shared, sizeof(dest->shared))); >+ memcpy(&dest->vm_userfaultfd_ctx, &src->vm_userfaultfd_ctx, >+ sizeof(dest->vm_userfaultfd_ctx)); >+#ifdef CONFIG_ANON_VMA_NAME >+ dest->anon_name = src->anon_name; >+#endif >+#ifdef CONFIG_SWAP >+ memcpy(&dest->swap_readahead_info, &src->swap_readahead_info, >+ sizeof(dest->swap_readahead_info)); >+#endif >+#ifndef CONFIG_MMU >+ dest->vm_region = src->vm_region; >+#endif >+#ifdef CONFIG_NUMA >+ dest->vm_policy = src->vm_policy; >+#endif >+} Would this be difficult to maintain? We should make sure not miss or overwrite anything. -- Wei Yang Help you, Help me