From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BBA1C02183 for ; Wed, 15 Jan 2025 11:14:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 020B36B0085; Wed, 15 Jan 2025 06:14:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F131F6B008C; Wed, 15 Jan 2025 06:14:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8DD9280001; Wed, 15 Jan 2025 06:14:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B85EA6B0085 for ; Wed, 15 Jan 2025 06:14:19 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7BEB4AF274 for ; Wed, 15 Jan 2025 11:14:19 +0000 (UTC) X-FDA: 83009427438.29.D2A9209 Received: from flow-a3-smtp.messagingengine.com (flow-a3-smtp.messagingengine.com [103.168.172.138]) by imf04.hostedemail.com (Postfix) with ESMTP id 6F7BC40012 for ; Wed, 15 Jan 2025 11:14:17 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=coelacanthus.name header.s=fm3 header.b=bMtaM99w; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="v wKAEsD"; dmarc=pass (policy=quarantine) header.from=coelacanthus.name; spf=pass (imf04.hostedemail.com: domain of uwu@coelacanthus.name designates 103.168.172.138 as permitted sender) smtp.mailfrom=uwu@coelacanthus.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736939657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WfiGYnphGqvudtD6RXFjAbGTohKPfJnsfNrRsHzlEL4=; b=7ae7TmjPPU0siu57xTbI8MBjmRMoSORjHkYjNZ69sg5jLrypfeoCBkL/2CmdlCYQIFU1jM iemYLNjt6dZY/9yFJxmWC1zggri2fJCPkCnfBzdZqEq95FMDkNpJoaKqVlt1ItbCJxqeVE mwWl9YxZZQsYtqW9gq+gwiG5sdkMLG8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736939657; a=rsa-sha256; cv=none; b=lX1RSZ1AjLjRyLvcJVze5vpQky1blvEcYfnVCN/DrZgNVU91CnkfppsTs1Her71uOTTfIv 9ghE/OGz1Ev0ZDgB/2j55sMGCe/yYW/HZvEDvhMNl5Bnc4jvNTWp4b1sCXIpJkhHEP8432 z56i6jKcX8MG2mjiVE5w0yaMjp+BB7w= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=coelacanthus.name header.s=fm3 header.b=bMtaM99w; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="v wKAEsD"; dmarc=pass (policy=quarantine) header.from=coelacanthus.name; spf=pass (imf04.hostedemail.com: domain of uwu@coelacanthus.name designates 103.168.172.138 as permitted sender) smtp.mailfrom=uwu@coelacanthus.name Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailflow.phl.internal (Postfix) with ESMTP id EB8BD200F84; Wed, 15 Jan 2025 06:14:16 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-08.internal (MEProxy); Wed, 15 Jan 2025 06:14:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= coelacanthus.name; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1736939656; x=1736946856; bh=WfiGYnphGq vudtD6RXFjAbGTohKPfJnsfNrRsHzlEL4=; b=bMtaM99wg2t0sGsWBBr9DRK+d4 6ElpWK4uVOU6I3S3fC5DrwS6XS5Bop4pBipUtYzdgo4tTPDBqilV9gQjblb7pgKW ZThERb5+upl9p5jRj57trl5UY5G6X2fdNebgjKdTBbk3bj83Kam9brdokLXr8JZ8 sm/eCiITI9F33g6DwKwtci7MDQ3jW5GpP8Vq0mtdZYzxCQqwass2ShGCvnRPmesg XbYrGe0uVK1I6L/cI3kppZskPKPTdMOvWypAUCdu3h7I+FB5NF/w884oue9CZ61/ 7q8cgJu5xGBsC4KeuTZaxkZCi6zyvvQ20ysPThLy0CZU5UqFks8YOFrG2z0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1736939656; x= 1736946856; bh=WfiGYnphGqvudtD6RXFjAbGTohKPfJnsfNrRsHzlEL4=; b=v wKAEsDy3E1Ykbo7zHQnkulDZ0dw9Uq6wZLJvdF2P1jPNEiKelP0sTZHWecUpSK4E bZStqGKG+BWi+Jjfx5jbblUqXArW/EGqqg14euV5qQYyzba7tFTFLGOSeQb/hO2w BhJ/RVMEp3kiuEfKLJNM3uARulwsZNbAZ7MMiV+QizNSIKk76aOoNQ5bxToWdwJe 5o41MBSDvENrjJidvtEzU66HcKY8fRr5if0H+hCPb+OwmayemsQU48Q5BuaJM2wR ju6vialqhZEfzvRe44PPV3Y3senx75wSOtZz2WJsQh2SJV8sZWdQfOAjzh4hBWXP mi+rHqlywRwL0ECEM7ydg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudehlecutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffrtefo kffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsuc dlqddutddtmdenucfjughrpefhfffugggtgffkfhgjvfevofesthekredtredtjeenucfh rhhomhepvegvlhgvshhtvgcunfhiuhcuoehufihusegtohgvlhgrtggrnhhthhhushdrnh grmhgvqeenucggtffrrghtthgvrhhnpeeuiefgudffleffgeeiffeffeefieelveejgfeh hfejffeutedvffeiudevtdelgeenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuhifuhestgho vghlrggtrghnthhhuhhsrdhnrghmvgdpnhgspghrtghpthhtohepvdejpdhmohguvgepsh hmthhpohhuthdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghr nhgvlhdrohhrghdprhgtphhtthhopehlughvsehsthhrrggtvgdrihhopdhrtghpthhtoh eptghhrghrlhhivgesrhhivhhoshhinhgtrdgtohhmpdhrtghpthhtohepsghjohhrnhes khgvrhhnvghlrdhorhhgpdhrtghpthhtohepshhhuhgrhheskhgvrhhnvghlrdhorhhgpd hrtghpthhtoheprhgvseifiehriidrnhgvthdprhgtphhtthhopegvsghivgguvghrmhes gihmihhsshhiohhnrdgtohhmpdhrtghpthhtohepiihhohhuqhhurghnsehishgtrghsrd grtgdrtghnpdhrtghpthhtoheplhhinhhugidqkhhsvghlfhhtvghsthesvhhgvghrrdhk vghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i95c648bc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 15 Jan 2025 06:14:14 -0500 (EST) From: Celeste Liu Date: Wed, 15 Jan 2025 19:13:27 +0800 Subject: [PATCH v6 1/3] riscv/ptrace: add new regset to access original a0 register MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20250115-riscv-new-regset-v6-1-59bfddd33525@coelacanthus.name> References: <20250115-riscv-new-regset-v6-0-59bfddd33525@coelacanthus.name> In-Reply-To: <20250115-riscv-new-regset-v6-0-59bfddd33525@coelacanthus.name> To: Oleg Nesterov , Paul Walmsley , Palmer Dabbelt , Eric Biederman , Kees Cook , Shuah Khan , Albert Ou Cc: Alexandre Ghiti , "Dmitry V. Levin" , Andrea Bolognani , =?utf-8?q?Bj=C3=B6rn_T=C3=B6pel?= , Thomas Gleixner , Ron Economos , Charlie Jenkins , Andrew Jones , Quan Zhou , Felix Yan , Ruizhe Pan , Guo Ren , Yao Zi , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Celeste Liu , stable@vger.kernel.org, =?utf-8?q?Bj=C3=B6rn_T=C3=B6pel?= X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=3197; i=uwu@coelacanthus.name; h=from:subject:message-id; bh=Bd0I0lIMKMC4KxEOjUIKWSGVerkNEic9IL2ALFZ+R48=; b=owJ4nJvAy8zAJeafov85RWVtBeNptSSG9PYZ5VutbCad5Tn5ndOR38uJYV7Dv+6vnvq+FfPTO Y/NcE6L4e4oZWEQ42KQFVNkySth+cl56Wz33o7tXTBzWJlAhjBwcQrAROaGMTI8d991KlKo4aFX I19XSsrdpJofD4xDWCJfvDU3FFGb/7qL4X8Ux5rc0wu8ddemZqSnL2Bb/XjS3wA172m/l4Umzts xwZIDAL8wRz0= X-Developer-Key: i=uwu@coelacanthus.name; a=openpgp; fpr=892EBC7DC392DFF9C9C03F1D15F4180E73787863 X-Stat-Signature: fcsr3yhofc8ohdyx3iozsxqtycrj5x5b X-Rspamd-Queue-Id: 6F7BC40012 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736939657-838907 X-HE-Meta: U2FsdGVkX18lochEnMO9qNnhMeI8GcGPLuR4W4Yx2W+iVUa6JeThG2I6kASIhr8HVXTD2pg+K4uJxpudTj7IJmiSJSm6M2oagGYXOAykPEJAyK0+Rey+2ORISmL8dxBwpN8rXebZpHuuHZHnwGbN9aYlunGrjAn5pZJxruUBafA1PT2SM3bkpPkrOZEqncUXuyyi4/SIAWlzZwp+aUIesJ5eXX8e4WJ1ewIv8FPbTCKy+a4l7eB+viOjuvIXvNiF0ampQ/ynrn6CfhvtaLXu6hdftb/rjixrYrLAnj8ScXv77IbMsYKQlQiT2mId62tvQXU1sGgeX8Q14/dKKLYu+MhQIu+L9h+VAAlnkWAgfmjlyy/dnYKFCu1snRUukgrwgIGwS51CZ0f8bTuvTyO4bRtTA8urlkrEqzY7M+wPrP/MOmbcUqH8D3K9nmUi3YEpDgs6Kp31xeEiO0mnaSFqsPgqCvYwonNd0N7VPemT4SaLv23es7lzOirOkHqrMnGM1Yy0J6sNjz0ej8TMhmQgujw3O+Z80uK7TrHCmCunn+Bf2dDS1WFYYGPunSLSiFg0UyumNKrbQA72+QlHdUAVJFRvwKuN4yHoW3R6ngZsn/97blpdVgkUuJEENJ8NrXDBd6AyL17Nw3U69vssljmU/748KW3eNyIbIzExXeeHW24jBMZ7GztqB4IbUM9JplfkazhxelsEjJOslA7rmNSa+0VjWEvnv3/rskJ7R/+VX2G+8fqyTBsJRdJymABAsb1LOzJFiRzFQ7N5/AFckFME2eZrvxZIZDtMQ2QbbG7A8Iu6vjzqJoQoTwaHlo3/NKawWDtV6JJTxghgY8dXBH+l1J7w4IU/tPca3fJMj+ov/Vs5kZGUi5nictbCEHU1ZUPim+ZgPJZbpRp7g0E7R8FoqNtL8z4r4fpgXn83a73hePDQSewgy6i78ubccuBa2vmubIUTshCS/5SQmDyXGq8 vMZ4tbMI s1fXDVCOGJJmvHxnAbpA/wCpWtlC82NHibsVcsM0uXUZlskSR1aLQxmgWImBGrk+XyVbe3ZF64lYuPonmXlEFZriSzn0tWcFARUFIfjTCARGD14ccQoXL12cXvl7y6r9L22xSu9rz7pWoqcv9KyHVwvBZnh7xtTXE8JmdMgkGawBrO1pS6RvhsUn76xZaGVyHiQs1hng8CUzABO7/GFso/x6cXB97RYy0LbCox/+dj1jbOt2nwMSz0ucDcTrV691HdKrmaaNTHHwpfjuDAZXC4AX1iHXCs5SRddqAGyYbKIbHWOwy+4qoQy+nS2XCz4LPNAKdVV+ngiXFaH/z0MQILdOT3PtJpb7O0PNf4m+cN7iZYiYUWZhFKS8tt13Dj+7/0hJQuFBW6ZRoZJ/sWi0HOdnEyCso38h1FHsjRvFCewNcodu2XfIJ5kIKelY08nMm+wnWpJlfnXF7XcImhRA59HLotMOpuuaca7VzPW1na/4c9McxswfOdJXPHBycX/Bl0krIo1I8egLyIU1Dlx7357EZq/Qbqc9mTYuyMctCwbzcUt7wubeQHIXmIdfU3udO00rAdgX5I68ttDjKLa/28qAMrfjQuBJSDnTC6O1lf9vqGnNaoKrax866wYJgErs2Ztl9Ni2Rn4t28GM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The orig_a0 is missing in struct user_regs_struct of riscv, and there is no way to add it without breaking UAPI. (See Link tag below) Like NT_ARM_SYSTEM_CALL do, we add a new regset name NT_RISCV_ORIG_A0 to access original a0 register from userspace via ptrace API. Fixes: e2c0cdfba7f6 ("RISC-V: User-facing API") Link: https://lore.kernel.org/all/59505464-c84a-403d-972f-d4b2055eeaac@gmail.com/ Cc: stable@vger.kernel.org Reviewed-by: Björn Töpel Signed-off-by: Celeste Liu --- arch/riscv/kernel/ptrace.c | 32 ++++++++++++++++++++++++++++++++ include/uapi/linux/elf.h | 1 + 2 files changed, 33 insertions(+) diff --git a/arch/riscv/kernel/ptrace.c b/arch/riscv/kernel/ptrace.c index ea67e9fb7a583683b922fe2c017ea61f3bc848db..ef9ab74c8575a5c440155973b1c625c06a867c97 100644 --- a/arch/riscv/kernel/ptrace.c +++ b/arch/riscv/kernel/ptrace.c @@ -31,6 +31,7 @@ enum riscv_regset { #ifdef CONFIG_RISCV_ISA_SUPM REGSET_TAGGED_ADDR_CTRL, #endif + REGSET_ORIG_A0, }; static int riscv_gpr_get(struct task_struct *target, @@ -184,6 +185,29 @@ static int tagged_addr_ctrl_set(struct task_struct *target, } #endif +static int riscv_orig_a0_get(struct task_struct *target, + const struct user_regset *regset, + struct membuf to) +{ + return membuf_store(&to, task_pt_regs(target)->orig_a0); +} + +static int riscv_orig_a0_set(struct task_struct *target, + const struct user_regset *regset, + unsigned int pos, unsigned int count, + const void *kbuf, const void __user *ubuf) +{ + unsigned long orig_a0 = task_pt_regs(target)->orig_a0; + int ret; + + ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, &orig_a0, 0, -1); + if (ret) + return ret; + + task_pt_regs(target)->orig_a0 = orig_a0; + return 0; +} + static const struct user_regset riscv_user_regset[] = { [REGSET_X] = { .core_note_type = NT_PRSTATUS, @@ -224,6 +248,14 @@ static const struct user_regset riscv_user_regset[] = { .set = tagged_addr_ctrl_set, }, #endif + [REGSET_ORIG_A0] = { + .core_note_type = NT_RISCV_ORIG_A0, + .n = 1, + .size = sizeof(elf_greg_t), + .align = sizeof(elf_greg_t), + .regset_get = riscv_orig_a0_get, + .set = riscv_orig_a0_set, + }, }; static const struct user_regset_view riscv_user_native_view = { diff --git a/include/uapi/linux/elf.h b/include/uapi/linux/elf.h index b44069d29cecc0f9de90ee66bfffd2137f4275a8..390060229601631da2fb27030d9fa2142e676c14 100644 --- a/include/uapi/linux/elf.h +++ b/include/uapi/linux/elf.h @@ -452,6 +452,7 @@ typedef struct elf64_shdr { #define NT_RISCV_CSR 0x900 /* RISC-V Control and Status Registers */ #define NT_RISCV_VECTOR 0x901 /* RISC-V vector registers */ #define NT_RISCV_TAGGED_ADDR_CTRL 0x902 /* RISC-V tagged address control (prctl()) */ +#define NT_RISCV_ORIG_A0 0x903 /* RISC-V original a0 register */ #define NT_LOONGARCH_CPUCFG 0xa00 /* LoongArch CPU config registers */ #define NT_LOONGARCH_CSR 0xa01 /* LoongArch control and status registers */ #define NT_LOONGARCH_LSX 0xa02 /* LoongArch Loongson SIMD Extension registers */ -- 2.48.0