From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A0FC02183 for ; Wed, 15 Jan 2025 09:56:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33E096B0085; Wed, 15 Jan 2025 04:56:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EE896B0088; Wed, 15 Jan 2025 04:56:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 190F06B0089; Wed, 15 Jan 2025 04:56:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EED9A6B0085 for ; Wed, 15 Jan 2025 04:56:36 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9487E1610D4 for ; Wed, 15 Jan 2025 09:56:36 +0000 (UTC) X-FDA: 83009231592.18.2CC8BE1 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf12.hostedemail.com (Postfix) with ESMTP id 9C14A40006 for ; Wed, 15 Jan 2025 09:56:34 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=C28df5W9; dmarc=none; spf=pass (imf12.hostedemail.com: domain of ajones@ventanamicro.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=ajones@ventanamicro.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736934994; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5Ke3Xx/wtgubyAhgh9gm7HdjX/OGZn6UodYiywkGpxs=; b=oTiGKAFzY67lshPFSarHICkto6aX/cao2otAi4cA+TDma4Qf5JdmAz/3/1elY/f7q8hoQk vvUlFrhcBvdEiFl2rou7UARR8kZNkTyQoda6UNknIHlCLVT4usJ3ed+rFGao17ZJBp7p/q D87erKqFOm2DvOXpX6DQl/uA2tw2qrg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736934994; a=rsa-sha256; cv=none; b=kP0ei+OmDBT+WSv/3Q6mZlvKXCtrQqZTzIs3qiDcbiAgXjHlbzLH0slf6s8CJcaxZj0DUZ HJF+n+tP8H0IqJCCDRZMEw2EYhz+rPfgyGlw5/wQ4bSH3qWmG9axJ4FHAjB2DnWC7YiLuD 1L+2jXGmqrSlL0CDBG/UxbX00FrMzSs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=C28df5W9; dmarc=none; spf=pass (imf12.hostedemail.com: domain of ajones@ventanamicro.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=ajones@ventanamicro.com Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-386329da1d9so3313672f8f.1 for ; Wed, 15 Jan 2025 01:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1736934993; x=1737539793; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5Ke3Xx/wtgubyAhgh9gm7HdjX/OGZn6UodYiywkGpxs=; b=C28df5W9L+sEza3nYtLghrAudbMeMLyu1VkVsLt2djUEztjAltM835z+XYMsGf+HCk SthI6Ed+zZ0d4WQR93dDV9/6bJTE0p64v/3G2YQrPtORZXbWtzkGQswSKYboUl6IDpsC ND7wx5BNJwq68Bdy6vb+SvMjNhWNZks48L/MBaxd4OolCqIPZVjHTvIokkmUUbwyt8QH Q75rMpNO4HQ/bAhJ6K5LT1NnxHo3uISkM5pmQmNcmpiU76dXS8ebeGgBeqImsXzfiIt6 NALJVV+Oil/+irIULCHMGZ8lNktN2Y8KPomg/+xDpoo8R0Z/e5PTkltu0KfceaUUcYAx o58Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736934993; x=1737539793; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5Ke3Xx/wtgubyAhgh9gm7HdjX/OGZn6UodYiywkGpxs=; b=ZE1csVFHITT+QS+6Jy0wN/mlOsOjpQgZjX6JzlazCPao3N5dCDnwVvk9C4h7/PtpAG Vavnnve+mUO1b6+EWognaCaU86YkWOCkeFEcn/BVv/OE6VAau5EiJ16s/HrXp38gL39D v7fADgederDRlnSSPJha5pGriHRPXYEsM3wyZBIrdS3MzNGrr40M1nIVBRe3UMO9lQYp pGDMF6y+1mfHj7nwk2XhxNDobRWL2Au9eTksPfmNpdT+xtNs0qjkBJ2C2iQej1lx5eoy /t7LwhrPOWfUsn/s1mCcXVZK8oFe92dIMjhzi/nrVo/V01GrOtF4V0W2OefNLyJ2zUWc MqlA== X-Forwarded-Encrypted: i=1; AJvYcCX9mHhEaSWh6uKOIllGUSW1Pajh6FjgTRfLvY/iWA1iR6SJFpiTLkL6ia+ajiQEXLR2xDwgWerJBw==@kvack.org X-Gm-Message-State: AOJu0Yyt9LG4pGV6stq2zwNkyAkVf8Ue7MK4j5K/8qqQgFaasKim6eqJ HbcUH11cVaR+DHI8FZhdkqH/YJeR4iKwnnRpKv/7ZbXFIrKbCKawlQFlIijfnac= X-Gm-Gg: ASbGncuPZ98Jk4y/dnAPo4QG+9zqZly6v4Xtry3bg1VYnBvcSjfPrYnSTk0f+9KY3fz dbrujMGwvOMsxq0aiik1jmB/5PIHEKfQy+8VOf9QdwO/rllT6XdtOU9GcHZzL0ifxMpa9Q+aVnV +tHZKU+3mp52LDAke5L1+in8oHPqCdrd0IcnGBK4hUtiYjY9Ln/XgbUIKB52iCMBWKJWy2GwzPy uitIPmRNCp3INM6UG8YM79dz1tzKO87osruDiJ5E2Ne7BERWrNx3wBQR4G1kWFnXMMwsPXTG2UZ OfY+P8mar5Ko2R7iIHLcLSH2wwG4nBovQ+KwpECHiA== X-Google-Smtp-Source: AGHT+IENVizyrpTDaL6AXD65KcGWw+5Em2NxzXA8Eh98pJFESDPN89Pap+1V8u237LVHxYhDj/sKOA== X-Received: by 2002:a05:6000:184e:b0:385:f560:7911 with SMTP id ffacd0b85a97d-38a872c93e3mr25276895f8f.10.1736934993168; Wed, 15 Jan 2025 01:56:33 -0800 (PST) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c749989asm17783685e9.2.2025.01.15.01.56.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 01:56:31 -0800 (PST) Date: Wed, 15 Jan 2025 10:56:31 +0100 From: Andrew Jones To: Celeste Liu Cc: Oleg Nesterov , Paul Walmsley , Palmer Dabbelt , Eric Biederman , Kees Cook , Shuah Khan , Albert Ou , Alexandre Ghiti , "Dmitry V. Levin" , Andrea Bolognani , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Thomas Gleixner , Ron Economos , Charlie Jenkins , Quan Zhou , Felix Yan , Ruizhe Pan , Guo Ren , Yao Zi , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= Subject: Re: [PATCH v5 2/2] riscv: selftests: Add a ptrace test to verify a0 and orig_a0 access Message-ID: <20250115-9a1a8e824977f49770a5358e@orel> References: <20250115-riscv-new-regset-v5-0-d0e6ec031a23@coelacanthus.name> <20250115-riscv-new-regset-v5-2-d0e6ec031a23@coelacanthus.name> <20250115-28c95808502d43f84b3fe0a6@orel> <17dfb122-4ae3-477f-93a8-1748b819c59c@coelacanthus.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17dfb122-4ae3-477f-93a8-1748b819c59c@coelacanthus.name> X-Stat-Signature: 4ngqptm9xib66skqkbrcin1frhdc1314 X-Rspamd-Queue-Id: 9C14A40006 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736934994-779350 X-HE-Meta: U2FsdGVkX18iH2r6UQqapnakGMQZV5now+2d0eCj/rqNGWwl1vv2cwIEm8Zqj/0zuh8fuLkXDozNC12+NUZWY9Q2zjoAN6Uoz18XpA8l/OH01AhYhRpYzGJxfMiZ+W6LaPhe0b+qJzW2Ohv6cTEQy7NO0CsAftjW/xQ1zBTguZdrODvTA+ogrp/+uhah/Cu9TwPA69Xm07aESh7xIFyp9EiUq1tzpoSr/eOj/7JrB5rP+RIeq2HZPgRwjzKrAd1oF/f3BvNtzHfWtWMlJsKhdO/oLsIumEWY5L+/upfcG1EWkcgJnoY3pcPEK62S6XGA2ihO1l9x+Sj6Dpyq6PW59adFPEjZGhdu7T1U/Q2Qsx8wud+yx4g38p77CrrY8KC/ZWlDqerMgI8MTnJTarShBodaOUj8u17vfcy4GwgrIbxNm5dbEv1hyiKE+76LDVoJUBRRz8sWys96zEW0y6+5dzByP0Wtj92SlDiCFkbvlBhaeEI77bSpvKGdRdO7toPyIhR0ldb8ip6YGOW02lpyE7qx2kZpe5z1/+TOtBOhFmialCKC/GSJm0E5MaUfS0Hw5/CmAnnCrf/g4kJhv4XlMn7DHynnVw3YsVzDx23BI/yNgz39g1q9BEcm04wg6fU6KKG2xXkrvDFUPYej/BWbbDgNew/oSqpT0CWIRnF47p8/jWSQwkNuZbaFNZbG6iZ/mUeOhsW8rQOmKpvepxINIV4D286/LcNXXqDQzcK4B8ytsuX+pFkuLvxVB/nFWaMn7j3Y4f67RJcT2qZiyly0bxpYaJNaNhkUfXkn9Gycgpj9Sbsx9eYr5uobI8OPA0i/Yns3JGb0afggDCoJbxo7ddS9GCexZ9H2pNkkSe2igmJksFEA4B3pXrUqzfNNc2tQMwIvLdeyb5Xb08Je+XKvqLk4NLcXwKmzOpjqkFACftrFByO2Hypt6iHUZRqJuQCqSVZ07Xn9VPDki4/quX6 EEjPL/CA xqtMO4mM58nJuqx+///++z69NmNW19FYxQAaIXM814n18QafN2isJfCkhjoGwVtpluI5HgqKMoCFt950Z7ndAb79li2S9OUSIX2h9HBkO0kRMXkQ0tSixrm44pw1902g4vGEHeE5WSQKxNvYZN/R1kRsG5E9NEtPvz+891e92crGnEd9hpTghNXXMJ5SM45a4RfzhcTcoGn+ha3yfIvt60dhW+q8AZpcOL7aKnAsrYOOo6KfAV62cmbSRiQrH/y6GJ6ifwsw+vkHEES5myGMEfVhhDjns3STwlTSLALnuyset6OxALeYmzJV/1D2v7rod3HQ677VSDcJaAKhU/qIKV9z171bxJz89uJd/OWINT06PERjot005mkMoEw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 15, 2025 at 05:41:57PM +0800, Celeste Liu wrote: > On 2025-01-15 17:14, Andrew Jones wrote: > > On Wed, Jan 15, 2025 at 04:24:59AM +0800, Celeste Liu wrote: ... > >> +#ifndef sizeof_field > >> +#define sizeof_field(TYPE, MEMBER) sizeof((((TYPE *)0)->MEMBER)) > >> +#endif > >> +#ifndef offsetofend > >> +#define offsetofend(TYPE, MEMBER) \ > >> + (offsetof(TYPE, MEMBER) + sizeof_field(TYPE, MEMBER)) > >> +#endif > > > > I think this is the sixth test to define these. We should copy > > include/linux/stddef.h into tools/include. We already have > > tools/include/uapi/linux/stddef.h with __struct_group and > > __DECLARE_FLEX_ARRAY, so I think it should just work. > > Agreed. But it may be better to be a separate patchset > so we can change those definition in different selftests > one pass. > I think a separate "copy stddef.h" patch could be in this series to avoid having to add the defines here. Then, another series can be sent with one patch for each conversion. That said, I'm OK with adding the defines for now and doing the conversion later. I just hope it will actually happen. Thanks, drew