From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B4A6C02180 for ; Wed, 15 Jan 2025 09:14:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E495F280002; Wed, 15 Jan 2025 04:14:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD302280001; Wed, 15 Jan 2025 04:14:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4C6C280002; Wed, 15 Jan 2025 04:14:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A41F9280001 for ; Wed, 15 Jan 2025 04:14:07 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4DC17A1131 for ; Wed, 15 Jan 2025 09:14:07 +0000 (UTC) X-FDA: 83009124534.23.19A095B Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf12.hostedemail.com (Postfix) with ESMTP id 3B3534000C for ; Wed, 15 Jan 2025 09:14:04 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=gM0VNfcp; spf=pass (imf12.hostedemail.com: domain of ajones@ventanamicro.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=ajones@ventanamicro.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736932445; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UkB3uXY/AOyeg5DHcTZ6HX3qGswDR1dziSNDHE7y11I=; b=GX8aPtJk0vMtGFcO3Oih0hLGaQK401lJT6gym8gBRjMbLVfl0VzZRfXGrjTSoqKLgPQXeu MGng6Z3vXyLK2hUCRce2wg6P9LUqY0im3FtQeoi40uXvK2mmTO6Pp1nNqbcv8Uch7MC25p u6yECBYAFqhX5oa11v7ZEr6Uwrwzemc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736932445; a=rsa-sha256; cv=none; b=A3gVZapSJfMZ/v4YmgbDrKjmseP65CVI3ghGE8GJAC9zxmMThxevMrs93FODnrrIVqRq4d OImQjQRisYYR7gY63sFFopzJw4YpUZqdOEbAPXEANHSfaxc7+wcUJ2Vw3iNRp85MNojIRg 1NARcJAvjVTIuoDfX4r3qKEgxXX/QY0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=gM0VNfcp; spf=pass (imf12.hostedemail.com: domain of ajones@ventanamicro.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=ajones@ventanamicro.com; dmarc=none Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-38789e5b6a7so3474773f8f.1 for ; Wed, 15 Jan 2025 01:14:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1736932443; x=1737537243; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=UkB3uXY/AOyeg5DHcTZ6HX3qGswDR1dziSNDHE7y11I=; b=gM0VNfcprqjp3KPxyVIt1BJ9mn5AQz1BqRXquDZ8eoMXFzFMsMHsEPD+e/zWjhHmkz +G81Fr3RgZg+aFN7Ov6A4NFjg7WC8OXwjkQ/dmmDsKKoWJO+Izh2wrObJuLJdppHik6H LczluZbUlz8oty3SaA1jnb7QAcRAJNYcYH4W7HtdKcio2cqNVgJr+9+JBT3Wsod+JE+/ buJ++KLVwieJCZl4uIbNOW3ctqk91DvBAatH+6vo9PfpyNBr6iqYTky4gRMjw94o+QM8 nL9HqIU018DHXJ2eQaeoQroi7CXPK0t9Mb6YCTFXE/TOAVyOYCKR3oxAl03nl3Acc5k1 E9Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736932443; x=1737537243; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UkB3uXY/AOyeg5DHcTZ6HX3qGswDR1dziSNDHE7y11I=; b=AmOyYIdbSg70Oy4XBVJ8KS+yScjmJRZ3RlCmCI2T5KRX4/WQ6RFVQjjosFOuBjmkU9 ja8cjz99VRNaPIR0Et+JCNrIFuYoD5ax35gLsj0/oY1wxbyDvfzG3u26ocIufck1ogqk 0LYsl38lbsdtIMbyZh0dG89RfpjN+cU0gebpWTDLj/MlAcR76UXBHCNir2waRt6ftAHy IHq2ikW9SBiijvyc3zk7Ykj7r6Pd+BltpPccfCU5SO+IW0d+EbbgYnautJqBqqQEfXda y83Bp3HW/A06cUZvzFnQVaA4b3WEgh4NE0tEy52MjSeauEiXdez9fk59kH9Wz7mA2/N3 0vFg== X-Forwarded-Encrypted: i=1; AJvYcCWnr5ktT1i3snXeRJDUPwh/IfA/JOWmf4Gjt3JHEg5cO546N/Qx+D4OQjcaZPxdQ0iXmNJVW/QndA==@kvack.org X-Gm-Message-State: AOJu0YzK77JTZ8PGI3VBueyZEqEzPkuExhZG0M3Qs8mezvR4hLPxno4g C05XvncnpibBKJdOdG20XTMRh6XD0j0CdIORSWgAmXfrVAF0lYQocqebhOMJmaY= X-Gm-Gg: ASbGncv1SbAHn4RGxHP9q7sj85AZVhgt/ZjhIWgxYdata7tmCJL11T+hkaltPr6q0ia X8vXCL2pRHAUMQygNT6F0G0stA8Nz2GnH94/k6kHURguzDslE+LiAd745an0Zj/vOfyMxqbZbNj 2ColcjqNKT9DuUb7ugxbqO/GGowo4wOrsoalIORPGq5Zwn6VdnedTbqpJdyeEz8gJbMwWmT0ym9 XqhlBHTmLecI1gmMF4scS94DRBO+ub+BnI0MbUfFTkAh90DMkah5eyHU/MtLW0VnimZEH42t+13 iwGMWigd/KzJMIvBNMNj+29lumQKekAprSkJxi9J5g== X-Google-Smtp-Source: AGHT+IGmhitdB2mwPEw/mSZXPL9iFDHsGoUy45feW5F9AYgsqTCf/RMUBQMFPFd1JqfQEgOZ/guGog== X-Received: by 2002:a5d:64e2:0:b0:38b:e32a:10ab with SMTP id ffacd0b85a97d-38be32a13a4mr4176173f8f.9.1736932443464; Wed, 15 Jan 2025 01:14:03 -0800 (PST) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c74e3b97sm15973265e9.32.2025.01.15.01.14.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 01:14:03 -0800 (PST) Date: Wed, 15 Jan 2025 10:14:02 +0100 From: Andrew Jones To: Celeste Liu Cc: Oleg Nesterov , Paul Walmsley , Palmer Dabbelt , Eric Biederman , Kees Cook , Shuah Khan , Albert Ou , Alexandre Ghiti , "Dmitry V. Levin" , Andrea Bolognani , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Thomas Gleixner , Ron Economos , Charlie Jenkins , Quan Zhou , Felix Yan , Ruizhe Pan , Guo Ren , Yao Zi , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= Subject: Re: [PATCH v5 2/2] riscv: selftests: Add a ptrace test to verify a0 and orig_a0 access Message-ID: <20250115-28c95808502d43f84b3fe0a6@orel> References: <20250115-riscv-new-regset-v5-0-d0e6ec031a23@coelacanthus.name> <20250115-riscv-new-regset-v5-2-d0e6ec031a23@coelacanthus.name> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250115-riscv-new-regset-v5-2-d0e6ec031a23@coelacanthus.name> X-Rspamd-Queue-Id: 3B3534000C X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 61fyaq61igcqzu1fmeyqcftb5fptmgeo X-HE-Tag: 1736932444-389294 X-HE-Meta: U2FsdGVkX1/5vsZ2FeWV0Z3+AjBSjaWhOQoMr3KzK1lSWS4eeVJZ9437wuXZ1NpnAOG/68UpJiXboAo2Paz6Mmh15vdz4PS1Q/ZrgHt7MqEssk/mGUOL9JQD9/lwYVYzd7PzvLLlgCgWpDOX0h6NjBt5gVlAUOvtlnqOucV30edcNAVrA9d5u8wv9JFna6EWxlHYJJmrs8isKgS0BTQZNKdb5jUBxT3QM92Xw+X56GxJG+hSDXHVg7238Xqury5gc1Ub8e0Tb4sSgJxOlToiJBe2JUMW5TKGmwhkbhE7s01OmEceOQ8h3wBDWv6w8UDEN/vg+BaLY4xO4QHljqMaEL2bUJXfq93QNPhZmgc8FtZUJBgeg4DRdkbMffLyiNOAa/RCuG383WDGeLMJgdwIKMzhceN6368mwp2lrmRhmxfkj6FRjt/97snjhjq2L4VYfmrPlPZLxTO0gaRzqdfVrb08bqGYj7OpomRweZBlnNdz0xWeyaOiIQd1N4nyv1uUVHGoNXCSbBu+Bpj63hKcyHXagm3lHhB41pXdsLmm+txwsUhc2DuNuh/h236/zT95YStcKvrEXXurz7yzZuxDQ5RtRoLHOJSmXh0qF2j3/aX28WsBlRs/aONjwWNS1dcxei9h/+LrrmmJJ4m5xzX7ANDwM+vMKyM/68UwaJLrrPyX1DlMWoAl1du1I+4SluKTDSwsUG23FftOwa4alDugNtc0FVL3oTrkKSe4ar4wOBkNPvHe9EBrLukEnljuUOeM7G/BpNxFFq2a5NeC3VPNoIt0AtBdYZSJ3AiIqWmbnCehofYAL+Cj/wNtw7FnKhwa+Ag+iMbzMsokDRLELCUzm/YgxR+YdXQzuCv6l+YFDyVeNEqJc3cxCsvZAee5kZJavXM0sUcbSQOMaCbrvIPIxmKQi+93PNk678DWOL6W4ZQxg8WUJG4jzYiPabBEYXhJG8A9IDlOJlifGDUU61a cbkbHllU n/jcb3z4MSKBdMGhcO9vie5FiW2WBHAuom2nPGHQfAVS21af/x6GxXRpXeg1ZPYsFbxbpSBHp259xru93qO++8OsBxeD9m4FmWhyaB7HNLcLFNhGtorVMQG0qIA1bLUju0RzuX31NTebYHaa7G8NiDGXPgfONGhtcDhXA2XB/+PLoatt0SSCz1xqc8XXBILBdqG8GWLCfmjM/J7FX0lsxYSth6GdlMcRYmY2EIOCo+wfmWQSLYYl5aW+7bl6EqLFIp7+AaBp+/8RQiDctWt9xAIjuPN/dzjQGvVu4e/NZi+TNvILQl1BiprMYjHT5TB8EcKORg3LE5t9CnFsDYatPp0MJCvKmdGMalz4Jh1ya756bUQ4qnUiFX8Q94F1N1tUTfGa6f4kicFhUwb+zY4Tr0Nmiqfx+zqFaYUpVYO9BaxteLozHXEUGxp4QG88bTH/IS9b5MSkqYWWKnOg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 15, 2025 at 04:24:59AM +0800, Celeste Liu wrote: > This test checks that orig_a0 and a0 can be modified and accessed > independently. > > Co-developed-by: Quan Zhou > Signed-off-by: Quan Zhou > Co-developed-by: Charlie Jenkins > Signed-off-by: Charlie Jenkins > Reviewed-by: Björn Töpel > Signed-off-by: Celeste Liu > --- > tools/testing/selftests/riscv/abi/.gitignore | 1 + > tools/testing/selftests/riscv/abi/Makefile | 6 +- > tools/testing/selftests/riscv/abi/ptrace.c | 201 +++++++++++++++++++++++++++ > 3 files changed, 207 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/riscv/abi/.gitignore b/tools/testing/selftests/riscv/abi/.gitignore > index b38358f91c4d2240ae64892871d9ca98bda1ae58..378c605919a3b3d58eec2701eb7af430cfe315d6 100644 > --- a/tools/testing/selftests/riscv/abi/.gitignore > +++ b/tools/testing/selftests/riscv/abi/.gitignore > @@ -1 +1,2 @@ > pointer_masking > +ptrace > diff --git a/tools/testing/selftests/riscv/abi/Makefile b/tools/testing/selftests/riscv/abi/Makefile > index ed82ff9c664e7eb3f760cbab81fb957ff72579c5..359a082c88a401883fb3776b35e4dacf69beaaaa 100644 > --- a/tools/testing/selftests/riscv/abi/Makefile > +++ b/tools/testing/selftests/riscv/abi/Makefile > @@ -1,10 +1,14 @@ > # SPDX-License-Identifier: GPL-2.0 > > CFLAGS += -I$(top_srcdir)/tools/include > +CFLAGS += $(KHDR_INCLUDES) > > -TEST_GEN_PROGS := pointer_masking > +TEST_GEN_PROGS := pointer_masking ptrace > > include ../../lib.mk > > $(OUTPUT)/pointer_masking: pointer_masking.c > $(CC) -static -o$@ $(CFLAGS) $(LDFLAGS) $^ > + > +$(OUTPUT)/ptrace: ptrace.c > + $(CC) -static -o$@ $(CFLAGS) $(LDFLAGS) $^ > diff --git a/tools/testing/selftests/riscv/abi/ptrace.c b/tools/testing/selftests/riscv/abi/ptrace.c > new file mode 100644 > index 0000000000000000000000000000000000000000..f1a0458adccdd040bfaa350e2e8d98b1ef34c0ad > --- /dev/null > +++ b/tools/testing/selftests/riscv/abi/ptrace.c > @@ -0,0 +1,201 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "../../kselftest_harness.h" > + > +#ifndef sizeof_field > +#define sizeof_field(TYPE, MEMBER) sizeof((((TYPE *)0)->MEMBER)) > +#endif > +#ifndef offsetofend > +#define offsetofend(TYPE, MEMBER) \ > + (offsetof(TYPE, MEMBER) + sizeof_field(TYPE, MEMBER)) > +#endif I think this is the sixth test to define these. We should copy include/linux/stddef.h into tools/include. We already have tools/include/uapi/linux/stddef.h with __struct_group and __DECLARE_FLEX_ARRAY, so I think it should just work. > + > + > +#define ORIG_A0_MODIFY 0x01 > +#define A0_MODIFY 0x02 > +#define A0_OLD 0xbadbeefbeeff > +#define A0_NEW 0xffeebfeebdab > + > + > +struct a0_regs { > + __s64 orig_a0; > + __u64 a0; > +}; > + > +#define perr_and_exit(fmt, ...) \ > + ({ \ > + char buf[256]; \ > + snprintf(buf, sizeof(buf), "%s:%d:" fmt ": %m\n", \ > + __func__, __LINE__, ##__VA_ARGS__); \ > + ksft_exit_fail_perror(buf); \ > + }) > + > +static void ptrace_test(int opt, struct a0_regs result[]) > +{ > + int status; > + long rc; > + pid_t pid; > + struct user_regs_struct regs; > + struct iovec iov = { > + .iov_base = ®s, > + .iov_len = sizeof(regs), > + }; > + > + unsigned long orig_a0; > + struct iovec a0_iov = { > + .iov_base = &orig_a0, > + .iov_len = sizeof(orig_a0), > + }; > + struct ptrace_syscall_info syscall_info = { > + .op = 0xff, > + }; > + const unsigned int expected_sci_entry_size = > + offsetofend(struct ptrace_syscall_info, entry.args); > + const unsigned int expected_sci_exit_size = > + offsetofend(struct ptrace_syscall_info, exit.is_error); > + > + pid = fork(); > + if (pid == 0) { > + /* Mark oneself being traced */ > + long val = ptrace(PTRACE_TRACEME, 0, 0, 0); > + > + if (val < 0) > + perr_and_exit("failed to request for tracer to trace me: %ld", val); > + > + kill(getpid(), SIGSTOP); > + > + /* Perform chdir syscall that will be intercepted */ > + syscall(__NR_chdir, A0_OLD); > + > + exit(0); > + } > + > + if (pid < 0) > + ksft_exit_fail_perror("failed to fork"); > + > + for (int i = 0; i < 3; i++) { > + if (waitpid(pid, &status, 0) != pid) > + perr_and_exit("failed to wait for the tracee %d", pid); > + if (WIFSTOPPED(status)) { > + switch (WSTOPSIG(status)) { > + case SIGSTOP: > + if (ptrace(PTRACE_SETOPTIONS, pid, 0, PTRACE_O_TRACESYSGOOD) < 0) > + perr_and_exit("failed to set PTRACE_O_TRACESYSGOOD"); > + break; > + case SIGTRAP|0x80: > + /* Modify twice so GET_SYSCALL_INFO get modified a0 and orig_a0 */ > + if (ptrace(PTRACE_GETREGSET, pid, NT_PRSTATUS, &iov)) > + perr_and_exit("failed to get tracee registers"); > + if (ptrace(PTRACE_GETREGSET, pid, NT_RISCV_ORIG_A0, &a0_iov)) > + perr_and_exit("failed to get tracee registers"); > + > + /* Modify a0/orig_a0 for the syscall */ > + switch (opt) { > + case A0_MODIFY: > + regs.a0 = A0_NEW; > + break; > + case ORIG_A0_MODIFY: > + orig_a0 = A0_NEW; > + break; > + } > + > + if (ptrace(PTRACE_SETREGSET, pid, NT_PRSTATUS, &iov)) > + perr_and_exit("failed to set tracee registers"); > + if (ptrace(PTRACE_SETREGSET, pid, NT_RISCV_ORIG_A0, &a0_iov)) > + perr_and_exit("failed to set tracee registers"); > + switch (i) { > + case 1: > + /* Stop at the beginning of syscall */ > + rc = ptrace(PTRACE_GET_SYSCALL_INFO, pid, > + sizeof(syscall_info), &syscall_info); > + if (rc < 0) > + perr_and_exit("failed to get syscall info of entry"); > + if (rc < expected_sci_entry_size > + || syscall_info.op != PTRACE_SYSCALL_INFO_ENTRY) > + perr_and_exit("stop position of entry mismatched"); > + result[0].orig_a0 = syscall_info.entry.args[0]; > + break; > + > + case 2: > + /* Stop at the end of syscall */ > + rc = ptrace(PTRACE_GET_SYSCALL_INFO, pid, > + sizeof(syscall_info), &syscall_info); > + if (rc < 0) > + perr_and_exit("failed to get syscall info of entry"); > + if (rc < expected_sci_exit_size > + || syscall_info.op != PTRACE_SYSCALL_INFO_EXIT) > + perr_and_exit("stop position of exit mismatched"); > + result[0].a0 = syscall_info.exit.rval; > + > + if (ptrace(PTRACE_GETREGSET, pid, NT_PRSTATUS, &iov)) > + perr_and_exit("failed to get tracee registers"); > + result[1].a0 = regs.a0; > + if (ptrace(PTRACE_GETREGSET, pid, NT_RISCV_ORIG_A0, > + &a0_iov)) > + perr_and_exit("failed to get tracee registers"); > + result[1].orig_a0 = orig_a0; > + } > + } > + if (ptrace(PTRACE_SYSCALL, pid, 0, 0) < 0) > + perr_and_exit("failed to resume tracee"); > + } > + } > + > + /* Resume the tracee */ > + ptrace(PTRACE_CONT, pid, 0, 0); > + if (waitpid(pid, &status, 0) != pid) > + perr_and_exit("failed to wait for the tracee"); > + > +} > + > +TEST(ptrace_access_a0) > +{ > + struct a0_regs result[2]; > + > + ptrace_test(A0_MODIFY, result); > + > + /* Verify PTRACE_SETREGSET */ > + /* The modification of a0 cannot affect the first argument of the syscall */ > + EXPECT_EQ(A0_OLD, result[0].orig_a0); > + EXPECT_EQ(A0_NEW, result[0].a0); > + > + /* Verify PTRACE_GETREGSET */ > + EXPECT_EQ(result[1].orig_a0, result[0].orig_a0); > + EXPECT_EQ(result[1].a0, result[0].a0); > +} > + > +TEST(ptrace_access_orig_a0) > +{ > + struct a0_regs result[2]; > + > + ptrace_test(ORIG_A0_MODIFY, result); > + > + /* Verify PTRACE_SETREGSET */ > + /* Only modify orig_a0 to change the first argument of the syscall */ > + EXPECT_EQ(A0_NEW, result[0].orig_a0); > + /* a0 will keep default value, orig_a0 or -ENOSYS, depends on internal. */ > + EXPECT_NE(A0_NEW, result[0].a0); I don't understand this test. Why don't we know what to expect? Also, the comment says orig_a0 is an option for the value, but then we don't expect it to be A0_NEW, even though we expect orig_a0 to be A0_NEW? > + > + /* Verify PTRACE_GETREGSET */ > + EXPECT_EQ(result[1].orig_a0, result[0].orig_a0); > + EXPECT_EQ(result[1].a0, result[0].a0); > +} > + > +TEST_HARNESS_MAIN > > -- > 2.48.0 > Other than the two comments/questions, this test looks great. Thanks, drew