From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E09DE77188 for ; Tue, 14 Jan 2025 19:55:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 957A06B009D; Tue, 14 Jan 2025 14:55:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9084F6B009E; Tue, 14 Jan 2025 14:55:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CF4B6B009F; Tue, 14 Jan 2025 14:55:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5F1386B009D for ; Tue, 14 Jan 2025 14:55:08 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 12719A0CA5 for ; Tue, 14 Jan 2025 19:55:08 +0000 (UTC) X-FDA: 83007111096.21.4D0375A Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf28.hostedemail.com (Postfix) with ESMTP id 8A13AC000F for ; Tue, 14 Jan 2025 19:55:06 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hjVfSd0n; spf=pass (imf28.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736884506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7W2aT8BWX6giXAseTlOgsmtHbwTMVQivNU1UwcFaxh0=; b=7ys2J+hMHFZPCms4vzR4U4m9tuqhLmtvnP1hQoCZ2qqlQgmQCCTUHxyuLCcYPfUWfah+Fl sQL7016j6np8eRjSFWneOOtsVkw0eTXQdwhTsa4NEaMGvnY+xwOO70IXOjPLwI1VYsKghO hjuWbHifL2TRW2c/Ltk6assawM8pi6g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736884506; a=rsa-sha256; cv=none; b=LgGHXIx5mUp6M1PHhtCKC5XZhwC70A34vOQ3yzHWXFelMFSJo60oC9DEHDdrs37Ezqz9TK PJ0mPQ51BLcP1IkL0Olb3PWDjj1QASkou0P+RusXtMr0XTqZ4OqhlC3jRGG/wNhuvibHbK mwIUjbz4i15GH0zf92yHzZYe0A+n5lA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hjVfSd0n; spf=pass (imf28.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 5C273A41B97; Tue, 14 Jan 2025 19:53:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D603C4CEE3; Tue, 14 Jan 2025 19:55:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736884504; bh=huRU/7680fWPaVRisg9yYeZG8JokqKmmOuhfyjkWRYg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hjVfSd0nh87uS3INYVUBWuySQV9DZ7yD6vtx15eel3Q9ksPUymny3SEeay+7/w/aB rU3vfdCRStv3XdnboLXoSNOdGe/DHY5tAOPGliObkY9h9iDKOP8ZRXs27kqWPnnSWr 4gnb9xBSPcO6f9FHBV7rM5oVdETpj5f4QmvA6TTtyXbd4RcigbU1K3ch2ladX6k/UZ K52TH1M/7wMCZfgFZ48UUOC0J4bRxnCBsdB8RBSKrhtRpBcC7iC3z6v7AW+fXpk3R3 mlRIoax/iZyhVgqPfGMMljdEmzfC1T5+BMC0N8txvzagBWfiZjC9k0AwAw4JUJFjuE ll4TPzxAaigEQ== From: SeongJae Park To: Lorenzo Stoakes Cc: SeongJae Park , Shakeel Butt , David Hildenbrand , Liam.Howlett@oracle.com, Vlastimil Babka , Andrew Morton , Jens Axboe , Pavel Begunkov , damon@lists.linux.dev, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH] mm/madvise: remove redundant mmap_lock operations from process_madvise() Date: Tue, 14 Jan 2025 11:54:58 -0800 Message-Id: <20250114195458.53517-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 8A13AC000F X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: rupoidgw7doywsr36nruqckf6zpsmuwr X-HE-Tag: 1736884506-192483 X-HE-Meta: U2FsdGVkX18W7Uwm7l7V/gLShETY10Wua1xpDP4gpIrEImnkeVpK8u3KwkDyVNQQZvikHQXN3Ah5DA3BV57FutE4b/cC2m/B1sasFnwTwKPbe2sMaOXmMhAfyczbAlUez0RJKnvNCqHhmVp8EtUaL0HHFAa1Wx/JIi6K5Lzd8m2m7QbJrpFwjeQTymGM4Wxo2UqF++8b89kAtkLh4E92vVQw0HWmjwN4674Eft9XxRkg6V7h+NIFFSm0tj0MbPI27ZD8jNefWLPqkBQTEQTX5hh/RAkVYAEtV5IbktFAmpFFW0ZnTZVeuSje7HsH3yLVAvAeVqfp9rMvEXd84T5srmqWXWrW6CTis4t0luahHXyUKqQrhiBbJfXybsOyGbQg2f2o7TaJCPpna1+pIdTkDg0Z9uavrndnnGRWWVsY/xvJnnhCZkjDRalcQqp17NFJRjNJ3Y0B1RIE1ZXwsZoiQJEt9ng49VOiRRH7Kt72GM0hcu1IurlGrA2dBo7s3qe+uEcHUbL6O9Wh+OCcAGUGxvNN2t5NbRjSNHUi0Pl/faNhH3hWe6j5TZYbljAL92aEHxjl3OD2Dk+wdRMSoeupfDGVAWXZZ606uVIlKv8auVivM14MK1BQ+wiZt1R25T+UJCdWJ07oxBzCXSBiNMk+Gt1bQpa1i5tBRMUPJw1zo74LZehSaXmxaaadJV/Tgw2zRpbzNqIzL4huHrEeQ77u9JXZ42rkAX+rpp+L31vhA8eh+XrVQHscWBxl5f0gS5nxk0opgAo5ip7E7gNJ/PLJ7KeGWK3hgbgioNIaMbE6XLSk1lD7wkNpwBItvUDFdo1DTrWsxPgqvEPUpn9sCv6PUelcyDSznW9r6zJwAyhniqRRd8fqJ+LtR8JwDB76G67QlgP67J4TryXJbeqnNv3X2eCzaPFU72EA8UaPlghwP8t3R8pPslnYpcR/8CJaV9i1RvmnnrNDeCRXF0XfYBV cL7H+uyi Se0p8Dlqu4KP4+PpgL3PVk08n0+vyIHUVesRg2AjQ5KpEWE502DnflhWjLDLFj0QLKgjKqt7CwqR2+wA3WT5S6FRqvTUGKeDYL1EgRpFV/9CIw8OZR4eSHoqUeuS2nIJ9Irw6Od3ld7rkPuivta8Lo3DI5gMFKkOKxzMKf/AXNJJM9PP26f/wZTfVA9t9iYTvPJjFdSNGV2WepAc680sM6VRdMcIMHOtcQ1Het8wpujdJleM2aTqUFtQfNQgjUOM8aVcLka6wqQPMSYRj31gTmZ0gw6SPg5SJr661pSDjESJaHJZEkEfPVGrR1xdpZ3cD98w5tYNpNaJnGloJJeFZYckvhItJJRi+P3OSokdBz+P/1yDk0M8yXAWIIA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 14 Jan 2025 18:47:15 +0000 Lorenzo Stoakes wrote: > On Tue, Jan 14, 2025 at 10:13:40AM -0800, Shakeel Butt wrote: > > Ccing relevant folks. > > Thanks Shakeel! Thank you Shakeel, too! > > A side-note, I really wish there was a better way to get cc'd, since I > fundamentally changed process_madvise() recently and was the main person > changing this code lately, but on the other hand - > scripts/get_maintainers.pl gets really really noisy if you try to use this > kind of stat - so I in no way blame SJ for missing me. Yes, I always feeling finding not too many, not too less, but only appropriate recipients for patches is not easy. Just FYI, I use get_maintainers.pl with --nogit option[1] and add more recipients based on additional logics[2] that based on my past experiences and discussions, by default. And then I run get_maintainers.pl without --nogit option if I get no response more than I expected. I will keep Shakeel-aded recipients for next spins of this patch, anyway. > > Thankfully Shakeel kindly stepped in to make me aware :) > > SJ - I will come back to you later, as it's late here and my brain is fried > - but I was already thinking of doing something _like_ this, as I noticed > for the purposes of self-process_madvise() operations (which I unrestricted > for guard page purposes) - we are hammering locks in a way that we know we > don't necessarily need to do. > > So this is serendipitous for me! :) But I need to dig into your actual > implementation to give feedback here. > > Will come back to this in due course :) No worry, no rush. Please take your time :) [1] https://github.com/sjp38/hackermail/blob/master/src/hkml_patch_format.py#L45 [2] https://github.com/sjp38/hackermail/blob/master/src/hkml_patch_format.py#L31 Thanks, SJ [...]