From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACF1EE77188 for ; Wed, 15 Jan 2025 01:10:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E64DD6B007B; Tue, 14 Jan 2025 20:10:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E15326B0082; Tue, 14 Jan 2025 20:10:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDBD76B0083; Tue, 14 Jan 2025 20:10:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AF3936B007B for ; Tue, 14 Jan 2025 20:10:50 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3376145017 for ; Wed, 15 Jan 2025 01:10:50 +0000 (UTC) X-FDA: 83007906660.28.4698BB2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 52EDAA0005 for ; Wed, 15 Jan 2025 01:10:48 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=eWEkpt4+; dmarc=none; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736903448; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fTBF6LOLAs1iWZZYcSxaZj1jggRfl4m3PTwrHdY8Wrw=; b=CRN5Y6r9Y2BwydPAxBxlQvekKVykWLfIl3VkxUgjVEAGZClDd1cJklUhz8u4865DqgjEhT /qB/9UYnpxivpBf/k8nLRdAd5+OjRRiXv4G/ioBpmhS/D4mKbJTb3GpNjoTndEoDE7JXli avVv6WoxgOf46OpYmmKOT2UMwiFZBaU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736903448; a=rsa-sha256; cv=none; b=aJeatMMHCqFk2mrVmXpkLznY+asHPmpyvv7qYsZjy7j+zrUuGOILu1AselzB1mIEmwPtHk sIU+0HmM2KDZRX6Du7QjUxq3Cy5MoaQcFNxbDxAfHNJt6mXcvSAE5o+OkISSHEynWucDTh wnBmovnclKGkzh12pAFgMVCDEYbgJ3U= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=eWEkpt4+; dmarc=none; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 36F055C5933; Wed, 15 Jan 2025 01:10:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FC50C4CEDD; Wed, 15 Jan 2025 01:10:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1736903446; bh=CVZEHx6Eh830JyI4aKceXPSCIH8O/uVKjeo6hr322K0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eWEkpt4+9LYfkwGuv6PXIk3wA7xv/c06xCt6oTLN4TNojw1EUKQ/IqoJCmdL0h531 MZkEtJUcydBHl7qmoNHiDEv3TywWqm4MU9gIXG/rdE9jNpnzZhOZjKbZaCsvzgEzFx X1r+iSoPq0OMilQ3Nmdw+5XAbauGxKMAZP4SbrO0= Date: Tue, 14 Jan 2025 17:10:45 -0800 From: Andrew Morton To: Suren Baghdasaryan Cc: kent.overstreet@linux.dev, yuzhao@google.com, 00107082@163.com, quic_zhenhuah@quicinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 2/2] alloc_tag: skip pgalloc_tag_swap if profiling is disabled Message-Id: <20250114171045.e5fadb8db51902ee0181fa0b@linux-foundation.org> In-Reply-To: References: <20241226211639.1357704-1-surenb@google.com> <20241226211639.1357704-2-surenb@google.com> <20241226150127.73d1b2a08cf31dac1a900c1e@linux-foundation.org> <20241226162315.cbf088cb28fe897bfe1b075b@linux-foundation.org> <20241226235900.5a4e3ab79840e08482380976@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: zrp71z1ue783joba1w7cu7ise18ex8wq X-Rspamd-Queue-Id: 52EDAA0005 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736903448-575353 X-HE-Meta: U2FsdGVkX1//JQzoj76aWuWmc48dKAE2Jz9p7SXR7FaBnK0T+0O1PTBGAbbo1oGe6hrKgbsRzLLCj4EBSCe/lJ/EKIh8nnTFz0VJDWogqFmdJvGayvLEHJir4F39ftu9a8K8pf5ZiKxNQlP6FALs8Y3hwg6PYT4kBm8uQi70+OgstCZ/QvmJNCBaQ7RRP9RbaLelsE3juVVWqgplVv5rikGKNhpNMN1CQjNBscduKdpuHfQ6gltGtmHlx3mICeNWBXgOO47KbyyJdcYFm1xchJEAtqCOGfWZ7etkx7x3q1+opNJvjB1638/ZFOJuWO+4HN9qWqCpLSETe5DZClC4P0KPbSZLf71AW/Xn0pQIjhLytGvssFDGGGGc3/3X5WgpOkj/RakVR+TEo8mOvBdT7pvhAjtlndWqod/SNmLulXPiQxb/sjLo8/GONP4qqkrVfE0oV+AdDNxXpa0HNjqR8WP72VK+ewhFUkr03PPNwLGjYsLfPnBDsK2Al6Pb1jGZIPYVLZh909qoxMQWMSB2KVzdm8NDusN6FM627n0tYOtN7GzXynHmsJWrExOeLAoo01qJVsFr0qtiOJneDzFNd8BbIgckwSUeWbHn1i0JI/X4AG5+BX5RYxtT0XzBVCgtMpE8lQyzN4pDchjn93lHyL3RU/Kwtw/yp+v2LyyyZKTXECpy1eMuj1DsXYUakgs1g36TTa5mZ4FsPQyRsXYRAocQNynHX9uutkkod9wl/mup0d3D6zeRUnb8Cc6gRyUTFduvSc2bnPgbvQUXWYLIJ40bym6/Xv0TlQtqvmVSZCa488Rwd1Lmp+iVYtUfMiOFEw4S6mlXV8BVxKXqFw+lcrjY7JpySjTFDqLQcgkysEe3hiJS8MeFezxEJOjpbu0PNYLRPgoPE+rNg8SpNDUd5BGp5vxLPso3dDZyoVPUhdV9YDlTT6wuzT/3CBHx3sPai3WRGIHTekDvS6YMoS4 UMC95gYe fiwqCiQA9ELh+xwb75b5bHRdl4tCbv7OnSOnCTsk4C7IuhcG6s4+sxXTDDuRh1ganLvfpqclJwC9XY4PwESSQYoEHrLzmPvws00CbcCsvCqYwWiSd1My2rPnWZP2IasyTPa3Wz5kPFdiTScWKUV8Mqh4WAd29/4+Lp2rX620gLu9KSYK/hCvWP/WlmUelSggN9PlzwXqZmgOr35lKVAR2VjG/UL4xl21uMWn30Gn0qo0nf57TqbAdl/9wNe656RbwgUbzrDafEBle+iqlBIIvNPFna9nTfWW9i2QjTOdYLSaMQbVnJr30CbdLk7wUhrvSajvs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 14 Jan 2025 08:38:37 -0800 Suren Baghdasaryan wrote: > > > Well, a 50% reduction in a 0.0000000001% overhead ain't much. > > > > I wish the overhead was that low :) > > > > I ran more comprehensive testing on Pixel 6 on Big, Medium and Little cores: > > > > Overhead before fixes Overhead after fixes > > slab alloc page alloc slab alloc page alloc > > Big 6.21% 5.32% 3.31% 4.93% > > Medium 4.51% 5.05% 3.79% 4.39% > > Little 7.62% 1.82% 6.68% 1.02% > > Hi Andrew, > I just noticed that you added the above results to the description of > this patch in mm-unstable: 366507569511 ("alloc_tag: skip > pgalloc_tag_swap if profiling is disabled") but this improvement is > mostly caused the the other patch in this series: 80aded2b9492 > ("alloc_tag: avoid current->alloc_tag manipulations when profiling is > disabled"). If this is not too much trouble, could you please move it > into the description of the latter patch? No probs, done, thanks.