* [PATCH] kasan: hw_tags: Use str_on_off() helper in kasan_init_hw_tags()
@ 2025-01-14 15:09 Thorsten Blum
2025-01-15 1:45 ` Andrey Konovalov
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2025-01-14 15:09 UTC (permalink / raw)
To: Andrey Ryabinin, Alexander Potapenko, Andrey Konovalov,
Dmitry Vyukov, Vincenzo Frascino, Andrew Morton
Cc: Thorsten Blum, Anshuman Khandual, kasan-dev, linux-mm, linux-kernel
Remove hard-coded strings by using the str_on_off() helper function.
Suggested-by: Anshuman Khandual <anshuman.khandual@arm.com>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
mm/kasan/hw_tags.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c
index ccd66c7a4081..9a6927394b54 100644
--- a/mm/kasan/hw_tags.c
+++ b/mm/kasan/hw_tags.c
@@ -16,6 +16,7 @@
#include <linux/mm.h>
#include <linux/static_key.h>
#include <linux/string.h>
+#include <linux/string_choices.h>
#include <linux/types.h>
#include <linux/vmalloc.h>
@@ -263,8 +264,8 @@ void __init kasan_init_hw_tags(void)
pr_info("KernelAddressSanitizer initialized (hw-tags, mode=%s, vmalloc=%s, stacktrace=%s)\n",
kasan_mode_info(),
- kasan_vmalloc_enabled() ? "on" : "off",
- kasan_stack_collection_enabled() ? "on" : "off");
+ str_on_off(kasan_vmalloc_enabled()),
+ str_on_off(kasan_stack_collection_enabled()));
}
#ifdef CONFIG_KASAN_VMALLOC
--
2.47.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] kasan: hw_tags: Use str_on_off() helper in kasan_init_hw_tags()
2025-01-14 15:09 [PATCH] kasan: hw_tags: Use str_on_off() helper in kasan_init_hw_tags() Thorsten Blum
@ 2025-01-15 1:45 ` Andrey Konovalov
0 siblings, 0 replies; 2+ messages in thread
From: Andrey Konovalov @ 2025-01-15 1:45 UTC (permalink / raw)
To: Thorsten Blum
Cc: Andrey Ryabinin, Alexander Potapenko, Dmitry Vyukov,
Vincenzo Frascino, Andrew Morton, Anshuman Khandual, kasan-dev,
linux-mm, linux-kernel
On Tue, Jan 14, 2025 at 4:10 PM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Remove hard-coded strings by using the str_on_off() helper function.
>
> Suggested-by: Anshuman Khandual <anshuman.khandual@arm.com>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> mm/kasan/hw_tags.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c
> index ccd66c7a4081..9a6927394b54 100644
> --- a/mm/kasan/hw_tags.c
> +++ b/mm/kasan/hw_tags.c
> @@ -16,6 +16,7 @@
> #include <linux/mm.h>
> #include <linux/static_key.h>
> #include <linux/string.h>
> +#include <linux/string_choices.h>
> #include <linux/types.h>
> #include <linux/vmalloc.h>
>
> @@ -263,8 +264,8 @@ void __init kasan_init_hw_tags(void)
>
> pr_info("KernelAddressSanitizer initialized (hw-tags, mode=%s, vmalloc=%s, stacktrace=%s)\n",
> kasan_mode_info(),
> - kasan_vmalloc_enabled() ? "on" : "off",
> - kasan_stack_collection_enabled() ? "on" : "off");
> + str_on_off(kasan_vmalloc_enabled()),
> + str_on_off(kasan_stack_collection_enabled()));
> }
>
> #ifdef CONFIG_KASAN_VMALLOC
> --
> 2.47.1
>
Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-15 1:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-14 15:09 [PATCH] kasan: hw_tags: Use str_on_off() helper in kasan_init_hw_tags() Thorsten Blum
2025-01-15 1:45 ` Andrey Konovalov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox