From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C8F8E77188 for ; Tue, 14 Jan 2025 14:06:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78BB36B007B; Tue, 14 Jan 2025 09:06:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 762C16B0083; Tue, 14 Jan 2025 09:06:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62A1F6B0085; Tue, 14 Jan 2025 09:06:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3FA526B007B for ; Tue, 14 Jan 2025 09:06:42 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E52E9C0A52 for ; Tue, 14 Jan 2025 14:06:41 +0000 (UTC) X-FDA: 83006233002.24.CFFCFBB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 24D07180015 for ; Tue, 14 Jan 2025 14:06:39 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UeNvKW0l; spf=pass (imf06.hostedemail.com: domain of mchehab+huawei@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mchehab+huawei@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736863600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/6RH1CIm3mbLCZt8PqL2UNbfokxwLR6u+sMER7W1VXg=; b=hT/PKAMEzK3fX7Ge0bXjK4/xMn79NnbifUKzRtRD2vU+9a5hITD+ai8XlWLQ89UrviqmRQ hKLJb6/CR6I9NDOUxOO0xeWMvlh9CqKGi8NUu1MRHnPEqTQ95fLrA55qkU7q+2rM3EhCP1 SmcUFPOoayaiiI0CBKNEBYT8BJnxiBo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736863600; a=rsa-sha256; cv=none; b=6GSz4nuH1o3PP7TsmjXxuvEeUflGwaDEwNYiq2JLLz+L7s4ZppsurUSjxOT/UQbB2LHCzF tPGV9kb9iIbnT+dYVl6/xgqmRnYCVEA+ucv68zrQS1c+0yjoCqixnksfvUo6O8IN008z+7 qKdyPij4BxSH6WYMYFjibA9H6LXoShA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UeNvKW0l; spf=pass (imf06.hostedemail.com: domain of mchehab+huawei@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mchehab+huawei@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 72D075C010C; Tue, 14 Jan 2025 14:05:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87C91C4CEDD; Tue, 14 Jan 2025 14:06:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736863599; bh=22mONV1hQ6FNPcsvXydlp444mm0Si+QkC50VtPd7T60=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UeNvKW0lMWyBwHMfjsDG7+/QmujYta/tfHMQvu4RHTe4e9NT6AaQuDCPiqol8viyU aHzvgLxqfl0IivFQGxYl51T27skt9Z6mRiEF2qsWAb/da+kZYCPqsNNeqpZ9vHakag YEgKXLKghivGc9eL9zG9gz+tW5aZnt5C+DTuW39ZjpNog/O3hNb8E5dyyF5V13nts7 4FiuWCdGD4hDYo3Yk0TlkYdRM414HlFH3F1voILDWNgs1yQ8dNeidKTvPYo5++D0v/ 62mdVOFGYAOtLmyETG6JSdYX37WjdVgKbkGPp7uVlss44zfLHQ4iceh+kpgo5USoFK 2O0bUqc7W2vXQ== Date: Tue, 14 Jan 2025 15:06:27 +0100 From: Mauro Carvalho Chehab To: Jonathan Cameron Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v18 00/19] EDAC: Scrub: introduce generic EDAC RAS control feature driver + CXL/ACPI-RAS2 drivers Message-ID: <20250114150546.0a769a8f@foz.lan> In-Reply-To: <20250113153639.00003dfa@huawei.com> References: <20250106121017.1620-1-shiju.jose@huawei.com> <20250113154634.4e831d66@foz.lan> <20250113153639.00003dfa@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 24D07180015 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: smys9sug7ku9mwon11f41k6c34uifdd4 X-HE-Tag: 1736863599-893798 X-HE-Meta: U2FsdGVkX1/+mV9xr3pdDaYl6MKd/7NZ6ThNyvCcmeGezmIjnec7VdLccNZmn2HG/LVKtpsEmTwQrJLVse3E8cKtGX+fFxXYhj9x4QIP10fL+YkU5DuCq62u1KqXXEjhcyDtoSIrQJuzhA3qWP2QHjbdiV5YbUQu2hELIZocI04x9NnT6UDLtn50h2ODVvAbCiOAJX5oekhK0xUgwXl5xHEco84+Uqop8ALIhq0whRvqjERpY18uEKIYxIu//R7KDiJ3hGTkQcDRhBOqyfgMHHRuG80j4dLFxUnS12L5p/P/UmaI3GZNhy3Mq/zH3TUZlJrgZXeSMQfipF1j87pxeOSJt4xLjurm2IccsCjRaPXsLEjO7ijsLHbkWvSMF9iAVEAIMHOapaAqkdgORVSwAKwxp3xEsYflKrOi37K7HIcgYhOq1kQ65gXFtT1oUNmJ21b1fg9wCFRyX5sQdm+mkYTQ6/Jtyj5RoflwihjNCQ25fFp6qAAQNoewQqUW86FjvzDRHq+YvsekivYVf6+q4aYQ0JkpZxe32hrhblVfLZ2Fz9V1tPwgZIKPV2PgkzqCLStajmzkRGEKGm06O3aPdoyGManZvOqWy5KQUKVvq0C+CuiyVihmrJt8zoCGNoJdxos73/G8RscuQ0q30dtTJ3dp6N70g0QKG1bOVxHi+DjwE3up249A4gN3IrCC81lxW28oG93sy1fMT79cxR/5YhNvNOA1r8vEZ4/aRkM3LxbrZfccVivcs3zcxReWQ4MZEv9TgeQeys4TdxkHGuRO0Pm0tqohzoyH0pi2nGPs2fZFFCGtTMchaNenVEIlz6h55LPgy+eezM7s9yoDtU7q6mDFIWDN0tKeG3RDA4Ps2DNsxvVLNDeCMAK63dPlCpaj84hqNfTuhNsnCVPBrnjBnll8Uc7GZp9hdEtVgTDPJnsNbW7TSGUO9rVFl7Fc8XjEZDgMnhdhsqv163GaDJZ fJ5N4cUe y2K2dq5K2Xxn24q5c79JO7SNkM2lNkjzS/v74BxfQMB79vnOy4bVSgDnMKv/GQldkzlaxQWvHhQEKLcyGgvwQ6P5YX4hbCgVimGjybdAps+z1pP4YFZTdg26I/w+RHljDIe54SfMexrhRSFO4+pipaSqgzB7NWP+4ULDD63mFgCad973zShDXS/nvoXjX4FUfLCT3fZHAHGKiqQjoEhVKN+826lGbjALNAXEmI67wFKTRYYeyKh6k/zEjSvwqjPEuJ5S0FNphgMEHBjfTVPMK0ULJ1nRHNXUHzx2skmZuziFKB5OCXRDQvte9XvGE527tF5bsdFlGiE8iX6YUCJwqqidVuodwWyAf7Qfw79Ud6K4YPi8/bL5zDRSe3g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Em Mon, 13 Jan 2025 15:36:39 +0000 Jonathan Cameron escreveu: > > > > > > 5. CXL features driver supporting ECS control feature. > > > 6. ACPI RAS2 driver adds OS interface for RAS2 communication through > > > PCC mailbox and extracts ACPI RAS2 feature table (RAS2) and > > > create platform device for the RAS memory features, which binds > > > to the memory ACPI RAS2 driver. > > > 7. Memory ACPI RAS2 driver gets the PCC subspace for communicating > > > with the ACPI compliant platform supports ACPI RAS2. Add callback > > > functions and registers with EDAC device to support user to > > > control the HW patrol scrubbers exposed to the kernel via the > > > ACPI RAS2 table. > > > 8. Support for CXL maintenance mailbox command, which is used by > > > CXL device memory repair feature. > > > 9. CXL features driver supporting PPR control feature. > > > 10. CXL features driver supporting memory sparing control feature. > > > Note: There are other PPR, memory sparing drivers to come. > > > > The text above should be inside Documentation, and not on patch 0. > > > > A big description like that makes hard to review this series. It is > > also easier to review the text after having it parsed by kernel doc > > build specially for summary tables like the "Comparison of scrubbing > > features", which deserves ReST links processed by Sphinx to the > > corresponding definitions of the terms that are be compared there. > > Whilst I fully agree that having a huge cover letter makes for a burden > for any reviewer coming to the series, this is here at specific request > of reviewers. Ok, then. Yet, even for them it would be very hard to track what changes from v19 to the next versions if you change something at patch 00. > We can look at keeping more of it in documentation though > it's a bit white paper like in comparison with what I'd normally expect > to see in kernel documentation. Personally, I like comprehensive documentation at the Kernel. > > > > > Open Questions based on feedbacks from the community: > > > 1. Leo: Standardize unit for scrub rate, for example ACPI RAS2 does not define > > > unit for the scrub rate. RAS2 clarification needed. > > > > I noticed the same when reviewing a patch series for rasdaemon. Ideally, > > ACPI requires an errata defining what units are expected for scrub rate. > > There is a code first ACPI ECN that indeed adds units. That is accepted > for next ACPI specification release. > > Seems the tianocore bugzilla is unhelpfully down for a migration > but it should be id 1013 at bugzilla.tianocore.com > > That adds a detailed description of what the scrub rate settings mean but > we may well still have older platforms where the scaling is arbitrary. > The units defined are sufficient to map to whatever presentation we like. > > > While ACPI doesn't define it, better to not add support for it - or be > > conservative using a low granularity for it (like using minutes instead > > of hours). > > I don't mind changing this, though for systems we are aware of default scrub > is typically once or twice in 24 hours. Yes, I noticed that we're using seconds after reading other patches. It sounds OK to me to keep it as-is. It is really unlikely that we would ever have scrubbing finishing in less than a second. Thanks, Mauro