From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EFB0E77188 for ; Tue, 14 Jan 2025 13:47:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2C886B007B; Tue, 14 Jan 2025 08:47:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB5216B0083; Tue, 14 Jan 2025 08:47:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9560C6B0085; Tue, 14 Jan 2025 08:47:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 742646B007B for ; Tue, 14 Jan 2025 08:47:27 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E8258A09B2 for ; Tue, 14 Jan 2025 13:47:26 +0000 (UTC) X-FDA: 83006184492.24.0CB0F8C Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf21.hostedemail.com (Postfix) with ESMTP id 425281C0011 for ; Tue, 14 Jan 2025 13:47:25 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Zq4YIFNx; spf=pass (imf21.hostedemail.com: domain of mchehab+huawei@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=mchehab+huawei@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736862445; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tf//4DSgsQHXKZlQUsV1v6SEip6gSUYyjpfmfGUkqgY=; b=8QiCUPDs7LSW8yxmhXZvN8R4OatgqhkbV5bg0R7igCgCuN7Hk/l3xzpNEWAW9POZ03Yjvk SopwHfDf6GJXeho9X95lVLK4VohaGkMq9RRMK4b6MIsian7OxiAPGJR9XkHE//lpT7BKgS d0FRDlEsHqpib3oVvEhJHTYL8N3AXVA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Zq4YIFNx; spf=pass (imf21.hostedemail.com: domain of mchehab+huawei@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=mchehab+huawei@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736862445; a=rsa-sha256; cv=none; b=C+gpP6EoXv0JDv2Uhkn3VHJBfb0tHxs21+Y0PtYsz4fZN1wZ7hIKnq+r3RpjQMv1MyZ7iz tJ/cHKlqJBkvY3STTJYcVCJMQucsDt7pwAZ1Td1gtlJvMobGyaRnbU3h2/krWSJpkjQBEw wmGpRPG0Qnr9cJ8P8qn5vwx9GPBLxSM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 2A74AA415F6; Tue, 14 Jan 2025 13:45:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 802D5C4CEDD; Tue, 14 Jan 2025 13:47:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736862444; bh=e72fpHGjY3D9f7LxRjXJmd4LWGSCP8u/02wYpWhOXTk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Zq4YIFNx3IvUdetyN3iQdwJWxkgJhfu/4+1GklYZR2AMfv0TNI1dtH8+lBmlhZZjO 0b4aiOGO94wFWqdFE0KfuYCiSX4NR+lP5UrS/eqYuDzkFYZh1OEm0KwuZVLFX7rY5T /FIvKZ3/yKqu2GORgWMqbfk3Q/ZUfux0VPyuW33hdztF5ZzEOJWB/qSXOGtiWEOQpj s2iF+P1qnvaKXG5wzfAA0RT2UhzVp84fYo0HRf1tKf3H8nzuqhaRiNaqSiHUhKGfwU 4YdIiN7k5LM4T9kJsqFJtZUUUemKDtCQ/bV+Mrxqvzn+Z0HmzX4u++RGR+KRWzeL2N fQlDiENdRbErQ== Date: Tue, 14 Jan 2025 14:47:12 +0100 From: Mauro Carvalho Chehab To: Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v18 04/19] EDAC: Add memory repair control feature Message-ID: <20250114144712.49cd98f2@foz.lan> In-Reply-To: <20250106121017.1620-5-shiju.jose@huawei.com> References: <20250106121017.1620-1-shiju.jose@huawei.com> <20250106121017.1620-5-shiju.jose@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 425281C0011 X-Stat-Signature: ep9g6g9pt6nmr7z7wj4wxhwezx1p3yxx X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736862445-95992 X-HE-Meta: U2FsdGVkX19NIxOcaw4iZgmygnTk89jdyooGLj6BTJxadrZNrfTnFpQRHQPhxKhQ9kBFMgN1sFBv6KmThuX8C6NSvlN/stNHtVNniicTZQ/w0JaQSDoqfol9PHfzVAajn6X0C4AZvNSIAzfiyJcDA1HmXaK/7IbcRHIn/rI9iK/hD4+7qrmPm+LQDZRXUQlsyEmrMp2crulReJHWubChiTeQiHlbiCuqwvGAa55j1ERGwfd4aDm/ztyYCrs8KTq7rN8/PPke641e4DlHvYKEc0R1VGi5V43l9tQ5Rhc60YZutfoI/XGoj1xBRIs9eUWqobycFtLdOtQxuZzE+FybhSRRChyvAmsGqtSwKZwn5fywOw/GNvjMC13iprbFy/ehnlMNx+DpRXrYnc9IUOB+B4lBW1NiOoO35xnGYFrg2YR1H792ZHhRFWX9QhI/9cfnm26tXGCNJIO8Tos0S5pILNsgzGkRaWuLg1LqfWaB69lwwUv6YaBH07wnnkgXNJdoMcLf6VEtfQpuYuBkTKsU+ZwdDaZLypdikGkfcqymbFUOQP/nFtCmVuhj8QCjANGG0879LPamHJMQYFXvf9SP6iYK8hpiGJoB4nWRb0jt3p8VXIgBo86gwwEFzbPk3tE9ZZ3Lj0vVTtJS6Kh/xvKGHJq8IleZj400A21O0ntmed4+N0bmNp/fvmGhRMuNrCslZNT19Kix2j68xpQcU3V7YdHf9x9qy6K8h1gOPiG7aQFfV0Bo/io52RhQvmb5PdPZmdRsJxVG0xsEpi2XiCYgV9Y90++23zmXM0l0hMvHLXyvgv86H6flRZ0/WrNpC2yRPu6lWeXgMAqPPrftbeOvKhjXLhjny+mRxqe4RGmApUnpyL0VYj/NhDWhCONwdEahb9aKZmmE2YZo529xtfZuAf86W3WB5ra05GbcZXONMQ+PP2MpzFJYIJcmaQbN3Bto1Jjx9xyqLwTMFW5gjlk AxuPo5Ob Uzj0J5V676ciABPk3823VoSD7s0+RPd5Cj4ADh3K8k642S/LkgYTT0DRSrtHWWzeGCo91hm6eP+ClE1rINqsZGva9T+JK/N7kHNCka7BazyLIm7Lkp9DIlyP6XnssIV3IgI/VrNiE8IuP+Zu5zedQ+Oip5Lgw9i+TvClznC1i7TYSesFpbxNYYba7owfJdQiiSBRFhnduHVWwPw9bWDIALmx9w32BXSk+75ny7PK2W6Y496RX0DaWQEqp+MsaRNSJd+JdCHOK2X+UuPW4JRIWkiMnMcRZop41LPQYuI+I3YOi60utNEom4O5Ok7nkPIwtgVtRf7e/uAElgz7/+wEhG039Pg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Em Mon, 6 Jan 2025 12:10:00 +0000 escreveu: > +What: /sys/bus/edac/devices//mem_repairX/repair_function > +Date: Jan 2025 > +KernelVersion: 6.14 > +Contact: linux-edac@vger.kernel.org > +Description: > + (RO) Memory repair function type. For eg. post package repair, > + memory sparing etc. > + EDAC_SOFT_PPR - Soft post package repair > + EDAC_HARD_PPR - Hard post package repair > + EDAC_CACHELINE_MEM_SPARING - Cacheline memory sparing > + EDAC_ROW_MEM_SPARING - Row memory sparing > + EDAC_BANK_MEM_SPARING - Bank memory sparing > + EDAC_RANK_MEM_SPARING - Rank memory sparing > + All other values are reserved. > + > +What: /sys/bus/edac/devices//mem_repairX/persist_mode > +Date: Jan 2025 > +KernelVersion: 6.14 > +Contact: linux-edac@vger.kernel.org > +Description: > + (RW) Read/Write the current persist repair mode set for a > + repair function. Persist repair modes supported in the > + device, based on the memory repair function is temporary > + or permanent and is lost with a power cycle. > + EDAC_MEM_REPAIR_SOFT - Soft repair function (temporary repair). > + EDAC_MEM_REPAIR_HARD - Hard memory repair function (permanent repair). > + All other values are reserved. > + After re-reading some things, I suspect that the above can be simplified a little bit by folding soft/hard PPR into a single element at /repair_function, and letting it clearer that persist_mode is valid only for PPR (I think this is the case, right?), e.g. something like: What: /sys/bus/edac/devices//mem_repairX/repair_function ... Description: (RO) Memory repair function type. For e.g. post package repair, memory sparing etc. Valid values are: - ppr - post package repair. Please define its mode via /sys/bus/edac/devices//mem_repairX/persist_mode - cacheline-sparing - Cacheline memory sparing - row-sparing - Row memory sparing - bank-sparing - Bank memory sparing - rank-sparing - Rank memory sparing - All other values are reserved. and define persist_mode in a different way: What: /sys/bus/edac/devices//mem_repairX/ppr_persist_mode ... Description: (RW) Read/Write the current persist repair (PPR) mode set for a post package repair function. Persist repair modes supported in the device, based on the memory repair function is temporary or permanent and is lost with a power cycle. Valid values are: - repair-soft - Soft PPR function (temporary repair). - repair-hard - Hard memory repair function (permanent repair). - All other values are reserved. Thanks, Mauro