From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71630C02183 for ; Mon, 13 Jan 2025 21:25:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F29A76B0088; Mon, 13 Jan 2025 16:25:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ED9436B0093; Mon, 13 Jan 2025 16:25:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC84E6B0095; Mon, 13 Jan 2025 16:25:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BF9436B0088 for ; Mon, 13 Jan 2025 16:25:41 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6ADF712036D for ; Mon, 13 Jan 2025 21:25:41 +0000 (UTC) X-FDA: 83003710482.18.FD643F5 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf04.hostedemail.com (Postfix) with ESMTP id A018440010 for ; Mon, 13 Jan 2025 21:25:39 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jkP8ghZk; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736803539; a=rsa-sha256; cv=none; b=zEEfWKsd88VxVO+Xk4ofLGC613Uzl6GmwLbIgyQSB9rmqSzYiXXaFpD86ZOhtHTNGHl1LB ozit0b76lvZ2i1I/eZ7vR9T3UvKBLyBlxcPdAJeZzSc5TzC9dP6NDwwpHgxKa1fXa+5lOH bBsuU1bMu8R9xhUXHEqvB2ee2jl5KBo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jkP8ghZk; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736803539; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f0iKjHig4ysKVSqSZjb0UBQYnerrrNXdFjlGVIH5X3k=; b=oRnUBNOON/jTAtB8h6md67BEz63GMk7b8j9oRhc5DOb/TdaEB1BkoZGPPfi+cWxKWjjvCq 7xM0kzQz4hwb2uBWnjA04FVjZOydtz0lRztOKGNa98GQD+2oxJvHgW4rDSRLi565ApUiyq u7HSVEK0AnbSUELeWMwbv1GVOW/G/fU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 95F9AA413F4; Mon, 13 Jan 2025 21:23:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BB78C4CED6; Mon, 13 Jan 2025 21:25:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736803538; bh=ubXq+bjMwy/AYRabDRJS7yunE1IcP6TJwdZJgnNCBlc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jkP8ghZkVjbg0T/f+TLgWMOzgh50xV0i8AXpFyT3MpVScYyUz7U/8dZOij/KUqbCF H1LgFQmhpNsZ8tUb1teIXlRqnZL8HTElnUF7tb6bdHDn95LlqN3EWdhF3gaY+zITyE POfdRlK09xtZQXLSlTXpDt4i9njzLQx/bDPN66BbRIAjVCIoeh04rWsk5IpUtikh9r bzofplI8/b1rWPkuR9ABOerd3XaS4IB3KZ4WfWxvhIUqUOTJFxGRJzr60tmGmhjj3Z UASP1JlhwNoy8xi9BFwPmfP43c/SMSpfOXhOXCGxirqFfrYerwgA3dYOrrphESg/pk /OtltE7VUgODA== From: SeongJae Park To: Joshua Hahn Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com Subject: Re: [PATCH] mm/damon/paddr: Improve readability of damon_pa_stat Date: Mon, 13 Jan 2025 13:25:36 -0800 Message-Id: <20250113212536.39564-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250113210201.446051-1-joshua.hahnjy@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A018440010 X-Stat-Signature: etmrun5p1fa6gixtgi8uugtwcdczacdg X-HE-Tag: 1736803539-725304 X-HE-Meta: U2FsdGVkX18zhCL0TP65HtaJPRkOqYygOyFokklR+KMnHuyw3k8IyMqcFS41YgSkAqb/AwQrPXptF3YeYqUwHVK/+TxaVVO8uZPTZGl234gRKmjCxF/AtnL5DhjHsHmHSSYb3wKzAfoV+8zjq3NQMCksjl4RpKK+bG25hTnfeCnFpfb8a76lKWt1GfI1nFlnS4CJ7+IJZkzIBXY6uM9b6ISLddhQHKS1706b2N0Aqt3E8Hy3clS46p8oEcgI90I+kn7ikymtAUajsc8vhTiskb9yqqrLZK6qWG09kUYnyhe1Jgf7T4zwE2ea3tgzBAUfRI6VgUXJ98WEox0f0YoBxE/uVk3dkgTK7ihAmu1+7gGs/nYHFbXSJE1L1ccTEp7ZPPBZmZphLF9+NCzfrxMEUmYXvHR4cY/Sjg1dE43c/8dOvcUuXAT0sB0573FuKnJoNdCVrTM6j1IClPij3v6hRlHHXigirHSCxPclJKKDsUtlF05vMEmTAJatVYwUNTJ8PQ/cZ11Qll0I6D7TDVezHWzAnl8XLHS49TnuxbgfPeaACr9ZiZBZ7gKa1UoMZZM6AVDRpKngLNfNcWbdpT5Lod9mA+Rf/t+w0+Wv3BjmmdruIUSbOLNoAg4FV11uehaLfZZFVPiOKl1klopfxy7pUn6s8Ps8kOTWQBII9UP7cbjAbl9L0H/jShZHVG4aXjQM6+/IcpLY02mtnA3CILfBsHv5cVptImgREh+yfn4HrTwrsqhxfMOtWUmfac/cLv3gmm5FcpBGKqICHVKSmOnufH2+hjK6uOnpUVzNTZ8D+EI8lIAyJFTKSyKLDts3jKLDcciciKq/fGHWR7LU33TIx8caawNbA4iwWJ/JR2EnCdO91zCoUa8JpINEVfshshYqbbdrRU0Rn4abLovpU9UU/TmwGEMkFEIjs8pabObRjg5fMh/CmkCnTB9StEGvopPOETap9YnvMxN+CN5lU4v VXF9QAGi ef1MExCh/jUmW3puT0ESLhHeMutJwmhlwB7m4OIselMXyBKisrbfiKLgO7mkY6zpm3RgowRYIQfmxg7EWTD1XB9TEdB8bFPkeyrJH3Dt6YzJAAidc6liQUYXhhDosvYwcwrmp9LUTDRUWA1qGUU5wWGjGHZr3m7wY7ZStb5qjJ5LB+ua3d4DOVvPAygXkk9BnVx43EvlxB1CY+Z1nJgxOrN8YSLfRGeXIcuzN4lsFq1GXIlF/b9rCRVWeqEHjYiDsael9vxEstOg6GIbPgeTg2tZHFVAgh89F3cpT5l1Jp4vEZb8hWZB79D+SSMP/CW5lhpeadlN4vEtBMRkfjdUHIkBQ1TOarjPZFcZw7NEyEg9u9urm6QrT6i/be6dQeACGhhjx4CDEg7u/8c0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 13 Jan 2025 13:01:56 -0800 Joshua Hahn wrote: > damon_pa_stat contains an unnecessary goto statement, and the if/else > can be re-written to be more readable. Thank you for this nice patch! Seems this patch conflicts with Usama's patch[1], though. I believe Andrew could resolve it on his own, but please let me know if any action is needed. > > This patch is written on top of SJ's patch series [1], which in turn is > written on top of another one of his series [2]. > > Signed-off-by: Joshua Hahn Reviewed-by: SeongJae Park > > [1] https://lore.kernel.org/all/20241219040327.61902-1-sj@kernel.org/ > [2] https://lore.kernel.org/all/20241213215306.54778-1-sj@kernel.org/ I think 'Signed-off-by:' like tags are the last part of canonical patch format[2]. Above two links may better to be placed before the tags paragraph if this patch has a chance to be revised. [1] https://lore.kernel.org/20250113190738.1156381-1-usamaarif642@gmail.com [2] https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format > > --- > mm/damon/paddr.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index b0c283808ba6..8cdf8320f9a5 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -509,11 +509,8 @@ static unsigned long damon_pa_stat(struct damon_region *r, struct damos *s, > if (!folio) > continue; > > - if (damos_pa_filter_out(s, folio)) > - goto put_folio; > - else > + if (!damos_pa_filter_out(s, folio)) > *sz_filter_passed += folio_size(folio); > -put_folio: > folio_put(folio); > } > return 0; > > base-commit: 2c0573ae5b4c9c0f9d81fa0138ed0014e1baf41b > -- > 2.43.5