From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33ACEC02180 for ; Mon, 13 Jan 2025 16:29:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDE356B0095; Mon, 13 Jan 2025 11:29:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B8E606B0099; Mon, 13 Jan 2025 11:29:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A55D96B009B; Mon, 13 Jan 2025 11:29:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 845856B0095 for ; Mon, 13 Jan 2025 11:29:45 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 28AFC1204FE for ; Mon, 13 Jan 2025 16:29:45 +0000 (UTC) X-FDA: 83002964730.11.CAD53ED Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 6FB2310000C for ; Mon, 13 Jan 2025 16:29:43 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lPMzoMzo; spf=pass (imf14.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736785783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vgd/0g+LaWmef5gDX62Sg126yqP4bAmhxx9nw+tAZek=; b=P1PGSOWIlfmyMFOROgoocxW1P7I3nUWZppctj1tcoBWEiIxC6JMIpBniRdF3grqOdQ2WVY sj9QTzhnwddxJgfYKl44GArxpWfgNTvbctz4hYPZZpo/kSmLLHrlgvlOJnS4XOVoU8+qQB zuq6zkoKlPAVxPKiVhQX8R5n1arnRGY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736785783; a=rsa-sha256; cv=none; b=T+Baxo8xOOhJMHuaTJIpimNGw5E1KWhC06cFv3V7dX4xQ6375LN/7TeiHQ1thHtcEvKiMy nQi4F0Sy56bdkr6FV9Hk06dO5O9OYGUr8LOoEVBEmNmviK5QGCQxIdCdKWB0IPt9u0Vij+ XCuBS9nM3KI+75baOPW+kGWaicDnzlQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lPMzoMzo; spf=pass (imf14.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D37DA5C56E5; Mon, 13 Jan 2025 16:29:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 749DDC4CED6; Mon, 13 Jan 2025 16:29:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736785782; bh=G/WL7za6/FhMEJQUPPYaVa5AR3im6p6zdx508VpTd8Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lPMzoMzonmm2uaOFLfrdzxlqYEZB9gyC4UNDIA7tmVyD1CdeiDw/0q7HTvvJaEdU9 O8zfvzFkV7uaD3Eeih9wt9NYEMgB9jFV0IHWkVr1H3T/eBEPpuOfFcMO/Ou4iLVDWQ Hml2UsTpltlAGqg8dCV2vjov8Jfdy8hAWDfRY3MLkqHK6jF+OtTwqCUS2Mr7UtQJAG LdHkSaSmCjlHGRuBlI0oL1FiCdYRvc0JfAH5RdDfH6z1lRwE3aqHCLNuC9IujuiGvW +MOXpYRLwV7Hg46tyDx5cj6hTBCHBY3taAzyPWeFgdxktJaT7Of+Zg4hhGTcDn07vF bC7Um3/mpT7aQ== Date: Mon, 13 Jan 2025 16:29:32 +0000 From: Will Deacon To: Qi Zheng Cc: peterz@infradead.org, agordeev@linux.ibm.com, kevin.brodsky@arm.com, alex@ghiti.fr, andreas@gaisler.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org Subject: Re: [PATCH v5 09/17] arm64: pgtable: move pagetable_dtor() to __tlb_remove_table() Message-ID: <20250113162931.GB14101@willie-the-truck> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6FB2310000C X-Stat-Signature: 441ipfaawrj8x6cnbbq1g17cikwc63hs X-Rspam-User: X-HE-Tag: 1736785783-578592 X-HE-Meta: U2FsdGVkX19t3Wf7zV3Un1Ib88x4kwbSMvO+AvjWe2ROWELEJdA8Lq7KV/DCiwLyjNRjwCvrroZcLiWCpPuy9ReFz/5FtwLXAZGnn+ocIX/xKqPw0wvxenid/lMuFFyJPGwCsFQfDWI/RN7rwhy7K2ytqqQhcivGVB0mNR69xdLTfRvEKcuEdXrkO5BwZj2c6y6qfdy7KmvrkMol2JRWAt3xjzt43HrLNXh8p5ZKyhgTd6LGyocGaHD9qE5wbvOJbzKYmgdpkfgYCbtdg4xDeDPMp6FpLZ0I2AnquhblN12ZqHKvcQ81fFClwv7sL4Sy0TmoXZUmhfHx999lLpBRR0DdrvtuFgY/zbSh2H73G1JfOdE7E9G5I/NiyrKXlpGZnoSsdC3y7wlbXd2qzkwNzjbwsJ/qbOsjl66djfcTrYQWyBOVfQ7IFk6DESJV9elVdiaJX7EOnqY1fAHs+udqmVUBZglf9qxcK7CXhYhlJdzhzDQ+ocKNmFW+o5Fc/3lwnc1pN6IPL4VI7w96FumZPEzZMu0B7SGsd6ytOhrZNZiSdFkDjQps7Sit3j7fGvwibxsz6hvfvcIKSNRmM9+ZOMiUKvA1QTM19nRaxkVXFYVe5lMRFINUaQ/QgwDivS3b8dvqGz8rKKZo/Jj2CplMpzJEeGVi3fTuihC1FVs7a8nJaF4IM9MmBUIMOUC0fyNtzF6g17JrLrrOzLr1anglZP5N4VPtIN/+e4GR/9hb22aIlF0HmFdNruwar/8h1B7wCQoZrK2vcqoPY2cFFaUG9XK113+Eolm7Vx2dVJdev34lUC+53ENpO7xQlY8CaT655kwlDEXxbwYjOMwKFvkmD7mMEYNkl6v3Mqe7L+MlVLB+b0OMBhbYyCDlbZWO/NaRCLHtJgYiy7HVbvSB3tt40RmHGAuwBCH1G4taO0kr3AowGg1BXMwX+7HIzjCgUPjR4Pu87hHVaqOt4PAmQAv IN3oWhGf Q/MUZB2bQropizQkK8BYkRPU0Z+HDyGf4wmeaHFiUYCMy0q+irjKP98kV4soH8XezXz6Wr1QdtVfVMaTvFSUCUYsUDzuHY2zffh0BLJF13DihzszVzqWTzYJmswsbqOK4sCOL2SwaFnpUxtjYGXhAP+y7eq1hc4Ups1VjZW5UAqJ5cdbP7QvEWdmfgAnd+6kUcPr7LWLOeKOF5pBCMiXZFWKyp1xUO6z0zXNVzDpDFA9oYW44eSTdT8QCeq2/PT9zFFy31d2RSN/GlwRyR/lx9JPK03xX5LQX3mupA4kff+WnCU1R4RF+2sfWyIcGNjMcKIMfEaQ7S6iPqAkcA2Qdo6zhQCXtj0hbKJYXF0YcRDjO+l7J68fjXNDs7MvGnL/S5bGFrg8W77Sxq+PhDibDMjjKZuBoKJRuaNu+Z9v29eMpwWK/EEksYs1hgUNsPhpn06Wy7DweyEUHpGY+YrHuWJPj8lVsKwFWN7rBikPtnVp9kS7xeW5PN2U7xg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 08, 2025 at 02:57:25PM +0800, Qi Zheng wrote: > Move pagetable_dtor() to __tlb_remove_table(), so that ptlock and page > table pages can be freed together (regardless of whether RCU is used). > This prevents the use-after-free problem where the ptlock is freed > immediately but the page table pages is freed later via RCU. > > Page tables shouldn't have swap cache, so use pagetable_free() instead of > free_page_and_swap_cache() to free page table pages. > > Signed-off-by: Qi Zheng > Suggested-by: Peter Zijlstra (Intel) > Reviewed-by: Kevin Brodsky > Cc: linux-arm-kernel@lists.infradead.org > --- > arch/arm64/include/asm/tlb.h | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) Acked-by: Will Deacon Will