From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99D7CC02180 for ; Mon, 13 Jan 2025 15:06:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07CD76B0085; Mon, 13 Jan 2025 10:06:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 02D476B0088; Mon, 13 Jan 2025 10:06:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0F826B0089; Mon, 13 Jan 2025 10:06:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 879806B0085 for ; Mon, 13 Jan 2025 10:06:27 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D13E7C04C1 for ; Mon, 13 Jan 2025 15:06:26 +0000 (UTC) X-FDA: 83002754772.07.4D29E36 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id BB472C0014 for ; Mon, 13 Jan 2025 15:06:24 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mKwmiEQF; spf=pass (imf22.hostedemail.com: domain of mchehab+huawei@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mchehab+huawei@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736780785; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JSf7HJkb0LGJbyP+o1w3me6utIh03wKiPZNJTps5u3A=; b=VT0v2GeXRN7NOsbIUGzs6KvnJTbfjdwL0nRJsOKkOQoHxLrY2Vqq4olUGHeOSNF7uFVEeh DoVnhhh/sDRJzGDd+Me4FoqZkYVYwhDR4KPdoUgv1DacffMI1H3bijabjL0x0VmMKdu4IN zWaPPbJZX3Ua9EwhYC2zt6Vqowi5H7Q= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mKwmiEQF; spf=pass (imf22.hostedemail.com: domain of mchehab+huawei@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mchehab+huawei@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736780785; a=rsa-sha256; cv=none; b=leesnXgh6IryUk1VXQbVctAA5cU/DmtQPBvrSjJ+dbUZJQvYorh5UIkCwSFVvIBauM8WGf H9TB91fSv9AhOD+n0CXh4j+tnYZgeRa4DEieFZ/b8Zzw+Mk6AH63cqnSnqKW93R6Mj9OJY cxB5StjugK8XhpWk8HrHum7eF8ZzTPA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 399335C5166; Mon, 13 Jan 2025 15:05:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83F84C4CED6; Mon, 13 Jan 2025 15:06:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736780782; bh=Q6YNGAd5oAgIkJE8XOKMMjMWOnnhVSZc7mV1uRa9eU4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mKwmiEQFH+u83kqAX+1ajwy6vYukC3GWU4c9TYhA38TUl4fjyLblNawhzrsFMotVa yuumUJl8YcD3zMOH+yNcUgSt/HQ1cbYFGLCrsfTmjgRHOyVOH0UW3dozciHjaMHdxW ekYLrku36WRipmcBZSeasWJxBj2v9hR795cH3/m7QjLiFSjBwVMGWhA7Z6bsjw0DFa Gk1Si5Zm/DgYNdUD9X/xZ+Uf/staSKmHdXVuBRYXut0l8m7QpJkrmPBUKfajjnN5KO l1QkplfKyzsorCL10m/B0kxsgqgkr0AfgjNIjjyvMV4R3LGgb6SyL5326kpsKHgdyK or8fp0Tzaa7MA== Date: Mon, 13 Jan 2025 16:06:11 +0100 From: Mauro Carvalho Chehab To: Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v18 01/19] EDAC: Add support for EDAC device features control Message-ID: <20250113160611.39bdf3b3@foz.lan> In-Reply-To: <20250106121017.1620-2-shiju.jose@huawei.com> References: <20250106121017.1620-1-shiju.jose@huawei.com> <20250106121017.1620-2-shiju.jose@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BB472C0014 X-Stat-Signature: miawxa7gojufe7646ec1nwfzyhr97jis X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736780784-160992 X-HE-Meta: U2FsdGVkX18gmANjFX2RWAuGwJolZF9P7MMHErd1gSk0Rp8RC0O2KNAaIhCGBJNA2y8KKEVQSq+pxb577cI1oYtjxaKyJyhp/5A+XlB7NQt9paXBe+Z2jQfZ5oDEfs0+SNISr4E0ZEvFjB7EX7JmmsyVvKm3/sn56ai3sACjJtI8lF+uy35yCNGZfbZySbgiAku+g+CkqIZenq7IHcBahlMk59h/dN5s0Of2qamR6LLrzo0tur+b1+enEiv5qHs1TVZ939PEhbo3l7OZI1SeH6+9AHAfMhrTuveygVVmdDEkimdehjYaC6BWKrA4dvt1ks+0wltyF/dgbagbQiwqLMsaSUYx8cFUYf+mOmNbUSqxOTChI20Ed25V+D3RTTZViskGiqSB3+6FsnY5APXy72DTbxccoKug6lxfg/dlyluGCAteuhNOKsZ5OX1jmzZeBwekcqALlScoKAdD4csh4VxezQxW/jAOGYGBwM6TMvkuLyBdrwYQXcSW1pcHx5S7udRGNe/BNx46svqVvr1+O3CvfSSpcyxhFjewZBA3cwN8gwYXQzQA7Y5enWc3SW1NjEwy1SXvpPyQ4z99WJvByWcPHAsQyqhkdeiZvPkE0WKCPVqUL1ZHA9O/OHTwLfELxhkkMioqtQiyFMvxwQyb1eiUwdqwKIM59F+eZZks8HSLGFKySkT9qFLj1fmw17WuiqoNRL+4Rx1Ohx3P44MBmmhYHQ4WB27cKIFlroDpoe1jB9x/ZfxKU6ZjkYddiMGgI3HhRqajgYBuMCV7dTTZNJEqCgcO6CP92bSGYXn8Us8Gwu6NAicl8Em7vyFfJJt8SUGS166psbpu5P5ld+mkONGggR/cLsOu2g5XCZpMLpi8lNlXoJnk87JrcQS7y/VJEbmHY2eEcdKbscP89V7mGcPtfF3A7mH8QcWmgQ6SRsujjuAH7jM71HB+6bCj/S7O04CMu5rjdgUuBhAfJAB BxS7ZAbg R3cEPJtNOibkXGdqwVmkZ1hINJ1vcF9C8YLMibYsCIPqQm+W3IOv26E1CKaK+N1xm/0tfMeTS30CZrfG0LGvfZ5QSYq7Oma3ypGxzgoe/HE3lyHuE1yCYUWDnTcNkarCtVicxtDXuXEU5av/x+mHC2RTDnFJNKvqw7Pe8kK4+Jsj5wSO9J1swz96VsEcyDoInHYVjphgmZMFYAnPm1Nk7QNWrFSHiwvNRI3+tXM/Ar21Pdmp6RZ3tFbHWEN1OZYLWw65QxNkUb7+7V7DWiLwTsxTO1hPj541XP1lQQliXpgCWSZo7pKLs4olAIfd2AR2lSRNxAj57SvLeLBxF1AAVWmP2ZCOk+dXGicc3seZ7jKUvNE+KsalsiYx3NLqApq+I9UhKmY3rKK4RIJqqpyl1SgCbog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Em Mon, 6 Jan 2025 12:09:57 +0000 escreveu: > From: Shiju Jose > > Add generic EDAC device feature controls supporting the registration > of RAS features available in the system. The driver exposes control > attributes for these features to userspace in > /sys/bus/edac/devices/// > > Co-developed-by: Jonathan Cameron > Signed-off-by: Jonathan Cameron > Signed-off-by: Shiju Jose > --- > Documentation/edac/features.rst | 94 ++++++++++++++++++++++++++++++ > Documentation/edac/index.rst | 10 ++++ > drivers/edac/edac_device.c | 100 ++++++++++++++++++++++++++++++++ > include/linux/edac.h | 28 +++++++++ > 4 files changed, 232 insertions(+) > create mode 100644 Documentation/edac/features.rst > create mode 100644 Documentation/edac/index.rst > > diff --git a/Documentation/edac/features.rst b/Documentation/edac/features.rst > new file mode 100644 > index 000000000000..f32f259ce04d > --- /dev/null > +++ b/Documentation/edac/features.rst > @@ -0,0 +1,94 @@ > +.. SPDX-License-Identifier: GPL-2.0 SPDX should match what's written there, e. g. .. SPDX-License-Identifier: GPL-2.0 OR GFDL-1.2-no-invariants-or-later Please notice that GNU FDL family contains both open source and non-open source licenses. The open-source one is this: https://spdx.org/licenses/GFDL-1.2-no-invariants-or-later.html E.g. it is a the license permits changing the entire document in the future, as there's no invariant parts on it. > + > +============================================ > +Augmenting EDAC for controlling RAS features > +============================================ > + > +Copyright (c) 2024 HiSilicon Limited. 2024-2025? > + > +:Author: Shiju Jose > +:License: The GNU Free Documentation License, Version 1.2 > + (dual licensed under the GPL v2) You need to define if invariant parts are allowed or not, e. g.: :License: The GNU Free Documentation License, Version 1.2 without Invariant Sections, Front-Cover Texts nor Back-Cover Texts. (dual licensed under the GPL v2) > +:Original Reviewers: > + > +- Written for: 6.14 > + > +Introduction > +------------ > +The expansion of EDAC for controlling RAS features and exposing features > +control attributes to userspace via sysfs. Some Examples: > + > +* Scrub control > + > +* Error Check Scrub (ECS) control > + > +* ACPI RAS2 features > + > +* Post Package Repair (PPR) control > + > +* Memory Sparing Repair control etc. > + > +High level design is illustrated in the following diagram:: > + > + _______________________________________________ > + | Userspace - Rasdaemon | > + | _____________ | > + | | RAS CXL mem | _______________ | > + | |error handler|---->| | | > + | |_____________| | RAS dynamic | | > + | _____________ | scrub, memory | | > + | | RAS memory |---->| repair control| | > + | |error handler| |_______________| | > + | |_____________| | | > + |__________________________|____________________| > + | > + | > + _______________________________|______________________________ > + | Kernel EDAC extension for | controlling RAS Features | > + | ______________________________|____________________________ | > + || EDAC Core Sysfs EDAC| Bus | | > + || __________________________|_________ _____________ | | > + || |/sys/bus/edac/devices//scrubX/ | | EDAC device || | > + || |/sys/bus/edac/devices//ecsX/ |<->| EDAC MC || | > + || |/sys/bus/edac/devices//repairX | | EDAC sysfs || | > + || |____________________________________| |_____________|| | > + || EDAC|Bus | | > + || | | | > + || __________ Get feature | Get feature | | > + || | |desc _________|______ desc __________ | | > + || |EDAC scrub|<-----| EDAC device | | | | | > + || |__________| | driver- RAS |---->| EDAC mem | | | > + || __________ | feature control| | repair | | | > + || | |<-----|________________| |__________| | | > + || |EDAC ECS | Register RAS|features | | > + || |__________| | | | > + || ______________________|_____________ | | > + ||_________|_______________|__________________|______________| | > + | _______|____ _______|_______ ____|__________ | > + | | | | CXL mem driver| | Client driver | | > + | | ACPI RAS2 | | scrub, ECS, | | memory repair | | > + | | driver | | sparing, PPR | | features | | > + | |____________| |_______________| |_______________| | > + | | | | | > + |________|_________________|____________________|______________| > + | | | > + ________|_________________|____________________|______________ > + | ___|_________________|____________________|_______ | > + | | | | > + | | Platform HW and Firmware | | > + | |__________________________________________________| | > + |______________________________________________________________| > + > + > +1. EDAC Features components - Create feature specific descriptors. > +For example, EDAC scrub, EDAC ECS, EDAC memory repair in the above > +diagram. > + > +2. EDAC device driver for controlling RAS Features - Get feature's attribute > +descriptors from EDAC RAS feature component and registers device's RAS > +features with EDAC bus and exposes the features control attributes via > +the sysfs EDAC bus. For example, /sys/bus/edac/devices//X/ > + > +3. RAS dynamic feature controller - Userspace sample modules in rasdaemon for > +dynamic scrub/repair control to issue scrubbing/repair when excess number > +of corrected memory errors are reported in a short span of time. > diff --git a/Documentation/edac/index.rst b/Documentation/edac/index.rst > new file mode 100644 > index 000000000000..b6c265a4cffb > --- /dev/null > +++ b/Documentation/edac/index.rst > @@ -0,0 +1,10 @@ > +.. SPDX-License-Identifier: GPL-2.0 > + > +============== > +EDAC Subsystem > +============== > + > +.. toctree:: > + :maxdepth: 1 > + > + features > diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c > index 621dc2a5d034..9fce46dd7405 100644 > --- a/drivers/edac/edac_device.c > +++ b/drivers/edac/edac_device.c > @@ -570,3 +570,103 @@ void edac_device_handle_ue_count(struct edac_device_ctl_info *edac_dev, > block ? block->name : "N/A", count, msg); > } > EXPORT_SYMBOL_GPL(edac_device_handle_ue_count); > + > +static void edac_dev_release(struct device *dev) > +{ > + struct edac_dev_feat_ctx *ctx = container_of(dev, struct edac_dev_feat_ctx, dev); > + > + kfree(ctx->dev.groups); > + kfree(ctx); > +} > + > +const struct device_type edac_dev_type = { > + .name = "edac_dev", > + .release = edac_dev_release, > +}; > + > +static void edac_dev_unreg(void *data) > +{ > + device_unregister(data); > +} > + > +/** > + * edac_dev_register - register device for RAS features with EDAC > + * @parent: parent device. > + * @name: parent device's name. > + * @private: parent driver's data to store in the context if any. > + * @num_features: number of RAS features to register. > + * @ras_features: list of RAS features to register. > + * > + * Return: > + * * %0 - Success. > + * * %-EINVAL - Invalid parameters passed. > + * * %-ENOMEM - Dynamic memory allocation failed. > + * > + */ > +int edac_dev_register(struct device *parent, char *name, > + void *private, int num_features, > + const struct edac_dev_feature *ras_features) > +{ > + const struct attribute_group **ras_attr_groups; > + struct edac_dev_feat_ctx *ctx; > + int attr_gcnt = 0; > + int ret, feat; > + > + if (!parent || !name || !num_features || !ras_features) > + return -EINVAL; > + > + /* Double parse to make space for attributes */ > + for (feat = 0; feat < num_features; feat++) { > + switch (ras_features[feat].ft_type) { > + /* Add feature specific code */ > + default: > + return -EINVAL; > + } > + } > + > + ctx = kzalloc(sizeof(*ctx), GFP_KERNEL); > + if (!ctx) > + return -ENOMEM; > + > + ras_attr_groups = kcalloc(attr_gcnt + 1, sizeof(*ras_attr_groups), GFP_KERNEL); > + if (!ras_attr_groups) { > + ret = -ENOMEM; > + goto ctx_free; > + } > + > + attr_gcnt = 0; > + for (feat = 0; feat < num_features; feat++, ras_features++) { > + switch (ras_features->ft_type) { > + /* Add feature specific code */ > + default: > + ret = -EINVAL; > + goto groups_free; > + } > + } > + > + ctx->dev.parent = parent; > + ctx->dev.bus = edac_get_sysfs_subsys(); > + ctx->dev.type = &edac_dev_type; > + ctx->dev.groups = ras_attr_groups; > + ctx->private = private; > + dev_set_drvdata(&ctx->dev, ctx); > + > + ret = dev_set_name(&ctx->dev, name); > + if (ret) > + goto groups_free; > + > + ret = device_register(&ctx->dev); > + if (ret) { > + put_device(&ctx->dev); > + return ret; As register failed, you need to change it to a goto groups_free, as edac_dev_release() won't be called. > + } > + > + return devm_add_action_or_reset(parent, edac_dev_unreg, &ctx->dev); > + > +groups_free: > + kfree(ras_attr_groups); > +ctx_free: > + kfree(ctx); > + return ret; > +} > +EXPORT_SYMBOL_GPL(edac_dev_register); > diff --git a/include/linux/edac.h b/include/linux/edac.h > index b4ee8961e623..521b17113d4d 100644 > --- a/include/linux/edac.h > +++ b/include/linux/edac.h > @@ -661,4 +661,32 @@ static inline struct dimm_info *edac_get_dimm(struct mem_ctl_info *mci, > > return mci->dimms[index]; > } > + > +#define EDAC_FEAT_NAME_LEN 128 This macro was not used on this patch. > + > +/* RAS feature type */ > +enum edac_dev_feat { > + RAS_FEAT_MAX > +}; > + > +/* EDAC device feature information structure */ > +struct edac_dev_data { > + u8 instance; > + void *private; > +}; > + > +struct edac_dev_feat_ctx { > + struct device dev; > + void *private; > +}; > + > +struct edac_dev_feature { > + enum edac_dev_feat ft_type; > + u8 instance; > + void *ctx; > +}; > + > +int edac_dev_register(struct device *parent, char *dev_name, > + void *parent_pvt_data, int num_features, > + const struct edac_dev_feature *ras_features); > #endif /* _LINUX_EDAC_H_ */ Thanks, Mauro