From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B4F1C02180 for ; Mon, 13 Jan 2025 15:52:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 974CE6B0093; Mon, 13 Jan 2025 10:52:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FF1D6B0095; Mon, 13 Jan 2025 10:52:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 777CC6B009B; Mon, 13 Jan 2025 10:52:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 529846B0093 for ; Mon, 13 Jan 2025 10:52:12 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 041C0A01A6 for ; Mon, 13 Jan 2025 15:52:11 +0000 (UTC) X-FDA: 83002870104.18.DF53CBD Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by imf09.hostedemail.com (Postfix) with ESMTP id D7C7D14000B for ; Mon, 13 Jan 2025 15:52:09 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=OL3mXht4; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf09.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.172 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736783530; a=rsa-sha256; cv=none; b=2wDuTihU4qGlc96JOhtYFJu4HKLbS5scbFJ6CpDd169ljKGA2h3mm2/LQSsC4Xr+yirMAI v+2CuYwWDZ7Kew6geXOIFy0nkdHWrlk+4MqijDsONQJ8A4vMPwMuPWmbFk8lfU8TbI7ZEQ LGyioI+fZ1CNtxMnZJJimJvThAno42w= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=OL3mXht4; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf09.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.172 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736783530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hoWZzFZ4pj30o8jUId65tsrWzQ2i2wmuYfON8PrXHnM=; b=tj12Y/h/Y5FV4SfdELX/afs5NN7Zc+MSAL8Tnx9DBxwU2rTuNkdb2J/sg93FqgP9SjudnW /WomjB2wcurRfLL2lDaeSbYnHE3ZsvqsIz5SKCpHjs41+gwd0z7FaVbekQ5fv8ziaWTCOr CmtwRuFBpC7kE/NXcvlN6epFIx5thig= Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-7b6e9586b82so384347085a.1 for ; Mon, 13 Jan 2025 07:52:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1736783529; x=1737388329; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hoWZzFZ4pj30o8jUId65tsrWzQ2i2wmuYfON8PrXHnM=; b=OL3mXht42Q2MiDwRpNWGcmQyszBrAhISP0Qt4zk1sVeRRPAYzZYRt3uD3amIvR3mqj gDBCNitgFQfdlfaFSJNNXg14WG0rn146+rdKSUxGFBRr+n+NTloZX6tU2DTHkabx5nGo W/JJfXWoA4qx3/25QXrYj15HZMq47EZz8IA3OBEit7IQ7Y4SNM+VX+Vhwg9NZscNxv5p sZawXrAl5doecdX8CQ9bDulETfPupjo6/H8kHlTzyDl5g+yzrrdpTHJ+zael18lIFuJn q5iPigM9zi8lm2ZztR1l2BojhzlOe7VFiqc4cRh7qBUSnwrgi7Zd+fWiFR7RDkoVVWl8 aOOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736783529; x=1737388329; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hoWZzFZ4pj30o8jUId65tsrWzQ2i2wmuYfON8PrXHnM=; b=gyOQht2maZ27fXEA0urYEV621rwWiUOWEFQU4nyx/SndBe+Ip9Gfc70TExj02PgPGW yxwjuxCs02lKnotElsLv9hyJfeKDYjyVOJgiyouEQHItaZTn167AR8tsTQ0Dc9XR48fa 016hlncwMY7oCx1Bit3knaxcKs/rErzCi6E5sQONxwlf68jkHobLRaxD80+SgNz1dfB+ 1TJ0bjvMOj0qR1V6po4oJ+vVh2ZRzXb0rH318CYUPiLEjErsDERUlU5P1vpGeG5c93za vBdqVdvIbCg4IQ/mS11rmJHCMBYVjoiy38My6pvr79JkjDp0FoRaDHZSR15wTLgzd6LU GJtw== X-Forwarded-Encrypted: i=1; AJvYcCW5sOsVW21KrWHxDwO9QxRxk3aZmMoKccRHYz2vOXLlpL5qfnR8eumc7jp1FxPOSW2w3UgIoN+hUg==@kvack.org X-Gm-Message-State: AOJu0Yya9VP6/0D6VN8sPXNLUDXwlkc5THxT39INyTG5W12SavQwK4xw L+0dLKE3uOMjSOag5oPhqlqh3lAgZkimdSILpKEFH0/AMkmxM7k8b40FxgByp/8= X-Gm-Gg: ASbGncs9H6iCjHHLvbrloEZMd3Tp9HrqYWr62mUS/UDCUva4k6tVxTfqG4cIyU7JeNp N8U3EbrkqDtAp7Nfb3nbx19Q56HB7WMZg4fiIPm0h/gn24n3QaGXWAljFFkSuxxNUFwCIhpAz4V L6KtIQBVaDOhwhrW7QPbF0KEECGEt+DV48i7Hj8Mer6tCBtv3NWjh+oMSPk1WWvVBGyoVJ8C5ld ItPXQud4k1RX8Kog+6q1YOx7XAMKRTlseofb/j6TXf0orJVge3D3nY= X-Google-Smtp-Source: AGHT+IE08BUjMbuLP4KmoqR9Eb5vn4epjyX/uelR4lIa8rg+NWttLIUyCND/2qz71rq/PmfYNaPV6g== X-Received: by 2002:a05:620a:2588:b0:7b1:5672:5d46 with SMTP id af79cd13be357-7bcd97084dbmr3002244285a.15.1736783528435; Mon, 13 Jan 2025 07:52:08 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dfade947dfsm42384216d6.116.2025.01.13.07.52.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 07:52:07 -0800 (PST) Date: Mon, 13 Jan 2025 10:52:06 -0500 From: Johannes Weiner To: Chen Ridong Cc: akpm@linux-foundation.org, mhocko@suse.com, yosryahmed@google.com, yuzhao@google.com, david@redhat.com, willy@infradead.org, ryan.roberts@arm.com, baohua@kernel.org, 21cnbao@gmail.com, wangkefeng.wang@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com, xieym_ict@hotmail.com Subject: Re: [PATCH v7 mm-unstable] mm: vmscan: retry folios written back while isolated for traditional LRU Message-ID: <20250113155206.GB829144@cmpxchg.org> References: <20250111091504.1363075-1-chenridong@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250111091504.1363075-1-chenridong@huaweicloud.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D7C7D14000B X-Stat-Signature: 79ai98okdmhcq5cuyfknzr9qr9schjjh X-HE-Tag: 1736783529-712922 X-HE-Meta: U2FsdGVkX18+urIDYyzXBV5MZpqSqgyCT0nNuJmRV6wBreLYNg2UB6OvlLAiLrT/Anfn6QZkaTitOUD33zw0grEGbCegtKJRlr9yhzMY2uE9pAhAAwZR0au8RTOMbSEkdBi0L1sOE+N+dyPbq/OmZDgOKSF8ZL+hnv+aH0m1JAfgheBi9x/4+HADr3wwJZ6+DC0Mb1aIoaxniFhp12SxijdZgz31MVPVpGHF000F/7wk5l0aaNMAp+L7681vvReI4GoC8V3s6SqSxLzq0k473YdDyKUTutDQIWB7HqTFV4n+esX0ngpGJWpUhzrKtRsSma1dve7sZ+TkgRSnpAiXEcjNRTzI1OACtmpffBmPoLz4iAy6UwHy3V/nnMW0t2rwYsRhCXyLEh0+ks06el8gTRM1thGh7MR1QJkKFIHYAQkkKORNDKnjlkiUu30JPPv53VIGrDJLC4w7h0xiP/SU8k5CL//yByY0c8KGJ/2L8fuLJVYExWxfosP9O3dw8g9WxFPQ7K88uV+6cM8c+0bBFzvEXLGjQTFEsbFfKZf7aUzn1xbHNGdubFpsrOQxKAa/vUVCeRtWaUjKDICX8BNA3lGySDxQmoX3C8tjhRMI12FjElj9Mo2ea7Dda5JR3dLNNnNDF9V24QeWioUg2KLvpo32i+8oj5nIU2hThOr9+Ud636DO6yDVxvMbI1JTYnxmER96qXvvf0p2dOyeW3gZ3cxgAdNiAVXSJnaVEIbim6uwdRA4P3IbgJrVbYQM7o4N3uXYcIHfgfXQVnYetZel6LuULO71u7YwVgqFOKoWHMWb50FZNnVNxjbi2uS9h8/oWCeAubcAQCCmAKrI8YVBe8cuOlllme+1HNvOXwXweEVLW829q/24bW8x8ABeSGx5hXevbVpCsxveozo+FQc8olBisqKAOseFOwhFGg9ATFcnec0lkHaVxSeSHEB4xoc96vUKFkzcqw3hQbmGbwC 43Q3PxmM JtsCWh8mxwyGdJ1Ign9n5fbs55T524oOLoaiXlMkMo1ldRO5lfvKC6ebR1yUV99AnO3mQq8ANlLB9V0DOZsFb+oykYtRAQweVtra1q1v67FteSkBsvdm8uH9sRkb8MlLcWypX0XBWXSgqSINPMksmsWaTCGcVAWUTsqq80nEB3lGmfknp2qePIDWO32To1jRay6Z3QQy2xNfLjYnS72CWHMC7cHS45RDzD1pHly8c5seOK1ZNE95hDnTOrU4fxY3GCbRjgOFqLZBWgHR5WWANyJ9r59r5VY3v+lbsb4C6i7iuLrVkYCGwZAn+PMNQBo3T3z7JeoiPwAi41rUcYHxGXBThE9QNW/bYB00/LJjmELMbqjvO+tyMnTt14QX3YbgmP+tYba5V4E6NOR1BucINKj5fZmKAhfCzIcmKU+3UTr8ycvvcYCe7ZC03/3CJrZM5xdiRbXQSmnl3txI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.003320, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jan 11, 2025 at 09:15:04AM +0000, Chen Ridong wrote: > @@ -5706,6 +5706,44 @@ static void lru_gen_shrink_node(struct pglist_data *pgdat, struct scan_control * > > #endif /* CONFIG_LRU_GEN */ > > +/** > + * find_folios_written_back - Find and move the written back folios to a new list. > + * @list: filios list > + * @clean: the written back folios list > + * @lruvec: the lruvec > + * @type: LRU_GEN_ANON/LRU_GEN_FILE, only for multi-gen LRU > + * @skip_retry: whether skip retry. > + */ > +static inline void find_folios_written_back(struct list_head *list, > + struct list_head *clean, struct lruvec *lruvec, int type, bool skip_retry) > +{ > + struct folio *folio; > + struct folio *next; > + > + list_for_each_entry_safe_reverse(folio, next, list, lru) { > +#ifdef CONFIG_LRU_GEN > + DEFINE_MIN_SEQ(lruvec); > +#endif > + if (!folio_evictable(folio)) { > + list_del(&folio->lru); > + folio_putback_lru(folio); > + continue; > + } > + > + /* retry folios that may have missed folio_rotate_reclaimable() */ > + if (!skip_retry && !folio_test_active(folio) && !folio_mapped(folio) && > + !folio_test_dirty(folio) && !folio_test_writeback(folio)) { > + list_move(&folio->lru, clean); > + continue; > + } > +#ifdef CONFIG_LRU_GEN > + /* don't add rejected folios to the oldest generation */ > + if (lru_gen_enabled() && lru_gen_folio_seq(lruvec, folio, false) == min_seq[type]) > + set_mask_bits(&folio->flags, LRU_REFS_FLAGS, BIT(PG_active)); > +#endif > + } Can't this solved much more easily by acting on the flag in the generic LRU add/putback path? Instead of walking the list again. Especially with Kirill's "[PATCH 0/8] mm: Remove PG_reclaim" that removes the PG_readahead ambiguity.