From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A80FC02180 for ; Mon, 13 Jan 2025 15:36:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87F1A6B0083; Mon, 13 Jan 2025 10:36:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 82E246B0085; Mon, 13 Jan 2025 10:36:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 743EC6B0089; Mon, 13 Jan 2025 10:36:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 56A8E6B0083 for ; Mon, 13 Jan 2025 10:36:48 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F1AEE80534 for ; Mon, 13 Jan 2025 15:36:47 +0000 (UTC) X-FDA: 83002831254.09.DF13640 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf30.hostedemail.com (Postfix) with ESMTP id 59A7880014 for ; Mon, 13 Jan 2025 15:36:45 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736782606; a=rsa-sha256; cv=none; b=bWyl+su+RASYvIfDLJzgAlYHl4h5uZtDTAK+t3Q8BUtcxb6Ahd3YOINHKeH+N0M0HtD1Zq OAjPFcY6d9P2239Nw03K1LUlFHGA0G3cvqMOglPn66tkao0Yzp0pyzlSyKPEq+4DlXGPQs ytwsrAYt8DpOta5m5oPQsqbKg+HxbEY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736782606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0dr7n4cnz68K+Jf7lM7+H7rbm8TyOGldwtQv2/3J+7g=; b=EaXCjT7MxOVKWa/R4jBDJtSg6LOTaemthG+tSc+l7iqH+mYCMfhdm7mUWKtBChfJp/I6v2 iZxDjTuqZZg+Xa7MYurMTVaKVxsjLB/O8GXh6Z01W6cq3zqKRCovQyXysKDdaJkerohPM9 ng6xNDPMqqXy/SBjZalHRnTiU6px6iY= Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YWxCp5KpJz6K6ZF; Mon, 13 Jan 2025 23:35:18 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id D0DC2140A70; Mon, 13 Jan 2025 23:36:42 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 13 Jan 2025 16:36:41 +0100 Date: Mon, 13 Jan 2025 15:36:39 +0000 From: Jonathan Cameron To: Mauro Carvalho Chehab , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v18 00/19] EDAC: Scrub: introduce generic EDAC RAS control feature driver + CXL/ACPI-RAS2 drivers Message-ID: <20250113153639.00003dfa@huawei.com> In-Reply-To: <20250113154634.4e831d66@foz.lan> References: <20250106121017.1620-1-shiju.jose@huawei.com> <20250113154634.4e831d66@foz.lan> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100010.china.huawei.com (7.191.174.197) To frapeml500008.china.huawei.com (7.182.85.71) X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 59A7880014 X-Stat-Signature: ccdkwaxazf5tw6gbdjn8joji4ois1ice X-HE-Tag: 1736782605-274480 X-HE-Meta: U2FsdGVkX1+jTVgactnHIU7pKnwZkJmsrTTWA6rfqIUzWPJ1iRx6uuJTvJGJ1HUf9CFJgt5mb8ziud9yY0cMoTXeyn5mYvnNv8yvoJhKUDWyJJrl56bVcgpR3KH05dbubwwOymaNnYdN31vvtWcBzC/U+yN8VAj2DZuU6zmiPIFF06d/zSvqt+B9Kh5ZTvmC6Y93OdFfiSqhXxSMl53H6BeMyEHESjrdkqcogGntZh5Imfa6L0T6+rmhAUyL181vClVghJsQjq5PDDfPPmNEBMmDEmJ7KtaP52OVZPiWLJBeSyi8/zGfrzn860aC4v6+veNfXHaaqDMJGVkR0ztI3wEWC8GyTpyHCBr45+VEutsutzW4qOUskNdNeyGB18NYSYAug6k2A+luTr/oQtqy6zMCqA+6K+R0rH5WsRQF0X19sbfgUNNufOiQsQZ6g77oOquKJuMCNLahWyW3NkNCQr18Y1qBCp1PS113elIkaQlqDxG4AvU2D46uBDTmEOIh0FdSsIsJOLxmsRKwVJtPDSN2plSMF/MZAlecxDpq7DARBBVsAEts9UCgwvDZmvgOJUcKgRPC221+fz2+zWY29s7K1wWAMRQ3QUlcae5pXkcdp66k8ogmG0J5jiULFtNYND5BZmiY+1uPjSJqfUdFLH6rTqx87Z6Ddq1V2kVOmh+JqJX3sTlfNqK0Ts2tOmAk3nLAIkIpoFHqOIH3lfzNUL77EpSm+qPuiIHma8EQ45+1em3j2hLvxDcrBlEjBWKichWbG/idIeDBirEl2GkLeokvaSWd2x4MM5BlH060TdDzLQRMkdmwwkr5SeYbNkMBVMEP0/LvmTA9+k53So764IX+SQkUInRydO13BgzJY1DNEb9+6/Mm5EkAnW9vkZizEvipF6oLUsiSB9c8lG4VxOjCKDJ9TnBLbVHGdopMBsPV++xNhqJUTQAexx/cIFmuZHUcsG7xe0szmGbKsRR J8E/utdV LqO2V7NnArfFrnu1VQv5eHMNvYRifpS3NB02ASfYAYPGxYjsBf2bPQNybhZAMltjNvXi7+DES8vda4RNRhF3j8/fDY523BOHDU+lQdjtZ6vdl+qoadlifXFxnTpPwhxAwnWAHESsm5VbVwBlBFsYJ1H9bFHdECsbwvFN7l6RAmUkXNPoc1SokqU0oaKodG+KxGdr/En9VOVH2c5cmTrX4E1xscUSbp0T1KMitmR57TxPz8mfT2NzsYF1EDkcKJiF3PdA7ps1POiv76tE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > > > 5. CXL features driver supporting ECS control feature. > > 6. ACPI RAS2 driver adds OS interface for RAS2 communication through > > PCC mailbox and extracts ACPI RAS2 feature table (RAS2) and > > create platform device for the RAS memory features, which binds > > to the memory ACPI RAS2 driver. > > 7. Memory ACPI RAS2 driver gets the PCC subspace for communicating > > with the ACPI compliant platform supports ACPI RAS2. Add callback > > functions and registers with EDAC device to support user to > > control the HW patrol scrubbers exposed to the kernel via the > > ACPI RAS2 table. > > 8. Support for CXL maintenance mailbox command, which is used by > > CXL device memory repair feature. > > 9. CXL features driver supporting PPR control feature. > > 10. CXL features driver supporting memory sparing control feature. > > Note: There are other PPR, memory sparing drivers to come. > > The text above should be inside Documentation, and not on patch 0. > > A big description like that makes hard to review this series. It is > also easier to review the text after having it parsed by kernel doc > build specially for summary tables like the "Comparison of scrubbing > features", which deserves ReST links processed by Sphinx to the > corresponding definitions of the terms that are be compared there. Whilst I fully agree that having a huge cover letter makes for a burden for any reviewer coming to the series, this is here at specific request of reviewers. We can look at keeping more of it in documentation though it's a bit white paper like in comparison with what I'd normally expect to see in kernel documentation. > > > Open Questions based on feedbacks from the community: > > 1. Leo: Standardize unit for scrub rate, for example ACPI RAS2 does not define > > unit for the scrub rate. RAS2 clarification needed. > > I noticed the same when reviewing a patch series for rasdaemon. Ideally, > ACPI requires an errata defining what units are expected for scrub rate. There is a code first ACPI ECN that indeed adds units. That is accepted for next ACPI specification release. Seems the tianocore bugzilla is unhelpfully down for a migration but it should be id 1013 at bugzilla.tianocore.com That adds a detailed description of what the scrub rate settings mean but we may well still have older platforms where the scaling is arbitrary. The units defined are sufficient to map to whatever presentation we like. > > While ACPI doesn't define it, better to not add support for it - or be > conservative using a low granularity for it (like using minutes instead > of hours). I don't mind changing this, though for systems we are aware of default scrub is typically once or twice in 24 hours. Jonathan