From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA208C02183 for ; Mon, 13 Jan 2025 15:21:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 678486B0085; Mon, 13 Jan 2025 10:21:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6289A6B0088; Mon, 13 Jan 2025 10:21:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EF926B0089; Mon, 13 Jan 2025 10:21:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3218B6B0085 for ; Mon, 13 Jan 2025 10:21:39 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E5F28A03F6 for ; Mon, 13 Jan 2025 15:21:38 +0000 (UTC) X-FDA: 83002793076.12.E452400 Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf25.hostedemail.com (Postfix) with ESMTP id 0443AA000F for ; Mon, 13 Jan 2025 15:21:36 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZevFtPpK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736781697; a=rsa-sha256; cv=none; b=a2oBuWc3t2fngoRmXCo/4IKYEb8hqmI5lRK/tYiumU6brhldBqthmhdoRkceSsugVVHT39 P0P8eooKFirr8zq3TAUQsF0usR+YfCmlaf5nM+Tf+4Fcn6PVVmSaXYa3+r4HC+U9irlb2/ WDJSU31HiCsN1SXYifDCF1nDvtuBDJM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZevFtPpK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736781697; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EItd3zJfgmeQs6GamX8dUjwzL+kw9r8hYoKvlpdsGz4=; b=Zvkdozo7wwJVFj/vhuT/q7TvN9QeOR+2px+B1DdQk+suieVftCzMAe6TZfzB8j/iZX4FeE +7s75iVED8ixpAGe7t2124dXV4LJayfkP7Frj04tWzKuN2DXCItW4aem+6yrsHyVftgUzk XtQF8cmyf/5Y2QnJ4MgQscMTfHSiuLg= Received: by mail-yb1-f175.google.com with SMTP id 3f1490d57ef6-e53ef7462b6so7333669276.3 for ; Mon, 13 Jan 2025 07:21:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736781696; x=1737386496; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EItd3zJfgmeQs6GamX8dUjwzL+kw9r8hYoKvlpdsGz4=; b=ZevFtPpKSYgc1V8Ia4hXreas39acWR5sFRFsHRAId6Ay1W9xayBIWzednLQE0BD7pe 9H6TeRLth4njJG+YTSGNRxRG83pFI+jlkDfgYBXUYLjG3HNZNBNWU9I+H2FF5TwmTKfh IrBGksGMENmDuNUDHrZ6azFQ79LU1Dz6qkeA4wM6mECmKmmWFRH2olS91uH4QH2nOICm I7yVDmVOIr7CqvomxRygX2+ZU+xodthouBnxKGwENgaq3XhHgL+ylR5Qg55zMUjZKrn7 ax8Ybjf3tFe4otlFZjjRqOIci7ojAIq6SrV5U7fCy6gtUUfZcdEcrR4/22Q8cAMiLZQb tpfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736781696; x=1737386496; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EItd3zJfgmeQs6GamX8dUjwzL+kw9r8hYoKvlpdsGz4=; b=pI+bZqLMOzRoZwx1yoA7uPvEbWFhZ/T/aHOaThMlcCzN1zzYl73Vdw/I2nDH9Ogj2R dfBiOANVy9wLXeZfqpf8I74lmf3xoHm9SSuz+wQZxz6IIfpS+GHBHodm6NlYWAW4y/VT 1VFghCMpUu8QXrKg0/m4ipS9n8o8Mb++nWxKvfAgukAgLlgOBb4DkoClLTv+Zr+S+4pR Una98x6j9fXKcKS1cqkrF6cyPpXatsqvsdpXSwbd3gI2OtsjraCPhL8+frylsJ5Wvvvr bGk9NmuJZnNlWWhyp1YqLyFNy7nl3X0z0KpNFCSJTu+qUIpXvvwt0oM1OjU5bWqHzUKK 6NKg== X-Forwarded-Encrypted: i=1; AJvYcCXW9oxJvIA1ohHI+bn55swTNF7FSKh1/yVzxs2QBssPsfg3ULBDbr+DaKTGG01vqpkH71l3lo690Q==@kvack.org X-Gm-Message-State: AOJu0YxzEZH7fCQxMGGovuuOlSAzpTB+dda320yKi9KEMPQbNNXAwGSL 8UGMGICKDIuYiwWFckStBi2C6kSssWCMGNLgZHPukmxJNRrB4g3G X-Gm-Gg: ASbGncu0+A7TKEv5LNT1OI0SWFVfCi4sWns1WIyaotaOK4JEqeRZel1kXhqM7dfyMrb MJIZsiqo3Zrfs+4DEQgxl+LyPqi84FGXZhVb0BsGdP0X8JR+GeWjt+5aW4RlbSyGi1qBSK8l5uz ARwn5mBiUyX93B/3r+1GWKsBBkQvi44ziggiRARNLG5uUFAei/aC1EOtkgiPVXKiZbxLPpKSgff OQKS0QmP1bzw0OvfYeTULSReo+L6YWoHY6m8fPHhThvPMfmLGtSTbU= X-Google-Smtp-Source: AGHT+IFJ41CkNcVYGIFsnjssiV1deK+mqGg5t2et7ElWjM6B6nSYdBn9PNbCm6u2S3+DDNgLRpHs0Q== X-Received: by 2002:a25:1ec2:0:b0:e4a:c0bb:7b25 with SMTP id 3f1490d57ef6-e54ee1daa87mr11389064276.41.1736781696005; Mon, 13 Jan 2025 07:21:36 -0800 (PST) Received: from localhost ([2a03:2880:25ff:8::]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e55be2487a3sm1590690276.45.2025.01.13.07.21.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 07:21:35 -0800 (PST) From: Joshua Hahn To: Yosry Ahmed Cc: Johannes Weiner , Chengming Zhou , Andrew Morton , Nhat Pham , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com Subject: Re: [PATCH] mm/zswap: Remove zswap_pools_counter Date: Mon, 13 Jan 2025 07:21:29 -0800 Message-ID: <20250113152132.2372632-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0443AA000F X-Stat-Signature: n84isewmwc7pkr87ohn5x7tedqa7yqc3 X-HE-Tag: 1736781696-605845 X-HE-Meta: U2FsdGVkX1967XmHqG+7WzLEXhkabl1QC8jszIPsKXxeJ2fj83rwC362EFCrFv2nyzW6Z5fIO2MMYIQHIxfyoom7578C2v4DWmRu57xRyvp9Hc+R/9LMhP1j2hifZfyb783Hpj35a0TZ9R9LD9fiwvxoKKQcKafozqbQYGcVbOa2jo5rGWjggHFdJ2NIvxHZP2C3VlOJWlfNo6jHJHWYFgB40XZf1fYEYlUaXXToml/dTVjN/1hD0NJmqZltnHC3rk111eB0j9EskLs9rN5WQ+S6p5BHpzztWGqJmOilx8kxVIJdlKfNZDvPA5LqmBldTitwX4bS6YjZxQcprsmNKxYe+QY8KW0kx0xxO4tcIihoWT4t6IyqDF/JEuFrDcK3UpvWcoyzk100JM/ue+YXAazX775iSdMIs6toRLXCMmE6P+hQThA2Xrq/VBYNjUjaTiTPtTLkNF/zBvLFq80ppsmt5sEFAoyMNbSvagpidRCOA+1f09Nt2PoQYapxI6Gyhp6XxU3M4grSqW+Zhjvf46BpmJN4Q04qCrCE05ZQC922RD7bm28leDGMmW+lidge5CGX3XqD1EVAWc1tpoEC10Z2uRLbt3/hvNaawxO2v11uJvw8b6bqHTK3p/xQrqTsAaQycrGGyH8tZCeRyaldgcSJxPqf3O3dV8mIMRnlbEPC+oiCZIzneeaKPLNwHTfHSSjPzM/XjSLL71RPDMTbMTfLoPzPxRUP7r+SqOT3kjn0tBwrTkvNDVUnwDDrFpgONGewDsw3790P4BGM3PTExAsmFFBjgsLelLhn/pznuJVDxzLvMnI3Yu0okJ0/3tyI6pekJ187eDAeoWhYk2IY7BeTgLLK8UM8Jli87DLFMtK86NV6eQPffI7YXI1bunbAwtlhxXKyuFnokoTvt8nQdUD76FCiUz0A24F0zApzNjfT14ip4nzxNJW7JUZIrhC3ANedmlYki/pCZN99zXU ltlaSbvH KZqzSAF7nPUtbZyTgXsOSurcOEZjC5JDzCRi+tSL5so0O3ptHvt/TYdoFbV7tDDJnsy4nOqb1QdD917lKkrPuaCiqwPNMsFSROwjpvOLByz6y3cKKLmp+4NRDZr5YNNdjaE3CryXIcYVSAQ2ZaTJ3x6la2/eZWBGPlROnPKU3frhaEiQBXcPM5IMREDLq3ac7WwSHER9hTjiubRF9lKQ0UySPdKFUWshH6iYs7KhCtIyvNBpULyp8Kw+EcKNSUVw8j1PcNttUFJ5lTFZTl8NAWm+L4X7tgtIPXiWISDsEhIqOcTcj47vMm/KiDBNAAV6+GFuPI17T9jktSzlWq9yVAthYDFpWV2lwoAr06ojDnDgx+yE+LruyISagbSvMuNun2Y6tNheZ8jSB5jb+4algqHy+HU76zWujKamMJEKylENIYYxSNhOkFogyeoymTlP0vX+YLOUw3SfUJAm0nmNpLt1ybw3ybNq0hLjOvV78Y5sQjp+lfe/Wpu6F31F1BJloruatUqSW/TjN/N4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.126283, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Yosry, I hope you've had a great start to 2025! (Is it too late to still be doing New Years greetings? : -)) On Fri, 10 Jan 2025 13:53:06 -0800 Yosry Ahmed wrote: > On Fri, Jan 10, 2025 at 12:33 PM Joshua Hahn wrote: > > > > Commit 8edc9c4 [1] reduced the number of pools used by zswap from 32 to 1. > > When referring to commits we use the first 12 characters in the SHA1 > and the commit subject, rather than the link (although adding the link > as well does not hurt). So this should be 'Commit 8edc9c4e72fe > ("mm/zswap: use only one pool in zswap")'. Thank you for letting me know. I grabbed the 6-character commit-ID from Github, but I'll be sure to include the first 12 characters instead in the future. > > As such, we no longer need to have unique names for zpool (zsmalloc). > > More importantly, I don't think this is accurate. zswap_pools_count > was introduced by commit 32a4e1690399 ("mm/zswap: provide unique zpool > name") long before we increased the number of concurrent zpools to 32. > It is needed because even though we used to have a single zpool per > zswap_pool (as we returned to doing after [1]), we may have multiple > zswap_pool's (e.g. if the compressor is changed, a new zswap_pool is > created). Ah, thank you for the correction. In retrospect, this was a bit of a naitve patch, it had completely passed my mind that we can still in fact have multiple pools at the same time. This could have been avoided if I had taken a look at where this code was introduced, rather than the patch that (I thought) removed the last users. Thank you for the review as always! Have a great day, Joshua