From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61382E7719E for ; Mon, 13 Jan 2025 11:53:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E405F6B007B; Mon, 13 Jan 2025 06:53:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DF0AF6B0083; Mon, 13 Jan 2025 06:53:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDF436B0085; Mon, 13 Jan 2025 06:53:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B05B86B007B for ; Mon, 13 Jan 2025 06:53:02 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5BB54121DEE for ; Mon, 13 Jan 2025 11:53:02 +0000 (UTC) X-FDA: 83002267404.09.05E37A6 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf05.hostedemail.com (Postfix) with ESMTP id 0C710100002 for ; Mon, 13 Jan 2025 11:52:59 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=BsQUyE0M; spf=pass (imf05.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736769180; a=rsa-sha256; cv=none; b=0srtXh/wr1hv9hReXCPfp7CzEutSePG0Jk/PWUcxd1cijEvJENO/GBhoIMiJVYLuVNy24L CfPm3wmbffzDH0q00j4+UUYWI06bljMTfxtk6F0bxPD3Q1Wwjj+porDbsgkZlYE9cdTYn5 +9v2jGYXSBMnkcxBuqT+MyW6RGsOYQA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=BsQUyE0M; spf=pass (imf05.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736769180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qSbRHcCxicQ2oaohgQJ8xn6gI1z5hxVzGPJ9KcO78ak=; b=y1v8Pb7vQ33whMb9r96jEqOv15W6fdyDksFVN6KOrmqdiOewaZ1yamv9m7gAwffyfCzKwF itHXN0WUSSQ1T/c+p+PleoRmUxxzykWzuT+vN/0hkEoDAnk1CZ6RasbquySc+KQBUE8cC7 /fEdRpCEliiciG8ThYcLNeRHSERogoE= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 94EB640E0288; Mon, 13 Jan 2025 11:52:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8xRRmxHxCCYP; Mon, 13 Jan 2025 11:52:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1736769173; bh=qSbRHcCxicQ2oaohgQJ8xn6gI1z5hxVzGPJ9KcO78ak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BsQUyE0MpgT/tvDuXqOP2by5wxaln0pgDMNsyorzlEBunwnsVmYg6L2A1phKwPV7s kprzy+NBoNbYbHsJnT3YmhuYEeQN554Y35wC/mmKzG9UGAMJVta9IWmsj8KPfG/LMv XfD6aFYfx/eAJf4Z4WMS7uJGUgv47TyMQcsEz3kYN83euyk5ovQcb00rZstpPUl+k2 XbESf4MoT3jT5DSHXgpKMVuLAP/j4GxI90mVoMrz7jo6PB/bu04vVroAIHe+P4wncu uMqHlK64sB5NHbaPMUduXTl1y6aXJwv3ihwZQc6RG0KfSGp8H2vD36ht30yi+eeqLV QWhvaRrxLFVJpiCA6H19MvlreYEL+92uTMcoce80ej/6rD/fnlBL+Ga63CK5k96ts0 n2vTOs2LhW2VMmg+88LAPYd8NjdMMEnfr6zy1QtfqPlktXHYlwN/tkF4apvCcnQ3VS CTn1EUlTZTFJseWRU7RWGhnI4DqXJUlXgdmWfAh0Hogqv0/+Bj8DIm/1FQJ6J6gGJO EwdXtvJeMUKmR9tsmgnfLa4Pn6Qe8PTZ85dV6YjZqO3pPejIvC42f/ZubgkapbMYf6 dhQef/RqIIoxyOJiBZ0pWPWElWKBrNqe3G6IJPjHGPHPAherBr5S2sILxabshks3Oo quZ4q2rdiiJ34vO8+Ur4yrU0= Received: from zn.tnic (pd953008e.dip0.t-ipconnect.de [217.83.0.142]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B4E3940E0269; Mon, 13 Jan 2025 11:51:56 +0000 (UTC) Date: Mon, 13 Jan 2025 12:51:51 +0100 From: Borislav Petkov To: Peter Zijlstra Cc: Ville =?utf-8?B?U3lyasOkbMOk?= , Mike Rapoport , Andrew Morton , Luis Chamberlain , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Suren Baghdasaryan , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.or Subject: Re: [PATCH] x86: Disable EXECMEM_ROX support Message-ID: <20250113115151.GDZ4T-VwIq_6ZafRE4@fat_crate.local> References: <20241023162711.2579610-1-rppt@kernel.org> <20241023162711.2579610-9-rppt@kernel.org> <20250112190755.GCZ4QTC01KzoZkxel9@fat_crate.local> <20250113111116.GF5388@noisy.programming.kicks-ass.net> <20250113112934.GA8385@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250113112934.GA8385@noisy.programming.kicks-ass.net> X-Rspamd-Queue-Id: 0C710100002 X-Stat-Signature: 796866ewa6ohozzzfkrnm88iz7odsgpi X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736769179-69903 X-HE-Meta: U2FsdGVkX19KDUKsypU7IhaJ4WxpPE8xLB/hSr7zy869sMch8Z3tIutZzasUIvV0cdWfmg0rjemgG21Yk9C0BqMmaRqyc4uQk70QAAtqW61s7V1iWUDmqFPH6MdvJT4qBPm7AHa4jSQ162lsjHusMT40aADc966yxDd972hHEm7X0XZE+JyZWKSQZG4bYQ/XX0Z7lt8r2p479LCX5bcJkwsOVkL2R6woxUkYIvd4WXCSVGSPnuU/MqNH00/K4UG9HBo8hSrjz0t4ZwMJqKM264vUp3rMOU8pkpDn9h0gn5czGRLtnTvJZJEwHIYHqOG+u86yqfxe71Ka5LUE06ufVUPhK4NC37T8CDSSe/ZrlcbK3+sFldNGrgF3Sv0FSfNGoGkgPPaRLzIcL1W7CWhpM7iMDYuj5QFkXcp59bpbO26RYCoLS5Rxn8ZtEo8vep9el96SPvjcgwwv31zZ7c977mQAqLYYHNJWCzE+49LUg1t8Tm1/Mp9aokHdsQ63jc37eTw9gozhVa85ggY3zKLnZNIzxyKZoObK0n5ncqe4aExLudI3BYMH/fl2Ia7JpO0Zqjzfs2Ig6TCe6cvw0K+QD9u0RCSXyreBRbQA712d13evOOsG8QeYx3ZJgxP/hC0XrjZZ40aQAEqpdvQrkewQwSv4U8+NDqgycpSKrYCpcsdHDtyjfO/eC8U0td+Z7Njdp+wRjArzI9Md0bvEw4Wg+XsTo7HlZIYwjeXClQe4N6LpLkCBCHa0fj9sndQSw4vH/qmIAZ28ud9/gLJDaeCgJelisax3Pbup4yoNrh11wpvEkVqGY5/mDOS9+k5Xiiwf/odJM1ISomUZJK4Je2dWjt/ksaSJHUTFUQOWTKST6iDXZg8/E1TYWOBsg7ywtK4YLE3bxpPU+S4o7VtY/EVdlX68opucOz6PvXTJ8Wt1DB5dYL9ojX5lCwthav6BZ0ID0zD6wqcxnZjJRGZu1zA l+EQB2kM YwBMX6rZnVo992GvqqAmvlUK8AvJU7c8l+X0wl7/PU+nVcpklQBJSWdf80E6Y5bpzkSJ25LooNzQFboydMHgBipB+NM5Lfcr3c5YKqqJVFYZXMEsGGjNLpDXeqG2K4VsnemvcITNOeAeFaySS5cYATwQxDvbxQQhX+cBHHe+AGEWki1/1+1sK+kUfHBR+A/3ZhSbFo56nSqyR2eFOsWj0oTcEuofWiA6Wg5AkPcE5rPNWM37nf7nJ6kytKj+PHHV60kTIV7ftZR9Dh3g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 13, 2025 at 12:29:34PM +0100, Peter Zijlstra wrote: > On Mon, Jan 13, 2025 at 12:11:16PM +0100, Peter Zijlstra wrote: > > > There's definiltely breakage with that module_writable_address() > > nonsense in alternative.c that will not be fixed by that patch. > > > > The very simplest thing at this point is to remove: > > > > select ARCH_HAS_EXECMEM_ROX if X86_64 > > > > and try again next cycle. > > Boris asked I send it as a proper patch, so here goes. Perhaps next time > let x86 merge x86 code :/ I just love it how this went in without a single x86 maintainer Ack, it broke a bunch of things and then it is still there instead of getting reverted. Let's not do this again please. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette