From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78A45E7719E for ; Mon, 13 Jan 2025 11:11:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE8006B007B; Mon, 13 Jan 2025 06:11:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E97EE6B0085; Mon, 13 Jan 2025 06:11:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D38D36B0089; Mon, 13 Jan 2025 06:11:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B59376B007B for ; Mon, 13 Jan 2025 06:11:41 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6FA701C7478 for ; Mon, 13 Jan 2025 11:11:41 +0000 (UTC) X-FDA: 83002163202.30.3A8AFD2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id ACA35100016 for ; Mon, 13 Jan 2025 11:11:37 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=RBeZjvjr; spf=none (imf14.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736766699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qj0XqtoExeVFzH/0zurjfq7xU6GfRici48V+bRozJOU=; b=nJgGkreJjCj76jNuIEDtwmhDb0JpE2dYBKW2tn1wHfhUSIXv3hfp6BbTAAA9+DXcNzH3VA 0FzU/Il/CBVZ9TtZMODvPPZcN2zM0s43Cp13BlDy0Tb5boE4cQSRIZ+6B9bRaiBF5Om8ys KjjtBvianZepwscVsAzSu9+f/4i2Jvs= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=RBeZjvjr; spf=none (imf14.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736766699; a=rsa-sha256; cv=none; b=g8T1ok/WdVIhaUZUWxlaazpNMtBFOGoKcx5A0TZiyobfKhPz0Sbk/HW6L3fM2dLpjNMrne vu6DHOD7hcqe9bYiLHPwbqtoudVzUSE9TMN2Zg3xskXGbyduK5ovVf1bO9bZ5JWhLytQ4d PrBHk1OlkIsCPbfNbCgkwldjTcXPsBM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=qj0XqtoExeVFzH/0zurjfq7xU6GfRici48V+bRozJOU=; b=RBeZjvjrDPcsThTXhXoukPjSAI NG77K2p71MbOxH6Hr5qVrPuCWPczlMw+Usz4bokWjI0fBdjtehyDAXTrQGWaT9i4QacSF10hny/fl f6+45RSS8YPaU1che58qLXvB808/OeemMrr+OxMrGlNDnXQB7b2TpPPhfKpDgTIF6FwQkbgsaHHv/ qWH8aMQaiLuDAwhO0wSyT9a/pEjhwF0eMyVTrcyQr7iWrcVB87HGjIDgYEa6Sc/aXZ3Fypjv84r22 BH1K2nUM+QDVXKQYksJjlCJihDeuyCAinjzkix2Z02HSasZ+qUs94+8Oaj8TFlpsejHZLSf1hn/do soSqXYVA==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tXILk-00000000a7O-2KHM; Mon, 13 Jan 2025 11:11:16 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 27A6730057A; Mon, 13 Jan 2025 12:11:16 +0100 (CET) Date: Mon, 13 Jan 2025 12:11:16 +0100 From: Peter Zijlstra To: Borislav Petkov Cc: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Mike Rapoport , Andrew Morton , Luis Chamberlain , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Suren Baghdasaryan , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.or Subject: Re: [REGRESSION] Re: [PATCH v7 8/8] x86/module: enable ROX caches for module text on 64 bit Message-ID: <20250113111116.GF5388@noisy.programming.kicks-ass.net> References: <20241023162711.2579610-1-rppt@kernel.org> <20241023162711.2579610-9-rppt@kernel.org> <20250112190755.GCZ4QTC01KzoZkxel9@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250112190755.GCZ4QTC01KzoZkxel9@fat_crate.local> X-Rspamd-Queue-Id: ACA35100016 X-Stat-Signature: qwwinjqzfw4jyk58pym5dmsyu4mhofz1 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736766697-365913 X-HE-Meta: U2FsdGVkX1+CpxigAxVoxFuRFbQCDxmRINjVW0RstMsDniV8B6HbfkVKNGQ+A3TRT4Jmo2RDuIkH8Uz9jZzQJtJ8inIXezqh3Jb+O+uA19g6TKlbxu6xl1TTd81v5jftlKq3KzKlqTDRLsfR52CHsjNnjeKNL9xM5ZHmdQ1rjN7YceIn2PRwtjkYWB8AAOzUmoIeiN2SuTqSyYgjbD3W/FqvUKbVssVFl3Id2OkAOHYDcTcHAg5ZsTbyqGpyfTeDGjEVn0DuNQX0l6PuiJx08lxuTAXvnA42wo/yswlC3T3JdAL5JAS1zL9XIXfe1IqwvldLJrxn6HZ4N+an/30w074GBxI0AxgwsGkPabMILFbOQjMRDYhmcH95++2S5D/RzjU8kBcc6ERfrMw7rWKnSndISO+5s8hZAcBhDHWEXEOGa9hofuZhxCNhh+3eNSxrd+sFTLRWBeLfz+F6IhWCstHIuaGozPIaaiBBaTFu3dyPNeQ0jC59tcb6trpKpDMle5DJn4B1bQ5VbVG9p2UfvNTmjBW5ksYPutoQMUC8kAta55bcXMeng6uXmcgO05ZXtgpr91cj9yJCVxQRy+3LAJz+4WFhBNhc9mOxbljnYuo7TG1+RyE7W8JD7eICEP7X8OWoEvviQzHi+F7poll+5ytgmZBwl8lkrG8mTRH+l7C/2Qi+kLkb3YjH2xrrWwgOHvONTaz5WF6u8GnJmafWc70TemrxNesMihBmjNQZOJAE9khuTluAElFb/DV3E0UedV0M7wO32Cs3pflJplG1TRMtZDHhRZ/DQXni13NOlpvqZJbwLcqrx6wq4Ndbi72x5G/iJ5eFhP2FnibA6cNmvLJ/MFmJCQjJa+pKF1NA2w3YpRZPTK+YPK7SXqdtmHxdHKaEnUHdwTjn3wT5HlYUPKcuWyrm9CSBE7sv59IDKJUFvuknDomySZQP9RNY8oEKMRDJ9w8+ny2dUlfF1mt 5m40aqlA 446+T9nXcKPM8WFkmqtcaN6eAiHA15IUE7h5t16nSfU77GV22vFwsAsVNpN54XWYHLT4WRnc3J6bY6J25jhzrKsInvcbb35QIogze7tmkKlD+sGcCCfZLXcLXBQyB6njOboJ+3cLMj+aPCwG9XcBfxuMgXNTDM/a1R51JMY7bR22pUorC8T7uA1nh7Z4wDoA+QQSPR7ucFAL6HSyqbxDrHJwFAg2jI7wBx4rgXCTxGoA3s88= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 12, 2025 at 08:07:55PM +0100, Borislav Petkov wrote: > On Sun, Jan 12, 2025 at 08:42:05PM +0200, Ville Syrjälä wrote: > > On Wed, Oct 23, 2024 at 07:27:11PM +0300, Mike Rapoport wrote: > > > From: "Mike Rapoport (Microsoft)" > > > > > > Enable execmem's cache of PMD_SIZE'ed pages mapped as ROX for module > > > text allocations on 64 bit. > > > > Hi, > > > > This breaks resume from hibernation on my Alderlake laptop. > > > > Fortunately this still reverts cleanly. > > Does that hunk in the mail here fix it? > > https://lore.kernel.org/all/Z4DwPkcYyZ-tDKwY@kernel.org/ There's definiltely breakage with that module_writable_address() nonsense in alternative.c that will not be fixed by that patch. The very simplest thing at this point is to remove: select ARCH_HAS_EXECMEM_ROX if X86_64 and try again next cycle.