From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B90ADE77188 for ; Mon, 13 Jan 2025 02:38:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 419F56B0085; Sun, 12 Jan 2025 21:38:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CA516B0088; Sun, 12 Jan 2025 21:38:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26A3C6B0089; Sun, 12 Jan 2025 21:38:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 08E0C6B0085 for ; Sun, 12 Jan 2025 21:38:03 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 85AD71C7E0A for ; Mon, 13 Jan 2025 02:38:02 +0000 (UTC) X-FDA: 83000868804.30.0B73BC5 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf14.hostedemail.com (Postfix) with ESMTP id 81793100005 for ; Mon, 13 Jan 2025 02:38:00 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MSHyFntU; spf=pass (imf14.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736735880; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KFa4UFnZYVUF29EjZIMNFsD2rSpOiFnUOuvrl5CUGCg=; b=1tZKF/TpgN/bCNTZZr9R7MRtjh9cf32FbSJ+cP4B+D2+3rHDFTTme6ehJQ+PBtA2rmWdp8 o2GCr9qbtL7E4KE6K4g7QTuhictXQqvcvcBNGK383rfIe+2ZF06/xiX3Qbja21QEqejK3j 39xKivv3L7EB8T1BvLBFlgQ2A70wZdE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736735880; a=rsa-sha256; cv=none; b=MwE0u0V4gDj9xMw4sKvep02k5/3OX4BGSlEVkgDaL3DHH+xuJSXCim8qZzSN1sqNbLY72e 67dT4G/uQ3eWUbPuMVZ6ExqXw3IrP6XABqNYHG6tld1QwGil4H/GtzGsaZau90s+IzyTiW EgB/JGyqnDppDciDcMG3OK5JIrmjPJM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MSHyFntU; spf=pass (imf14.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-aaecf50578eso754904166b.2 for ; Sun, 12 Jan 2025 18:38:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736735879; x=1737340679; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=KFa4UFnZYVUF29EjZIMNFsD2rSpOiFnUOuvrl5CUGCg=; b=MSHyFntU/PWnoALgAc1mcjotR9eNsjpIwpjhZGpG4FHVuI3+OzWqMjA99Oa2hNY0QT 3UWPbbWL4JtNmdEKnpjs4Tp+vOPiLqAP7O9ffKBoVU7BbX+vuQfGttlNzjv4Yy6oYIPy hcFn+BIfP1xg06yPp/R4V5ViNFwlCzZnT0Q7XDzTpX+w3MnzXwErTxn50+mWyhhsmzBX B4DVOJgr2uVkbGDXjmim2OvvMB2I6fuLTeG10BSBaZgpwpNFrR6vy5FVVf8RYVxCeKBy 6tNQhuWaG7gBPktcknZYm7DWWRGqSzhiQelqNAgfYSiWS4X68KhleHhjKmkE4szJFjk0 s42A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736735879; x=1737340679; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KFa4UFnZYVUF29EjZIMNFsD2rSpOiFnUOuvrl5CUGCg=; b=chQmp7e7DUXU2guDS3X910tj73EG4tx1zJmU4gsFX65zN2KyLxq8sxjOPuVUg5yIqb Wc+aUFoArX7ksviyQmvXBqqCM5o+ssQm8mWOXfiIUkypa2ojZfA/v2U0RO0t1qUjAY8y E7yeJPgv39sHVi9BBt8YRi0HuOh1ZI5wQBRNRFhwhJU/UkTyCiieTztAKMJIYLuv+1rD Klf3hWK4R64m4Ddz9fT34u1T+AMhlKhHT1HziqrzyJaPjjnmMrCHlaGAGoRej2abN5ka mzlcrsshQaE23MD3q3fgUdHhvYZChu1nMAzPdIUJi34q2Y5pte9oVuRAe4fSGfhNJhnS Kcug== X-Forwarded-Encrypted: i=1; AJvYcCWfl+gF5TX1SIScYWEaV4SQqzfF4UOJ6d/+/cWQX+QGEH2AcHUzXeIhHouEZTgheaLCSHlem7eEbQ==@kvack.org X-Gm-Message-State: AOJu0Yw/wRibemxlfHSQXs5yhxwbsc4FaPeQ+MffJYaj5RvPBYlJ5HM1 F4/Z5rQM8d/97EPxZ6cdYTqRlfR/JmdSfftzWhK8oxZA4SufFtLr X-Gm-Gg: ASbGncuKHC6jqb8OeoVvRbLb3lI4132/eTppeofz2/vmL/L/x2OUTGXOKBlmDHZ7FFv 4NhIWrnUs8izpbLU8nA2uFCn3kasyDdt7sCnjEFi0kT17HMmO0xN8jfP9IUsVLieawxYYKdO+ET 8NHBrkOEMU1Sak7Vzc5edeqxy9RGoqsmD7iuBMYFADn9I0e84Vn1MYiW+YU7boIRM1eE8BZ9Fly r2WL0lGc9COEyQgh/cX3QEKjHCu56Lg0dSGTVpUp3GBODSuVMH7VBij X-Google-Smtp-Source: AGHT+IHEDkltBWyWbX2j4wixCxax7BMgnbEMmgEZ3qHErBAvGklHMF/EJlOvm24KMsZfkoihiOMM6A== X-Received: by 2002:a17:907:7255:b0:aa6:8600:24f3 with SMTP id a640c23a62f3a-ab2ab5f5353mr1491294366b.25.1736735878714; Sun, 12 Jan 2025 18:37:58 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c9060db6sm441445866b.8.2025.01.12.18.37.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 12 Jan 2025 18:37:57 -0800 (PST) Date: Mon, 13 Jan 2025 02:37:56 +0000 From: Wei Yang To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, david.laight.linux@gmail.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, richard.weiyang@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v9 11/17] mm: replace vm_lock and detached flag with a reference count Message-ID: <20250113023756.kgu7hdeow7ltsj7m@master> Reply-To: Wei Yang References: <20250111042604.3230628-1-surenb@google.com> <20250111042604.3230628-12-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250111042604.3230628-12-surenb@google.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 81793100005 X-Stat-Signature: g5uyk8fmbhu9krnd846pxszpt6hfpth1 X-Rspam-User: X-HE-Tag: 1736735880-531546 X-HE-Meta: U2FsdGVkX18+B/6S74NO2EoLLvt4BAacozxAW/j7qm3IRIB+fA2l9cyk9Odrw2Huq96MIJZkJCIik49Kr4/MnE+WvW3Ca8uxdbOCCR25mUOsNLomgM7jXjVLPMyVomeYIv72sFl0DOkyJJoDbjrb5Qr4CVDWVPB+tmIKjUWC2M66ZG7ojMeO3CsDw9C9/IUPvqa7PaJGS1ZYDj+/W2m+FdLlCok+c18VSvIbdNGqY2AB5kKs642JDVbbhb15F8yTIOIzS5Pe763BsPBzXXDDQvLvqklLxuTcdoDq8DEpoLv9OoYTx67uEocb4PyzktRDTUm7hSPm8tYRjMo+A7PKrOsYvQYxc5otlihm+dxxzttTgooyaEo2Dn2oimKznckUGuuameE9ZTSK2u4enmTmonwm0dezTp+9a9n0U+LUBmumlHl1MGxQaPPou8L4avAmWM7TPZRPi+ZJi2QYZIu5qjHD/PpcRtTLq0ndlVruEmH7a5+RJ18PGpLiRXQJKMVyANav5SD9o+OCuZB1jv0M3nhunwJVajr9R2/MpKUHQ432R6m9RbuRVnThSKe9euIv0VaD1piQ/KPBGtUSjKQBQzmTR7CZBLhotzootUq0xvQXaxqwdlTOF7BhXcUPLva/bowsKvh/bx3O8f5G9Y/QRCK6eprweSRfjjRUY0qgWBgZR7IASLIs+GhdWqMK7/jph/RZSifg/M/gH2tdEnTxScQIEZ7h2yERNbaNxaOFEGC4coLAx4xiOjoy7qXi2vXmywcVRITshEPWgXVpLGJGh8Efdt9GWzxUsaInvNjcN9b0dzAAk+yWT5GI38IGphZNdNjXncelXe8+wXhoQCBdUqGuGxyf4zSgJlbrH3t781hJqaPf2djd0afAQx56d1OY9LaRrBkc+WASmHmQIgpQP6NCQLPT6NtEL7ToUr5aZnGUXhujnv1HIbvcg/ds+YByTyu2j7dLWC76iNh93O5 mSNAlfSc eqZbhb/KcdQypG+SIB0dDLi41o4yBNEiJou1yWktP5AUJlVSqNrw+aBGzgupNUtVydAhUV1jKU4nrEIyDHCeDIt6tP6Ds+O4hEs5eKOmKRio3lDZ01iTl+HTCV/QIS4IwNfS7haYBWnLcE6BNanhQJaUNEcgyn+OO5ubuPKCy1J7/qMA+woNqCxMMmY9W1EV1zfyyKYoDCPF3QqzB6EDRRo8glQ8tM7Nbp/s65Lc6wNgb+slF4c2S/FkRxXbTbaPK3MtUg2Nsbsk2xHA97D+McsBK5AvLQocqeuleY7gwIL7qvrh0GgaFsnzYLGP62HRMgBnlDddLoI0SIYsor6DMLCD4LTZhhIjFv1LJnx6DYziLwcRLVRYJaymaFzUlkQoGxsf/iQ4AUTh9f4qawwP01hzK76LRRWGiNYuewsgAZ67r6VfzEE5pdI8wMqjr2FgeBWw/IXj/dY8Lx1QLH+4OJrnBYUU3kKk1HHf0SdxQWtP975ceDqy6+cPLGTPMlw+7sIQUy5ExQ44KLP4mU3yIb+k59SB7LCgmghGYicrKMa+A4Uk9/NiWKNRNeQl67cGIuz6vPJb8Dq0Jcz3xPDLBTFvh5il3/Nw7YRG5c+YXVGBU9e4SFMpthZkpfpCuL/MIjoo3pX5JQMAAJUs7ZrHkkfjZTQrWRZg+MBhPNHnGcpymR5bDgIOWgYeqgr7r5+YBIxYv X-Bogosity: Ham, tests=bogofilter, spamicity=0.002781, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 10, 2025 at 08:25:58PM -0800, Suren Baghdasaryan wrote: > static inline void vma_end_read(struct vm_area_struct *vma) {} >@@ -908,12 +948,8 @@ static inline void vma_init(struct vm_area_struct *vma, struct mm_struct *mm) > vma->vm_mm = mm; > vma->vm_ops = &vma_dummy_vm_ops; > INIT_LIST_HEAD(&vma->anon_vma_chain); >-#ifdef CONFIG_PER_VMA_LOCK >- /* vma is not locked, can't use vma_mark_detached() */ >- vma->detached = true; >-#endif > vma_numab_state_init(vma); >- vma_lock_init(vma); >+ vma_lock_init(vma, false); vma_init(vma, mm) memset(vma, 0, sizeof(*vma)) ... vma_lock_init(vma, false); It looks the vm_refcnt must be reset. BTW, I don't figure out why we want to skip the reset of vm_refcnt. Is this related to SLAB_TYPESAFE_BY_RCU? > } > -- Wei Yang Help you, Help me