From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF535E7719E for ; Mon, 13 Jan 2025 00:56:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D0C16B0089; Sun, 12 Jan 2025 19:56:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 180DD6B008A; Sun, 12 Jan 2025 19:56:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 021086B008C; Sun, 12 Jan 2025 19:56:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DA2356B0089 for ; Sun, 12 Jan 2025 19:56:43 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3BD43121A58 for ; Mon, 13 Jan 2025 00:56:43 +0000 (UTC) X-FDA: 83000613486.28.855C8F0 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf10.hostedemail.com (Postfix) with ESMTP id 45E9BC0006 for ; Mon, 13 Jan 2025 00:56:41 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BLb7AsOm; spf=pass (imf10.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736729801; a=rsa-sha256; cv=none; b=39WCq/ffPGrAFalLyVtP66oI1fZfquknRzNxvfSqOXgJ5V5kxJKBca6dMwaGUjWVCMme53 SxnJ4pbCk4G5icoBEWfxqUl7kP+qGyVORx6HGDWvULDcTQiq/ck+ZX/Cms4RfYAQ+zF/i4 rbQ9b+LUUsAMDSuzGvQXZtAxvPDtGkg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BLb7AsOm; spf=pass (imf10.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736729801; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0V56Sb7sqNGix6HQ1QvO1EkN6QyGEMwBCv4yPDzPp8o=; b=iakZPD/nmMbiX73l3eUqkVJWhNlmusXv7zyUEOHi+Fh6cLWsBwth2z2vreqvPqOIgErUKz FXciSGzInDnQ9BUVGluePCQDGHOxNdgmv7PGDXQh2zAmcQ2B9SQXbNzwhH5ZxTq4SQdFUv 9MmxjN4TYc1NF7mBJ3DmcjW3J8dUvxg= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2163b0c09afso65013855ad.0 for ; Sun, 12 Jan 2025 16:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736729800; x=1737334600; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0V56Sb7sqNGix6HQ1QvO1EkN6QyGEMwBCv4yPDzPp8o=; b=BLb7AsOmtXj+GqRlIJ00je3thZTtqr+xZYUf29AM0FIIzZXUPDnFEn2EA7W18oAxTC mSgPU0qXSxMmoaD6KglYCYhZN7G4kkE2VvEvBFtmJtanEni+gJLtK9m1+pGZrqKRIJM0 Ufj7bJSkB3tKxeDqxs+iyOBPjbOqKT7647YwpGGrEpiWyoB+Vf9/wVN4HSX0UK9otz5o e5FDZG3l/5tfAR+ZqjCdow7eA9KjAWerlPfe4aI1L653FOl2GSsv3ID4IpuxudSDT9sY YYhloKc9o4PuGv/2v7gHE6Tp/MBLKsBUy45YU0S+yiqeULEV17vEZM0/zeOxH+32cEbK chyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736729800; x=1737334600; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0V56Sb7sqNGix6HQ1QvO1EkN6QyGEMwBCv4yPDzPp8o=; b=ualuB6x4EuMm/Qhi06S+WZhGDE150JaBWd7gkPKMCFQpWxcKEJna2G7zTf8qWs7iTv gL8N68lFRN/frGp4jJIEvBsMz8kDsE3YKkxHMCa422tteCZ16eHxKyQgnWRdYeMRrSfR g2WNRc+ylwXqlttEi4Q3shfFqffnBliSSURGNlEKaDh1dpohSYU423yTMrlYI3EnX5to RLSxubQ3UmI8pfKGbxUiLRDIIZk457HDT05Tp+2W3ZE1KTbntbxCS928CGLrcHlTCzhp GE11d6UhVy9BvbxD+fGpDCodOsbq7eqewpJYJGcUV0ZuHyNxJ0lIlgk3rGEtT4u84eUK fFXQ== X-Forwarded-Encrypted: i=1; AJvYcCUuyPEXei4ZCJmREadspN5dwR+8sIc6UWV9jOu3ABuSYlkexQvCXI6xfWhFWrrmnj67zbx12RGa/w==@kvack.org X-Gm-Message-State: AOJu0YxnoLcZzSdk+Ooi5wtGaDJympBF6Vv7Qh1uD4PvInw6HFsmJOWV U8MuA3AGYWDwuc+XbkpYm7vEGvghqhoM3V7pwrUFhokr1T85jmy+ X-Gm-Gg: ASbGncvbrrBYc/RWP/2X0okLIylYYDOilcvD/tSlJb8u1SfzFvj9mbXICfBThpvd2yH zZUoguQdCTkI1yzzE9DrYqCLHuwTbjkPzBFqEIKhfY3ysZ8ydJLhI8ePBuETw4rBuyQVZ2xb44k Y1Srewd287ffoiAG4ThzsaT0FCZuDVfD3KJn5j6ITlsDnx1dp4RBbtuZVssFeAxZhSuej5+kTlu ojIzQJunolFQU0hVLrU4+4Yucrk0JB1w4IH08dhfQSkRLK6xzRWg4yB3Vcd9ZCbEHk= X-Google-Smtp-Source: AGHT+IGzxYWm0tbkwANQHKte1ZrD6ajm4Ul4JqKrWyhZ4nm01na6Fa/9M40NPrsrME9FDL8oyW0k+A== X-Received: by 2002:a17:902:cecd:b0:215:6995:1ef3 with SMTP id d9443c01a7336-21a83f3469cmr255885615ad.3.1736729800033; Sun, 12 Jan 2025 16:56:40 -0800 (PST) Received: from Barrys-MBP.hub ([118.92.30.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f22d134sm43087125ad.187.2025.01.12.16.56.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 12 Jan 2025 16:56:39 -0800 (PST) From: Barry Song <21cnbao@gmail.com> To: lkp@intel.com Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, anshuman.khandual@arm.com, baolin.wang@linux.alibaba.com, bp@alien8.de, catalin.marinas@arm.com, chrisl@kernel.org, dave.hansen@linux.intel.com, david@redhat.com, gshan@redhat.com, hpa@zytor.com, ioworker0@gmail.com, kasong@tencent.com, kirill.shutemov@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mark.rutland@arm.com, mingo@redhat.com, oe-kbuild-all@lists.linux.dev, ryan.roberts@arm.com, shahuang@redhat.com, tglx@linutronix.de, v-songbaohua@oppo.com, wangkefeng.wang@huawei.com, will@kernel.org, x86@kernel.org, ying.huang@intel.com, yosryahmed@google.com, zhengtangquan@oppo.com Subject: Re: [PATCH 2/3] mm: Support tlbbatch flush for a range of PTEs Date: Mon, 13 Jan 2025 13:56:26 +1300 Message-Id: <20250113005626.2290-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <202501061736.FoHcInHJ-lkp@intel.com> References: <202501061736.FoHcInHJ-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 45E9BC0006 X-Stat-Signature: 7ex5repmxkttpgpdzajww1yx96cgkjhx X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736729801-220769 X-HE-Meta: U2FsdGVkX18ozPD3utx3jjSY9JdTtAJt7cjctvm63CLYSeRBV7evAQckrCATwehQ1cE8zHQrD+pz/82zpmprYAg6B9tpmCICb6/FaNCG6zFPJ1DMk0uDVxqnP2e0x7+84qixaniL74uR+pOgpuKLrI9TRhSyVP1Z8WARPaUjQDDbXM5mv1ijjoqjL1X/ryHJoxdqfetPpxMkbEKrfB3BycLQIQ5jlvhwwxrv4bYhDQjWaheUlr7nVpwLRiwaZ5UNEGQYiGdJFKNpcrbWfPTCHTMCIeaBnf8NbKM2UQxYQCLy5DqivHyLUivEUmrFSxVM3/Gv7iP2ccbsOEnSP/wJ2y2vgiK3kaBY7y7//UIchO/SWdV6RgiE+GJRmRX779Ubeo9i///BEHPMND9v00fnnU1f5mtEDuHCa69gkb42q1RxE4BaSuPu0go2RcV/EeQOQBT9mwZosdIuDXQs3fLkRHfQuel9EyhK7Ez+aSzPLcdGudWCVdpH4I6K3CiFvSpw+9b8u1kq0DX5ZiwmA/52HWLDWcDmadDE+4ldIdWllosCR3H32gSmzNtkR1Yt3GGBw1J7MgJF016LBtuJ40hVHrM9hAvOt5HDEx6Kt2nkFKCmm1n5yvb996sp3UsF78mrkKRJ0dQQk5uNGvF75Qbxc8ViYZRmlFOpJuOwlzIRqMNyGgDfOFULgFYDpufb+a0OBlDldxpDCgB9OdnEBDnnasxMxpI4akJjxeoL1rwtcALLCKYVPqTTwDFNvhK2xzIO1NAmE3bVwHRYMXB1Rt6eeSxAbbkwfeZnjmGnLnNKhL/Lkh9NF9/3Bj8lxYnmMjrWtBLQwkEdddRDhx8elJz0Ov6nJqK2snJDfQSsiU7mBCZdK2ChOqSd9tmIyNeOEXX8+8eAsY64iVVhFqLSZHG0SAmtQA2fF617r5PKMl0xZRP8bi3CMpL4hKmB0y3OPQ+UeT5QCn2YGlMoKhN/wiS JY7AOkrQ av7X1LnywG/QkS10Ly8gL5m101Lse7ic5XfnGC7TCm62UjOpKoM8yRS/+ZBZIIF+USuQcWrLGCcBZpE5v66qlLH5RAcK7jj/QdvA15oEqXboVu4LKG8WVKUURK84iS29Qo7cN0Zw2o/ZcTchzG/cQp2NloKSa0S0KXLb0s9xDcTuU4UqeXnnkpJ9EbbBPdfvtke88T/f7JJ99Z9NGy0461V7ptvmJSMC1Pw4vSfiOxLdeVW5feR79b/5QqURBn0UDcuOhLxuSb1BY85nG9B2kvzpJ35TLoiOE/TnNpLXWD6n2VZOIPEZbXUM0g7B7jJhX1CD07ZYDDRpnUF4QDhweJGgT/qlOTyji/LMqCFkGPnE+l7hFLYrvImYlLt9Mt34MNE182sUM6uz4oz4qOZ+CtzIv6pQ7Ks3W3HhBB+veF5T5ordSQ+IAX5uA4b0ZWs+Nu/F2ynoS+bReaQY9DdhAHz8y8jJcC8ELxL1ecfLx8DkvYgmBGWDJkpRL3MAAGOqj/j7ulPNFeUvgmehXG/tCUsEx9zBdhYY49VNv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 6, 2025 at 11:08 PM kernel test robot wrote: > > Hi Barry, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on akpm-mm/mm-everything] > > url: https://github.com/intel-lab-lkp/linux/commits/Barry-Song/mm-set-folio-swapbacked-iff-folios-are-dirty-in-try_to_unmap_one/20250106-112638 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20250106031711.82855-3-21cnbao%40gmail.com > patch subject: [PATCH 2/3] mm: Support tlbbatch flush for a range of PTEs > config: riscv-randconfig-001-20250106 (https://download.01.org/0day-ci/archive/20250106/202501061736.FoHcInHJ-lkp@intel.com/config) > compiler: riscv64-linux-gcc (GCC) 14.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250106/202501061736.FoHcInHJ-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202501061736.FoHcInHJ-lkp@intel.com/ > Sorry. My bad, does the below diff fix the build? diff --git a/arch/riscv/include/asm/tlbflush.h b/arch/riscv/include/asm/tlbflush.h index 72e559934952..7f3ea687ce33 100644 --- a/arch/riscv/include/asm/tlbflush.h +++ b/arch/riscv/include/asm/tlbflush.h @@ -61,7 +61,8 @@ void flush_pmd_tlb_range(struct vm_area_struct *vma, unsigned long start, bool arch_tlbbatch_should_defer(struct mm_struct *mm); void arch_tlbbatch_add_pending(struct arch_tlbflush_unmap_batch *batch, struct mm_struct *mm, - unsigned long uaddr); + unsigned long uaddr, + unsigned long size); void arch_flush_tlb_batched_pending(struct mm_struct *mm); void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch); diff --git a/arch/riscv/mm/tlbflush.c b/arch/riscv/mm/tlbflush.c index 9b6e86ce3867..aeda64a36d50 100644 --- a/arch/riscv/mm/tlbflush.c +++ b/arch/riscv/mm/tlbflush.c @@ -187,7 +187,8 @@ bool arch_tlbbatch_should_defer(struct mm_struct *mm) void arch_tlbbatch_add_pending(struct arch_tlbflush_unmap_batch *batch, struct mm_struct *mm, - unsigned long uaddr) + unsigned long uaddr, + unsigned long size) { cpumask_or(&batch->cpumask, &batch->cpumask, mm_cpumask(mm)); } > All errors (new ones prefixed by >>): > > mm/rmap.c: In function 'set_tlb_ubc_flush_pending': > >> mm/rmap.c:685:9: error: too many arguments to function 'arch_tlbbatch_add_pending' > 685 | arch_tlbbatch_add_pending(&tlb_ubc->arch, mm, uaddr, size); > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from arch/riscv/include/asm/pgtable.h:113, > from include/linux/pgtable.h:6, > from include/linux/mm.h:30, > from mm/rmap.c:55: > arch/riscv/include/asm/tlbflush.h:62:6: note: declared here > 62 | void arch_tlbbatch_add_pending(struct arch_tlbflush_unmap_batch *batch, > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > > vim +/arch_tlbbatch_add_pending +685 mm/rmap.c > > 663 > 664 /* > 665 * Bits 0-14 of mm->tlb_flush_batched record pending generations. > 666 * Bits 16-30 of mm->tlb_flush_batched bit record flushed generations. > 667 */ > 668 #define TLB_FLUSH_BATCH_FLUSHED_SHIFT 16 > 669 #define TLB_FLUSH_BATCH_PENDING_MASK \ > 670 ((1 << (TLB_FLUSH_BATCH_FLUSHED_SHIFT - 1)) - 1) > 671 #define TLB_FLUSH_BATCH_PENDING_LARGE \ > 672 (TLB_FLUSH_BATCH_PENDING_MASK / 2) > 673 > 674 static void set_tlb_ubc_flush_pending(struct mm_struct *mm, pte_t pteval, > 675 unsigned long uaddr, > 676 unsigned long size) > 677 { > 678 struct tlbflush_unmap_batch *tlb_ubc = ¤t->tlb_ubc; > 679 int batch; > 680 bool writable = pte_dirty(pteval); > 681 > 682 if (!pte_accessible(mm, pteval)) > 683 return; > 684 > > 685 arch_tlbbatch_add_pending(&tlb_ubc->arch, mm, uaddr, size); > 686 tlb_ubc->flush_required = true; > 687 > 688 /* > 689 * Ensure compiler does not re-order the setting of tlb_flush_batched > 690 * before the PTE is cleared. > 691 */ > 692 barrier(); > 693 batch = atomic_read(&mm->tlb_flush_batched); > 694 retry: > 695 if ((batch & TLB_FLUSH_BATCH_PENDING_MASK) > TLB_FLUSH_BATCH_PENDING_LARGE) { > 696 /* > 697 * Prevent `pending' from catching up with `flushed' because of > 698 * overflow. Reset `pending' and `flushed' to be 1 and 0 if > 699 * `pending' becomes large. > 700 */ > 701 if (!atomic_try_cmpxchg(&mm->tlb_flush_batched, &batch, 1)) > 702 goto retry; > 703 } else { > 704 atomic_inc(&mm->tlb_flush_batched); > 705 } > 706 > 707 /* > 708 * If the PTE was dirty then it's best to assume it's writable. The > 709 * caller must use try_to_unmap_flush_dirty() or try_to_unmap_flush() > 710 * before the page is queued for IO. > 711 */ > 712 if (writable) > 713 tlb_ubc->writable = true; > 714 } > 715 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki