From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 721F5E7719E for ; Mon, 13 Jan 2025 03:29:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 047B26B0085; Sun, 12 Jan 2025 22:29:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F392D6B0088; Sun, 12 Jan 2025 22:29:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E28A66B0089; Sun, 12 Jan 2025 22:29:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C356F6B0085 for ; Sun, 12 Jan 2025 22:29:13 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 369FF141B55 for ; Mon, 13 Jan 2025 03:29:13 +0000 (UTC) X-FDA: 83000997786.08.A51EEE4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 82AFCC000C for ; Mon, 13 Jan 2025 03:29:11 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZmnL7wrr; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736738951; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gCdpWbBE16xeZj/W5fMg+luik4Ql+dbSa/gBj+GBksA=; b=2x2vfzs1++vJfyED0VCrM+wAVJYkg7pAmRWLhf6D7SEEJ3LrxJpdPxi6/WzDK9jrJAkV3y O8ZCd7FOoE/Cn1aPu13NqVtMIzBssWzOEHWZqG16FUt3Grj7XcWzTpQDOTC64QBTyW7+GQ nkCVXRb9hvg5hMdLIhmicaZJAATefYc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736738951; a=rsa-sha256; cv=none; b=70yOmiLGC3q5v/LnQUYsID09oACU15mo8Qc0EfZp98lErIeW40n5u81C/IOX5sqPAara+k Zdjr9IN9R3wwY8S+nG+dpuuTpHFA9fO3+uyAQ9Np82qEaHOj/6bkMTfUq26XQzVTZP2o62 SUmBHSrHZ2vrZ4uhX5VD+KLfNAJQOLk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZmnL7wrr; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B23F35C05B9; Mon, 13 Jan 2025 03:28:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29838C4CED6; Mon, 13 Jan 2025 03:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1736738950; bh=Eedtq1VzFWhpYQLzQjLWXECgkfUwx0YIjmx5hoqveGs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZmnL7wrrpoWtRzdX2ws7ON9ClFuELMVsFAmAGcW5ZqQY8g34pgyqubUZTI2WrGZbK jdYJj7o0oBbR+APzEKneh8URklubSjeYJLvkqeKn8fejyysKJQjXXcuqZ1giuiRoOy xHuop8DPm4EgTc1y2biIHmtsHO8vqDh2IcY5jBVQ= Date: Sun, 12 Jan 2025 19:29:09 -0800 From: Andrew Morton To: Vlastimil Babka Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, David Hildenbrand Subject: Re: [PATCH v3 13/15] mm/page_alloc: Add __alloc_frozen_pages() Message-Id: <20250112192909.47d20c3d8c3b0c9fabb7b811@linux-foundation.org> In-Reply-To: <9de07435-73eb-4772-81c0-d95cfe3964c7@suse.cz> References: <20241125210149.2976098-1-willy@infradead.org> <20241125210149.2976098-14-willy@infradead.org> <9de07435-73eb-4772-81c0-d95cfe3964c7@suse.cz> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 82AFCC000C X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 6onoky8f6wxzmum35fcshugpt3k7ebmd X-HE-Tag: 1736738951-815811 X-HE-Meta: U2FsdGVkX18pUAY84dqwe/U0cV4c8I4h2jC1mf9xvf1QQ5Xy5WUdcXLY+fKWFjhgN4yFMfm3E5auX5+W06JZAWKTIFZSlNtSE0nAky1eqhYfNkITn8Z6kLaunY8GCwyjIFNEGvYKfc8WLMCmiqqACa5tHbx92LMwPGyMqP0I5rJ/a+YysUAyeKXJ5Bi4JuojlbrtVFva58r7JzHeWLchDD3XepCL2BApj3BLQRnnD7nTrKbGcW5P8KrnMX5A4LrUY+xDe62AI0qiO9bcGdpkYmuiBGg4qU+5O3OaN8ATgVOITZpx8URJqaJqR1ygE7xHChIbCrsiDNrHmHW6XaycCK8cmBcQJcMkJp1NS7GTbXLgXWy719oG8NW1EtDm5LjRvBQ6lN0ZLvoCJDmJTWBpr4CZGXh8WH5ObyGZoXLP1KQxMkcUDouDclrWBmh48b6rYSGw0sJhKy0PBun7OMa98ARapBTj0jSSV51LbSKXp+cjK8Bl7dF6Tjd3Xfuh4XvPm0sbI9uKhhHRcqvQXC+swrkjqWkIIWcELm18tkrlryZgUVYCNRoRxHO8R8kFcHXYVus/MSAVjn/bB+gi0SQlOlwxXKD4pplDPwF7RqGFXs5+BPYBkMjtzpkEJajdcpeWHREJ20gx/DE9Vr1PgKxqfZNNcKZWVXIINcrkzXWTiRvbC5wrodIeHX7q/2IHxSZFj/eyfa+FnbUoVKk/JeRQrSmF1FwyyjfEYmrTEpMT0QSlnhJn+dAghcQB9heVRQ2E3hizaXdkn/lp+1OXPoxHkLkDDNRe3xf3iboLKJC/ho3w/YXa2e+uAzC9OLB6wMFpl5nR7PzWw77XivH4V9pG+ylK3KsWUoUAjPPQv+fRT/Ar/LgZsTOuvn8RhegaOoC0Fd+OScGv9NUhssfXy6l41KRDePBo/hd4xs9XZKHiEglCv2QXjpeXH5fO+SDp0RsCNyVaXIwOQL+aigMUPIf OcD507C5 X41Mn3czkiTSQ0WrSgiVf0MQx1RQwUD4L472CYr6Kx48O9nkCI6coA6FUQx6DCGiXpytMqVlfhrwXKqtIizAwyQEkSLTHCCZGYwuSxB/MDw5Pgo21FjjXMi4GJz3UbrWwIRoR3sKxCyQdAFuGvk7kUfWU1eAGgLvzAlPtwm4CwKPanjTty9AySkRK2OzOUSwHjRmblgh4KkP7r74YmnnX5hte6cBbDL+/sNKTed44xatPSdCIQp88HyBlEomAfE5QVKmq/7yzc0JZb9hWLECnA9+qhx6omTV+zZ98qcOWNIH+OrA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 4 Dec 2024 12:10:12 +0100 Vlastimil Babka wrote: > > @@ -4804,14 +4804,24 @@ struct page *__alloc_pages_noprof(gfp_t gfp, unsigned int order, > > free_frozen_pages(page, order); > > page = NULL; > > } > > - if (page) > > - set_page_refcounted(page); > > > > trace_mm_page_alloc(page, order, alloc_gfp, ac.migratetype); > > kmsan_alloc_page(page, order, alloc_gfp); > > > > return page; > > } > > +EXPORT_SYMBOL(__alloc_frozen_pages_noprof); > > Since there's no user, we should't export. If a user appears (I can imagine > e.g. KVM), it should be EXPORT_SYMBOL_GPL(). As should have been the rest of > symbols here, but oh well. I'll move this into mm-stable, but could we please address this at some point?