From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14281E77188 for ; Mon, 13 Jan 2025 02:33:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 836576B007B; Sun, 12 Jan 2025 21:33:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E5796B0083; Sun, 12 Jan 2025 21:33:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6ADA86B0085; Sun, 12 Jan 2025 21:33:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4B0C06B007B for ; Sun, 12 Jan 2025 21:33:43 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C3DFD43204 for ; Mon, 13 Jan 2025 02:33:42 +0000 (UTC) X-FDA: 83000857884.09.0774EAD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 02EEAC0010 for ; Mon, 13 Jan 2025 02:33:40 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=dnOWtYc4; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736735621; a=rsa-sha256; cv=none; b=QVgAniVCF6rwSfKQAe5YvOrywPrc8BiUN9d2Md8jxnF4lcZtlDsh1fNXAdIMPMGPU6qqKA FpjPrt5bdOhr67hSh2PqtFcVZHTBtWsG0bjA+33HgwRiaIWKnB2puCmdF8EtazpL8CSYwQ JRh9RxOsXWw/OW/NoZxSsN2oE8w+ANw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=dnOWtYc4; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736735621; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Bwwe8EuTVBtvBY2f918HRQkRXd+Z7LHxPMBmR5/VYNo=; b=vRt9ivWhg9b/c/HK+Wf2hDBSLtLTWATayIzLdiWRcVGYTL2Ed+QZR2WpVQsiovfUeknFq4 nX+9SWRmFgB2Eflzzn5qqBDocJVu4r1szXNJ7zMJwe9w6fFLn58Ma+KNNnT+fJ3chFhL0+ 23+tMUbNhiPJaEMbp+IeI4TmeLAuT+M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 05D255C4333; Mon, 13 Jan 2025 02:32:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60AA5C4CEDF; Mon, 13 Jan 2025 02:33:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1736735619; bh=KbF0qP1vSxTPlYtBDXYKvVDalbRHDTGiPiqpYchnszQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dnOWtYc4TziA7MoLTdmdSwg6qD3dSEVeWyvWxz2Mwi3lekmVcCtr5WyyEVBj2R8K+ I0T3x22YDhK5/F0bwgokYtm53Spbui6sM6E7MWsLf0BRCnn2AXrCaGASE1OZHoS/ri Q+/S/7BHMzssSIWJoSjq0QMAVI22lJmb4PWq8dkg= Date: Sun, 12 Jan 2025 18:33:38 -0800 From: Andrew Morton To: Randy Dunlap Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Frederic Weisbecker Subject: Re: [akpm-mm:mm-nonmm-unstable 171/173] kernel/kthread.c:913: warning: expecting prototype for kthread_create_worker_on_node(). Prototype was for kthread_create_worker() instead Message-Id: <20250112183338.0ac4e721a48829afffd16073@linux-foundation.org> In-Reply-To: References: <202501122249.upmy4970-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 02EEAC0010 X-Stat-Signature: oc1pgdc7bbuf6f7zcque1rjmmj934o3d X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736735620-288178 X-HE-Meta: U2FsdGVkX1/yImawCyTxc+aj1vBguvSdluLHWQvZnzpu09o2XMZerNMGj1ElTzI0NwkCUfzxMlDDa4E6tbjcs/jS2swWp4wgQ/BVmH+4l+Gqk6wpda9cjibrHJ14xQI1FGHCWSfszPTXvv/8lWwS3oJ3qVT64zSGOLottKg+HAOZDN/JEHGDAcoz0ene7k1pKZIfmJpfTdG9Ja3cTgTaj9zPOLL37p//OVDEwQWdnwW9twuxy5aNdQ+7oNcVK4/L0IA48eL/CI0xlMmQ1CMbte07cLnpPZqQRUo18DSDj6qgW6tjTi4fjOu6v3qtk4yDgzghYbXnUfw4lQAHs8nkAhbtE4ec3iCnxnlit5Rhr9OGrA4nPWhyNc1PCeqy/JsNyvR1cAacZltJpOFDbh7fHfUbkrUxSfMwpxcCkpZh1ReybrFF0nmS0RNXEHn62ruiILTAW1OQDGWc46rz3a0vUbgXzLTAOJBh1Rvew9DzSCcCl4SYjNWIVV3DtvzZXYn4edsAzw13HyXlPEe2/AhELQxEWJz5UeXI+FiHmvaQXDAQejKxIRWs1kVCJzSwcUnrJqP2iXCMEjs/rYIfZJvWbOwOn7jOAQ0WUm6TkNhquwfZpJh7yhSpMsCES2ikOe5wRL/WSzG9nHq4oYffeL/6UAHYJ9ghYO8wu3SQMM3p7npsCVwGOTR/y95RjWMKgzeUMvLtmeLyvFarFkzoU02d9B2ZfLh4ahUJqz6GM3eHj+o3P+5r7Xh1pOdHEeipQdmEs5thTfp9inEdF4pC2ki9rkQti4ES7xhWKCzRABrMG6mkdIpW0TcVNh3p4pXeUGODor1h5MO6YJsaMfHXvGTCZYTnlIaWHd24t5YVuoj7UF+NGb3YFjosjkO1OaiuTIZOkDSHdDvhJOXJ9v3aAj6x4tbftSt+pKRJpgdfvn7u2DxYaJdj5AQcDJ5M5xSMGf3gYW6pveCDZ5p9Trg1m6C t45N2p7W pLhJM45CEY71L7EyFokyU13BohpNeaX2YMigKEUbQpAvfs1veR/cgHWSdzm6eQQtDvXrb8e9d7zqYRv20QsoG43nifuaStrSCyr7xAkr/ui/0Ni9sPh5NPkLEFlrCYx+V1DTbfDmPuXzAIrBk8WYMuS6XcSyoGUvINlKM7QZ52chqdoet1VCjcSYqSSRSb1OF+6lsNnpFkuTeSpRb/l6FRx8pYqg2IBFjZNCKwbMwhbOF4MeyQxqTGgP+apH5rmlIKf1ERVoKzci09lQ+ArCzjfDXyy/Y++WS0gpqrTmq4YL8pZwdOXGOtB5rHDnXcEwNw0H+ay5MtVknOzAg4c6Zezxq89HJbGlzwW/9pF406U2DaK8ez9jrcWVR8XYRnEaWMaXqEjZOv2T2syyxwpBPX2zklycUstbSjODhASRkS2ExXBCRk+QnLolCbw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 12 Jan 2025 10:21:40 -0800 Randy Dunlap wrote: > > > > fbae2d44aa1df7 Petr Mladek 2016-10-11 901 > > fbae2d44aa1df7 Petr Mladek 2016-10-11 902 /** > > 1bc3c5db9becd0 Randy Dunlap 2025-01-10 903 * kthread_create_worker_on_node - create a kthread worker > > dbf52682cb0286 Petr Mladek 2016-10-11 904 * @flags: flags modifying the default behavior of the worker > > fbae2d44aa1df7 Petr Mladek 2016-10-11 905 * @namefmt: printf-style name for the kthread worker (task). > > fbae2d44aa1df7 Petr Mladek 2016-10-11 906 * > > fbae2d44aa1df7 Petr Mladek 2016-10-11 907 * Returns a pointer to the allocated worker on success, ERR_PTR(-ENOMEM) > > fbae2d44aa1df7 Petr Mladek 2016-10-11 908 * when the needed structures could not get allocated, and ERR_PTR(-EINTR) > > d25c83c6606ffc Petr Mladek 2022-03-15 909 * when the caller was killed by a fatal signal. > > fbae2d44aa1df7 Petr Mladek 2016-10-11 910 */ > > fbae2d44aa1df7 Petr Mladek 2016-10-11 911 struct kthread_worker * > > dbf52682cb0286 Petr Mladek 2016-10-11 912 kthread_create_worker(unsigned int flags, const char namefmt[], ...) > > fbae2d44aa1df7 Petr Mladek 2016-10-11 @913 { > > @Andrew: I don't know how to handle this. My patch applies correctly to linux-next > where this function name has been changed. It looks like 0day is applying it > to mainline linux + your tree(s?) for testing. It appears to be a fix against Frederic's b1e125dcbcea ("kthread: Unify kthread_create_on_cpu() and kthread_create_worker_on_cpu() automatic format") so it would best be carried in whatever tree holds b1e125dcbcea. From: Randy Dunlap Subject: kthread: modify kernel-doc function name to match code Date: Fri, 10 Jan 2025 22:30:08 -0800 kthread.c:1073: warning: expecting prototype for kthread_create_worker(). Prototype was for kthread_create_worker_on_node() instead Link: https://lkml.kernel.org/r/20250111063008.910712-1-rdunlap@infradead.org Fixes: b1e125dcbcea ("kthread: Unify kthread_create_on_cpu() and kthread_create_worker_on_cpu() automatic format") Signed-off-by: Randy Dunlap Cc: Frederic Weisbecker Signed-off-by: Andrew Morton --- kernel/kthread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/kernel/kthread.c~kthread-modify-kernel-doc-function-name-to-match-code +++ a/kernel/kthread.c @@ -900,7 +900,7 @@ fail_task: } /** - * kthread_create_worker - create a kthread worker + * kthread_create_worker_on_node - create a kthread worker * @flags: flags modifying the default behavior of the worker * @namefmt: printf-style name for the kthread worker (task). * _