From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3F4CE7719A for ; Sat, 11 Jan 2025 23:45:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEF6D6B0089; Sat, 11 Jan 2025 18:45:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D9ECA6B0092; Sat, 11 Jan 2025 18:45:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8E266B0093; Sat, 11 Jan 2025 18:45:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ACA896B0089 for ; Sat, 11 Jan 2025 18:45:23 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 35D9DA15CC for ; Sat, 11 Jan 2025 23:45:23 +0000 (UTC) X-FDA: 82996804926.17.EB1FC2B Received: from smtp134-31.sina.com.cn (smtp134-31.sina.com.cn [180.149.134.31]) by imf15.hostedemail.com (Postfix) with ESMTP id DB048A0006 for ; Sat, 11 Jan 2025 23:45:19 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of hdanton@sina.com designates 180.149.134.31 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736639121; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q4NYUCNiJ9ZHO4mvT7MqYqh9yk6WCQX7Q5vMiZd1hYU=; b=6nZO+/gdqELbYva+IIXCQLgfHsOw5pdiIuQqlKyXn4SH3Zpyk/NpOuMG+la7uWe0VRAbkD lX9RuNUX+KreScpGITxO30CkYCeRuNbdQ0cCN8SwJ40VpZHgmRzeBA38Y2V3mn+1igJfb9 lgUeBtW/dTY6Xdjv7+zTGkol5y4+MGQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of hdanton@sina.com designates 180.149.134.31 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736639121; a=rsa-sha256; cv=none; b=Cd4n5jhy9NbntwoN3A2P1hL+dofN/niS5Xvp4DAbBiwx+XBpkQGDy+OUEE7z894JdFBpvx 43+PazRclSKz6obaBuhLC8H7WfcrUs+dygqMy+tWRgywKtom1YxzMv941OwDjokhOjaQkn rJhiyeVoIKELON/uaKe5Dr3NqP9SDvA= X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([113.118.69.152]) by sina.com (10.185.250.21) with ESMTP id 6783028600004C1F; Sat, 12 Jan 2025 07:45:14 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 222563408369 X-SMAIL-UIID: 495635CB69394426804E48B2206A60CD-20250112-074514-1 From: Hillf Danton To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka Subject: Re: [PATCH v9 10/17] refcount: introduce __refcount_{add|inc}_not_zero_limited Date: Sun, 12 Jan 2025 07:44:59 +0800 Message-ID: <20250111234502.1739-1-hdanton@sina.com> In-Reply-To: References: <20250111042604.3230628-1-surenb@google.com> <20250111042604.3230628-11-surenb@google.com> <20250111063152.1638-1-hdanton@sina.com> <20250111121320.1656-1-hdanton@sina.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: DB048A0006 X-Stat-Signature: g93z31eg5fyuzma51hd3fkm9aikpumrj X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736639119-497296 X-HE-Meta: U2FsdGVkX1/6KY7WCv1rbvwGx7keOMcDtNAp8vaBr1lQHeXT4Xrf98RFMMIw7PVbQYiFABUz7D5UT9i2pZkBBjQzmAO5PQwfMDyK1ZrL60DjVInlZNfftwaEFr0dqKrCNM/Lffj8xJinm+tSqk5uMdqa1y8DxW9cow+49F8SrXkN/h4q3IgGVSpoRVMLDrGWxmTvq2N+bCs9PmenKX9sn9t5m6G/o2LfY/nd2KTLlmjnpYPG+HVP5nYHnYwtYcLgWggwKMI8YyCYrDZJ1k+rcA8gY6PiMAlr9au2YEK4tCxzcArBfzmMtqym9WLqrbozL+BNBiLVS7p4O4x8+LDhm5TmAxj2Egorae3BEtzPVk/ClXN0MEZC8VvDQPNw0AKhzlRuJVACbX3sai/QJ/Rj5283HGmVbZ17vYLIlAqhs9Hdy8+uVVTp6RzPBlVbNfNtzXyrv2CHO6gpFpODec0qSimZ+8G6owMgQj/FrcO38T30dwpwoIF2C7Ux+OIo42DXQOOLAco9w54t9sioT7rZC1pvQuaSEVdkq0lv09zpNXypxlgWF3ot6xaMG1q5Du67w5YHK0F9uQQYwMTeJ+hyUUMqK9DGTPLS3N7kKR/NX6nPXVp9eRlMq6bM3KzFGjadJNCEb8GIUC2QgKFKzMgZOu3o/CVRAdV3xnjwkWv15Q+p5gRFh0bbqcRGGNSm6ChwMe0Jbxf2ksESwVyBmjnQzXcMsHQexzMsQ9YRgjHIvtpBbrOIEhrDViGo1MK0ZwUNndppHmeJGb94W+VPfRdnlC4m/+T9LoD2oYiA8ipfhGiHIGuiwRSqg72LQApNqEG5Wmc6JBh3CPVgVJAmp52/O8YPxIWl5QH20UjAEwI4rtNWVKfy7ihM7+yr7sY5+WYt6t/6ymh1e32PAMFAEZuOEv/9Yts7J7r7e1RvT4o5LOxacDxJddIaB08TtlChbQnIjusVgqUQuLAP3wMLe0v TmAHedBZ tyN5I1tuTm+NrH+3c2ux+SamyAoHvNvYf+QHqnb/76wTv9P59/hlpa68phhFSjRUBwuu5FRY/HLGYFVa0noYzRokRMVux5Nc+Qr1Ayfdu58P0nEUR855RGFFBk4M9TzGHUQZG/Lz8ezbprER7zcG0rQ9g6o6Wcp2jvZOSXaULwXFd8EOPqKwSTkuHofPEkQT5WnL6rdqy9BW31n3fpKmnME9R0cNEjDB4ESGb X-Bogosity: Ham, tests=bogofilter, spamicity=0.001190, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 11 Jan 2025 09:11:52 -0800 Suren Baghdasaryan > I see your point. I think it's a strong argument to use atomic > directly instead of refcount for this locking. I'll try that and see > how it looks. Thanks for the feedback! > Better not before having a clear answer to why is it sane to invent anything like rwsem in 2025. What, the 40 bytes? Nope it is the fair price paid for finer locking granuality. BTW Vlastimil, the cc list is cut down because I have to walk around the spam check on the mail agent side.