From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9150E7719A for ; Sat, 11 Jan 2025 22:19:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55BC26B0085; Sat, 11 Jan 2025 17:19:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E3F66B0089; Sat, 11 Jan 2025 17:19:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3848B6B008C; Sat, 11 Jan 2025 17:19:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 161E06B0085 for ; Sat, 11 Jan 2025 17:19:47 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B0D9F441C7 for ; Sat, 11 Jan 2025 22:19:46 +0000 (UTC) X-FDA: 82996589172.18.EC4FD2E Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf14.hostedemail.com (Postfix) with ESMTP id C1214100005 for ; Sat, 11 Jan 2025 22:19:44 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VOE2r+Ss; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736633984; a=rsa-sha256; cv=none; b=H2hjgly+4PzZmNeZZGUX0CNaFtyofUWRXScLlJswJZsOPO2YqGndLcd1LWtvi5MzT58qZw KzBfNhdNiF3qqlewf0cf+1e4QP+GLjYwwEU5EdbpRvPuXTgLpisoIWxI68zs1s4ccX4k+u tqbh+RVURYtRYtHzVFp2BA6y8NMndlM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VOE2r+Ss; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736633984; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mIvPyEsdWcc7PrrnQYVuWIV+U0hbxqd2iRUelJDmbp4=; b=Q9gLgwEQndDhXOI15URne627ssrRkVY9pf46VYlI0WZWgw5kQQtHges5Qw9Joh5OJv4b81 ljt6TGEkul5NNnQaXNA8Qx6/Fjh/eQu4HC4daU/+FVNTgLo+5gBRP5djnJoMGkkSHciUHu OyRct5/bMdz6r4Zi9CCucg9NYiuNY0k= Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a9e44654ae3so485722466b.1 for ; Sat, 11 Jan 2025 14:19:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736633983; x=1737238783; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=mIvPyEsdWcc7PrrnQYVuWIV+U0hbxqd2iRUelJDmbp4=; b=VOE2r+SsJvHi6sQaR245RgpzEyIeoYBUwFpcKjccOGVcPofIkbRhpcmkJmF+S5Lzth 6XKnClwqJljrzJnbEyD0+GV8qyIimBNo6ypSLBUj6+vEh5jh47D/zJNz8ZmzA9YKRanH Ufp36zhPe9AxktWWh6yoq6RfscmCGvZTpB/btncbcbwWbj+qxktIf8iU0A79eYhCDyEx 0rmZYjBpIz2u4Cx0ZOE4sslHib1g37Psw0icObKKevLyMXDziWVUQey/f9ys4hLG4ooY 8khOXNHElNDaOTOSqLhTZJx5k5lrz0qug4TrdP5IglbSJ639ouEuzoxslsTWM76bDlXM vLaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736633983; x=1737238783; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mIvPyEsdWcc7PrrnQYVuWIV+U0hbxqd2iRUelJDmbp4=; b=O2IQBkr1C6mfDVwrEWEe0HSWHhE3U5RkIoBAPFkrX3Nx36HjCh6Ximsth0gQS7219A W5jwMNhIvNt3aVU4p3eXr8tki1y0IFYAKhdSa2/mnj0OezTx/a3of4YsOWNJVSRKl338 fbQkcapE8ZVjXqyYVKAx9TU+kpSrQqfXp07GVygoBEQxdVNq9Tzk/V/I9pltKhGXKNR5 02GN7fiVh7oZ3R0n6bC10BMLRA+sMa8QTpVYfFErRzymLqUQ6Y9vX7fhLlwFhcYJcCqS 2V9wntln4K01Yu87s35U59eD6kcytkJ98IndChrH7GcPb2Vv0C95LXjNQqzAxsUTItvL 1vHw== X-Forwarded-Encrypted: i=1; AJvYcCWZmVU2G5OqqbD5xpy3N2E6PDEtuhKY9mO0FQ0KBL7PNlNgATLd1oD+ExLN4WwUEuNALWexRq3lug==@kvack.org X-Gm-Message-State: AOJu0Yyrx5dQkUz0BND2PUWNmgQKlFiRLIz9UIqhP4lLX8ri3RgMrZxH N15f3vBqJxlu3WFi7PGruhNgxcjrV1+CBOhPqKD9Ofjv40+C+oxn X-Gm-Gg: ASbGncsV97TorsRtphJ2piyEizVKhbFiZN87fmCyohFDNy79jKG6sO04Vw2aFBf+d+u p4gkSLz08AYFEoJo0lfbu+Mj/NWf9WcJd5pw3QOqEjSUHE4Pxpol9Rk1k6nOSXE3/cA5G7EM+Vj wA0D9hOO4DmsZiahm3NkD/C47Va5zRhWGzPDvJQSik55JLWCAqb3vxSQSNOFZLeKuN21tzwO0kl MU7ITql6GCdqlb+/zn/0JgRouVaQPUbU8ClQ0whivcD6PrLaDlnn9NHKe/rwwuznmOLXDJedike /nyYpmcb4jb0cSRQzLw= X-Google-Smtp-Source: AGHT+IHlUgypIRT8cmPyfu1CbpbExxV+JECs8Ye78qu5DL0IregbmFFgcQX4wO1y5cazvG3p9v+Zsw== X-Received: by 2002:a17:906:ef0e:b0:aa6:3f93:fb99 with SMTP id a640c23a62f3a-ab2ab74ba27mr1566197666b.36.1736633982743; Sat, 11 Jan 2025 14:19:42 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c9563af3sm313885566b.105.2025.01.11.14.19.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jan 2025 14:19:42 -0800 (PST) Date: Sat, 11 Jan 2025 22:19:39 +0000 From: David Laight To: "Paul E. McKenney" Cc: Suren Baghdasaryan , akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, richard.weiyang@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v9 10/17] refcount: introduce __refcount_{add|inc}_not_zero_limited Message-ID: <20250111221939.3a36908d@pumpkin> In-Reply-To: <9086dca2-3d53-4147-abc8-bf2d1cca0b5a@paulmck-laptop> References: <20250111042604.3230628-1-surenb@google.com> <20250111042604.3230628-11-surenb@google.com> <20250111123900.643e4b49@pumpkin> <9086dca2-3d53-4147-abc8-bf2d1cca0b5a@paulmck-laptop> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C1214100005 X-Stat-Signature: j3u59cqcm4r8ikptpy173jhn6sskdupb X-Rspam-User: X-HE-Tag: 1736633984-917097 X-HE-Meta: U2FsdGVkX1+j4huFdilSz99HP1kXgFr1tgow5Ne6/1R3J6oDjAtzgEOdl0/lO8VpJQB18w5+1irWMg0kAZX2b5kFcmT2jw5GW9B/ElK/c5fFgLDC6rvFa8z+UbH3/Dh/To6KpmaSsPQO0ilrU3Rruy/U2QkWZk66plAujoiRssn0st7GMxzI+TP5q7M9/fddm7End3xMh4C8baxeiPN+fL+diYxPFANRulIZ92827IGyI9G1aS+jAaY+RAk4Sm2pTswbN5QIJx0NBXIzbH/Xy2Q+4GcYNTQzFwKcVcZSRtc5YTReib8M7Utls2GsKJPrGB4AEmS9wTJGrPlAaedL7crQmKJrQ5UioYkPHnwKgC4Jz4UdTvZ68Miz11gXaFg8dXB0+3zdCdwGLh1uI53ZyBGzRSoM/N3rlZU4bSy5/KOJPohzsDFQo4U1wVJ0H3BiU+P/ErWf6hM8webK44E+/ayY7+ZPDfg6gRai6FVqWJZdsvrbZ9yLzDIT6HQobQRgieCEmTeWabsOEd4aWKHTfVj1V1lBoCBpWVLQGo9J74T9Upm29cjkROKHhCWiTqY2RLkZnz6YeyhSPnOBv7sdijoJeb1AptMhAF9TE8HWWsnojaqwfeSngakbuxEeffE7oI63Ugjm2phCjg7aZOyZiWNSMp991/4THx4wLgHOoLaF82UlnvNRLGNFTkHmW8SSLPRBNtNjB8tHtSnKMNzPRdAjFlwy34o46BO+8tpYqbiNtPnOoe/IfzKGCzSD691xlp5lcjY1gBjB5fE82ftOLPDBT4pD3IpYMWg6cIq1xyW424Ru8t5MvGIjkB7as2Rw9qHjSE1bBhkEvxB/ZJYpf8cGY1MecaP+kI3duw2xII6SRSoJk2Ya8bh/0/w+rBcJoJnWTGvknSwKKeqtuh9p5BLgNERapEyVjPaozle3O9mjP9A877o7/eqmCOrROG0YJUTdTapD/UuVFWaBMFU SOsQnBzP yt+khec+ZZA/ol5hcOKl3j+2QuBaHJkNWQ/Znra7S0bF/WbVAsoclQEHEw9QwcS24KRad4aO9I7gXJsWFROUMdM2KiwCftRmhXLKcIUUW1HSXIRAf0Zvy/VUguv1QUBv0WDHSOMjhwQwexvsxu884Sy7fq9TgC8dvfp+NKrEd/xlwrp1tbNNIAwcLRbfSs5ovy8GCRcawbzoPp5bv957bmndPrz4QGx31cn6Wm4ZveydAwfnyP2EeEYigvMmUxnhxa9bYgmU/ZWkjC3uU3eEfJX9ztWl2y+6iQU1qt52NmyjiddOSXL3VdLu5PVxIP9PQ4JSJ/Sg3U8xMSeV9yulnotfjTQZt922vavLM9tJVAbFX5HNPF2w+4WVOEF/CM0ylb+EW87Kcbu+K94B4AVOTDYHNQdU7cTh1OAMuCnh71YqpwnxFYyhHRnHxN72L0XrSMEA9zEt/QJtdJEikNS1ITbcQ6RNrBdVp4NE+O/Y80/5RshmSLxoEFdVT2HDs1sTqVGXbOAe96DCNJaAIZrWpUNArUx4k5pOnSN72fPFqEnueUcfOpr9g9pE+ennkOkaBvjLIcecECrmjNLc0TSVR4u/fKu+oN4N3LA+P+SkCVagT9uxafa3UoJ0Rtg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 11 Jan 2025 10:30:40 -0800 "Paul E. McKenney" wrote: > On Sat, Jan 11, 2025 at 12:39:00PM +0000, David Laight wrote: > > On Fri, 10 Jan 2025 20:25:57 -0800 > > Suren Baghdasaryan wrote: > > > > > Introduce functions to increase refcount but with a top limit above which > > > they will fail to increase (the limit is inclusive). Setting the limit to > > > INT_MAX indicates no limit. > > > > This function has never worked as expected! > > I've removed the update and added in the rest of the code. > > > > > diff --git a/include/linux/refcount.h b/include/linux/refcount.h > > > index 35f039ecb272..5072ba99f05e 100644 > > > --- a/include/linux/refcount.h > > > +++ b/include/linux/refcount.h > > > @@ -137,13 +137,23 @@ static inline unsigned int refcount_read(const refcount_t *r) > > > } > > > > > > static inline __must_check __signed_wrap > > > -bool __refcount_add_not_zero(int i, refcount_t *r, int *oldp) > > > { > > > int old = refcount_read(r); > > > > > > do { > > > if (!old) > > > break; > > > > > > } while (!atomic_try_cmpxchg_relaxed(&r->refs, &old, old + i)); > > > > > > if (oldp) > > > *oldp = old; > > ? > > > if (unlikely(old < 0 || old + i < 0)) > > > refcount_warn_saturate(r, REFCOUNT_ADD_NOT_ZERO_OVF); > > > > > > return old; > > > } > > > > The saturate test just doesn't work as expected. > > In C signed integer overflow is undefined (probably so that cpu that saturate/trap > > signed overflow can be conformant) and gcc uses that to optimise code. > > > > So if you compile (https://www.godbolt.org/z/WYWo84Weq): > > int inc_wraps(int i) > > { > > return i < 0 || i + 1 < 0; > > } > > the second test is optimised away. > > I don't think the kernel compiles disable this optimisation. > > Last I checked, my kernel compiles specified -fno-strict-overflow. > What happens if you try that in godbolt? That does make gcc generated the wanted object code. I know that compilation option has come up before, but I couldn't remember the name or whether it was disabled :-( You do get much better object code from return (i | i + 1) < 0; And that is likely to be much better still if you need a conditional jump. David