From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 195A7E7719C for ; Sat, 11 Jan 2025 01:45:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 980676B00A4; Fri, 10 Jan 2025 20:45:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 909496B00A9; Fri, 10 Jan 2025 20:45:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A9F46B00AA; Fri, 10 Jan 2025 20:45:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 58D486B00A4 for ; Fri, 10 Jan 2025 20:45:45 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 07FC3120FA9 for ; Sat, 11 Jan 2025 01:45:45 +0000 (UTC) X-FDA: 82993479450.15.BD7F523 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf22.hostedemail.com (Postfix) with ESMTP id 563EAC0004 for ; Sat, 11 Jan 2025 01:45:43 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wDyltxgA; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736559943; a=rsa-sha256; cv=none; b=tRavoyCvdXOcA3FPzQx9Ji5SQcZaqttQpXW7Jzi5wVSTuFF40ziwn2wgvkhRtVyFfs6sp5 U5Fzx8ZLdP/rQZpaIUqVUFfRz8L3VCVQ1F4RChNRUXXoABfQt1IuIiud9hNY3nCFfyLQxv G7teppo1+ib0yat9522fjaA+9DtF0dk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wDyltxgA; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736559943; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NF0yx5As0u+CCvAAiDVA+lDim/ovMyMzrIRqJoiPIpo=; b=iZ3GcjU/vX6WNd9/TFCYTrHw8n1Pk3GtxbgPiqEEnFmlJNQycaRaotLGtO47guwwcXLczk RcmWuU0uMvQCNdJYQIXsuOgBvrADJ1on5UTv4JWmUggMCUoRE0oKGKwvCagFWcQqWEULVE ue9/QNUL96uKu8ScTr131qmLmz7EsC0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 36E6FA4281F; Sat, 11 Jan 2025 01:43:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F38E1C4CED6; Sat, 11 Jan 2025 01:45:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1736559942; bh=nBnDsOoHXQcYFac7WyKXVagOjHw6E4ylabSU1vqZAf4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wDyltxgAluBWKfsJvy3vcIBZ65Hdx8jr9A+OMbO67UhDeGxIRwdBf/YcgOx1fVmUh JmGnsL2pAe6Ucwug0fuAZEN2fZBAfyfsCS7utZDpqQ3hbegAF51oNey7/y9GDzfGNu g8wHTXoUQCtAJSq1NuR7+plDwedi1bS2c+Ot4P5c= Date: Fri, 10 Jan 2025 17:45:41 -0800 From: Andrew Morton To: David Hildenbrand Cc: yangge1116@126.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, liuzixing@hygon.cn Subject: Re: [PATCH] mm/hugetlb: prevent reuse of isolated free hugepages Message-Id: <20250110174541.bf22caf1afa227b9a76a7e4c@linux-foundation.org> In-Reply-To: References: <1736477766-23525-1-git-send-email-yangge1116@126.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 563EAC0004 X-Stat-Signature: oss6ce3nc9whrqbj3u36639epf9796cs X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736559943-232332 X-HE-Meta: U2FsdGVkX19SUcpxqg3IKmB+0cuH+BiGjkrjHXDHw9H2YdFx/RY1ZImMqfmiss068vFGqxBhZ3qrUt8QtO/g4amHuwI77/rROSZ7jJJYHmKFH1LxpaPHYRk0iJj8YkygKduW737SIakZUF6d+WcU2vCvZQRC2IRf8HcX00V7TCvl0FKSJ5Bv40uTI73wizvSd5KZ9q3vuyUA4WMqHecP4E6YW0qemycNgNgl77RV3zTAC8wInh5Gp9JSk+ZBLMwF55FgCNnZzqBuDowkd3cx5atMDuQGA8ubtXC0aISe2PeScrZXAiMtwqYcqYJowMSroSGr8nXKhdGO4aTpwZ+xZTwEbfsyneT+QIk+CkzKbeC734z3O1OieZTV2adSIlePxPvO8hjfkPGMUbw1svOplCoRyRQB80gGT7Vzt1EM3tbSAB/ffuv+hP0viBlxhkhP4HRO6hQ6zpzDr/W7d8tdVaBd4gDh9y7EHIq+YLgt8kmKNYsEGekqIr65QYtQMJBshFbP1M7Xtrdca0A/kL5jMxu8MG6cHcbcGQeKKYyeDODztgI4NsQLhU2iovEuUQ6VTLwJemr5RIM1KNJoAtT59Y2CvRbN8hBuIry0xASrMOu6hFggUnlkIbBMbFxOOv3P+FWUROj62u2+NjOmZOYDmmJTJmQc6abo/T+CbA4ZFjjKOzEpNdXwoymLw/8Cqm1FTXCj4aIq2ZrcsFl4mE8K4g7PXY+XdLohFSJIsqM7tcwohID23YM1Urot4UHkwyiAvGHaLd3wWPgOKv9c9PodJnf63HnjEMyN+f7ldNf3K9PE/x5Yx/CjjI2SxwXbxar3xMmLyodAsvYa7FrSDSp2aQB8cVYPZPdT15jEJ0WXdTqmdYzhpiLwHA2r9aWo1zrf3ErixT1J6hKG6tv65iGlj59gwUDUVf4rDNJRcD0ErC1nl7O2bCB4wAEKC+p7c8GOvgAnO6ic4/e3iK7nlcd ySHoqxpF HEGjjBKt6SXDdj9DFwgdCkf2bAVc5BaIW4lHFtRLm6DmTZ4LZkdwMLMZsGk0LTFSobR89RBt/10BUwK49dYHMJdnE/elLdTSgvjm638cdp/6/FJGDN4/JMuQzn6dD+SxOu82lNLzFFVDO+fJh3h4rQ6uHz7YiXgzuAJkvAFCWgYSzc2zylz/K+GlJoEmi4dgrpzVTctZISL3JvVGzetc6jSGc4Ek4FAPfAtw2BUVM0Xg9M+tPlCfJzbnd8MpCpHhnsJIsdFIx3nAq0CJtAdO177aZR0hHppyw8oy/OVrLNmbnPmu3AsqVvXLXtgC6I7xP+D9pM9ncVrwmanyJIWj5HkqxwHZcdDbfz9CL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000154, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 10 Jan 2025 09:14:47 +0100 David Hildenbrand wrote: > > To migrate huge 0, we obtain huge x from the pool. After the migration > > is completed, we return the now-freed huge 0 back to the pool. When > > it's time to migrate huge 1, we can simply reuse the now-freed huge 0 > > from the pool. As a result, when replace_free_hugepage_folios() is > > executed, it cannot release huge 0 back to the buddy system. > > > > To slove the proble above, we should prevent reuse of isolated free > > hugepages. > > s/slove/solve/ > s/proble/problem/ > > > > > Link: https://lore.kernel.org/lkml/1734503588-16254-1-git-send-email-yangge1116@126.com/ > > Fixes: 08d312ee4c0a ("mm: replace free hugepage folios after migration") > > The commit id is not stable yet. > > $ git tag --contains 08d312ee4c0a > mm-everything-2025-01-09-06-44 > next-20250110 > > > We should squash this into the original fix. Can you resend the whole > thing and merge the patch descriptions? I queued this as replace-free-hugepage-folios-after-migration-fix-3.patch. But yes, a clean v4 with a redone changelog would be a nice thing to have.