From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5005AE77188 for ; Sat, 11 Jan 2025 01:32:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB14C6B00A6; Fri, 10 Jan 2025 20:32:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C38696B00AB; Fri, 10 Jan 2025 20:32:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB21C6B00AC; Fri, 10 Jan 2025 20:32:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 899AC6B00A6 for ; Fri, 10 Jan 2025 20:32:39 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1AF01A0FA4 for ; Sat, 11 Jan 2025 01:32:39 +0000 (UTC) X-FDA: 82993446438.29.AFFC483 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 6ED5740006 for ; Sat, 11 Jan 2025 01:32:37 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=AmSiph8M; dmarc=none; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736559157; a=rsa-sha256; cv=none; b=IOpr1/z3GiYrWerU01swem2i8LoctICcFRJLCOTM3eOjvMrNFCb7pbmNGYEHC/ZfniTjQ1 YQQadHNYkAAGbm/eFXM+uiZOMDtX3FpodgifNWlee/G42LOjhKazXvYKJFUw50PziLDDF4 ObwoQvZ4wcTePfwOTmckBBOEBfLWiiQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=AmSiph8M; dmarc=none; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736559157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O5MW3mhZJkH7ucILzz+KbkyagRYvoQ60/AsLTIzAtXo=; b=rAmvfRnln5JinBS33SJdAzmzvc+EWotq0ePqQZFMGLczn8GaRo1fShT7tYTu5qsiN4yLlz 7sOdB0tTUjeHs3hjHpFv3vB4I9thtzPqJzZ0ImP42npF03KNQ+sSIn6UApwVYCCuygpmMt H5/LjoHnc+lqXTmzc1hDxU5kweTgjos= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BE3DF5C0613; Sat, 11 Jan 2025 01:31:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18237C4CED6; Sat, 11 Jan 2025 01:32:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1736559156; bh=Naa1MueS6NKXmsJ32tHtZbRquKuKd/mWpNqbjYykXhM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AmSiph8MXUpxNGHN0rScykUIS0fsCdxYututft1+Lac3Xfzzr4UUikQrxiHZU19ms KTB9flxL1S5uD0Y7hh10+ivP1Kiu1vYQMi7OTkXN2BSCVQIEt4ROT4LPSuP0G8ql65 9kIkV8mXvJsRCR/vHt7k2piLKUmcVEO/dIevk6ZU= Date: Fri, 10 Jan 2025 17:32:35 -0800 From: Andrew Morton To: Hyeonggon Yoo Cc: Matthew Wilcox , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kernel_team@skhynix.com, Minchan Kim , Sergey Senozhatsky , "linux-mm@kvack.org" , Vishal Moola , Alex Shi , Alex Shi Subject: Re: [PATCH v9 mm-unstable 11/18] mm/zsmalloc: convert reset_page to reset_zpdesc Message-Id: <20250110173235.5b7e6ca5beb189a1270627fa@linux-foundation.org> In-Reply-To: <2c4596bf-ee80-46fc-af87-d564b90c5110@sk.com> References: <20241216150450.1228021-1-42.hyeyoo@gmail.com> <20241216150450.1228021-12-42.hyeyoo@gmail.com> <2c4596bf-ee80-46fc-af87-d564b90c5110@sk.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6ED5740006 X-Stat-Signature: 7tjgybm1hz75dmqim8tz94ahd1pwddfe X-HE-Tag: 1736559157-439989 X-HE-Meta: U2FsdGVkX198LzEX80nh7MrOltkUOWmUq5sfHBv9oFIMvEJl9h7A2sk+1Fu6FFU1zLc/Yf8p6BdF8kKPVvifGZqJ4nEWtJT9ks3tvnfHWXQHx8enxACI2KzP7Vx55L5yYZy713xgA3vesCt6qIySC6E9Pf2D4i808BynfzJoqN0dePQbbK7HIb8KfZZzJZKS/3U0/jvOL9hVm4Hhs8Fd78JXs/eaQLjlR/n6xdbd5k4krJLkTTnUy4xP7LmixZq9Mn9zBeLtVngLohtlFJFFX6OoMVsECBeORVfs6uWp/ZMtaCSQC3MLBN4SMSREvOCF825m+dSdFJrArIC0QrRs73yL12aZEtFwV2fakcuBrPQa/pP6S1GEa6bEEqPna+caZVso+o/GW9xhVzB54o4I+CMeLSeaaa8Lxbhtz7YW3ih0T3P/jAKXbz4ZNVBlEaY0J9XOWyWYvmDH73NMSsKBzSRE3gOAMXwmY5iV8hnLTVlW8uNKXUw5xOFHaWdGBQsO66OrvyGCZvzOnWz1smYYFPBlNpk2XaExN2xpKNLp8gA2pwBN+NCLcgIyj2nBz/gMr56LLu09QhzQkjgTHUdL0ANk26zmiQZvb9Y1R7fwLxdlfqq1HOTWu7ahgA8oX6K27apayi8lZ7FnpuEI76dSpV557qHLjhrX+p5wGesWTEtsJDpjZrVZN0LtFKsgQcgRXaqaMDhgXxadWlNV7oZSpy0ebtc44JY/BPDSeO+xfeCBensNOvZN4hkpR9GvHDa6+oNMxsbr2eZM6xr+j3T3/l1rUlJaxeki4muLA6hxljBAv6OZuDpeaWTlZ7NpoK3Wd5pVO22vZiB4wgEFtjg7X8egHf2mxj+Vj+1LcXRDpkebc4X2xpa+i8wSNIRumcMRxwIHTD4MhM+im7lyQMU/HbkXUqClL7KOrdashS6ir6VZ/Lw5HElBxWH2XBaD8m8nmOWVHisJrn26DNqe/bn dgFmoSMf jVlv65YYMfMrw5+S4i2QGw3etEmureBJJauUmGRo66cn38AZUek0XeGDVNE4C5u83b/nGYGcj1nEbjoplbRbWQTS6w0nwFw5v2gXkcN7jY77UbqNip2wudE6ajy1MwE5EVEvcShESDS6EW8LLXxPi+pk/YSge4t0K8tm5XWTpqGTmzO4/T4N9hnCkPWgvc1pIokKVDIC1pVqsxv4tgoxS0I7zMyVOR/UcKuxdkECJpmAm8OhCVHKZHjoCTAjcJlNgGsvJ2xMnxmtxxWZeBlumViu2OwPTVNh2q8z0OUFjwNgumd7qgFskAcNMPJFj/Mo7U/qJukFC88s6aeu88g3zjTVrY1UIpU7ZLzG61kt+vyKZM6RhaVRm8mcS0Qtz8cgc4+4nDFWAqsrsfKAs75P24FbgYWKy2EsjHD5hh2G63A0lZoembbQFVmBtQO7Dfj6vThTRc2kuGXJrndUZHRh/CFtAfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 10 Jan 2025 15:08:44 +0900 Hyeonggon Yoo wrote: > >> [42.hyeyoo: keep reset_zpdesc() to use struct page fields] > > > > Ummm ... why did you make this change? Now page->index still has a user > > in zsmalloc ;-( > > Ohhh.., my bad :/ > > I was thinking of a situation when someone re-arranges zpdesc fields > and forgets to reset the field that overlaps page->index now. > And when writing it did not consider that we're going to remove usages > of page->index anyway... > > Let me fix this - will send an updated version of this patch or series > (whatever way that is convenient for You and Andrew) A little fixup patch would be preferred at this stage, please. Or a new version of this patch, from which I'll create a little fixup patch.