linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	damon@lists.linux.dev, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH v2 00/10] mm/damon: extend DAMOS filters for inclusion
Date: Thu,  9 Jan 2025 09:51:16 -0800	[thread overview]
Message-ID: <20250109175126.57878-1-sj@kernel.org> (raw)

DAMOS fitlers are exclusive filters.  It only excludes memory of given
criterias from the DAMOS action targets.  This has below limitations.

First, the name is not explicitly explaining the behavior.  This
actually resulted in users' confusions[1].  Secondly, combined uses of
multiple filters provide only restriced coverages.  For example,
building a DAMOS scheme that applies the action to memory that belongs
to cgroup A "or" cgroup B is impossible.  A workaround would be using
two schemes that fitlers out memory that not belong to cgroup A and
cgroup B, respectively.  It is cumbersome, and difficult to control
quota-like per-scheme features in an orchestration.  Monitoring of
filters-passed memory statistic will also be complicated.

Extend DAMOS filters to support not only exclusion (rejecting), but also
inclusion (allowing) behavior.  For this, add a new damos_filter struct
field called 'allow' for DAMON kernel API users.  The filter works as an
inclusion or exclusion filter when it is set or unset, respectively.
For DAMON user-space ABI users, add a DAMON sysfs file of same name
under DAMOS filter sysfs directory.  To prevent exposing a behavioral
change to old users, set rejecting as the default behavior.

Note that allow-filters work for only inclusion, not exclusion of memory
that not satisfying the criteria.  And the default behavior of DAMOS for
memory that no filter has involved is that the action can be applied to
those memory.  Also, filters-passed memory statistics are for any memory
that passed through the DAMOS filters check stage.  These implies
installing allow-filters at the endof the filter list is useless.  Refer
to the design doc change of this series for more details.

[1] https://lore.kernel.org/20240320165619.71478-1-sj@kernel.org

Revision History
================

Changes from v1
(https://lore.kernel.org/20250107201739.79484-1-sj@kernel.org)
- Correct wrong comments and documents about pass filters without
  successing block filters
- Rename 'pass/block' to 'allow/reject'
  (to avoid confusion with sz_[ops]_filter_pass)

Changes from RFC v2
(https://lore.kernel.org/20241227210819.63776-1-sj@kernel.org)
- Wordsmith messages
- Wordsmith design documentation about monitoring-purpose usage
- Rebase on latest mm-unstable

Changes from RFC v1
(https://lore.kernel.org/20241226221445.78433-1-sj@kernel.org)
- Fix encoding issue on the last patch

SeongJae Park (10):
  mm/damon: fixup damos_filter kernel-doc
  mm/damon/core: add damos_filter->allow field
  mm/damon/core: support damos_filter->allow
  mm/damon/paddr: support damos_filter->allow
  mm/damon: add 'allow' argument to damos_new_filter()
  mm/damon/sysfs-schemes: add a file for setting damos_filter->allow
  Docs/mm/damon/design: document allow/reject DAMOS filter behaviors
  Docs/ABI/damon: document DAMOS filter allow sysfs file
  Docs/admin-guide/mm/damon/usage: omit DAMOS filter details in favor of
    design doc
  Docs/admin-guide/mm/damon/usage: document DAMOS filter 'allow' sysfs
    file

 .../ABI/testing/sysfs-kernel-mm-damon         | 13 +++--
 Documentation/admin-guide/mm/damon/usage.rst  | 54 ++++++++++---------
 Documentation/mm/damon/design.rst             | 33 ++++++++++--
 include/linux/damon.h                         | 15 +++---
 mm/damon/core.c                               | 12 +++--
 mm/damon/paddr.c                              |  9 ++--
 mm/damon/reclaim.c                            |  2 +-
 mm/damon/sysfs-schemes.c                      | 32 ++++++++++-
 mm/damon/tests/core-kunit.h                   | 14 ++---
 9 files changed, 127 insertions(+), 57 deletions(-)

-- 
2.39.5


             reply	other threads:[~2025-01-09 17:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-09 17:51 SeongJae Park [this message]
2025-01-09 17:51 ` [PATCH v2 01/10] mm/damon: fixup damos_filter kernel-doc SeongJae Park
2025-01-09 17:51 ` [PATCH v2 02/10] mm/damon/core: add damos_filter->allow field SeongJae Park
2025-01-09 17:51 ` [PATCH v2 03/10] mm/damon/core: support damos_filter->allow SeongJae Park
2025-01-09 17:51 ` [PATCH v2 04/10] mm/damon/paddr: " SeongJae Park
2025-01-09 17:51 ` [PATCH v2 05/10] mm/damon: add 'allow' argument to damos_new_filter() SeongJae Park
2025-01-09 17:51 ` [PATCH v2 06/10] mm/damon/sysfs-schemes: add a file for setting damos_filter->allow SeongJae Park
2025-01-09 17:51 ` [PATCH v2 07/10] Docs/mm/damon/design: document allow/reject DAMOS filter behaviors SeongJae Park
2025-01-09 17:51 ` [PATCH v2 08/10] Docs/ABI/damon: document DAMOS filter allow sysfs file SeongJae Park
2025-01-09 17:51 ` [PATCH v2 09/10] Docs/admin-guide/mm/damon/usage: omit DAMOS filter details in favor of design doc SeongJae Park
2025-01-09 17:51 ` [PATCH v2 10/10] Docs/admin-guide/mm/damon/usage: document DAMOS filter 'allow' sysfs file SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250109175126.57878-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=damon@lists.linux.dev \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox