From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10746E7719C for ; Fri, 10 Jan 2025 00:12:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 599926B009C; Thu, 9 Jan 2025 19:12:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 548416B009F; Thu, 9 Jan 2025 19:12:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4100A6B00A4; Thu, 9 Jan 2025 19:12:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1DD6C6B009C for ; Thu, 9 Jan 2025 19:12:51 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BC8E11C6828 for ; Fri, 10 Jan 2025 00:12:50 +0000 (UTC) X-FDA: 82989616500.30.13DDA1F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id E561EC000F for ; Fri, 10 Jan 2025 00:12:48 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=crfQ6j27; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736467969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PbJzEUaYgW14meSH8vF3YuqyEOxUw6B8Xi8jhimJpkc=; b=ruTbTrQFgiuT/L9H0CP6HaveCP9oDbS9DQBKpKO68nFp2/MN2gPG2zZnlbhmUJdkXcA4V3 NRAYj9CJ5f/afNlZQy3IRoj0z2cd9+5AlWXJll7aMMVMHo6+Ny9zZafTgYEUK9X4SBkfxD 8F9eMNi9iy+5ymySLFab25Qcl7YPuB0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736467969; a=rsa-sha256; cv=none; b=hr3R/HKa5zFS2YMJ7fsoMxfmUS2GYpOQ22OrqQrvZMiVVoXduV2mBwGErKTz4Ttw3IisBt 4BS6lzpX/J4Miz9EKLo3An0o6Ha9YlJQ+2ah10MUYx5dAg5/k2APh2STygOCdgudD0QSKJ mmTQ4Ba9cVjftidBBEtyPGLVn/hVkmg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=crfQ6j27; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BF9975C107A; Fri, 10 Jan 2025 00:12:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AE7BC4CED2; Fri, 10 Jan 2025 00:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1736467967; bh=rDQeTjvQwRT/nd2YKdWqi0hN0vLQhu/Ejz9wMqiJcf8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=crfQ6j27WeD30Pi802j0+AyXq0ZC/rlOe0CWzx+J/JrxJkzPmNdBOl9okCHgB9LSi 5L6zS3AGRm7mhb0wcabOZGIGDobM1Py0faj9ri6mq5xuTBWIWoib4VZElMJCtNCw9v 0uNEpjQi4/BPkrkD4r4eljJBWYEWEKZFjCw1+hRY= Date: Thu, 9 Jan 2025 16:12:46 -0800 From: Andrew Morton To: Kees Cook Cc: Muhammad Usama Anjum , Andy Lutomirski , Will Drewry , Shuah Khan , =?ISO-8859-1?Q?J=E9r=F4me?= Glisse , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel@collabora.com Subject: Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters Message-Id: <20250109161246.f43a69773b5459e5200d3f45@linux-foundation.org> In-Reply-To: <202501090949.793D9A0@keescook> References: <20250109173842.1142376-1-usama.anjum@collabora.com> <20250109173842.1142376-2-usama.anjum@collabora.com> <202501090941.5289E7444B@keescook> <843bf743-4005-47bc-9e39-8ea49255b152@collabora.com> <202501090949.793D9A0@keescook> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E561EC000F X-Stat-Signature: mhpqxfnptsi6ahqfb48y49z99454aypj X-Rspam-User: X-HE-Tag: 1736467968-119499 X-HE-Meta: U2FsdGVkX18gDp33pFd6V6FZWOpD0kJu2VlawMTXyQfacpw4OCgdHPNWgWF/3hOoosqUn9PX4gYT3cv6tJT9Y9XgoYNKOhXHzIy8pQx+KDoVJzIjHRaZ4GQnVtkRvlFCG8boCwTQ9tEvR0R0zhzlGLwhzmbjm0KsBHiuB709GFJXbIfctkx5vUqEHWyjbPZzWqzPNfHwdseHQahN0cY6fbvTYFgPGGGhDwc9kALCerVcns7wZrqTF1Fp1kN9OWxIBGMzKEC9kBCFb4jrZRSAyGUY5sU4ZPe1vgaKGcl4uIcLkmEbOSQry2Q1YaEVcyO1U+aml6sqT0szuUqh2DzlvxhafGhlMNxsDJugk6kPvjtzAHJyy9agAQDIqi5Iu832tVZpQtOtiBl0JCsIQoQAWkvXsiU0bs9zrobUmfSgVomSnXijOrvZ3XZ2zoYJIoHoE9dwkeu1GASlB3c469qVXomh9d5nt4q9TB+ZzhfLeKVGgn7XCZQMTEU1qRviROjwZQlsHwsKF+9HnIGrxGPZUA70xPX8JIoxhHPY0gW+DLC9+8ycRttE4/mx8fuOhTC3UYE6OQ86VypitdU1M0gCWTgxPjbN7em7gKtFuIhJxdAmTbEsR3+tiFHOnep9k83wR9VuNAdmEkat6Sm1akvCaC6MfD9rOr5SJ8xpbbtHl1de3cVAQDj5feqJVVlnhFJ1Cc7Wxc4TNGEyjZdOO/UPRaL3IIcJ8cowTvlr3guL0JWK7SF7uixrHhFx7aUpNzdJC4u+kyVclCwW7dVRZdkFg/BVxsDq0WNaaQCcKbdN5bxpXqAeNZlekVYPwqogriJlgasoBHOcJZBdqeXTIQ9pOcrQ1+Dpfy4cp2WRzfIc63K5DBXI1FYLXartCG3TspzI4Rv4eqWoQdE+Qe6c4Qt2mQgvawMzREtC30ucAhtQS659jXJut1323CLR8y32kO6o4yQWBCtZyzJqS8HcCsO azH8yAWJ vQALLrBYl5OoVQLuy9T8KiTgs23zSzV2l3qyh/BfM3h5RDqHw0UdUfCVn4QEYKO5Ai9mUMbedZMXv8V0/fY0VTLraJ4p6R1Zj4PaOIkRDTjNpLqZdMlXHObHedgha4JXI0OlLPV7WxPnGFONl+a8KSA2uTraF3e3GXsXNVWd9vuRsc3j/IrIr8SAbzlZhNEqrIW37nVLyMwmSmHLpJnCLFMa0/HsEthn2VAwNBkeNCZi5TFqEa7zCgEdHfQgHAbEEvJltUtTAW75IEkTOIErbAmAyexonI7xuiI2JoHGItwYYK4w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.027003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 9 Jan 2025 09:50:45 -0800 Kees Cook wrote: > On Thu, Jan 09, 2025 at 10:48:52PM +0500, Muhammad Usama Anjum wrote: > > For the all other case, why should we keep argv/argc and mark them unused > > as well when they aren't being used? > > I'm fine either way, but my personal code style instinct is to keep the > "standard" main declaration with argc/argv present. But it's mostly > aesthetic. > > And if you think use of kselftest.h isn't universal, then perhaps we can > avoid the macro, but it does seem nicer and more "normal" feeling for > the rest of kernel development. > Agreed. __attribute__((unused)) is a bit of a mouthful and isn't what the kernel developer's eye expects to see.