From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 215EAE7719B for ; Thu, 9 Jan 2025 15:51:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 957486B008A; Thu, 9 Jan 2025 10:51:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9108C6B0092; Thu, 9 Jan 2025 10:51:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77E936B008C; Thu, 9 Jan 2025 10:51:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 593216B0088 for ; Thu, 9 Jan 2025 10:51:58 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 19B721601EB for ; Thu, 9 Jan 2025 15:51:58 +0000 (UTC) X-FDA: 82988354316.10.A623071 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf18.hostedemail.com (Postfix) with ESMTP id 3EC0F1C0006; Thu, 9 Jan 2025 15:51:56 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F9BSlQcx; spf=pass (imf18.hostedemail.com: domain of djwong@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736437916; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aLvwPrq2OgaU0a/cBhR7BasCwOVkoEZA5e8ZFXYAKgU=; b=6MV9NM9+NYRk8MVNWjAi/SeY/RUDyMPOrC4PB3tg1JozJ3GM4FDCISKtaEUPMJzHmICTJy qBb42/OUVFBZI+eEg7RHmdtXAMzqwrcButRr1a/Qdm0gAwEqlWD9eTTPvsagtH42WZRGg3 mThTx4yEK29Dm3BfwhF7CwfmExvUQkQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F9BSlQcx; spf=pass (imf18.hostedemail.com: domain of djwong@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736437916; a=rsa-sha256; cv=none; b=W0W0+Ch4RlR13hxgg4k45KMJ/+9t+mpgNMl4KIVehUd0RS40OSt1VH8sDwHov6m2X1+RDf qL8kjSXCWsqqOA6uCRnll4hDfnPJEbZga7TKr5ZzAX9691b4MLljpXVhnE/VvZ/pOe7S7j atkItjYwlXX/PkSHPgGVvcrYJB29LTg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D378CA420AB; Thu, 9 Jan 2025 15:50:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07E5AC4CED2; Thu, 9 Jan 2025 15:51:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736437915; bh=4PNW5U1RCpwSI6ed5qCmkDfjxSB39XjXAAnaje7o+L4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F9BSlQcxUU/kvrDz8ezVoOO+s/YBhBI99DBGbLdRbteRKBcsdBNKhfA6NIrkjDYkC 9GtrmQ7VK0dv7qDBCLFFprwhk5flkxmRl+V2FYyKWlDlaQk5dy/y43RuJc1rAObSVE sl7FszvwCJ3ZWmJ3LwoRXHehBmq48TqQ4/nOFcPMPAGWGxlPfP39p5Evt4580Qxykh T6IreW5JxdI40u2aiQRRvDdYRS5jpPoTlnD0T3RTnaN10Mg41YwaqUaSESqRhF+j/w 8yWPU7z9RguVCtFoKzz3OeFzncyxzknkL/0P6P7tlQkSO/uCgw6CAfTy6ch0j+etXR 6KWhdTwfzx9bw== Date: Thu, 9 Jan 2025 07:51:54 -0800 From: "Darrick J. Wong" To: Joel Granados Cc: Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Kees Cook , Luis Chamberlain , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, openipmi-developer@lists.sourceforge.net, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-hyperv@vger.kernel.org, linux-rdma@vger.kernel.org, linux-raid@vger.kernel.org, linux-scsi@vger.kernel.org, linux-serial@vger.kernel.org, xen-devel@lists.xenproject.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netfs@lists.linux.dev, codalist@coda.cs.cmu.edu, linux-mm@kvack.org, linux-nfs@vger.kernel.org, ocfs2-devel@lists.linux.dev, fsverity@lists.linux.dev, linux-xfs@vger.kernel.org, io-uring@vger.kernel.org, bpf@vger.kernel.org, kexec@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: [PATCH] treewide: const qualify ctl_tables where applicable Message-ID: <20250109155154.GP1306365@frogsfrogsfrogs> References: <20250109-jag-ctl_table_const-v1-1-622aea7230cf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250109-jag-ctl_table_const-v1-1-622aea7230cf@kernel.org> X-Rspamd-Queue-Id: 3EC0F1C0006 X-Rspamd-Server: rspam12 X-Stat-Signature: i4oz4c58cdt3rn6ggcssu7knxdogab6g X-Rspam-User: X-HE-Tag: 1736437916-635553 X-HE-Meta: U2FsdGVkX19ZgZOQ59Vjowk9Ah1ZQ2cLvQ3qwWX6Dz0X5mdrO29l8F8am6YeNAakK5IxhPjcB9++k3FjAFZOHNrEhcyWFdy4jrx/egJonynwv0yd5lGDe59ipNbR4PXXBWT9uixSI4DVggGMI4yUFM6Z84za8Eb6rruo/s70LJNuv7a2gA2QY9OFw0+LA6yh797+zoWq+5j/9rTfdzWjYlpn+yp5eQM14sGSiN6pZDVaDTW7sQ/+Z73l/20Qe8pS1wAmwcaewFw1fvEYaMPtSXfQrTLZViEvS+089PIOX5bYkVapY8VadyWkbvrwbWngUeXRB76OFcKqV3wGK5oWvaEGgR2kOXGGiRHnsO6ttOkGUYot1mrkUq1uYh0rQcABS1Mv/nQpOHxZf+GARsTokpWGfFgU8HWZXC/sL2j6+lfc+HsmG07NBEQ4Ucz8L6KBm7L9jVlg7rRGjnu8KXdSDGLBbgG+szusS818jyDa05UlESrHyQxmsMRWKhB6ogKciZB9Di3ej0m/xwLvLnfLXSVUI3XIURJdpclglXcQ3INPjLpYAltuIKpDCTRP+DkJ/nbRTiHh73uqmAohu30LH25SFp3A/SscxFlIIDvKLr1wh2bOQq9QhgKsS6fJcuNAJzT4d2PXpdRxQMPHg2usiem8zlXnR51TtbaMXFdV088rciPYJTS5bpzl3eaCSiZ1mJQ5+5QS+debyjpMYt3wqyXK7sKvs6+f+DaM52KCSvoeKCTQ5uqfB9sehgjTlJAMPOxPj0op0abMpjmE7BU80hqrHRzOdIxs2VhylT01e4iFlMRYXzQIWPEzqabQM4lbkrB0u9Vcr9sb3T5mKbjsc7nb9fyC00P57Z6HuF9EWq4pWPo357dqTMGzhIHKpzJCdHl1F+2QfxESSxBpUQkl7QlQxeT2TWmq+fOWov9eEp++rirde8zNXy5GFTETTXh82GKIRqpmMEP/MDlghwu F4UTsZso ZznA61IKGS1a2zaY+WKJ7jw9fwRrsJk9HSyoysqGwBhdDfCfIXNEL2lB3hOneeWjKxPOWUgIGlGfjI4q2LAuL/6vx0EWhVBBbf5QUgh6kHcFqkFOcNisFp5QT+PHY/YnsBNH1Crh0MDsktrEoAfEpQSxr5SyUyRc0VAW332zf3Y4yc84yOK1a1h35NUDcnuIAUR6FuGdGtIDxtQps/NgjKqy1yZGZJztSoHvnaC7Ae44x77lRp8QQODSeC6XsKJycBWgxcgfQfed61fKJXu7PAOIYvjYGDbjI5XJIHhe5wrJcjKgkneiAbMKUtcvFPoaUOSrdrL06rCEF4q4wsQ3sofxmprw4P3O26ypZozzDmJCG/Ow= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 09, 2025 at 02:16:39PM +0100, Joel Granados wrote: > Add the const qualifier to all the ctl_tables in the tree except the > ones in ./net dir. The "net" sysctl code is special as it modifies the > arrays before passing it on to the registration function. > > Constifying ctl_table structs will prevent the modification of > proc_handler function pointers as the arrays would reside in .rodata. > This is made possible after commit 78eb4ea25cd5 ("sysctl: treewide: > constify the ctl_table argument of proc_handlers") constified all the > proc_handlers. Sounds like a good idea, Reviewed-by: "Darrick J. Wong" # xfs --D