* [PATCH] mm: Remove PageTransTail()
@ 2025-01-09 15:22 Matthew Wilcox (Oracle)
2025-01-09 17:22 ` David Hildenbrand
2025-01-09 17:27 ` Zi Yan
0 siblings, 2 replies; 3+ messages in thread
From: Matthew Wilcox (Oracle) @ 2025-01-09 15:22 UTC (permalink / raw)
To: Andrew Morton, linux-mm; +Cc: Matthew Wilcox (Oracle)
The last caller was removed in October. Also remove the FALSE definition
of PageTransCompoundMap(); the normal definition was removed a few
years ago.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
include/linux/page-flags.h | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
index 691506bdf2c5..330929b6e062 100644
--- a/include/linux/page-flags.h
+++ b/include/linux/page-flags.h
@@ -894,21 +894,9 @@ static inline int PageTransCompound(const struct page *page)
{
return PageCompound(page);
}
-
-/*
- * PageTransTail returns true for both transparent huge pages
- * and hugetlbfs pages, so it should only be called when it's known
- * that hugetlbfs pages aren't involved.
- */
-static inline int PageTransTail(const struct page *page)
-{
- return PageTail(page);
-}
#else
TESTPAGEFLAG_FALSE(TransHuge, transhuge)
TESTPAGEFLAG_FALSE(TransCompound, transcompound)
-TESTPAGEFLAG_FALSE(TransCompoundMap, transcompoundmap)
-TESTPAGEFLAG_FALSE(TransTail, transtail)
#endif
#if defined(CONFIG_MEMORY_FAILURE) && defined(CONFIG_TRANSPARENT_HUGEPAGE)
--
2.45.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm: Remove PageTransTail()
2025-01-09 15:22 [PATCH] mm: Remove PageTransTail() Matthew Wilcox (Oracle)
@ 2025-01-09 17:22 ` David Hildenbrand
2025-01-09 17:27 ` Zi Yan
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2025-01-09 17:22 UTC (permalink / raw)
To: Matthew Wilcox (Oracle), Andrew Morton, linux-mm
On 09.01.25 16:22, Matthew Wilcox (Oracle) wrote:
> The last caller was removed in October. Also remove the FALSE definition
> of PageTransCompoundMap(); the normal definition was removed a few
> years ago.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> include/linux/page-flags.h | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index 691506bdf2c5..330929b6e062 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -894,21 +894,9 @@ static inline int PageTransCompound(const struct page *page)
> {
> return PageCompound(page);
> }
> -
> -/*
> - * PageTransTail returns true for both transparent huge pages
> - * and hugetlbfs pages, so it should only be called when it's known
> - * that hugetlbfs pages aren't involved.
> - */
> -static inline int PageTransTail(const struct page *page)
> -{
> - return PageTail(page);
> -}
> #else
> TESTPAGEFLAG_FALSE(TransHuge, transhuge)
> TESTPAGEFLAG_FALSE(TransCompound, transcompound)
> -TESTPAGEFLAG_FALSE(TransCompoundMap, transcompoundmap)
> -TESTPAGEFLAG_FALSE(TransTail, transtail)
> #endif
>
> #if defined(CONFIG_MEMORY_FAILURE) && defined(CONFIG_TRANSPARENT_HUGEPAGE)
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm: Remove PageTransTail()
2025-01-09 15:22 [PATCH] mm: Remove PageTransTail() Matthew Wilcox (Oracle)
2025-01-09 17:22 ` David Hildenbrand
@ 2025-01-09 17:27 ` Zi Yan
1 sibling, 0 replies; 3+ messages in thread
From: Zi Yan @ 2025-01-09 17:27 UTC (permalink / raw)
To: Matthew Wilcox (Oracle); +Cc: Andrew Morton, linux-mm
On 9 Jan 2025, at 10:22, Matthew Wilcox (Oracle) wrote:
> The last caller was removed in October. Also remove the FALSE definition
> of PageTransCompoundMap(); the normal definition was removed a few
> years ago.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> include/linux/page-flags.h | 12 ------------
> 1 file changed, 12 deletions(-)
Acked-by: Zi Yan <ziy@nvidia.com>
Best Regards,
Yan, Zi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-09 17:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-09 15:22 [PATCH] mm: Remove PageTransTail() Matthew Wilcox (Oracle)
2025-01-09 17:22 ` David Hildenbrand
2025-01-09 17:27 ` Zi Yan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox