From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0F06E77199 for ; Thu, 9 Jan 2025 12:34:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEB146B0082; Thu, 9 Jan 2025 07:34:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA03E6B0083; Thu, 9 Jan 2025 07:34:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4C8C6B0083; Thu, 9 Jan 2025 07:34:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 89AE66B0083 for ; Thu, 9 Jan 2025 07:34:05 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3A3811C9012 for ; Thu, 9 Jan 2025 12:34:05 +0000 (UTC) X-FDA: 82987855650.20.5299706 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf18.hostedemail.com (Postfix) with ESMTP id E1FE91C0012 for ; Thu, 9 Jan 2025 12:34:02 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=OBJrs7n9; spf=pass (imf18.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736426043; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zC24gEoKY7o0cyYHKnhih9i9LV/2PfvFg5/BIbGabCY=; b=cLhf0Ee+LhwzinOQ4W12VdBBb5MIxha0A88ji9scMutYRugaeYb8SnIb5QyUvT+E9BFUZq 1yeBoGEM/0oAGOqQjUsOCa0HQRdOFM4kwFQM3jV8dxBeXzNzRcnViIJ/jEpSpW2ngy4lD+ Spf9u5YqvxHvUVOHtl1jOa+NKMs1+Mo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736426043; a=rsa-sha256; cv=none; b=XgdoP0AHFBoHvZ8XUfBHacGW3hb89W1Tuc64AYUhLMoXceghaGP0XNSZ0HLXZudVDRxUpb r+Q+KCqYjjLtqTAyN6KhAsQer37e4OOaCiccOkidkV9OdcpMKPdDQBlr5Kr+vpKifkKyDH cVB1fUfoR8SQXC2rsLTfSBA2OyzG0aE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=OBJrs7n9; spf=pass (imf18.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id AE42B40E02C0; Thu, 9 Jan 2025 12:33:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id axfxdHjtJrxR; Thu, 9 Jan 2025 12:33:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1736426036; bh=zC24gEoKY7o0cyYHKnhih9i9LV/2PfvFg5/BIbGabCY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OBJrs7n9ekrVigZkybghYD28bUH42H5g1FA+vX3ZrmFuSpTFThRHkjwfq5Zmoo68K m3aGQkw2vQ7lo5204ZF0LzhnYFOE8FG5fSMLnyNHHe7depL8X766cz5d6ryxgRoNTH ouTjmPMkJ/fdZ0sAaB6CS0E8X8UPPhtSQnRDdDfCN1+Lcl4we+I3nA9F9joLWNG7B8 spXGrZNZaTZErRkSzOkrBR7fYYeH8O9i/n0YoevuI+osdljP/oDHBPvk5XxzoEISRo wQoFKg4NAkUiVatLCW6X77ISKCiDYdgTDmeZ2i8JZgTFlGB1K/AVJ+0uZ55nkz7e76 4h9Fwimx9lrUsSrD2m0pC6a3qaYJFUrMhJlhPeTR7UCe4DH2KKRaOVLqlacr6E5IWe QUPtPqOxX/lzIAOP1tIDwuAWdXXjz1xyOM1sLim7g2SQkOR5xDFQ0qMOuiG/nZdXLj KVDIph65vu5rFtQ6hI4psno8IAqfCSSmYG55P/XiOeHqE2/uz4g6WfaZ2VrZ4hByE5 +0kQo9EFxTJ6pA+U8Y8+jlRxscPxNmX2MLkCIOvwXwH+sawqW/h1VNMZjZleXHasDN M+uiu8ON/hu5qIi3xL7ryFHJR1AMAUEa37rr5yR5oTP+aI1aH8LxDkkuSO+c/xqWfm jg3eU85kZxRE9VKafXEJfz9Q= Received: from zn.tnic (p200300ea971F933C329c23FfFeA6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971f:933c:329c:23ff:fea6:a903]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7E0B940E028B; Thu, 9 Jan 2025 12:33:12 +0000 (UTC) Date: Thu, 9 Jan 2025 13:32:22 +0100 From: Borislav Petkov To: Shiju Jose Cc: "linux-edac@vger.kernel.org" , "linux-cxl@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "tony.luck@intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "dan.j.williams@intel.com" , "dave@stgolabs.net" , Jonathan Cameron , "dave.jiang@intel.com" , "alison.schofield@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "david@redhat.com" , "Vilas.Sridharan@amd.com" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "rientjes@google.com" , "jiaqiyan@google.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "dferguson@amperecomputing.com" , "wbs@os.amperecomputing.com" , "nifan.cxl@gmail.com" , tanxiaofei , "Zengtao (B)" , Roberto Sassu , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm Subject: Re: [PATCH v18 04/19] EDAC: Add memory repair control feature Message-ID: <20250109123222.GBZ3_B1g3Esgu1-MPi@fat_crate.local> References: <20250106121017.1620-1-shiju.jose@huawei.com> <20250106121017.1620-5-shiju.jose@huawei.com> <20250109091915.GAZ3-Uk3rkuh38cQyy@fat_crate.local> <3b2d4275d1d24dbeacee0f192ac4d69b@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3b2d4275d1d24dbeacee0f192ac4d69b@huawei.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E1FE91C0012 X-Stat-Signature: izscifmw7ks7nbnfxw3568hcahibuz14 X-Rspam-User: X-HE-Tag: 1736426042-812628 X-HE-Meta: U2FsdGVkX1+DAjTyellOVDwZ9v1OdEKIplPG0iKeAq0r4E33HVkZTePuR901/kBHF17IXEdAe7/6zBo17KERD2Ylyl30fRd5/02epnFTeHWEJjGtB+uPkXSZUFeQryNob6Fnp4xf4bqxkwt4w2UnQubE/iOBEgBKDmrQPCmUyWoYIgYVpwaaNegNSWTfvVJ8U/kAZsd8LDvBxLCendvnSqB12LWlz1ecXrobYUGjmW4pa/6hcDEsbwLEUQo/72egX7+TE53h4ESah+r8XzPq7Itrrr+fZdlF1y8GGaYBVyRwMR3OJY+J2nQ1T0nFBPDD4/fBQsv/BDu+w1Xdgw1KkB4WLTY7Xj/Hx8tbhGaUcJoAbvCTiXYrNc1sI89ABoaTL/F3cMoxpuuc4uWH92CknZp5HgrteXAe73EWWrQGhDBqACxxnmpUq3Asmb7yQCERR+DVNQ9K7LsbGf/O3a2c9U5+BEqOqh3totwV2xAqSIaxIhGFEAHgtk3JX9uJ3+cmupkaiU0EXVl3W34Hh24cfMMxEAVzZ7iZcFfUrFfdt6hAmm6YIS5QWfEphuJkZDXZex4i9LGJaczq9MPJrmKc9wphtxgtZHvcef8aReNad1ZH8RkzzcXcY0z25qEOLSEbdvD6PoqMZA9S5wnhuognc5aAXIHtoeXfnxihW33CAhDs7YEziWXSYQa5dbCNlPK8VytsPxfwp23M8PU9c1SJvIW+RYm45AwJ9OOQ4ACml7Inh5xxcRB3//u/wF9n5zFNAUO8n7TO6l9HoWSk7WQ4LOsZ9gGX7idKHj+dPVItFE+d1rbDPkEaoPCIB0rVhpuCt3QrRPd6byexsuExVdqV0skDFNMomvVGb32MJHg+Ow7QGEv+g9M0yrMIXVMyt9ChkSu9bIdnwKBxctZIU6oUQnWDhkfTDC0IdRGEBNSj2s3faR9HmFst059cz7vZdjkPHaYGGixsRQfdSM9L5L9 ys8CynLl 7aUb36w9J3FSShu2YLO6pFk1sN8xt9txMUjcUsUY3kfRoSJd6zl4FJ9gq90zU630Mg0azPnEMLQpkStjRk0BBzj22AbmJSuTojCyOkrKoJ+vR1Z/Pbz68kt+ibKf2RoZGgOKVovLFy58e0DTlatgMO5OIVTrSmcpTpGJja6W/vv19OMCCaZ87KVc80ZHiEickXDUUUl+ca04mqnq3LC75/1fOsYR0xw9dbCS8Nn+3I3TKf8LDX6lLqL6T0MJ8J1v5EnDFEHano1w+C92b/tgp7juT+QEYb+CarWi4vJeRgMGSKv/ejzJrGvWxHfJi0M/mk7ecCjJmYc8p+VMlhHFVuzhL3FCAKeAYzB0/al4/uDqQ36Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000221, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 09, 2025 at 11:00:43AM +0000, Shiju Jose wrote: > The min_ and max_ attributes of the control attributes are added for your > feedback on V15 to expose supported ranges of these control attributes to the user, > in the following links. Sure, but you can make that differently: cat /sys/bus/edac/devices//mem_repairX/bank [x:y] which is the allowed range. echo ... then writes in the bank. > ... so we would propose we do not add max_ and min_ for now and see how the > use cases evolve. Yes, you should apply that same methodology to the rest of the new features you're adding: only add functionality for the stuff that is actually being used now. You can always extend it later. Changing an already user-visible API is a whole different story and a lot lot harder, even impossible. So I'd suggest you prune the EDAC patches from all the hypothetical usage and then send only what remains so that I can try to queue them. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette