From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8D14E77197 for ; Thu, 9 Jan 2025 17:50:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FD3B6B009F; Thu, 9 Jan 2025 12:50:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AD6A6B00B0; Thu, 9 Jan 2025 12:50:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 374C36B00B1; Thu, 9 Jan 2025 12:50:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 181736B00B0 for ; Thu, 9 Jan 2025 12:50:52 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B5B4EAEBE7 for ; Thu, 9 Jan 2025 17:50:51 +0000 (UTC) X-FDA: 82988653902.28.5900EA7 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf17.hostedemail.com (Postfix) with ESMTP id 244A74000A for ; Thu, 9 Jan 2025 17:50:49 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XkKzdywN; spf=pass (imf17.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736445050; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pJWnZgMq5/DR8K3teGXk42rxXJuZ9F8Ao8/B6KLWZYQ=; b=eR3pLkb/o39wqGcDhqtr+TZ979dFRkFguBIFhFHIhpUOwY4Cw+faEIzfI28+DUu7fXJVEM Ni5/Dx3LfNoZlHlxmWb5ygS9JMGMMx4uCIlH9D9uExt2lXTZNdNJzna28nmAfkF0qM6IvQ tOEGtqe1Xaq6NZWf5AwpTOpejuud7Zs= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XkKzdywN; spf=pass (imf17.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736445050; a=rsa-sha256; cv=none; b=ahoqk3dA2IkZ/6TC1kXpP+T1jqcI2dhX6YJgL/1ShPzxRHjXs+56KyhdI7snYVD3QD17gx 09AVeuNL5TNEMCDgQbTzoGdxH/OfUvHYYxvCFArxhlWxVwbJbZPlrWwKMQGJ+7te2/7DNz Cpt2fq+G0PHM6l89Xm/CaOGJA8lMJG0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C8164A42162; Thu, 9 Jan 2025 17:49:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDA07C4CED2; Thu, 9 Jan 2025 17:50:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736445049; bh=+VmR34GkdqkkxBn3H7GkFY2zqJQCS4x+lDjQUH0jTMc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XkKzdywNFuYEtI8r5OHdB5TPKQuuuf5dAIP185gk/uZmroXONxcZtZ1hnW3Bci0vK zzxm8rBSaCmlMMEOz7hAVo6sLtsUCRyz0fomQgiO1VjHpkafe5jRRSPHqLunUf8n8q 7IGOqbidS57+DgCHd6WQralDlYx6rYennGytGZ14ijTrMKwn+Pb0Q4p8yUpHKTSRwM zGDMSYRZGIo2lT9eqKUBShlvEztuu3AtXO/Gqe9dFyF7nO58SBrdyrAVacAn+uyva9 h8YEVclO5NFyFASn5sC1h3zTO50OcEtD+SBVHtrKkCs1UrCfpiEj2nQ2kdnqec1OJX KlgehVK5P+1pg== Date: Thu, 9 Jan 2025 09:50:45 -0800 From: Kees Cook To: Muhammad Usama Anjum Cc: Andy Lutomirski , Will Drewry , Shuah Khan , Andrew Morton , =?iso-8859-1?B?Suly9G1l?= Glisse , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel@collabora.com Subject: Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters Message-ID: <202501090949.793D9A0@keescook> References: <20250109173842.1142376-1-usama.anjum@collabora.com> <20250109173842.1142376-2-usama.anjum@collabora.com> <202501090941.5289E7444B@keescook> <843bf743-4005-47bc-9e39-8ea49255b152@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <843bf743-4005-47bc-9e39-8ea49255b152@collabora.com> X-Rspamd-Queue-Id: 244A74000A X-Rspamd-Server: rspam12 X-Stat-Signature: 4aaxqyq7nqgs514bcgogtqimz69pzrip X-Rspam-User: X-HE-Tag: 1736445049-744799 X-HE-Meta: U2FsdGVkX1/dAfGAt61LpWUjggcw3IIBLxRBtRSqWNjHBtwhkS3hSOQa8YxcHXmxYaWs9uiL6a5unb8rJEalw8nASgjuODbn/msXzIzSpxdoDqaVwU3DQIiuxd8szdsrwqIXf7ocEDGq5un7fwiJTFJ/Xhta6bd5dchyajBEK+uCpIKJlz34WFGqO9ZSOP4PsQ62TZxMgNefPUgAWVVwYQu3k5CYtUVhSPTDYg4DGCNUbivxS5xbTmjMgUAgmD18VGqBCJFO3wJiG2KQpjprL2omOybenyu1XDgulFXF6Me2SSKwtWGJZLVg42+XnsnVICQzECNerbUKv3caYaw5sPRhFaVxbIhsjjBVfEWV3pBGIDMZVDUrC31+4oduhtUwc+jJl5TJRaxcPgw/dzd/nGrL4Rp5ZJ3mE6PuuIQHCgqOQlIjn16su9H43kOp/yblJr8bV0916g1pqLmuSqva5X3NhhtiGTf8kHmS3zgjc4Qyiee/gLnDIVHXrYG8106vRPeEJhOBkP1h+KMgvIt1DR93KdnDtmf067rwiRJDkkaILgGdi9yj/ix8cTFgOQhjW4/ucWLMqJ0DqV7O8YjNFi8RqECR5h+zjqA1SPndVYcslBO5HzNr6uTZXhXV7SgWrlSjBxHYcEdsF8Up4vGq9vc/QXaYS7iKbc0pGsXQ/xxFWvrip2xInc/o3rkhGGbhDYrAJoD2TwH1hEzR2Qu8KMoBmzMIcufyFOOrYbnz4TM3BjwBgtlhB+92NmQXPaykHLSZavv6Uh7BDGiA9ZA55/C9aAuZ+YiobxLRmDgVLHL2WX6Z5Aod/8UVXDMEyeiRc74UVUJX9c9n+9q5Od04luRT6g1KwdswnHz7OG+V6/3Z6KSqyLHIebvQtGvV/WHG5Qkt7bo5nGPHS9WizdZnJuxRj/OkCVhFSIgtK3WCXSbguwqEvIScA8qFCcl0EjhjB3m+lSrrkdxya63uTEV XxVzfFe3 syD90/t5tzynR24VBz5kGbmGHm6jbc+tHkCqnO29QGx8+U/Hv/wcypGG1kIHL+e9QJrBYeYbO5fCBjRgLcUuDWiTUAu9p/5RRMh0y57sPMkO1pCtH+cuARr/GJAu58qWfY4ahSnouX+g+aPULtd9X0Z7QK173l+1ubvvOkr4Tj5nFriqg4UNneLVFcyYwWB92dKqFIKFesjEFkvC8OITUEye0Hz8dGT7ByXZonD/AvNb2/mopmswRig6GYgiX4klJjkcBn5KHpOggrPq+ZAxRii7Cbg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.056246, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 09, 2025 at 10:48:52PM +0500, Muhammad Usama Anjum wrote: > For the all other case, why should we keep argv/argc and mark them unused > as well when they aren't being used? I'm fine either way, but my personal code style instinct is to keep the "standard" main declaration with argc/argv present. But it's mostly aesthetic. And if you think use of kselftest.h isn't universal, then perhaps we can avoid the macro, but it does seem nicer and more "normal" feeling for the rest of kernel development. -Kees -- Kees Cook