From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 517A0E77197 for ; Thu, 9 Jan 2025 09:20:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B835F6B007B; Thu, 9 Jan 2025 04:20:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B32F66B0082; Thu, 9 Jan 2025 04:20:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9ACCA6B0083; Thu, 9 Jan 2025 04:20:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3E4AD6B007B for ; Thu, 9 Jan 2025 04:20:16 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EB44B1A1812 for ; Thu, 9 Jan 2025 09:20:15 +0000 (UTC) X-FDA: 82987367190.17.B82FB11 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf02.hostedemail.com (Postfix) with ESMTP id 94D088000D for ; Thu, 9 Jan 2025 09:20:13 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=hKgpMKJ2; spf=pass (imf02.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736414414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LD6Fod+6Pr95sk9Mi4pDaHYRb4hj3jfrssJ789s5mN8=; b=YSYp/B/Z59mu0VxYOABmzUYz0xQ0r2+gJ6dE0mLAs9AFoapfSvFb1bkeyMy/RADWzuXQWc xA1a1PmzylSBo29PGFnRiAJs6vm3kgzxKVheeVzkZwbUQvMF3UQIQ0QSn8bI81C0owQQ88 9T6NLlGJSOjFRiSNWsfTrb6UrwYKOXI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=hKgpMKJ2; spf=pass (imf02.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736414414; a=rsa-sha256; cv=none; b=bb0XKHNqgRFjxyzAEn3WE+yxnYDIDZ9bBNDnBD5xXnA4DY8CIBZO7G9jr5zrWHNQDlMJS/ ndZ7bndOySI6DqzCsuIeHtrVbfQTVkcCQb6tj3TiaS0YKx8HH+mC92TC33bL5mk8Dx4vl4 qVoB0DujmQyGmHx9jeehYgvmFwt23HE= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id BEAEB40E0289; Thu, 9 Jan 2025 09:20:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id l-d59qMPqdD8; Thu, 9 Jan 2025 09:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1736414405; bh=LD6Fod+6Pr95sk9Mi4pDaHYRb4hj3jfrssJ789s5mN8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hKgpMKJ2nNwD+QLd9aQPpp2hi/PyZjEg14CxdVWJCaSEaeSXnOR8USnWk5GrJOTC5 dexMAGS/rpcQT1WLSPHx93W+k2hZ9hHW6JR3vY/Okxq6ZOVZaoLETIkCXJl7NMOgf6 jhFdnrARkqoaC6pqm+BcTMAdJ/zyNzxhDbFDfXhsBdw0ztoGYY4pbgwzfxIDWUbcUq +B6/icQkLUwmgkuJGqULBRouhIXbilK3SNlO2aWW5jTAvAK9zOO10sW3jsS1CRZHyU mcWFnMgUPvOq+A8Gd1DOsdFQt/m+2WSPSgS7P6bIMbKHcTWKZLqrxiziHtQgsXNQSg UwNGv9C66DpAlE095fu1ZECkV80rddlpErX4eJm0eV7dDd2vE+tdavqghKTydY82vy IYJncSGhprtrUNB08V9WE1DpPTtZqwHK3C/1Yqzo17SY6RR7GNDwYN81graPzon8Bj kvl1w/5Q/z8TJgajQUHStgeXjartB/+lnAWLYpbqTYYhikK+I9WhQH8H+WFqHqs7kz bpB3/4RHyMaX2ewh5aoGk/UcIboxAh5dF0Y3/cJrXE7CBbKeJDUx8PcE6+LYex4f7K 7gjP8S6v3WVjIXS5tqszGKip43wgfhp5jja6UT4SIzLQomtjqY0nKk2OCMsh3lZSLO Q7NXVdDO10VcMT1lCc+Matb8= Received: from zn.tnic (p200300ea971f938f329c23fFFea6A903.dip0.t-ipconnect.de [IPv6:2003:ea:971f:938f:329c:23ff:fea6:a903]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D30E740E01F9; Thu, 9 Jan 2025 09:19:21 +0000 (UTC) Date: Thu, 9 Jan 2025 10:19:15 +0100 From: Borislav Petkov To: shiju.jose@huawei.com Cc: linux-edac@vger.kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v18 04/19] EDAC: Add memory repair control feature Message-ID: <20250109091915.GAZ3-Uk3rkuh38cQyy@fat_crate.local> References: <20250106121017.1620-1-shiju.jose@huawei.com> <20250106121017.1620-5-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250106121017.1620-5-shiju.jose@huawei.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 94D088000D X-Rspam-User: X-Stat-Signature: anhehu9tosqfrriunji6gtfijaogpks5 X-HE-Tag: 1736414413-252079 X-HE-Meta: U2FsdGVkX18XTdRdNpYtW433F5xvPf2XuZiA4ekSA7Ms6vcEK13cfDXpkXGB59qcSWNOP5b8VQwSaAXCXmkbW69/Qfh6/jW8AkzH1lsF6mr297TeWkwJ88yvxI6sF3CgNjt+iHk49s76U2QtpZ3RCAfXof+xz5VGGJx9PQtJrsZzCajbU74WFIjOha/gtA07JcSmMlqjtNI94T21HkNaTLuGh8y+l4rVe9OSK2R8GnO3oDL7uRItR+FKH06EUq1T01rVqqKYvKxy1iRLpCBKq0E0DbD204Vh6JF9CncIFsKTQU4Kg9/lRhR1wFVfaayizDvZA3eYQr8ElbIcTij4GPj1UiFS32bd5NUrnjoMbdF53SLBrb0mMZPLpMfHyRew/Ass3lqw1h2VT8AQ1/rfBISM46VK6mQ1v6hexvV/zraH97eN+SYSmiJiL1OK0GarTwnSnPlgIHxtk3g4iNO7P9uIKTWM5sSD9DTeGm1DQkyOs5yhwibe9B3yQEr54P6tPfwsTsgAh2Rgrdfl/25izZ/rCiFzMv8YnKDY4hpnXVlNIB8Lci8lDbDVBEc45FpGvEm9haf8vBCZ2LNJ4L0Gmz8/wAdIUWI6JV2sRBS1bHBCErTJ8ZWy58cfjBDMJDdolEKkcvuAOASdDKQMnB85qKtO2M2osRL6ia8t3ZvtLUo6vr0HH9q/Krg+z6OX5LsybT8qvmAf+WE7ILrOREulfnLxzRtDaEf5Ejqs98OI/52axWdYiQMYif+EQoh3lPSkKfkTD6o5ORUtAwfT2fmM0tskp4BrNxQFmm28/G8MiCic+90qCNbAhqnd+UioWht2JJgtIa2IxRmb2Orw+3Ujqr3WiZHxw7KyhTwy7RqC2rB8ZTwykNA2pN4j1OKX1rvSQiCZHZZ+W0x+xJqlQmiKyEU8l9NodLy8T/JppSUfn036mtX70Xj5ag/86Fj4gcKoNZNo9Lc/VVQFBpFHxuj rX8E4nsn LJMru/JVqDfZDDW77OaYgC8o4Zgj1MxFMlIMjXcqRVxa1EHAlbwqdHShwbkOuVoOGuZ9+DP62xz3Qi0QseooaWrLCzby83t3PmKT8v4rJEwDSsdCU5UznRp6FG2mwtUMJ90XMeSFFKuYFpp4AaaOhLuAXXtWPsdCV0qYs0wB5we/NeVA4fKAFhMp7ZNOE5ozHMurQ94BiCVKNbIa8CH7EV5BPmsm3+td1xJXeL0xO/nN9Gf/vUBoFIUhxKsx+W6c8imKpOQLAzRQJxN/3YmCeGjaoZmtSmE84N4LsoeYjgqDBq15MxasW2N/PichjVNtDeBA+XvsmiVJQRt6UUprgfSqJOkdP2vW8fcoM X-Bogosity: Ham, tests=bogofilter, spamicity=0.004579, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 06, 2025 at 12:10:00PM +0000, shiju.jose@huawei.com wrote: > +What: /sys/bus/edac/devices//mem_repairX/min_hpa > +What: /sys/bus/edac/devices//mem_repairX/min_dpa > +What: /sys/bus/edac/devices//mem_repairX/min_nibble_mask > +What: /sys/bus/edac/devices//mem_repairX/min_bank_group > +What: /sys/bus/edac/devices//mem_repairX/min_bank > +What: /sys/bus/edac/devices//mem_repairX/min_rank > +What: /sys/bus/edac/devices//mem_repairX/min_row > +What: /sys/bus/edac/devices//mem_repairX/min_column > +What: /sys/bus/edac/devices//mem_repairX/min_channel > +What: /sys/bus/edac/devices//mem_repairX/min_sub_channel > +What: /sys/bus/edac/devices//mem_repairX/max_hpa > +What: /sys/bus/edac/devices//mem_repairX/max_dpa > +What: /sys/bus/edac/devices//mem_repairX/max_nibble_mask > +What: /sys/bus/edac/devices//mem_repairX/max_bank_group > +What: /sys/bus/edac/devices//mem_repairX/max_bank > +What: /sys/bus/edac/devices//mem_repairX/max_rank > +What: /sys/bus/edac/devices//mem_repairX/max_row > +What: /sys/bus/edac/devices//mem_repairX/max_column > +What: /sys/bus/edac/devices//mem_repairX/max_channel > +What: /sys/bus/edac/devices//mem_repairX/max_sub_channel So this is new. I don't remember seeing that when I looked at your patches the last time. Looks like you have all those attributes and now you've decided to add a min and max for each one, in addition. And UI-wise it is a madness as there are gazillion single-value files now. "Attributes should be ASCII text files, preferably with only one value per file. It is noted that it may not be efficient to contain only one value per file, so it is socially acceptable to express an array of values of the same type." So you don't need those - you can simply express each attribute as a range: echo "1:2" > /sys/bus/edac/devices//mem_repairX/bank or if you wanna scrub only one bank: echo "1:1" > /sys/bus/edac/devices//mem_repairX/bank What is the use case of that thing? Someone might find it useful so let's add it preemptively? Pfff. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette