From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C27A0E77188 for ; Wed, 8 Jan 2025 17:26:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0549A6B007B; Wed, 8 Jan 2025 12:26:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 003216B0083; Wed, 8 Jan 2025 12:26:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E344E6B0085; Wed, 8 Jan 2025 12:26:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C74896B007B for ; Wed, 8 Jan 2025 12:26:53 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 83727C1163 for ; Wed, 8 Jan 2025 17:26:53 +0000 (UTC) X-FDA: 82984964706.27.F245959 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id E2B56140015 for ; Wed, 8 Jan 2025 17:26:51 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="hzH3em/1"; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736357212; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w0nLbBK9cDlJIdnOGYd2Kib6le6Xzy7H3Bx2QP4ATd4=; b=6thxlvYRGWm/WJyzRRPjqz8fIFAelDzYyan2MFiennQS68ZbB6WfP5xIyzIKt4kB4U1P5M XGlLaoA6405pNTo1CZFis6VO14N7UFt0XBZhx7fb2OEl/S9aY3Pw1vc87VLBmDtGKzDBlA Fe4OsQwB+ZpSOI92Tu0iMOMu1HHow4k= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="hzH3em/1"; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736357212; a=rsa-sha256; cv=none; b=Za5L9DSZW3O3F0saoiPEtABdXL807gHQO3isDQTKWiRrD4QCJ4E2RP++EK0GF3eljAyGWS iUStbos+i8R2fP4b9cp2w0A29dmz4o+e1tCyI8fuFnIgoJW/TkBEVqb3wujbXFnNQcrAUf Qw4FC/hkF70vRnFoCCrQSKiY71cXSgQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DF8F15C10D5; Wed, 8 Jan 2025 17:26:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F3D6C4CED3; Wed, 8 Jan 2025 17:26:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736357210; bh=tIIhLJb11NqDqWXBo/NWi6wvo01S8sFAFxHTXh8cKV0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hzH3em/1M8euyLT6vG28pOZjaQDQrNnyQvzgJ6XnQXUI2sDBbUzrEBNEbEGoTEaRe EFKV/R/VhSGMhSl+s55L9lsE0w0m3ZPuITN5pKOsq9POkdyAB+IuvHyATwuWsQqNUv /HGEGhvpW1NryBSe/1ozgV0ep6bK7zI72E/z+NsWoqmdyST6SImmryAEClSo1e7EVU VmYw18MToWbBDVCrIlHVqXDblX5kfuQojJYqwqpmq4WhBh7T1VTJFIYv1YrN37Rx3Y AeU1WLG5zQrkqb4EcqDaKVKxif1wEw6JD/LFUIaoUgCEoEPEnfjfoJc4YdmeYyNagh lGTKu213UHydA== From: SeongJae Park To: SeongJae Park Cc: Andrew Morton , Jonathan Corbet , damon@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 07/10] Docs/mm/damon/design: document pass/block filters behaviors Date: Wed, 8 Jan 2025 09:26:46 -0800 Message-Id: <20250108172646.6226-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250108040454.1283-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Stat-Signature: xcrztjo5ze3r9rtubgk5ibiiwi438p67 X-Rspamd-Queue-Id: E2B56140015 X-Rspam-User: X-HE-Tag: 1736357211-421811 X-HE-Meta: U2FsdGVkX18QNnPPMlXxegHBWFpHTDOLWCxcRrAZ3KQyNU1HM/tfWg2rlScBzCLgDie/4ScWqbQ30KGylHBBdjsO2fB0o1BYS2dpG8q2toBEUNIXBE+1SU4uD/cngKChc7Udb7WbeC6vakIdKsEovFuw36J/uHE3TiFAgKjHi8y6nGdsxCdtt9D0ScUy3O5+x2rFd9e3fIqIlnKCWVqfQzMDr3OGtnb5Iu3d7AdZuKNczgZ1KqjfzT3A/BH4kWH8XH1HcH5C3CFyficdBCPl2oMbecEhFpt0BQrqzDE6SaZB1q0iLeSvuu2eG34e5UuMzJmSBPjUVX40NPvYufqMFCO62vjMIh3Iw5FcafswU2WhYc6taXEhrOnFvWk3TePXWfERHC1k1EhjGwClcEF6mgEEwPSFaqyyxt4SnDo+U2goYPjyor6YXCXgxoLC01JRBFEK0ypPEhXHGTuCbLE20OrKGQQliRUZSkW6T30cru0TeCxVKsW6POCFeYUfSVBKDeacdqF5mElObyb3UX1U7WvQOaWGb+8klhkUXPxKBDqm4/gJ8/WIlltGg2Hyoi5pUbz9PYPVHHU0LthAlrrZg0CJsfXxlLJQruowLh4OworoL6gdfzS8nsQ2SH2LF79ZtDSvEI5/Bv/4pVlbdm4ZJ1EIOaKT1qh3orIaB7jzXg/+OnmAEm802a+qQfWFVtCL52rcbUVzcHW8M6BTzaqxn0Rw7MR09E0Mg01QxZzhFYEnIuoEbgp2OV8iSAIkWGNMo5B5RuPk0BeM0oXeq6tFrX1FbULi4KXrep9867pmOtwO7VltbEll1j3E4KFueYYGmDtq2K+ROg8aZzTkb/RfDaFlTMd1Z7+HNWJJDYu8I4akbhP+dEyDs+sPTmM8aAmNJhF/SmXWH7a2nimOzUteKMQmvYgVvhEifxrj4fcj8bhi71fHyvOPH11Gh14L4a2myalFL0wV31BjFcJn1Xm Th4kijcS kztPlyIv0PyRZRJTFGQbND1UOJ5iQXXtpiasc+8+OnSk1gHqG/4U/SPHSRV7SozwkM3qn4l6Owlenj9dhFd/ngXl0VY96qw1/4M6D4+TNP+dvLC8uKXLrReXcjF1vsoq7FeWLbJRDaj8ksH97aHCGsZV1fOt+jjUTHaPQOmBf4DTJHm801KbIQunX4D1YoVreZOBKNTpu/TVGTpxAnFe63XS/StVwB8n4lqQ/4yeRSzR93Qc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 7 Jan 2025 20:04:54 -0800 SeongJae Park wrote: > On Tue, 7 Jan 2025 12:17:36 -0800 SeongJae Park wrote: > [...] > > +The fact that the action can be applied to any memory as long as no block > > +filter explicitly excluded it means that installing pass filters without any > > +block filter after those is same to not installing the pass filters, in terms > > +of the ``action`` applying. Statistics for DAMOS filters will still be > > +accounted, though. > > The above last sentence is right in a sense, but not useful and could only > confuse readers. The statistics for DAMOS filters are filters passed size > stat, which is provided as per-scheme accumulated stat and per-region instant > information. The stat is for any memory that be able to apply the DAMOS action > after the filters check stage. Hence, whether it has passed the stage due to > existence of a pass filter that matches the memory, or the absence of any > matching filter is distinguishable. > > > It is therefore still useful for monitoring purpose. > > Hence, the above sentence is completely wrong. The case (installing pass > filtrs without any block filter after those) is not useful even for monitoring > purpose. > > The RFC version of this patch was mentioning it correctly, but was not clearly > describing why it is not also useless for even monitoring purpose. I was also > confused due to the absence of the context. I will rewrite this part and send > the whole series again as v2. Another reason that I was confused is the conflict of the term. The term 'pass' at sz_filters_passed stat means passing through the filters checking stage. The same term 'pass' at "DAMOS pass filter" means it will let the memory that matches to its criteria pass the stage. Hence, the term for 'sz_filters_passed' is a superset of it for 'DAMOS pass filter'. This is obviously confusing. I will rename things that introduced by this series to be called "allow" instead of "pass" in v2. Thanks, SJ > > > Thanks, > SJ > > [...]