From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A8EE77199 for ; Wed, 8 Jan 2025 12:04:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81A556B0088; Wed, 8 Jan 2025 07:04:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A3086B0089; Wed, 8 Jan 2025 07:04:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F5F36B008A; Wed, 8 Jan 2025 07:04:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 31DA76B0088 for ; Wed, 8 Jan 2025 07:04:52 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2D00FC1336 for ; Wed, 8 Jan 2025 12:04:35 +0000 (UTC) X-FDA: 82984152552.15.74017E8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id B2FF540011 for ; Wed, 8 Jan 2025 12:04:32 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Z/6/g6AX"; spf=pass (imf04.hostedemail.com: domain of mst@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736337872; a=rsa-sha256; cv=none; b=iDeWdnbZitvNJ2k4GMXUUsCey7p8pZMnS/BtW3RAJdaJZcnDc+d8RKYysa9qCT5rgoGJ9v +viqQFmgS93Q564JFAMAVxQ9qBLDXCVHa8ruO1WmQQ56w7IrBnP4LiCg2ZYxuDj+D54vrF AJR/3D8UsUxWmBCQuKyHVMdglxKzdJk= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Z/6/g6AX"; spf=pass (imf04.hostedemail.com: domain of mst@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736337872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=erQix5YBM/Y/uEtirG3GeKXgXkkPiaihYorhESefFJA=; b=qGUZAIuG+R3JBg94OnHD7vUVp+hDie22utTkcBxbZLSjisswIYt5/F1r2EHOzE7mxLOma0 39xBYjHsV1iAWrm3X3Gfbn4YXDMESGswRZCZu5rGXarQb2idhiwTDgEXyhQlrqqDghxi3R PG7krXfJX3wbcw7I39MELIPoK7pFH7k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736337872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=erQix5YBM/Y/uEtirG3GeKXgXkkPiaihYorhESefFJA=; b=Z/6/g6AX54ptMQMDmjIQK3YqN1Nz7W5o30nePrqHSICVzUaKtGQv6ISoP1Drxnr0+EUwDj 7/0Qd7mo2nlBDHfNqc0a+n6VLKQNl73MmFakEarrH+z5b2EnSnFhUtlbSdBVr09bQHktV3 KX8OJ5aF+5El25kB9EbN2QW13DFgQq8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-117--ypNZLr1Mh6xiCOvxdGQpQ-1; Wed, 08 Jan 2025 07:04:31 -0500 X-MC-Unique: -ypNZLr1Mh6xiCOvxdGQpQ-1 X-Mimecast-MFC-AGG-ID: -ypNZLr1Mh6xiCOvxdGQpQ Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43623bf2a83so120744815e9.0 for ; Wed, 08 Jan 2025 04:04:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736337870; x=1736942670; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=erQix5YBM/Y/uEtirG3GeKXgXkkPiaihYorhESefFJA=; b=DM7zhTiLSZyS/pruQhdILTNhZOizWVFMawqXUTUlPxr115Hit4Oabj+lZ9TML35ClG fD3PDjIZ29A1AxWfvpRWU+9TR2wXKAdXvIb7yer7g91zfv9LdKRHBU9BruPykCuHjWPO n2Vfa07RHC2bbTOLQyqiZxEbn8gIyLUzSn3IxHl52WW6kcXHQVchdgpfKM0PV9+zpQiq ECjsgqfviixnA3IM9Xk5Bgo62mRw2duk5RDbXB4YkD6PV1UC5lR5TMrnYoafX46z1G3T 2hT5Gmu9a+suXjC1IZge8Qg7LFew/ocC4D9RP0nKa1/jMPACIAtw6KyR05sY94c3rUP2 Trgg== X-Forwarded-Encrypted: i=1; AJvYcCVFDWu6wHXJ7u21OzRRD53LjQ8HamVsRjINoOKvAc3UF1QNzFHrOpSVEqvP8v0xeRRFzwwKAZMwXg==@kvack.org X-Gm-Message-State: AOJu0Yz/A9zDywkqx5IWB68vLOBbjkmQKZAMvXQQ+QdHISglL4Au8Fo2 9pDbn/UZoAyNmY7G5nLunuJafLD89RuciXlcJHHol4cbM7Xyu9LoxK4b/tJ2icLQZ9tJFu/0/Ig FQSweZV8Hii3lXOaic85px8GCZusA3NqNqjlFa3rmb4pkgO3Y X-Gm-Gg: ASbGncvy1KSXSor+bvV6bGLQiFqqhyvvCw5+POHJTzeQyh7OGSP1MgWsTP0Q/T4ucpX UPvZblSW9YAtY4al7vf/FDXvuomSm5u/n4z4hgZKbA/1Mdzc8FrR9OuLoObdosMeFuqQqlxEtAn ReOKerfjC5oRPNpNXoZsLtlhIoih8YobwA/E8D9TwSCcvBbbLBpj842GmO9rbnq5UgG6fGr1T4u Slb4gs07O+OBNQHCoXbBq0d4qaqoFon29aFLxKFmjcjcwag+LA= X-Received: by 2002:a05:600c:5251:b0:434:f4f9:8104 with SMTP id 5b1f17b1804b1-436e2700050mr18200275e9.33.1736337869686; Wed, 08 Jan 2025 04:04:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IFUR05pl8seK2xsW/qB5D6saVHw6QWnqhWJEnho0PIwlVj0Pr14aAjP/a/iJR8rsa6d05BmGw== X-Received: by 2002:a05:600c:5251:b0:434:f4f9:8104 with SMTP id 5b1f17b1804b1-436e2700050mr18199815e9.33.1736337869281; Wed, 08 Jan 2025 04:04:29 -0800 (PST) Received: from redhat.com ([2a02:14f:175:d62d:93ef:d7e2:e7da:ed72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2e8bea5sm18342805e9.31.2025.01.08.04.04.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 04:04:28 -0800 (PST) Date: Wed, 8 Jan 2025 07:04:23 -0500 From: "Michael S. Tsirkin" To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, kexec@lists.infradead.org, Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Baoquan He , Vivek Goyal , Dave Young , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , Eric Farman , Andrew Morton Subject: Re: [PATCH v2 00/12] fs/proc/vmcore: kdump support for virtio-mem on s390 Message-ID: <20250108070407-mutt-send-email-mst@kernel.org> References: <20241204125444.1734652-1-david@redhat.com> MIME-Version: 1.0 In-Reply-To: <20241204125444.1734652-1-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ignBCX0XlnrQgSc1XZzCcRfvCNc_PgnsxcHl6VE9WoY_1736337870 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: B2FF540011 X-Stat-Signature: zatt6qbmhstt81fz7qthtszqgfrct8su X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736337872-228300 X-HE-Meta: U2FsdGVkX19wrBuvmwgCKlJPnUwpOUp7XJe5TnJOG2SWuCcjYadr11Whuk4VD9PHWyaJZlOP/FmiTLhSdbBgwR7UKkI5ACEpssGudX4TG4tfC9pt0xo4hikKc0yfPaw2xy6PPrNMHTCdHy/UTjYXlNcd48jpJrpEYTE7KcLeLZJi+amqAfFBHPuoUOpYbS1OzkaDTi5aaLhMs7tR7gZwqz/VlD+AZiW3lzisi6E+ZaCRwtYnBZX+wPuw69auTEy2LC770lHi3te5NyaPqtTsx7KC+o0ZAeDR8G7JV4i9efBeAXsQ68HwG6OCc5r7nwf4u/YxkObnZFU6MSI6rdwHAYnfe0Lt2t94CjvhdicuRHhX9X0/en0ZwTtQQFI7ZJEUTbEvTGUkmmUYYE/cinBi/n/cJMIcrjco4UhTcncpTWDsThnP2Kyug55FyHzGDmd63QtJT5QSiOSRrsCDtlvH4tOvokhTr+K2f/QbpVI2j9JGfjnM+HCfUutFzKeMmYdmeh4dGNWHHMLlGrERAp3ERVNk359qdekSez+tvHucTDX5WHBw4xCkgGyc2nGNnsw5LW5Qfd+Ir9q1PNyg4+pFmpt3KWA6v5Gj68+Dj1ZBUniHeas+Qe83wJ6cP86eUrdNfjZyKqHbKWn3rWMtGPEG8lKSp9QoTn5ItTS4JaVE51nE8u/b43XwCKa9XFwIEnxFkD+R+05OIw7SpkDQTkx3yPkzB3XYsmxLbUZyMtIl2t/L78doVh1l0nT1RlxbWoORR9z2KH6e/XpKDJ3PI78Pg47ef9RZ6gZKwkOaFOR60VkIGgjda99mv5KtpbzMp9T4ARwOKCStYfE49HhGtFoV9lq0fXoSGJR+W3fWrAr7n3lByAnvwZQSpRtmXQ0VGgkIPaV2wEtqZBcwMecULrZjbk6uZTM0nzSgchnFGg108KBT8yKaapwOBLM91/P0ZTsL/oL8kLOhgcQSCfq3qDi +ibauYUf WwAWL4H5PdMcLJhNkAUOZ7cSPbeHjpSG5g8NioD0y7sUQIjDXBHQdnSYMFygkp5sGRChkS4Z67C7R5S8RigoqLl8scgE0NBVmX1AoD/RGMSEgGQWuPIv5W6fQdGfMS/psyqvazDLRtw20g7hToa2IhVIKKns+528ZgIAZWxRvhr/zgUb0DkdxUrdAEZbO/0p/h1L4lWlcDONYwnXgq4Krk6S8jEBQL2NxJUSv9Wujg7kd28ypA3/EZPlbazl3iIvRdBdjU5j9thF/r/5Lri4mVZ8P+6TM3eyAbQqu8dBREFJSd7gTdcaB8EcjKs6uYbB/cuwoLKwmrYVUS8MFE3gVfF8KL8y4iA6obQyfABWgwOY598CiqChZY6WzOJdFify/Zeut1C6PL3fWg01MmlgbWjECmnO0vyTCpf67tTdpE3W3fL6ZqJHiUq4GTee4hEX/ln/OEGjtupAePwX8pX+pzn9PYOeDiPQtAG5Qc418g9jCh90mMK0uj8HPyrG0Icu2AHqRWRZmfNbI1z90y7iXqaVAWw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 04, 2024 at 01:54:31PM +0100, David Hildenbrand wrote: > The only "different than everything else" thing about virtio-mem on s390 > is kdump: The crash (2nd) kernel allocates+prepares the elfcore hdr > during fs_init()->vmcore_init()->elfcorehdr_alloc(). Consequently, the > kdump kernel must detect memory ranges of the crashed kernel to > include via PT_LOAD in the vmcore. > > On other architectures, all RAM regions (boot + hotplugged) can easily be > observed on the old (to crash) kernel (e.g., using /proc/iomem) to create > the elfcore hdr. > > On s390, information about "ordinary" memory (heh, "storage") can be > obtained by querying the hypervisor/ultravisor via SCLP/diag260, and > that information is stored early during boot in the "physmem" memblock > data structure. > > But virtio-mem memory is always detected by as device driver, which is > usually build as a module. So in the crash kernel, this memory can only be > properly detected once the virtio-mem driver started up. > > The virtio-mem driver already supports the "kdump mode", where it won't > hotplug any memory but instead queries the device to implement the > pfn_is_ram() callback, to avoid reading unplugged memory holes when reading > the vmcore. > > With this series, if the virtio-mem driver is included in the kdump > initrd -- which dracut already takes care of under Fedora/RHEL -- it will > now detect the device RAM ranges on s390 once it probes the devices, to add > them to the vmcore using the same callback mechanism we already have for > pfn_is_ram(). > > To add these device RAM ranges to the vmcore ("patch the vmcore"), we will > add new PT_LOAD entries that describe these memory ranges, and update > all offsets vmcore size so it is all consistent. > > My testing when creating+analyzing crash dumps with hotplugged virtio-mem > memory (incl. holes) did not reveal any surprises. > > Patch #1 -- #7 are vmcore preparations and cleanups > Patch #8 adds the infrastructure for drivers to report device RAM > Patch #9 + #10 are virtio-mem preparations > Patch #11 implements virtio-mem support to report device RAM > Patch #12 activates it for s390, implementing a new function to fill > PT_LOAD entry for device RAM Who is merging this? virtio parts: Acked-by: Michael S. Tsirkin > v1 -> v2: > * "fs/proc/vmcore: convert vmcore_cb_lock into vmcore_mutex" > -> Extend patch description > * "fs/proc/vmcore: replace vmcoredd_mutex by vmcore_mutex" > -> Extend patch description > * "fs/proc/vmcore: disallow vmcore modifications while the vmcore is open" > -> Disallow modifications only if it is currently open, but warn if it > was already open and got closed again. > -> Track vmcore_open vs. vmcore_opened > -> Extend patch description > * "fs/proc/vmcore: prefix all pr_* with "vmcore:"" > -> Added > * "fs/proc/vmcore: move vmcore definitions out if kcore.h" > -> Call it "vmcore_range" > -> Place vmcoredd_node into vmcore.c > -> Adjust patch subject + description > * "fs/proc/vmcore: factor out allocating a vmcore range and adding it to a > list" > -> Adjust to "vmcore_range" > * "fs/proc/vmcore: factor out freeing a list of vmcore ranges" > -> Adjust to "vmcore_range" > * "fs/proc/vmcore: introduce PROC_VMCORE_DEVICE_RAM to detect device RAM > ranges in 2nd kernel" > -> Drop PROVIDE_PROC_VMCORE_DEVICE_RAM for now > -> Simplify Kconfig a bit > -> Drop "Kdump:" from warnings/errors > -> Perform Elf64 check first > -> Add regions also if the vmcore was opened, but got closed again. But > warn in any case, because it is unexpected. > -> Adjust patch description > * "virtio-mem: support CONFIG_PROC_VMCORE_DEVICE_RAM" > -> "depends on VIRTIO_MEM" for PROC_VMCORE_DEVICE_RAM > > > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Alexander Gordeev > Cc: Christian Borntraeger > Cc: Sven Schnelle > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Xuan Zhuo > Cc: "Eugenio Pérez" > Cc: Baoquan He > Cc: Vivek Goyal > Cc: Dave Young > Cc: Thomas Huth > Cc: Cornelia Huck > Cc: Janosch Frank > Cc: Claudio Imbrenda > Cc: Eric Farman > Cc: Andrew Morton > > David Hildenbrand (12): > fs/proc/vmcore: convert vmcore_cb_lock into vmcore_mutex > fs/proc/vmcore: replace vmcoredd_mutex by vmcore_mutex > fs/proc/vmcore: disallow vmcore modifications while the vmcore is open > fs/proc/vmcore: prefix all pr_* with "vmcore:" > fs/proc/vmcore: move vmcore definitions out of kcore.h > fs/proc/vmcore: factor out allocating a vmcore range and adding it to > a list > fs/proc/vmcore: factor out freeing a list of vmcore ranges > fs/proc/vmcore: introduce PROC_VMCORE_DEVICE_RAM to detect device RAM > ranges in 2nd kernel > virtio-mem: mark device ready before registering callbacks in kdump > mode > virtio-mem: remember usable region size > virtio-mem: support CONFIG_PROC_VMCORE_DEVICE_RAM > s390/kdump: virtio-mem kdump support (CONFIG_PROC_VMCORE_DEVICE_RAM) > > arch/s390/Kconfig | 1 + > arch/s390/kernel/crash_dump.c | 39 ++++- > drivers/virtio/virtio_mem.c | 103 ++++++++++++- > fs/proc/Kconfig | 19 +++ > fs/proc/vmcore.c | 283 ++++++++++++++++++++++++++-------- > include/linux/crash_dump.h | 41 +++++ > include/linux/kcore.h | 13 -- > 7 files changed, 407 insertions(+), 92 deletions(-) > > > base-commit: feffde684ac29a3b7aec82d2df850fbdbdee55e4 > -- > 2.47.1